From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.5522.1589424559617635902 for ; Wed, 13 May 2020 19:49:19 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=KnlwgWYQ; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: zhichao.gao@intel.com) IronPort-SDR: +SLFsKjKURzwZKi2J+PFSnkzPtHAEjlBk0/b1kbNrg7oCdi8HjRGWt7lR3geuvvVhbqcv/tNSt WGaTaEu6D8xA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2020 19:49:18 -0700 IronPort-SDR: 31Fth8Cv1e2yMu3FQvSUtbWWgzMKyEnGMyLxsngQZglZX1JiuqqH5tGTwkw3BbWF5bDB7b/LMN StRAesPIeTqA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,390,1583222400"; d="scan'208";a="409916719" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by orsmga004.jf.intel.com with ESMTP; 13 May 2020 19:49:18 -0700 Received: from orsmsx111.amr.corp.intel.com (10.22.240.12) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 19:49:18 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX111.amr.corp.intel.com (10.22.240.12) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 19:49:18 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.51) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 19:49:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KTKdw648bW2cfOssC3S7pomVxcRCz7/jC+FuNpP0TO92KACvjFTJwZA9LihAXgeG2BA3H3floM7gytqAc63cZ/SNj1PxuKYm9ppDEJbJHkrVzuNSKLgd/kOC2avI1WaxMiG4rGZXQCRf6qQSyg111PJPMc47sy6DFusuqeMDI1F6JimTFtN0OotmfXGyWhXkLzEn+MU9TvMGpVXSJDe8jjwHvrDwmBlecdygJfgcPnxrqb1WY/p5UH6jxWo51wZRKOxFs7YaINiIa8ceQnvKT1BDCVfXUvqKlnxaHMwfdrCE5x16OyyqSgojVmEYKO0H6viblYt7NRLgvB9DlqDhPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Uy4Iaapcr8mTaI0GVB4q25Oz4UPsdPKtUgoG9uZ+yxI=; b=MMcTSEvNg5MLDXolkKtVdvGNRwHhdLzDVBMsFFPuUMssocBibj35qVm53zPEqS5bd01yPMsBoPdkKfWvCdbE6vVajIvsh4HyaJcMGX3UitdPtS68Lc0cyU3IXCkEST43AWCKlSY3+U3cxNG1XMLZen+8vg3j4aVqMaqXZLQz/s8G+nmHhrZhQqxIic/vlBVaG90KOPaG7oI7E9/F+U1nZFa8Qm5g7bTY0SQMki+AxWgJFEInmL8m/0BzaUk8POnYumPvNkCVSwK/byGIblCzLTKpX/jvh+AKMFZb6GfmcMX/p6rOVZBqevOOcDAiy6kizfiipHJM6/kYQxZ7XrHpGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Uy4Iaapcr8mTaI0GVB4q25Oz4UPsdPKtUgoG9uZ+yxI=; b=KnlwgWYQStuFRtER5qRNrJm7deVBX3BMSvfLBwDmeyivI1iRzDh+lRvVX0W8peZVsjiXh+bM+Kp7fxHYi3zSFPBMLA9mvdXL4zkICMD3tjU0QRHjQjF6QAzcARfbjijSNNQssGvt1oBZWND8UXx045IYxEK1gdLAygHwn1JVzI0= Received: from DM6PR11MB4425.namprd11.prod.outlook.com (2603:10b6:5:1d9::31) by DM6PR11MB3579.namprd11.prod.outlook.com (2603:10b6:5:13c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28; Thu, 14 May 2020 02:49:16 +0000 Received: from DM6PR11MB4425.namprd11.prod.outlook.com ([fe80::615a:17b0:aa95:be1]) by DM6PR11MB4425.namprd11.prod.outlook.com ([fe80::615a:17b0:aa95:be1%3]) with mapi id 15.20.2979.033; Thu, 14 May 2020 02:49:16 +0000 From: "Gao, Zhichao" To: "Wang, Jian J" , "devel@edk2.groups.io" , "Fu, Siyuan" , "Kinney, Michael D" , "Yao, Jiewen" , Philippe Mathieu-Daude , "Lu, XiaoyuX" Subject: Re: [PATCH V4 00/11] CryptoPkg: Retire the deprecated functions Thread-Topic: [PATCH V4 00/11] CryptoPkg: Retire the deprecated functions Thread-Index: AQHWJ8Ha/KDxt/qdI0iHRyvCNDz8pKimCmNggADVUoA= Date: Thu, 14 May 2020 02:49:15 +0000 Message-ID: References: <20200511182718.7728-1-zhichao.gao@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e27d5352-729d-4438-81c5-08d7f7b16453 x-ms-traffictypediagnostic: DM6PR11MB3579: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 040359335D x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4v/LUMA0lgWk7ozRpn9x9dbywSe9h6ZkaPXYY2n3X2USroTzs8KgRuWgcwx1u7+hCr886DE/FYURTC/tm7RPtQhz/qo7g3ySD5+j6L8l4p93Ze7D1nlkpuCKfTWWhaNvSnFxCyw08O7U0tk8/hKpV9qBHjE/C0Bpdo9hu/dHATvOMNuvYQ3H1yHheyhh/PYHaRlc0XgAhkYU1VQt7HViSGNz9xW+XJhm6egNd/NAChHeNilCTcTYDuQSByZ2Tf60vPhUlGNQYgGUthgYEDviEdkQ3xS4ilI1NEL0NcOytUe5SCyjKRtTkxMhTUOqlbGDDoCedYXXOZtvWdT+O3QSZsBzcWeWYi3GjE9/wNezyMSimt0Vube8Tt3zfImqGKxTM2nDOUJHJ7HzIOmRBuBHa4vOjj5uNW9xTVzeX63+Nj6LquoEBFO2T8cg4gjnPTcIkBr9TSkIpTKyCaL8ICm5OVKwOYyS/SLlKH6BzmuyDHzEhGzwsskSQj9RRtBBW9AmxA78loxqGtYMdd0qKvUHSqazcdd5N0OWYAMpcI3waIK+Vo/2IJIx6dAJXK8JHP1u x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4425.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(346002)(39860400002)(376002)(136003)(366004)(396003)(66946007)(66556008)(64756008)(478600001)(966005)(26005)(9686003)(316002)(110136005)(186003)(55016002)(8936002)(8676002)(66446008)(71200400001)(19627235002)(6636002)(6506007)(53546011)(7696005)(66476007)(5660300002)(33656002)(2906002)(76116006)(86362001)(52536014)(921003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: k8L5CXx6Z6BO7ocxT1jgkU6XkVEJsHvL9Xj/yklQq8ezCME/yDf0TmAlrIpTNMuhJSBdFTSeuOYbq66C2rxzyZN04affPuUXSJU0RUn4X0p7xidFnX3bhxAJjRH+hNNeyHnHgrARp5nweikXscGq5aJ7blHt04XmjeuwCcrbLwecQSN1aYxoxgVc3WVc5Ks7GGcgtKVewl7K8rx31vCDKGuySn974v/Tjg2pO70XgUQEhp/EF/hoegt4D9JBo7Vol4hOrAjgURxaPrYnpIbvVGkMW9TmZwLjesIx3sO5eJLlquxh2jY1TZIcw7QPCzeWAEmxNo1CJxYsVpp+90YR2AA0lPM8WSXEZ3f+uSiIRtFS2+Y/eQ4ZDMOWmgrwfEhdxV/ipF/HdwgdFebNW/tXFvkBkFmcWSvrLZc97RDQg/8UjSnJJnmkQ8s+mx/dWoavPJjIIJZvlQuU8uuR+pEJXEC7pWO7gr1KW+GkECru4FOEm5hZB1iTjO6IFd8341Tt MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: e27d5352-729d-4438-81c5-08d7f7b16453 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 May 2020 02:49:15.9321 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: H/iAzn9ofuN2i7i1NAPrarTp/vCKCYNXLsaCqaDimuNohaCJxj6jLVJEDmrGVpODdgMtKecJ46Qg8syw4DnJJw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3579 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Wang, Jian J > Sent: Wednesday, May 13, 2020 9:49 PM > To: Gao, Zhichao ; devel@edk2.groups.io; Fu, Siyua= n > ; Kinney, Michael D ; Ya= o, > Jiewen ; Philippe Mathieu-Daude = ; > Lu, XiaoyuX > Subject: RE: [PATCH V4 00/11] CryptoPkg: Retire the deprecated functions >=20 > Zhichao, >=20 > Two general comments for improvement needed in your future patches: > 1. Add r-b for those patch files which have got r-b 2. It'd be better to = add > summary of changes between this and previous version > of patches 1. I change the typo of the function definition. So all the patches are cha= nged. That is why I didn't keep any R-B 2. I put the summary change in cover-letter. Thanks for the suggestion. I w= ould put the changes for every patch but not put them in the commit messag= e. >=20 > For v4, > patch 8: the updates of OpensslLib should be done by process_files.pl I didn't find the config string to disable the AES ECB mode only. Can you h= elp guide me on this? Or should I remove the change of OpensslLib in patch = #8? Thanks, Zhichao >=20 > With this addressed (for the whole patch series), >=20 > Reviewed-by: Jian J Wang >=20 >=20 > Mike, Jiewen, Siyuan, Philippe: any more comments for v4? >=20 > Regards, > Jian >=20 > > -----Original Message----- > > From: Gao, Zhichao > > Sent: Tuesday, May 12, 2020 2:27 AM > > To: devel@edk2.groups.io > > Cc: Wang, Jian J ; Lu, XiaoyuX > > ; Fu, Siyuan ; Kinney, > > Michael D ; Yao, Jiewen > > ; Philippe Mathieu-Daude > > Subject: [PATCH V4 00/11] CryptoPkg: Retire the deprecated functions > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1898 > > > > Retire below deprecated functions: > > MD4, ARC4, TDES, AES ECB MODE, HMAC MD5, HMAC SHA1. > > > > V2: > > Seprate the MD5 and SHA1 changes to other patch set. > > Change the deprecated function wrapper implementatuion in > > EDKII_CRYPTO_PROTOCOL to call a dummy function to print debug message > > and assert. > > > > V3: > > Remove the missing part of deprecated functions in V2. > > Change the name field in the EDKII_CRYPTO_PROTOCOL to indicate the > > function is deprecated and unsupported. > > > > V4: > > Fixed some typos. > > Separate the change of OpensslLib and make the change with > > process_files.pl. > > Moving the incorrect changes of AES_ECB from HAMC MD5 patch to Aes Ecb > > one. > > > > Cc: Jian J Wang > > Cc: Xiaoyu Lu > > Cc: Siyuan Fu > > Cc: Michael D Kinney > > Cc: Jiewen Yao > > Cc: Philippe Mathieu-Daude > > Signed-off-by: Zhichao Gao > > > > Zhichao Gao (8): > > CryptoPkg/CryptoDxe: Add function to indicate the deprecated algorith= m > > CryptoPkg/BaseCrpytLib: Retire MD4 algorithm > > CryptoPkg/BaseCryptLib: Retire ARC4 algorithm > > CryptoPkg/BaseCryptLib: Retire the Tdes algorithm > > CryptoPkg/BaseCryptLib: Retire Aes Ecb mode algorithm > > CryptoPkg/BaseCryptLib: Retire HMAC MD5 algorithm > > CryptoPkg/BaseCryptLib: Retire HMAC SHA1 algorithm > > CryptoPkg/Crypto.h: Update the version of Crypto Driver > > > > Zhiguang Liu (3): > > CryptoPkg/OpensslLib: Set MD4 disable in OpensslLib > > CryptoPkg/OpensslLib: Set ARC4 disable in OpensslLib > > CryptoPkg/OpensslLib: Set TDES disable in OpensslLib > > > > CryptoPkg/CryptoPkg.dsc | 46 +- > > CryptoPkg/Driver/Crypto.c | 786 ++--------- > > CryptoPkg/Include/Library/BaseCryptLib.h | 809 ------------ > > .../Library/BaseCryptLib/BaseCryptLib.inf | 7 +- > > .../Library/BaseCryptLib/Cipher/CryptAes.c | 114 -- > > .../BaseCryptLib/Cipher/CryptAesNull.c | 52 - > > .../Library/BaseCryptLib/Cipher/CryptArc4.c | 205 --- > > .../BaseCryptLib/Cipher/CryptArc4Null.c | 124 -- > > .../Library/BaseCryptLib/Cipher/CryptTdes.c | 364 ------ > > .../BaseCryptLib/Cipher/CryptTdesNull.c | 160 --- > > .../Library/BaseCryptLib/Hash/CryptMd4.c | 223 ---- > > .../Library/BaseCryptLib/Hash/CryptMd4Null.c | 143 -- > > .../Library/BaseCryptLib/Hmac/CryptHmacMd5.c | 216 --- > > .../BaseCryptLib/Hmac/CryptHmacMd5Null.c | 139 -- > > .../Library/BaseCryptLib/Hmac/CryptHmacSha1.c | 216 --- > > .../BaseCryptLib/Hmac/CryptHmacSha1Null.c | 139 -- > > .../Library/BaseCryptLib/PeiCryptLib.inf | 11 +- > > .../Library/BaseCryptLib/PeiCryptLib.uni | 8 +- > > CryptoPkg/Library/BaseCryptLib/Pem/CryptPem.c | 7 +- > > .../Library/BaseCryptLib/RuntimeCryptLib.inf | 11 +- > > .../Library/BaseCryptLib/RuntimeCryptLib.uni | 8 +- > > .../Library/BaseCryptLib/SmmCryptLib.inf | 12 +- > > .../Library/BaseCryptLib/SmmCryptLib.uni | 8 +- > > .../BaseCryptLibNull/BaseCryptLibNull.inf | 5 - > > .../BaseCryptLibNull/Cipher/CryptAesNull.c | 52 - > > .../BaseCryptLibNull/Cipher/CryptArc4Null.c | 124 -- > > .../BaseCryptLibNull/Cipher/CryptTdesNull.c | 160 --- > > .../BaseCryptLibNull/Hash/CryptMd4Null.c | 143 -- > > .../BaseCryptLibNull/Hmac/CryptHmacMd5Null.c | 139 -- > > .../BaseCryptLibNull/Hmac/CryptHmacSha1Null.c | 139 -- > > .../BaseCryptLibOnProtocolPpi/CryptLib.c | 1157 ++--------------- > > .../Library/Include/openssl/opensslconf.h | 9 + > > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 28 - > > .../Library/OpensslLib/OpensslLibCrypto.inf | 28 - > > CryptoPkg/Library/OpensslLib/process_files.pl | 3 + > > CryptoPkg/Private/Protocol/Crypto.h | 709 ++-------- > > 36 files changed, 402 insertions(+), 6102 deletions(-) delete mode > > 100644 CryptoPkg/Library/BaseCryptLib/Cipher/CryptArc4.c > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLib/Cipher/CryptArc4Null.c > > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Cipher/CryptTdes.c > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLib/Cipher/CryptTdesNull.c > > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Hash/CryptMd4.c > > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Hash/CryptMd4Null.c > > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacMd5.c > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacMd5Null.c > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha1.c > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha1Null.c > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLibNull/Cipher/CryptArc4Null.c > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLibNull/Cipher/CryptTdesNull.c > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLibNull/Hash/CryptMd4Null.c > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLibNull/Hmac/CryptHmacMd5Null.c > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLibNull/Hmac/CryptHmacSha1Null.c > > > > -- > > 2.21.0.windows.1 >=20