From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.10696.1597134824676028672 for ; Tue, 11 Aug 2020 01:33:44 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=jIi+3dbS; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: zhichao.gao@intel.com) IronPort-SDR: kmAt1ld1uZ/Tas1D1Tsnk6nx/CXC4deku6JwQBCAoESvKk+lecw+TQcizDuwXoZSm5cSXSOIDV 2yfrdhGumxvg== X-IronPort-AV: E=McAfee;i="6000,8403,9709"; a="218026366" X-IronPort-AV: E=Sophos;i="5.75,460,1589266800"; d="scan'208";a="218026366" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2020 01:33:43 -0700 IronPort-SDR: zEJU/zxM8qZCFyZCdKVosF2IEnbMBAIpLl07rmjIBeM+MsmDBxYjKsv8/Tgz5szQziOTHZXxSH PwYcxRLfOk5w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,460,1589266800"; d="scan'208";a="326776489" Received: from fmsmsx602-2.cps.intel.com (HELO fmsmsx602.amr.corp.intel.com) ([10.18.84.212]) by fmsmga002.fm.intel.com with ESMTP; 11 Aug 2020 01:33:43 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 11 Aug 2020 01:33:43 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 11 Aug 2020 01:33:42 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 11 Aug 2020 01:33:42 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 11 Aug 2020 01:33:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jAXQLBm7FSYLEqOqPpPxo6gQvh4dOyOvYZjUIudelV8t6aqYYRz9zc2r7i6kmoLEmu9HyWxBUpEPS8TwITH50NR6/Jjj1+pavsVoch84Pqkoqe3fzLHEPKiDKoZnvIT+j7Ta0n1XCyUZvvFEQc2Wr9vfrh6+ax18q+u3evr8lSGrC1ZnUkEy1ktaCGXbekEjVUCEUrJymK7atc1TGcELU5It6N8eZw1hd1lSCbfw4RhXJo6KVLpqNwuHrCgG4y5elPsNBnXw0Rt3OM7Koy0ShETSbh8iY17wHYb+tVEKd9d9LlsBzhSjT+FjQ2hj0FVOH8hcTDyYYlL9hv7hpRvZ2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LYImTIjWhDjEqGUoKhmVwBgYL+uSmxCQlybK+mmNDjw=; b=N63jrsyoZqNXicWRHYmt+MZ5lscKzoa2r3mSiG2bPSDhjRpLmfbEeJbT9jV96robUzWGIs8zJNY5B4jy2V73dENz+J4iGS9175478MGaq7j2yVbRmFw5Hh1bw7jw5XB7M1SL6MM+Qa9pgqT3QqmMbfQxM7axh+9KdSUqmOsaThbIr87KGq90QN3iGOPeDQcFstB4bxHL4EalpHcFHgQXFAClE/blOYs9tf+2i4IrOUEKz6a49veWvuY/X6IPI3t0lllSudUiMLnzu907EwjV2sU/bSFHjnm04FIjSX8m0hFZ90bY7EW3Lc3kf4bKzYYdoblj1VjSNRaFbXJbIkhK3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LYImTIjWhDjEqGUoKhmVwBgYL+uSmxCQlybK+mmNDjw=; b=jIi+3dbS/tLOxArVMbP07FmlDqz/Zbt00rP4ry8eqYUkCdald25Oe69squ1+m1pC9MBMp9KGY2Cr5RWciVO9ViC5MDLr56SvbaNGwoXjtPrW5cMcW+bns75T4mLCRnbH+TuTds/lQZ/B2KIAR09piluuuYP8p1LR8aq9ok+++NQ= Received: from DM6PR11MB4425.namprd11.prod.outlook.com (2603:10b6:5:1d9::31) by DM5PR11MB1835.namprd11.prod.outlook.com (2603:10b6:3:114::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.19; Tue, 11 Aug 2020 08:33:37 +0000 Received: from DM6PR11MB4425.namprd11.prod.outlook.com ([fe80::ad34:e1fc:2e7b:d124]) by DM6PR11MB4425.namprd11.prod.outlook.com ([fe80::ad34:e1fc:2e7b:d124%3]) with mapi id 15.20.3261.025; Tue, 11 Aug 2020 08:33:37 +0000 From: "Gao, Zhichao" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Wu, Hao A" , Gary Lin , Andrew Fish Subject: Re: [PATCH 1/3] MdeModulePkg/PartitionDxe: Put the UDF check ahead of MBR Thread-Topic: [PATCH 1/3] MdeModulePkg/PartitionDxe: Put the UDF check ahead of MBR Thread-Index: AQHWb6qzYeXAyAynkE+lNNOhF/k5iqkyjEOAgAAHhqA= Date: Tue, 11 Aug 2020 08:33:37 +0000 Message-ID: References: <20200811064302.33188-1-zhichao.gao@intel.com> <20200811064302.33188-2-zhichao.gao@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C66892B@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C66892B@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 38e491d2-91b4-40b0-954d-08d83dd13e50 x-ms-traffictypediagnostic: DM5PR11MB1835: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5qVjhu3XcyBHqd6gshMB7UgIzkQ6aPV4rYbV2nC49plPym3yE/cjTNo/tW6CJamBNQuzWMhrW8FOdgR9lhgsKlL6wKF22bBJ8THGP6Lz7DeuVso/TAeZpCi2n/LsqnL2e1n+1YC8T384Uo4BuQwbYyI8Z6LMrC4lLqc+FEiY9B+8aA1uRys2cvMBc/1sJk3PQe526nIT5uU7NF3syu6tN3V7O621Z7XjIHzXC8SmDR7SJgAh/1d72MpMuLCBnJy884oPK/lL1otK03gRcqi6G/gnh2HasEcwaxncsFeDdkANI8E8ehWjCpLXwUyvN1T/g51tsDerneK8dtYiDefO2K171f2SWTFFzlznfF+eUMWOsumUubdunJ24l9e9o2H6PXe/Be7rbs1mJjVeJQzmHg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4425.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(366004)(376002)(39860400002)(396003)(136003)(346002)(71200400001)(186003)(966005)(52536014)(66446008)(478600001)(5660300002)(64756008)(66946007)(66476007)(8936002)(2906002)(316002)(66556008)(76116006)(33656002)(55016002)(83380400001)(110136005)(7696005)(26005)(8676002)(6506007)(86362001)(53546011)(9686003)(4326008)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: Xcg7utiOd5rMV1rAxWj7avsCaQcN5LHGJwiZdriH+bpB79T//0gavUgCGG1nqpQm/sCPXvaV6faFAIXACgmcIV28qp2TEAgYgX7W/Inm/Ad3cJHviL0b/nXh2+W4N3kBUQbpvMS8PBcluwq4yOWMfNnAdNhh3DV0p+bx5nAwa5G5kwmtJat0ulNNumfClLGHmCkJmfnwtAYOH68TiZNZ2aDSrsX9EiDxb0hLKTBJvPvWnlJsWIsu5o45pqfr4ylwjXIpSlfThbie44nZ3bJCarnlJA/ImowarnTByBstXXTHsEUf+M4yRUn6z2nfarmmAjiW1keVnA/z9I/dTvHsQatk1yRWvSPGMHE5VDWhfsmuWbRLhLws/XlNVlkCfjv/M7xqrVndCTla/GosD3tDlbSU2lmUoNuVyEbnu+X67KBH8mopEuFeiy0ylBJnpjtaqKkhaQkcxGj19g5dzV4NTmfuI9hsudTBmhQKwDzCtQ7p0tkrHkD1Cjo0WOKvW9k9dz3Dkzx24DUA4KeunDzVUmRQga3yiKc4KQZqPLsYUmw9R3l+BKBFud7t8M4xc88AB4Pk7SbZ0XGaoRQROltbfXFfJ1W9hxIkRZbhBsAHUxAd5ehhQ9ikcWu6mr3GDymtfHAWveSqstwqwNhgttG4qg== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4425.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38e491d2-91b4-40b0-954d-08d83dd13e50 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2020 08:33:37.4793 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Vrho+3rzXdjqPR4dt+imBfLxIPtsDWlcyKy7nzxZPg72pa9L0Dxt+NhcGxkYcBBPNxAB77NZXPqEyg63UNtafg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1835 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ray, The MBR info is correct. The order change is to avoid the MBR being checked= before UDF/ISO 9660 check. That is why I make the patch #3 in the last of the patch set. Thanks, Zhichao > -----Original Message----- > From: Ni, Ray > Sent: Tuesday, August 11, 2020 4:04 PM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Gary Lin ; Andrew Fish > Subject: RE: [PATCH 1/3] MdeModulePkg/PartitionDxe: Put the UDF check ahe= ad > of MBR >=20 > Zhichao, > Can you also add notes in the commit message describing that for some ISO= s > (better with more specific ISO info), the MBR information is not correct? >=20 > Thanks, > Ray >=20 >=20 > > -----Original Message----- > > From: Gao, Zhichao > > Sent: Tuesday, August 11, 2020 2:43 PM > > To: devel@edk2.groups.io > > Cc: Wang, Jian J ; Wu, Hao A > > ; Ni, Ray ; Gary Lin > > ; Andrew Fish > > Subject: [PATCH 1/3] MdeModulePkg/PartitionDxe: Put the UDF check > > ahead of MBR > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2823 > > > > Refer to UEFI spec 2.8, Section 13.3.2, a block device should be > > scanned as below order: > > 1. GPT > > 2. ISO 9660 (El Torito) (UDF should aslo be here) 3. MBR 4. no > > partition found > > Note: UDF is using the same boot method as CD, so put it in the same > > priority with ISO 9660. > > > > This would also solve the issue that ISO image with MBR would be treat > > as MBR device instead of CD/DVD. That would make the behavior of the > > image boot different. > > > > Cc: Jian J Wang > > Cc: Hao A Wu > > Cc: Ray Ni > > Cc: Gary Lin > > Cc: Andrew Fish > > Signed-off-by: Zhichao Gao > > --- > > MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c | 10 +++++++++- > > 1 file changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > > b/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > > index 6a43c3cafb..473e091320 100644 > > --- a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > > +++ b/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > > @@ -35,11 +35,19 @@ EFI_DRIVER_BINDING_PROTOCOL > > gPartitionDriverBinding =3D { > > > > // > > // Prioritized function list to detect partition table. > > +// Refer to UEFI Spec 13.3.2 Partition Discovery, the block device // > > +should be scanned in below order: > > +// 1. GPT > > +// 2. ISO 9660 (El Torito) (or UDF) > > +// 3. MBR > > +// 4. no partiton found > > +// Note: UDF is using a same method as booting from CD-ROM, so put it > along > > +// with CD-ROM check. > > // > > PARTITION_DETECT_ROUTINE mPartitionDetectRoutineTable[] =3D { > > PartitionInstallGptChildHandles, > > - PartitionInstallMbrChildHandles, > > PartitionInstallUdfChildHandles, > > + PartitionInstallMbrChildHandles, > > NULL > > }; > > > > -- > > 2.21.0.windows.1 >=20