From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.7035.1587883406328803060 for ; Sat, 25 Apr 2020 23:43:26 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=cbM9oxYs; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: zhichao.gao@intel.com) IronPort-SDR: feTAI1Fv5srtViZ5XqnVXYtApJSHsmbRXhiMbSPhLNyztj0l5RVVZy5kT7fenwyf7gTqpiBnnc 76OrC4U54uIQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2020 23:43:25 -0700 IronPort-SDR: 7CP0tRpRWIO27YG3IL1IZF/C6eJOaFFvcMcJXmc27zA6TOHE+GAYuEmNQ7x86/oakeloU1tmei l/PPgz7CfGCA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,319,1583222400"; d="scan'208";a="403878465" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by orsmga004.jf.intel.com with ESMTP; 25 Apr 2020 23:43:25 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 25 Apr 2020 23:43:25 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.52) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 25 Apr 2020 23:43:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XCOv8aoNpDHyUDURDNlxWcs3AqT3pGZhHPecID+JO+5KDaPP+aklD/QW8qeJS83mDY7dUaV0S22t9QeffY29ArEXx1kGScQKEOD1BJe5c1h1J2TASyL0F0gANkRRuVxQj3yNCNahTZHtfmpplK9LzbGHEyHkDIhFxhaRCsIhluiQnvElUw1j1GKaQqJPqcELIEmZjg94vwa8hqEoGSXTkbnAvGtlbBHkClR8lPsyzNAvvQCDlrqdxdgwAWiPGSEdsnpxDgBiDetdoy071ic+fvPynNV+ymEsiC+IrpLi11w/b5d0L21bTFiYUz5yynpXgKqRtKBk9otD1OGdyXAkcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8GHNeXXPkaF/bCjj8iqLa3jmjicB8ftI7VUtkzJAlJk=; b=lOOB7UUxKIf58vy1syaz84y93QYSdkzogrKDtHSa2M/M1R3BGUFH7DoXS37XuTJDpge2Lp8VB25xPXShBmGsjWiWPapcuafRgbYUhH6iGeThgUnSZUJDcTzxzzTydgCcN9R6qmezh5hhmBk2e/YdgPmaKptbzwzRnsnrzT+iU8KqcD+ibSnKJYrifVomlVI2iUIVL8q3AgNd9TNSTibo870BUNVGO1+AkPYKS/MqEcYnUX6Z26yCr7bWBX5e3oe1aTEGyOnwwSUdcSrOb6gckjTDH4rsGCRJuBUQgOotNNwKX9X4iPkQAyamdORJXb56pZDqaJ5D2/satVHj24mmhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8GHNeXXPkaF/bCjj8iqLa3jmjicB8ftI7VUtkzJAlJk=; b=cbM9oxYsKtwPgPFBwmasZeAknDeEaE+XhieAvKrnW9dlvSE/YNgKzKajXPH+8PwyetxuphQbQHOyhE+pTEcMd88P6gvy+LHnCV5gKZhWpz1KjvHs3B3Tu2FoPF4u6TgVmmpJT0ot6jCUlOL1eyk6tV2IiAj07rOkW8HEWdg/PyQ= Received: from DM6PR11MB4425.namprd11.prod.outlook.com (2603:10b6:5:1d9::31) by DM6PR11MB3579.namprd11.prod.outlook.com (2603:10b6:5:13c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Sun, 26 Apr 2020 06:43:23 +0000 Received: from DM6PR11MB4425.namprd11.prod.outlook.com ([fe80::615a:17b0:aa95:be1]) by DM6PR11MB4425.namprd11.prod.outlook.com ([fe80::615a:17b0:aa95:be1%3]) with mapi id 15.20.2937.020; Sun, 26 Apr 2020 06:43:23 +0000 From: "Gao, Zhichao" To: "Yao, Jiewen" , "Fu, Siyuan" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Lu, XiaoyuX" , "Kinney, Michael D" , Laszlo Ersek Subject: Re: [PATCH V2 7/7] CryptoPkg/Crypto.h: Update the version of Crypto Driver Thread-Topic: [PATCH V2 7/7] CryptoPkg/Crypto.h: Update the version of Crypto Driver Thread-Index: AQHWGUvNsY1k9UDKbEefUj5DweWQ46iJmUQwgABEgACAARqicA== Date: Sun, 26 Apr 2020 06:43:23 +0000 Message-ID: References: <20200423084627.3384-1-zhichao.gao@intel.com> <20200423084627.3384-8-zhichao.gao@intel.com> <74D8A39837DF1E4DA445A8C0B3885C503FA0B443@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503FA0B443@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=zhichao.gao@intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 73e78195-57ed-4dac-9450-08d7e9ad1dc1 x-ms-traffictypediagnostic: DM6PR11MB3579: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 03853D523D x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4425.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(346002)(376002)(396003)(136003)(39850400004)(366004)(316002)(8676002)(81156014)(8936002)(33656002)(66476007)(66946007)(64756008)(26005)(66556008)(52536014)(15650500001)(86362001)(66446008)(2906002)(76116006)(71200400001)(4326008)(9686003)(5660300002)(53546011)(6506007)(478600001)(110136005)(54906003)(186003)(55016002)(966005)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KCthRBmtfySNo3gl4SvQrTKfnPTUjgx1QMtiFg22iGvkb3U95IHAOanx/s/AgLH+Z4fd6MvXPTybxClisiMIAp1Anoq2MpYSF5wSxyR9HejE9dj7PMK6qOdX3xgpqiQQNNJ/pA5sdTWix8kkcSpPaqaLO/oyDQqDrrTDfEBnjc48UP3efrl4+fGlRGSfqJRMLExsnCkQoecjH8Vp+/lD0OSGiL2fjUYGtvfRxfp9Hl5yM08oYERKRf0Fzl5iDQ1yKbCbC1crLrGqMw2bTtnORyDtzXm8xUjbRMvfsPNb3RGGz39KLqMVgft2ozkqMyVjh0/i966Us5A7+7Zr1hbYRjoLk/DmOWRBy7G6dtiXVgDKVun/GHuFafmqGdxqvUYiTfhgD6+Gcu1JFhpkbOQ00fpRnhoNfmn4//ONjj67V5ifyEcjGGSfasRA+4+2nd7DryL9Tlr03k/+2Lt3UiU15NYYs7Aqwzj81LlaAkNmBIAdLZgrBa0XhETwtLKm7AEFXPNA4eOSh6nh54E6pvU5lQ== x-ms-exchange-antispam-messagedata: LtJHIFVs7npTK14UGvWDPpZHoWjx1DVEkWE0jAO7RwCK559JoUOifsewuqpROSrjm4lRftyqtKuFhpFWoDrGxFP6vMZyRcKanQ6IXKBLAPLc6cqKBWe4NiKwe5NA1cwHqxx1nGUzFqB17jcoffk4KDXW4eOBzkREJk6gJ/aFbN4vNUiv/e173gaHUyEmb/phDqxxIUeJFaZylKAh/EUPitGsPgxbAkLt7zolwsmSroEE3ZDxCit3zTC9t2cD0KFEUxXD9vkbjirMJ4hWxv4m873sww/nDv4SBy+XvInztRSqA0ay51XcG+K/a486e7Qmk+ZUt0e+yKZdBESqHUGHBIOZ2MzejQXSzIaV+9tZ4Q7H6gQ8jYiigr3QtysVqicx+UvlGSU9GEvus2BKX+h82o129g6IwGvq6ZrtAF2Q2AFL4By4RuXbco89rV//WSfALgz8Dx/NW7ACi3YZ/BPGHaTYsC5xuQOKsnpMyOl3/uicTuYIc+GC2QApZcXuroLvcgSP3vq98uBC51VTpttKqsjLvsN5X1GBVsZuYA8cB5WAaoP/nDK3pp2b3izRxBwEc8A25pllwMgx1PF1eF5rYpliCNhjNO5RMHtfw+xdbWd/iLmtmz+/Grfj7DzEFxDSlJQHMQ7tZN4RIcB1wGBMZoJC1ZxAZYefar1lDN0vmoaWujFHhlEDe4lBpCnpEDGeM5lhSSII6lc1nrGGg8EMMjJd7SLptmBvmV1f47htq+3dY946jTv8T1yOLWn/rN0pTenOW2vLTepX1iAj1rBvfJZaY8BtMzqKxYU/g1AuIDc= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 73e78195-57ed-4dac-9450-08d7e9ad1dc1 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2020 06:43:23.2375 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PzX5048tvDKbf8JGMJmygkHomA+5z1NfgtZKgClbihPk+PM2obeefBXmyzA+HdaJ1KR+Pu+H3USkvah2ogWf/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3579 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Jiewen, Do you mean remove the definition of the deprecated function and keep the N= ULL value in the protocol structure? I am not sure if that is a good idea. Because that would give the protocol = a chance to call a NULL pointer. Siyuan, The binary would be totally different. Does that make sence? Thanks, Zhichao > -----Original Message----- > From: Yao, Jiewen > Sent: Saturday, April 25, 2020 9:48 PM > To: Fu, Siyuan ; Gao, Zhichao ; > devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, XiaoyuX ; > Kinney, Michael D ; Laszlo Ersek > > Subject: RE: [PATCH V2 7/7] CryptoPkg/Crypto.h: Update the version of Cry= pto > Driver >=20 > Why not remove the deprecated functions ? >=20 > Thank you > Yao Jiewen >=20 > > -----Original Message----- > > From: Fu, Siyuan > > Sent: Saturday, April 25, 2020 5:45 PM > > To: Gao, Zhichao ; devel@edk2.groups.io > > Cc: Wang, Jian J ; Lu, XiaoyuX > > ; Kinney, Michael D > > ; Yao, Jiewen ; > > Laszlo Ersek > > Subject: RE: [PATCH V2 7/7] CryptoPkg/Crypto.h: Update the version of > > Crypto Driver > > > > Hi, Zhichao > > > > This patch set doesn't add or remove any field in EDK II Crypto > > Protocol, but just change some API implementation to return false or > > unsupport, right? If so I don't think the Crypto Version need to be inc= reased. > > > > Best Regards > > Siyuan > > > > > -----Original Message----- > > > From: Gao, Zhichao > > > Sent: 2020=1B$BG/=1B(B4=1B$B7n=1B(B23=1B$BF|=1B(B 16:46 > > > To: devel@edk2.groups.io > > > Cc: Wang, Jian J ; Lu, XiaoyuX > > > ; Fu, Siyuan ; Kinney, > > > Michael D ; Yao, Jiewen > > > ; Laszlo Ersek > > > Subject: [PATCH V2 7/7] CryptoPkg/Crypto.h: Update the version of > > > Crypto Driver > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1898 > > > > > > Update the Crypto Version to 7: > > > 1. Retire below deprecated functions: > > > MD4, ARC4, TDES, AES ECB MODE, HMAC MD5, HMAC SHA1 > > > > > > Cc: Jian J Wang > > > Cc: Xiaoyu Lu > > > Cc: Siyuan Fu > > > Cc: Michael D Kinney > > > Cc: Jiewen Yao > > > Cc: Laszlo Ersek > > > Signed-off-by: Zhichao Gao > > > --- > > > CryptoPkg/Private/Protocol/Crypto.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/CryptoPkg/Private/Protocol/Crypto.h > > > b/CryptoPkg/Private/Protocol/Crypto.h > > > index 40c387e002..667ca1ef07 100644 > > > --- a/CryptoPkg/Private/Protocol/Crypto.h > > > +++ b/CryptoPkg/Private/Protocol/Crypto.h > > > @@ -20,7 +20,7 @@ > > > /// the EDK II Crypto Protocol is extended, this version define > > > must be /// increased. > > > /// > > > -#define EDKII_CRYPTO_VERSION 6 > > > +#define EDKII_CRYPTO_VERSION 7 > > > > > > /// > > > /// EDK II Crypto Protocol forward declaration > > > -- > > > 2.21.0.windows.1 >=20