From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.14206.1594706175245252263 for ; Mon, 13 Jul 2020 22:56:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=GcuBm1AB; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: zhichao.gao@intel.com) IronPort-SDR: XMm4nByX3evyxcJpJdmP2+m5vesCDB9WuOSqK+ylZdKqBzIvkFGSXVO4oc7iW8Eo2rb2FHKbEh 1RT4/fGL1dUg== X-IronPort-AV: E=McAfee;i="6000,8403,9681"; a="136280424" X-IronPort-AV: E=Sophos;i="5.75,350,1589266800"; d="scan'208";a="136280424" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2020 22:56:14 -0700 IronPort-SDR: T1fioa13Et15iTT1j1wI/4CROxi6zdNk/EhWou8vHi7olYrn7OqX+HSBK/xnwMEEX9ggY8i07P sDY30BUKRpJA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,350,1589266800"; d="scan'208";a="317610910" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by fmsmga002.fm.intel.com with ESMTP; 13 Jul 2020 22:56:13 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jul 2020 22:56:13 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.58) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jul 2020 22:56:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mclRRHXGBbYsibdx7fW7TGR5S5dglgddHjos50SsPXRTbenV5YB4A6n0lXEALs7Fid/rCsoozHnAdbzOK0ijMLEUTZMhNrDa3c1pHGze+AmqXqqCMA6ochJIYwE7SLI4kLvSChQeqYnVIgyeywQG5/16njGZgYzsGZyPso352E6hKcd4WGKf0BWt2K5h3rQPwV+t5YrtD8lKS/hTix8k8zGFNFrO10rvdGyoO1XOGh/IJZuZ/YyRiZRaGTxFMiHgmbPWpxgIyIVsMh9hXsXztYw2CnTEYpcEMqqNVXPNPRR4lo1BEKDAYd8tg1z5q87bhqBD69OMmMmhvbma0bIWZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1q6tNJkkV384vElvsNf1MU1ridDDJxaeWCYeuMkmIkY=; b=dElv3zWVbKn0zDHaYiMOOcVSP4VocevMesfhBxU6RSGQ+S24dxxSyNaMu8n9QTcMon3h/w3Xtpf3vbq/VSRnqPt8byW1unQs1ypeEvflwbABkjliJS23MQmUxzif1TS4U4BswW/ojxBiwsxY/1H8vQDBdlJ3Tl599J7VGku0CiMrdk/O4XPmpNnrcLJlyHupq16W9TIOeLRK9KR9/3zg5Ceoq04wzoAEfj/5S11ynL7dWTxLLIT4qM9M05kmUMzjDm00qNT4Hy4g6a8gRBn7CebaSm5aBRcP6lv3avk3qJdnm4GeZ41EpyaXeQTh+ENnQ4++FmCoJsR7ZAxBejR4zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1q6tNJkkV384vElvsNf1MU1ridDDJxaeWCYeuMkmIkY=; b=GcuBm1ABh5UXLtsGjbO3huCeHf8B7KMrWvhfUgEDz7+8ApcS5esR+jtx66qcuFBFdY/91n79fZwoEVyQ7AHnPP6YXTZj16Xiw4d8NqZ+XJLHJQ79CHbcanttHO3ueVuqYXrBPuoFRswUjIY7iq050IkOWnnjlmwUN+YvUA4HhSU= Received: from DM6PR11MB4425.namprd11.prod.outlook.com (2603:10b6:5:1d9::31) by DM6PR11MB2970.namprd11.prod.outlook.com (2603:10b6:5:65::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.22; Tue, 14 Jul 2020 05:56:11 +0000 Received: from DM6PR11MB4425.namprd11.prod.outlook.com ([fe80::ad34:e1fc:2e7b:d124]) by DM6PR11MB4425.namprd11.prod.outlook.com ([fe80::ad34:e1fc:2e7b:d124%3]) with mapi id 15.20.3174.026; Tue, 14 Jul 2020 05:56:11 +0000 From: "Gao, Zhichao" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Wu, Hao A" Subject: Re: [edk2-devel] [PATCH V3 3/3] MdeModulePkg/PartitionDxe: Add already start check for child hanldes Thread-Topic: [edk2-devel] [PATCH V3 3/3] MdeModulePkg/PartitionDxe: Add already start check for child hanldes Thread-Index: AQHWWYMWaut8+o5+mkSLrRnOoZtlJKkGXMUw Date: Tue, 14 Jul 2020 05:56:11 +0000 Message-ID: References: <20200714012259.30504-1-zhichao.gao@intel.com> <20200714012259.30504-4-zhichao.gao@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C612C31@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C612C31@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ca3af9ff-7046-485b-3c60-08d827ba9c6c x-ms-traffictypediagnostic: DM6PR11MB2970: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0DXW0eURFqPAEDDRZERKPJwxCJBcJVm88knqvL80EomnoI5+AYvfuEmbkvbONgPT4gAdbjqNsqoFjDs4n/NwR9g54k+Oz9g8YLPeH+hIpresg87g9hcy/NVlYLOaxd4RSrro7Zgy8hVqdO6le+K1FK4KRd9ADY053m4C1/Z/W8CFV0ghwCImpfJ0wuiB2LfOG8THlxaOxlgRMbUPRZePl3YUERYWE3VJ324FRYemDVBjAKCrbjR+m/t2EkuBuWRckhGOC5xwtlu3/dWsCWACQtlvG0jRzwmB3o4hlwxR27TVItSIo/+D3f7oysBP/XLx4n9iLvHwR6XI7Qf/8v60KKGzPRC4kjuGSIlVkvOC7oi7fWy62sFfP5DmztT1glzUiZhmlmUPLVkPCE28ipjwhw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4425.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(366004)(396003)(136003)(346002)(376002)(39860400002)(66476007)(76116006)(5660300002)(83380400001)(53546011)(66446008)(6506007)(52536014)(64756008)(66556008)(110136005)(316002)(66946007)(8676002)(2906002)(966005)(55016002)(9686003)(7696005)(33656002)(86362001)(478600001)(4326008)(71200400001)(8936002)(107886003)(26005)(186003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: ZdIQS8ah5yAO+LXrCIJxS1gUzVimY4dAeDshSawdziBqdUknm8wztWZyRsars6UzhoEl3JHXjiUVxLBTAj4eOwYdZk1Xg68/XZ3jjnStoB3uQb5H2fvXq+nsy2Aj5WsFGZixPjbSnNgvAPMk/pjDV2bMqovByX0JVTcMLs3eKWSuNnbEu1ThMx2BwGhOHmkKB5xoEx+ljnkgXdwcOwHtLAxCUTPqGrpIACmqezdCgGvkaRpy6dZZVKTxSGyQt+v1lyrfiZSd0GAvkdVL4p+WKxiDLyG1LcCr8kdB3tqb/covcsQURV11UE6jPmV0YTPilRjIhgHBn8vGHIM/e6hAXHukIAqwFkCrnQX514xhyaPBkY7wm5/qEgwB60ZOFQp7l5gYMGW4JPThz2xghyPktaN1wO41p6399VZ5nft6Y997Ig6uV+C+E2jPPCX7qK6KqvBswKla8JXniGYa60notGJNXQZKb5q4jyFfbvEQ/nFMzCkESI7JTNQ2NcNdX/CQ MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4425.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca3af9ff-7046-485b-3c60-08d827ba9c6c X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2020 05:56:11.2945 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: USJi6m7GwHzuQAAFplavku59CP9KjXhcJhpD9gWAsB+U/2QcHdOC9sRGSUtNWVfanFSJdo1TLRogJEf7KR2CoA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2970 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sure. Update the commit message here: The partition binding driver would run serval times during BDS. If the par= tition supports MBR, it would pass the first connect in the MBR routine fun= ction. The second connect would return already started which would be treat= ed as not found and continue to run next routine. That is incorrect behavio= r. The device should only support one partition format. Treat the already s= tarted as success to avoid incorrect next partition routine check. Thanks, Zhichao > -----Original Message----- > From: Ni, Ray > Sent: Tuesday, July 14, 2020 10:04 AM > To: devel@edk2.groups.io; Gao, Zhichao > Cc: Wu, Hao A > Subject: RE: [edk2-devel] [PATCH V3 3/3] MdeModulePkg/PartitionDxe: Add > already start check for child hanldes >=20 > Zhichao, > Can you add more information in the commit message on what bug the patch > can fix? > With that, Reviewed-by: Ray Ni >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Gao, > > Zhichao > > Sent: Tuesday, July 14, 2020 9:23 AM > > To: devel@edk2.groups.io > > Cc: Wu, Hao A ; Ni, Ray > > Subject: [edk2-devel] [PATCH V3 3/3] MdeModulePkg/PartitionDxe: Add > > already start check for child hanldes > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2823 > > > > Treat the EFI_ALREADY_STARTED as EFI_SUCCESS to avoid the partition > > driver continuely check next routine function. > > > > Cc: Hao A Wu > > Cc: Ray Ni > > Signed-off-by: Zhichao Gao > > Reviewed-by: Hao A Wu > > --- > > MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > > b/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > > index d1c878ad2e..6a43c3cafb 100644 > > --- a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > > +++ b/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > > @@ -1276,6 +1276,15 @@ PartitionInstallChildHandle ( > > } else { > > FreePool (Private->DevicePath); > > FreePool (Private); > > + > > + // > > + // if the Status =3D=3D EFI_ALREADY_STARTED, it means the child h= andles > > + // are already installed. So return EFI_SUCCESS to avoid do the n= ext > > + // partition type check. > > + // > > + if (Status =3D=3D EFI_ALREADY_STARTED) { > > + Status =3D EFI_SUCCESS; > > + } > > } > > > > return Status; > > -- > > 2.21.0.windows.1 > > > > > >=20 >=20