From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.9391.1594876132783335541 for ; Wed, 15 Jul 2020 22:08:53 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=hMai0jqC; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: zhichao.gao@intel.com) IronPort-SDR: 7kVUPr1zDjnXqbAIAHj9P/m7PDLjAcjVcbg4FHL0GXnv4H501FsSNgC4D+5CwW/S/fADVH2QW0 WGVKvFNjsYCQ== X-IronPort-AV: E=McAfee;i="6000,8403,9683"; a="234178182" X-IronPort-AV: E=Sophos;i="5.75,358,1589266800"; d="scan'208";a="234178182" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2020 22:08:52 -0700 IronPort-SDR: lzaEmEarhfruVM9F+NScJVD98dwMzZo19PgjxvA2l9151lGQW+HvtbDs0strpmJSIXdQCWVASC 6Kr8qjIEQk4Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,358,1589266800"; d="scan'208";a="286358076" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by orsmga006.jf.intel.com with ESMTP; 15 Jul 2020 22:08:51 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 15 Jul 2020 22:08:51 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.103) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 15 Jul 2020 22:08:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a6gO0ELJTUJ+JZVInUKJ1Mc5L0iJXK8d72X+Nfnvgw8xBfnZQYQU/+0DIIG9kN/2YLkAlBUw8LoMMkz+uD2uu/597U/cCwBk59IE1cBbK66n5hdxzYXLMYL/e6Schh7XRy4idW2jWyfnhNU7Un2baVS2FSXKPEyYLP9Yw2qqhqTbUOcO2rSizjFw4B4UVWCDaqFiRFiUs5GGZzYBPizWBiE40zstzBU2lOkm3q4MdZybkqLEw9pdr/ZUZsJCw58SAE1L2haqWZY6zS0o2oipaCMBHzqiQmJHhac1GzoKwLLXTybjHHjbjf/zT2xAEj4OxDNhuDwSNlsGI1n+ollB/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a4vJpsY+o7WZgEqfmvUE7Z3lqKDkFZDLvrthwtEXlCM=; b=BD+c3YG6PR/MmMI8Kbv3rU3l4YWWu0KmsiyeOxly9PnFw1orLWPww8KsjhiQDNBfUA41Trtxhj5B7ADXpwnUW2oU3bA0pisNbVEoX+8ux+bOuh2SIoPjU6jl+dhJ0V/SzqCWWbP0/WkgPaHc+P7pQWSz/VCnD9q8O7bn3pPzALEYWmeyNAOqF0NhtfSlUTP1u4AFs3RSvKB5iIeJOQ518Y1qdi737gfY9EcokegGPQE6Q07+5sv2sRvWfS4DJA/c3Ocp6L1uzp7oObFIWmTuIBAAv//z/8IrnQ5tQWF+Lbos7IoOVC2JinM6rcph5YdWByQIiLqh5TIlYmI40KJq7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a4vJpsY+o7WZgEqfmvUE7Z3lqKDkFZDLvrthwtEXlCM=; b=hMai0jqC0NwXfXf74rYCt8Tf19WO8m0FrSGuRjFZmzddX2W+MXCiB1KbPDB2IrZNpBoQU7HJlhTuEBX6k5KzR/uaxHYUvi0+TAUa3o9EADRsi49bzUD9x6iiNpDo2/Gmzq9ezw+Vcx53QAyLgnCGlZ4+6wvvzkcFY9lRkDBNeho= Received: from DM6PR11MB4425.namprd11.prod.outlook.com (2603:10b6:5:1d9::31) by DM6PR11MB3211.namprd11.prod.outlook.com (2603:10b6:5:58::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.23; Thu, 16 Jul 2020 05:08:49 +0000 Received: from DM6PR11MB4425.namprd11.prod.outlook.com ([fe80::ad34:e1fc:2e7b:d124]) by DM6PR11MB4425.namprd11.prod.outlook.com ([fe80::ad34:e1fc:2e7b:d124%3]) with mapi id 15.20.3195.017; Thu, 16 Jul 2020 05:08:49 +0000 From: "Gao, Zhichao" To: Gary Lin , "devel@edk2.groups.io" CC: "Wu, Hao A" , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH V3 3/3] MdeModulePkg/PartitionDxe: Add already start check for child hanldes Thread-Topic: [edk2-devel] [PATCH V3 3/3] MdeModulePkg/PartitionDxe: Add already start check for child hanldes Thread-Index: AQHWWyHKaut8+o5+mkSLrRnOoZtlJKkJoFaQ Date: Thu, 16 Jul 2020 05:08:49 +0000 Message-ID: References: <20200714012259.30504-1-zhichao.gao@intel.com> <20200714012259.30504-4-zhichao.gao@intel.com> <20200716033255.GL6058@GaryWorkstation> In-Reply-To: <20200716033255.GL6058@GaryWorkstation> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a9a1b4e8-ef4e-4a46-6be0-08d82946534d x-ms-traffictypediagnostic: DM6PR11MB3211: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: siLcHSDyZKYBFjrhpxLExNXckKgxbSHwysqGoX2I120HxafvYY/3sIKhR7k6pP94K6lLgsQ4sODJMdr8tzLSPi70StIOxt7XfFPwf/S3fGSRksAFSX5+v3x1uvQHKc30LoHFOc6NWUy0mhx9KiStnftYuMbVonpBbZpG0/oVwvnzyx0DgGvMgj2385V4UxnqedEMigFMRGeWNdVa9nmxnSwR7K9dflK2OqJMFnRRcPcXh18LGvbkDQ5Cs5y5IbIRFtmpZQmqs3+04nOkFpDb8nMQRpg3x8DGdhSanZn3poYJN/Qm4SIYaSpc2tX7iGr1rdOckn91DcThicw1GV3LGVeM9BhF3dfJtrJQJCkYOpyt9X6mv8Lna+bx9mqdF9YNkR7FYOHSWsuXUox6khxAug== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4425.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(396003)(366004)(376002)(136003)(39860400002)(52536014)(26005)(110136005)(9686003)(55016002)(71200400001)(186003)(76116006)(107886003)(2906002)(4326008)(478600001)(33656002)(53546011)(6506007)(54906003)(66946007)(86362001)(66446008)(316002)(64756008)(8936002)(7696005)(966005)(66476007)(66556008)(5660300002)(8676002)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: kMOfIloxdD7AnHDwpP5Bwrcgi6sEKdPW7e79vCZPO/+o8C6xibUZ/u7Xf4IfZaL5qDYsFLGXrr2GrKK36vhji2ilxAMawrEf5FI6e4yzpNfH3wr8UigAhTzzETOq4o7iKTHmik33br+aY5nd988H/b2V8o48dzzxvlV9gd/GZV0iDTyfS5gPh4YD5ux4lUHa/nU/XFaRoPOJW9aUwYXkNXtbuz9bBtZII1EKYolTd5FyOe2go2V5rQvDlsZuUoQ1XRyB2HTg8/lQXslJh0z2d307ngpDyNsnZiB2FMgzPpJr2M9M+dODOqCHd90bI7OpQ92szPNyLJYN/TgAtIUE1qBbXQSuao+RAozBkzgu7/Wy1+CjbSkwpH8Tvp3rhGT1it19HZARuF2yrL7S4e3HJG9+R5Iyx7IKqL71Tq5MEyaQCMDO9L4qiXfeb5LZMqNEyA90MJ2nfDt567ZkXUKDU4Tur7xICakFwHs69v50QxeyMvnYczyDnKoHlqIgYzpg MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4425.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9a1b4e8-ef4e-4a46-6be0-08d82946534d X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jul 2020 05:08:49.2948 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JETjVQm2pIrafjt7eMqOrihl2rVocTsxSHoUUM4Jer6UqcOC53ECCt0UB1RoKULcNrgwRfbRtv0Pqns8jLEmzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3211 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes. I have checked the image with OVMF. The SUSE image has the MBR table b= ut not like others, such as Ubuntu, RedHat and Fedora which would contain a= partition entry with the entire disk. That means it would pass the MBR child handle check and would never go to = the UDF(or ElTorito) check. I think we should update the invalid MBR check logic. Thanks, Zhichao > -----Original Message----- > From: Gary Lin > Sent: Thursday, July 16, 2020 11:33 AM > To: devel@edk2.groups.io; Gao, Zhichao > Cc: Wu, Hao A ; Ni, Ray > Subject: Re: [edk2-devel] [PATCH V3 3/3] MdeModulePkg/PartitionDxe: Add > already start check for child hanldes >=20 > On Tue, Jul 14, 2020 at 09:22:59AM +0800, Gao, Zhichao via groups.io wro= te: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2823 > > > > Treat the EFI_ALREADY_STARTED as EFI_SUCCESS to avoid the partition > > driver continuely check next routine function. > Hi Zhichao, >=20 > I just found that this patch breaks the loading of openSUSE iso images[*= ]. > Would you mind to take a look at it? >=20 > Thanks, >=20 > Gary Lin >=20 > [*] http://download.opensuse.org/distribution/leap/15.2/iso/openSUSE-Lea= p- > 15.2-NET-x86_64.iso >=20 > > > > Cc: Hao A Wu > > Cc: Ray Ni > > Signed-off-by: Zhichao Gao > > Reviewed-by: Hao A Wu > > --- > > MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > > b/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > > index d1c878ad2e..6a43c3cafb 100644 > > --- a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > > +++ b/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > > @@ -1276,6 +1276,15 @@ PartitionInstallChildHandle ( > > } else { > > FreePool (Private->DevicePath); > > FreePool (Private); > > + > > + // > > + // if the Status =3D=3D EFI_ALREADY_STARTED, it means the child h= andles > > + // are already installed. So return EFI_SUCCESS to avoid do the n= ext > > + // partition type check. > > + // > > + if (Status =3D=3D EFI_ALREADY_STARTED) { > > + Status =3D EFI_SUCCESS; > > + } > > } > > > > return Status; > > -- > > 2.21.0.windows.1 > > > > > >=20 > >