From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.173.1587947520467990580 for ; Sun, 26 Apr 2020 17:32:00 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=iOMPvG7D; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: zhichao.gao@intel.com) IronPort-SDR: w1+K31ugbjh9I9SY6derzqFzvVzI1oqkd49J42hiCETR4eYxZOM6J5kNGCXomRxfBX1TqSIz4J IXkDHk0mQ+0A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2020 17:31:59 -0700 IronPort-SDR: DDSKBO+e/ckhvGwucka2a52QmEY9x6wiZBB1ZRukUqF2DMjCmkVly6oHzB9BFnIuF6QvfMx7om 7cduUcm6FSMg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,321,1583222400"; d="scan'208";a="458135457" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by fmsmga005.fm.intel.com with ESMTP; 26 Apr 2020 17:31:37 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 26 Apr 2020 17:31:36 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.109) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 26 Apr 2020 17:31:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ERyCn1dNKt0Y27P0UYrqOzWdZzpv0ytL9i3i54rqasM24fDSWONG0SQf5DVSfcjxUjUxzkOjsCZWtd7UA2eevHF75aR3JsbEp1XKevpP0IORpKcDAD6IjdiScxlPsGXkWsAMkYXfERihZuRIsktKr/lmH7rD5icbv8H/eoT8wvPa05vfMNLbsNlHLnA7DYtbf7WmixB0N+SfVdkjgvFdkMsUwHW1Gk1IFmgp9MJ3H6Yo1CpqFwIARmS7U57Yys6TFI1LG7Nk7YZmOOpJobkRaOyRBxCUbZjgyOAyIueIHf0Xauia8bQvhNbOVsve02FaB1PHuyYirFcQJSGI5hZpRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IhQR35jgBh4IxGrO6tWlAxU6LCzkekvUG39vd9H/YZg=; b=ilakBxmVedWkUXkp8QtHZ0Jzn9JmvjMuXrH9O46D7JV2/via8ZXzWw7Qhk0fw5PFef6DO59LRK+oonD4eGTDesscZ9WkFSVLNlB1FaRjTnPOB+4fSSYw1rhguI3aY0p12LbpQwGBKkL1OTMK6VAGC/JRBesa6byHs1dPnzfqGbg6LA96hEOTPxyg1CHD3Fm9EJT2URKNIO9fFVEd1svm4ygDkZN4o9QPYztA9SEf0WsprfOCUCuyMbC/icVrPRa3WwnKriWKEhkCV2n3BbrV7ojcxiqhWm8a/cJ8H6+cjzPeyFPBST+s+HzVj9xuwYSi4trtqGG2t3ln0Vym+8G4cQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IhQR35jgBh4IxGrO6tWlAxU6LCzkekvUG39vd9H/YZg=; b=iOMPvG7DGiNPfx0TfVHPjwBozmq52IbLKMabzDIJtFVBRpEQI1JQE2dVahzVNUwrRJYNKu7S/ntzqJtPp19Nx+B5h4bz486RJPzvD/7IipbSHgWExIYR4XeZ2SNUT3pnG+gpPkVi/5KnQdfdOiUx/dGOamdjc5nLwZE5Q7aQiIo= Received: from DM6PR11MB4425.namprd11.prod.outlook.com (2603:10b6:5:1d9::31) by DM6PR11MB2889.namprd11.prod.outlook.com (2603:10b6:5:72::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Mon, 27 Apr 2020 00:31:34 +0000 Received: from DM6PR11MB4425.namprd11.prod.outlook.com ([fe80::615a:17b0:aa95:be1]) by DM6PR11MB4425.namprd11.prod.outlook.com ([fe80::615a:17b0:aa95:be1%3]) with mapi id 15.20.2937.023; Mon, 27 Apr 2020 00:31:34 +0000 From: "Gao, Zhichao" To: "devel@edk2.groups.io" , "Yao, Jiewen" , "Fu, Siyuan" CC: "Wang, Jian J" , "Lu, XiaoyuX" , "Kinney, Michael D" , Laszlo Ersek Subject: Re: [edk2-devel] [PATCH V2 7/7] CryptoPkg/Crypto.h: Update the version of Crypto Driver Thread-Topic: [edk2-devel] [PATCH V2 7/7] CryptoPkg/Crypto.h: Update the version of Crypto Driver Thread-Index: AQHWGUvNsY1k9UDKbEefUj5DweWQ46iJmUQwgABEgACAARqicIAAAkcAgAEnpEA= Date: Mon, 27 Apr 2020 00:31:33 +0000 Message-ID: References: <20200423084627.3384-1-zhichao.gao@intel.com> <20200423084627.3384-8-zhichao.gao@intel.com> <74D8A39837DF1E4DA445A8C0B3885C503FA0B443@shsmsx102.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C503FA0CEFC@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503FA0CEFC@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=zhichao.gao@intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cf4444db-13d3-4d6c-e230-08d7ea4256ca x-ms-traffictypediagnostic: DM6PR11MB2889: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0386B406AA x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4425.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(366004)(376002)(346002)(39860400002)(396003)(136003)(186003)(6636002)(4326008)(71200400001)(55016002)(9686003)(5660300002)(54906003)(110136005)(478600001)(8676002)(86362001)(66556008)(64756008)(66446008)(66476007)(52536014)(76116006)(66946007)(966005)(6506007)(53546011)(26005)(7696005)(8936002)(316002)(2906002)(81156014)(33656002)(15650500001);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: W79FvWKHlRUva6ec+bskejk5P/Y+hyVj471RYEYzoLRmaelRjK48PtGjVjtjVbkrWLCBK2A70vi80Sii7ryinUNoojTkTGxrbFwquiox3Cq8SqEv1AOlTmnbxp6Nmu75HrT2aj0phWXbb/oEvvIQHQTdZIeuhO19NDNXqiSNXckaTx56jmMMVSgibUo6NFSRyf8K72Uc6tjIhl8y3yHwUE6U5bAxYsbW+dyA2lx2BxDHYreTlcMkRl+zDQ2z3hkggCc1Ks7H5tMN63hG4JvktEENQMK0SNcGRAqTSaXNM277jbV4Uk2Fv55eD4veelCUmhVWMep3IM3lqn0eLJ/i+Ft83mbRSxF/TP9E1Qi11cg9ET0KWRuEBA8/iwCcPs+p6ZLO2FhokCyHbEfg05xzd6qzkjAsvC3MJGERWMT2icKdxO+dpWi99v/G56LV1cTuDT2jjO0leAfhq0Abj+7DQZqH2capGbvakLv//89O6eWQOWB3WmvGhWOguCaRNOqSz2+22lX9597LwzPlby30yg== x-ms-exchange-antispam-messagedata: qTq7iODPumYqynKKs8V3dLrsuSQ1FCq+oxwL6Dj6YOzXda1xLf6pzlTcntSWUqvYKTZfiQAD6FEuOjzo1JDSwMmfZfYAJYLXuWAW9KLBo+kB4e8ovxEwIcxwJsJPwVA6AJMQtenp+/L5b2eq+yT+g2qOcQ4ktwAqTF+PAIsHmfgldVoag8+iVgYWI2c7IR72fwIq9ycEoCVtjnf7nDhWnOsovj1curVdVyR2TgD2mQpkp8FZOQH0QWASFeK8QkVeanMb55qxNxK3EZMhinjmTCdPYjscPjAA7g7KQ24m1OpjQq3/c3WcFk1xJL5nm5adU5+XDYNZI3Pk3LbUI2KBNejRNCDDQPFEagByxPyucZTHPuK08oy0znowX8dtbeKz7y3I7YTBCKVRs48ENHcRyMBqeBAYkyFYVx7dPI4yOoV2voSxq2x+t0XX+dI/ijkWiqpuhkt0EHwc1hufe0xQu/ZGlRt0sKDPRN/1nz6wSFwSupS2tXflyEvbwEYh49S0cfowLApWm4SBPfJqJ4ObvhyHSfxaxJGdnMNG3RROh0o+CeegVzCwVIH1yojreQciliM0a5lMtSl2AQuoBphORU8plOIoq5vXg/zc7QQTrdc53Bb5B3zJ5l0vj+VFxvmWff93ClIE7ybLmoahxnYZSwzswEWFIvi4tQjfeOUeSzDucxTnmH8sze7+yNtmQJ0keaRa7zz4ivUX03P29S4OzvJny5Jo97haVbd+4xMS7XaegNuj/ETofnty8ixp2cQHdxVnNtRiqqhfpqPR38D9+ip7Da7GPevTmqs5pTTA48E= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: cf4444db-13d3-4d6c-e230-08d7ea4256ca X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2020 00:31:33.9563 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 88EDBt6cBuf6EVazKqYjqDaDUGxU8f4fdh6bait+wO97pzXmxbXuShzzRxAbeIp64ny1QjHe9vPqVIAvjiwfQg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2889 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable It is a incapability change. Hi Siyuan/Mike, Do you know who owns the update of the Crypt DXE driver? I want to get the= suggestion from the owner if we can make this change. Because the consumer= of this binary driver should aware of this change. Thanks, Zhichao > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Yao, Jiew= en > Sent: Sunday, April 26, 2020 2:48 PM > To: Gao, Zhichao ; Fu, Siyuan ; > devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, XiaoyuX ; > Kinney, Michael D ; Laszlo Ersek > > Subject: Re: [edk2-devel] [PATCH V2 7/7] CryptoPkg/Crypto.h: Update the = version > of Crypto Driver >=20 > You can change the protocol GUID and remote the function from the protoc= ol - > this is an internal protocol. It should not be called by anyone. >=20 > > -----Original Message----- > > From: Gao, Zhichao > > Sent: Sunday, April 26, 2020 2:43 PM > > To: Yao, Jiewen ; Fu, Siyuan > > ; devel@edk2.groups.io > > Cc: Wang, Jian J ; Lu, XiaoyuX > > ; Kinney, Michael D > > ; Laszlo Ersek > > Subject: RE: [PATCH V2 7/7] CryptoPkg/Crypto.h: Update the version of > > Crypto Driver > > > > Jiewen, > > > > Do you mean remove the definition of the deprecated function and keep > > the NULL value in the protocol structure? > > I am not sure if that is a good idea. Because that would give the > > protocol a chance to call a NULL pointer. > > > > Siyuan, > > > > The binary would be totally different. Does that make sence? > > > > Thanks, > > Zhichao > > > > > -----Original Message----- > > > From: Yao, Jiewen > > > Sent: Saturday, April 25, 2020 9:48 PM > > > To: Fu, Siyuan ; Gao, Zhichao > > > ; devel@edk2.groups.io > > > Cc: Wang, Jian J ; Lu, XiaoyuX > > ; > > > Kinney, Michael D ; Laszlo Ersek > > > > > > Subject: RE: [PATCH V2 7/7] CryptoPkg/Crypto.h: Update the version > > > of Crypto Driver > > > > > > Why not remove the deprecated functions ? > > > > > > Thank you > > > Yao Jiewen > > > > > > > -----Original Message----- > > > > From: Fu, Siyuan > > > > Sent: Saturday, April 25, 2020 5:45 PM > > > > To: Gao, Zhichao ; devel@edk2.groups.io > > > > Cc: Wang, Jian J ; Lu, XiaoyuX > > > > ; Kinney, Michael D > > > > ; Yao, Jiewen ; > > > > Laszlo Ersek > > > > Subject: RE: [PATCH V2 7/7] CryptoPkg/Crypto.h: Update the version > > > > of Crypto Driver > > > > > > > > Hi, Zhichao > > > > > > > > This patch set doesn't add or remove any field in EDK II Crypto > > > > Protocol, but just change some API implementation to return false > > > > or unsupport, right? If so I don't think the Crypto Version need t= o be > increased. > > > > > > > > Best Regards > > > > Siyuan > > > > > > > > > -----Original Message----- > > > > > From: Gao, Zhichao > > > > > Sent: 2020=1B$BG/=1B(B4=1B$B7n=1B(B23=1B$BF|=1B(B 16:46 > > > > > To: devel@edk2.groups.io > > > > > Cc: Wang, Jian J ; Lu, XiaoyuX > > > > > ; Fu, Siyuan ; > > > > > Kinney, Michael D ; Yao, Jiewen > > > > > ; Laszlo Ersek > > > > > Subject: [PATCH V2 7/7] CryptoPkg/Crypto.h: Update the version > > > > > of Crypto Driver > > > > > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1898 > > > > > > > > > > Update the Crypto Version to 7: > > > > > 1. Retire below deprecated functions: > > > > > MD4, ARC4, TDES, AES ECB MODE, HMAC MD5, HMAC SHA1 > > > > > > > > > > Cc: Jian J Wang > > > > > Cc: Xiaoyu Lu > > > > > Cc: Siyuan Fu > > > > > Cc: Michael D Kinney > > > > > Cc: Jiewen Yao > > > > > Cc: Laszlo Ersek > > > > > Signed-off-by: Zhichao Gao > > > > > --- > > > > > CryptoPkg/Private/Protocol/Crypto.h | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/CryptoPkg/Private/Protocol/Crypto.h > > > > > b/CryptoPkg/Private/Protocol/Crypto.h > > > > > index 40c387e002..667ca1ef07 100644 > > > > > --- a/CryptoPkg/Private/Protocol/Crypto.h > > > > > +++ b/CryptoPkg/Private/Protocol/Crypto.h > > > > > @@ -20,7 +20,7 @@ > > > > > /// the EDK II Crypto Protocol is extended, this version define > > > > > must be /// increased. > > > > > /// > > > > > -#define EDKII_CRYPTO_VERSION 6 > > > > > +#define EDKII_CRYPTO_VERSION 7 > > > > > > > > > > /// > > > > > /// EDK II Crypto Protocol forward declaration > > > > > -- > > > > > 2.21.0.windows.1 > > > > > >=20 >=20 >=20