From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "Jiang, Guomin" <guomin.jiang@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: kuqin <kuqin@microsoft.com>,
Sean Brogan <sean.brogan@microsoft.com>,
"Bret Barkelew" <Bret.Barkelew@microsoft.com>
Subject: Re: [PATCH v2] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer
Date: Thu, 14 May 2020 23:22:34 +0000 [thread overview]
Message-ID: <DM6PR11MB44583EF4F148E0CA966E36E2D2BC0@DM6PR11MB4458.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200414013254.2245-1-guomin.jiang@intel.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Mike
> -----Original Message-----
> From: Jiang, Guomin <guomin.jiang@intel.com>
> Sent: Monday, April 13, 2020 6:33 PM
> To: devel@edk2.groups.io
> Cc: kuqin <kuqin@microsoft.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Sean Brogan
> <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>
> Subject: [PATCH v2] UnitTestFrameworkPkg/UnitTestLib:
> Correct dereferred pointer
>
> From: kuqin <kuqin@microsoft.com>
>
> REF:
> https://bugzilla.tianocore.org/show_bug.cgi?id=2609
>
> SavedState is not sticky, copied pointer update will
> not change source
> pointer
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
> ---
> UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c
> | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git
> a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.
> c
> b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.
> c
> index b136992d99..ba4b18568d 100644
> ---
> a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.
> c
> +++
> b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.
> c
> @@ -209,7 +209,6 @@ InitUnitTestFramework (
> EFI_STATUS Status;
>
> UNIT_TEST_FRAMEWORK_HANDLE NewFrameworkHandle;
>
> UNIT_TEST_FRAMEWORK *NewFramework;
>
> - UNIT_TEST_SAVE_HEADER *SavedState;
>
>
>
> Status = EFI_SUCCESS;
>
> NewFramework = NULL;
>
> @@ -264,8 +263,7 @@ InitUnitTestFramework (
> // If there is a persisted context, load it now.
>
> //
>
> if (DoesCacheExist (NewFrameworkHandle)) {
>
> - SavedState = (UNIT_TEST_SAVE_HEADER
> *)NewFramework->SavedState;
>
> - Status = LoadUnitTestCache (NewFrameworkHandle,
> &SavedState);
>
> + Status = LoadUnitTestCache (NewFrameworkHandle,
> (UNIT_TEST_SAVE_HEADER**)(&NewFramework->SavedState));
>
> if (EFI_ERROR (Status)) {
>
> //
>
> // Don't actually report it as an error, but
> emit a warning.
>
> --
> 2.25.1.windows.1
prev parent reply other threads:[~2020-05-14 23:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 1:32 [PATCH v2] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer Guomin Jiang
2020-05-14 23:22 ` Michael D Kinney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB44583EF4F148E0CA966E36E2D2BC0@DM6PR11MB4458.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox