From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web08.1436.1617091697801345761 for ; Tue, 30 Mar 2021 01:08:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=q/qSxEj7; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: rangasai.v.chaganty@intel.com) IronPort-SDR: Jgc23WrcpGVOGZBwpLmBTU11W9gUlUK1hGPn3cRGDphc64rVc9VT3T1mqPq4Zr2j+K3P0jq2eW M7n7wPaORjNQ== X-IronPort-AV: E=McAfee;i="6000,8403,9938"; a="191187646" X-IronPort-AV: E=Sophos;i="5.81,290,1610438400"; d="scan'208";a="191187646" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2021 01:08:16 -0700 IronPort-SDR: W93FEkRobt9ujHXcPeh2IsJRaaZh8rsQtplQ75iVS/ZPjcdwiWe8KWK9odi1kCWILVZrp1f2lg 2AmkXTsAVhOw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,290,1610438400"; d="scan'208";a="445105903" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 30 Mar 2021 01:08:16 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 30 Mar 2021 01:08:16 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 30 Mar 2021 01:08:16 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.173) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 30 Mar 2021 01:08:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AKQ12LCMd8xEG/LuBgbrbdLLSuj8jBcYKATFQdddmn3fn8ZdFF8loc6pjwRmXyEN6slGLWuDwfklflOk1sgJUbvDSPPJLnF3z0mJZC7k4NM7uBe0ykJf0kAgBhQPzfZwPujGnnI2zDI6+YMkJGeMMK0okGhSC1L4OWS5XB2CKwVGE1FJTC7oJlLf1ry2Re4EHCS3zWzkb+hG+h1wAd2HHXYYXibXKquWNB04DCYRF15GILS57tRFOyI3UtrOyvrPpQa+9i4KvDh1XS/c77oU5W8VzsNhscUDjZN6ra9bxtFJm0jeVQJV296GdFwcgw4zyT5neKWeSk3JJOeAOur52g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9IU3r1M9ghIBJnz4CVzWBtGGQhd5WCUPQIm3N+H5CrU=; b=ZueF2Ymlo8TjIMl+rjHrQ8vUvBUG681YSvi7KPNB5RHQH/QlG5/qdr0vwyMcywtuaFqNySPROHDO8LRGVOK1hs+1ED2KkXg0R4OdAyF0oRoPGmzTYKurXmFyeQ7KpK66YDKn31baaFZYs1KqhasFXHqhJqUs32OrxI+BDifCHB0s1fvI3bBdEYJqSMJaJDULKx3zzxNQa6iP8e7fvUIqhGLGwlaCIfP00+r4Nk65UrzBCjGX38xcRUQEs3e0DaRUqbs6+CeyGtqk5VAhkXB9Ah0Ed9ZTL1AUSfA5LZzVLs1/6vc0PBypmkbPMqgUrNyVc6V2tl9CyELqh3zMzRCtYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9IU3r1M9ghIBJnz4CVzWBtGGQhd5WCUPQIm3N+H5CrU=; b=q/qSxEj791FY9h3Sc9on/oB0tUSBX8fyralwHt67avbb4m1jw77tbqMwMgg3euWCle2F1ElLR8TVFYSZuXGPVd7Q9jZ2fl1ESB4RMdJVE/WfnimQ5vA79dXYULZmA8wRQeO9yFPh8MbDRsFpb9zT0Ne4za1phCsYLniDDotofps= Received: from DM6PR11MB4476.namprd11.prod.outlook.com (2603:10b6:5:201::24) by DM6PR11MB4675.namprd11.prod.outlook.com (2603:10b6:5:2ac::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.29; Tue, 30 Mar 2021 08:08:13 +0000 Received: from DM6PR11MB4476.namprd11.prod.outlook.com ([fe80::4167:e5c7:e700:aab9]) by DM6PR11MB4476.namprd11.prod.outlook.com ([fe80::4167:e5c7:e700:aab9%6]) with mapi id 15.20.3977.033; Tue, 30 Mar 2021 08:08:13 +0000 From: "Chaganty, Rangasai V" To: "Ni, Ray" , "devel@edk2.groups.io" Subject: Re: [PATCH 1/3] IntelSiliconPkg: Define PCDs for microcode location in flash Thread-Topic: [PATCH 1/3] IntelSiliconPkg: Define PCDs for microcode location in flash Thread-Index: AQHXIhLP/HqF3EV6K0iVdwB8YBXonqqcM2qg Date: Tue, 30 Mar 2021 08:08:13 +0000 Message-ID: References: <20210326073629.1383-1-ray.ni@intel.com> <20210326073629.1383-2-ray.ni@intel.com> In-Reply-To: <20210326073629.1383-2-ray.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.45.159.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dd5de34f-4cb9-4da0-830e-08d8f352f72f x-ms-traffictypediagnostic: DM6PR11MB4675: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aE0PypDg/g5+G3hrS9bbZNPAaGMwc3D+ytWfdmOr/KDJPdo0J0bYQKYiMfU5rMl0093gU/a5OEdTzSwYmd6+48fUuC3+c1rssSHHhte1byhO5DD27ZJQwcjpP1TSk+/UYmfzR6m2hJO3KaYaIToOXTlgtJIGaY2337/m8kKescopE5XN/XrupMsYPUYcrPHeCHVf5iLmorYxO5fJFHGefcPQALf8cFKIPVOpv+uz+fOGvjntpKIpTaIU7QTtrslTbPfC2HEdTB3pqlpqZ/a762vsDytWej/Imt3O6UmBcrBPNwEuCOoUtXFygwRsi3u8BSQFTfcKy8kh84ZIYEQsO/x5p/ey+S7JimSHhoVcZ0yFhJwB5hPs4Ee12SiZCstFJSelCixOqD5xhsrUBMoERzqoZH7Rmny6dPJ4BdiTuLE37mr8KoB6JDXgiW4LApCupxGVcABw0Jw8DbBVw9cwpdM9PuIx7GjY5v90ETTKMy5zsIcfqDPFVGnLXZPeTCtdKyOBu0FyRulyIphvwaqIcDcEmnrHTrJQ5aHEZuoJhLrvDDDgieJCbdSSewXmQFU8rbyItIXDgYq5CuPlSn860M/QwhMfjcDijttr5nwm9kZJHYpzvyK6l4+fvLuwBA0FCa1b9VbwAY4GGMCG70AM+Sr8lgzK99k0L3rijb1nuqE= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4476.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(366004)(136003)(396003)(346002)(376002)(86362001)(6506007)(66446008)(2906002)(9686003)(33656002)(53546011)(5660300002)(316002)(83380400001)(110136005)(76116006)(66946007)(8676002)(66476007)(71200400001)(19627235002)(52536014)(186003)(478600001)(26005)(55016002)(8936002)(7696005)(66556008)(38100700001)(64756008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?2yKgkme8mZMReBPaX6QgGnvNN9O3obtVOG8QFwvWZii8IzFVhEG5N97RILFX?= =?us-ascii?Q?AbFdlts2e1L3punBJOAnAv9dB7RDDM4o41Apotbmh2KLy0nw4/ALXiIFguDT?= =?us-ascii?Q?r608b/bBpd0UkefhOQ7xWyBn13jUvGUeJVy4h2GjBB2k77tu/z0nLI3Pt82r?= =?us-ascii?Q?aQ8fD5GzSJYKm8GNr4ywA27VkDtM9vLWJfj3fa8W4F/X8vGOx/cwVWIzsodT?= =?us-ascii?Q?V0CujoDbxNiHej7ZWocz9dbJ57ScOklpGCtOkQtNWfEDye5B/cJlxJ+61hVA?= =?us-ascii?Q?TQt9k7RHVyU7q1i6F2S8zdftBDmdMHDAvZfgdS9mYer5F0CRNQ+I8MS4g9Nl?= =?us-ascii?Q?wRQ1Wo5aVt1l6TDiY4NcE4we1/rXYG4aWpEn3KUiHyFZmXEUFasVdpAy6uIC?= =?us-ascii?Q?HQ0GX0yjRhwlAa8qD5m3zW7yub90mgXnl76R/5YXepS0I1p3FTy59AGI3BFw?= =?us-ascii?Q?uaPMCFrxe2SVQFzVJnBeufIPeVtKVH7WE/VJ7lhLkDtXVK3HzqHv/sQup7Lk?= =?us-ascii?Q?eNjkGr3gj8PR8P+45nndbVcD8xQciwg2nF0830h5QOQAn4voGO6xhKvaEwOu?= =?us-ascii?Q?+VKaPStDrBi5NTSeJCquESHXVv2ItnSJVirQxUb2nQjqCtV/OAO7EyzJQNOK?= =?us-ascii?Q?+/VTvT8pvlBfADU+q0xSoKaIZ+x8pyWrgMN+2C8asC6O446rlNJ1caV6DsP2?= =?us-ascii?Q?cK2zt09WFFKhJpgvtfjMq2/f6rgB49x8Dw2eiQWDh7ZkhOpV9XoWmcazhx8k?= =?us-ascii?Q?jdeDxZyB1B9RSmGTi95VE2F2i3EFDJC4CcfVQm5njE0P9f3ZkAsRsdYsD+f1?= =?us-ascii?Q?QyNfJQmg7F2mD+n1x1Sfi2wzoVBrDNacc0VRySAIZXKsir1Ukhb/0tVjC+F5?= =?us-ascii?Q?SN/OndBNOH/sXnPGlhKUDDfsOuTPt9nBAzmt14jcsw3Q2FB06jj7zAE0gYLS?= =?us-ascii?Q?wyDdQF1yVfmQs2K4ibAXJ9H+mZlBCX5zh9jXYlLY2HdZaVaQjl6MoXErK6MN?= =?us-ascii?Q?yMf6EztWlnlzasMWmuAAzNN2mQqR0Sq2kK8b6fcEKi4hKA+s0Rp6Anvmp+Uu?= =?us-ascii?Q?IKP0lBLCc0pAiOT1woHpxTyQDx+TCa5C5SRJHV6dXCeyjlh55YOcx107CAXH?= =?us-ascii?Q?IVCvrBPflj85Z7TdY+ipdE/oDCOq/KPIJYE1ySkSAPzb3NSOQE8M19WnX7SG?= =?us-ascii?Q?HpTxRDDoZjlyWnlDYSZrQ0l0L7voADLWBADFF702Ff0EmMZCHIlXFKdISrWv?= =?us-ascii?Q?1VJSOeZy0lRfgjkbQCHOKMecnOse/IlNi1oKFa7AEjlLUHyVlwwbJgCCY43s?= =?us-ascii?Q?xXhREHLkg+Ok1kPYISkeej3G?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4476.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dd5de34f-4cb9-4da0-830e-08d8f352f72f X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2021 08:08:13.1459 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xV4l/Tp6txfRQLeRk9UouejCs8QU+scYSrOI8Upipdt8CD/lu9Gc2aSS87948b76jSlnfur/uwDTxPLhSGmvbGyAojcoYzI/CGuHR9nbZBk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4675 Return-Path: rangasai.v.chaganty@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sai Chaganty =20 -----Original Message----- From: Ni, Ray =20 Sent: Friday, March 26, 2021 12:36 AM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V Subject: [PATCH 1/3] IntelSiliconPkg: Define PCDs for microcode location in= flash 3 PCDs are defined assuming that microcode is put in the end of a FV: PcdFlashFvMicrocodeBase: The base address of the microcode FV PcdFlashFvMicrocodeSize: The size of the microcode FV PcdFlashMicrocodeOffset: The microcode offset relative to the FV base address The 3 new PCDs are to replace the following existing PCDs in MinPlatformPkg= and IntelFsp2WrapperPkg. The ones in MinPlatformPkg will be removed in a separate patch. The ones in IntelFsp2WrapperPkg will be re-positioned as only using inside = IntelFsp2WrapperPkg\Library\SecFspWrapperPlatformSecLibSample. Defining PCDs in IntelSiliconPkg is because certain close-source silicon co= de depends on these PCDs but the silicon code cannot depend on MinPlatformP= kg. MinPlatformPkg contains the below 3 PCDs: PcdFlashFvMicrocodeBase: Same meaning as IntelSiliconPkg.PcdFlashFvMicrocodeBase PcdFlashFvMicrocodeSize: Same meaning as IntelSiliconPkg.PcdFlashFvMicrocodeSize PcdFlashFvMicrocodeOffset: The FV offset relative to the firmware base address. Note: MinPlatformPkg doesn't contain the PCD that tells the microcode offse= t relative to the FV base address. IntelFsp2WrapperPkg contains the below 3 PCDs: PcdCpuMicrocodePatchAddress: Same meaning as IntelSiliconPkg.PcdFlashFvMicrocodeBase PcdCpuMicrocodePatchRegionSize: Same meaning as IntelSiliconPkg.PcdFlashFvMicrocodeSize PcdFlashMicrocodeOffset: Same meaning as IntelSiliconPkg.PcdFlashMicrocodeOffset Signed-off-by: Ray Ni Cc: Rangasai V Chaganty --- Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec b/Silicon/In= tel/IntelSiliconPkg/IntelSiliconPkg.dec index 4a2cbca5..6611c3af 100644 --- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec +++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec @@ -3,7 +3,7 @@ # # This package provides common open source Intel silicon modules. #-# Co= pyright (c) 2016 - 2020, Intel Corporation. All rights reserved.
+# Copy= right (c) 2016 - 2021, Intel Corporation. All rights reserved.
# SPDX-L= icense-Identifier: BSD-2-Clause-Patent # ##@@ -90,6 +90,13 @@ # @Prompt Error code for VTd error. gIntelSiliconPkgTokenSpaceGuid.Pcd= ErrorCodeVTdError|0x02008000|UINT32|0x00000005 + gIntelSiliconPkgTokenSpac= eGuid.PcdFlashFvMicrocodeBase|0|UINT32|0x00000007+ gIntelSiliconPkgTokenSp= aceGuid.PcdFlashFvMicrocodeSize|0|UINT32|0x00000008++ ## This is the micro= code offset relative to the FV base address.+ # Microcode address equals = to PcdFlashFvMicrocodeBase + PcdFlashMicrocodeOffset.+ gIntelSiliconPkgTok= enSpaceGuid.PcdFlashMicrocodeOffset|0|UINT32|0x0000000A+ [PcdsFixedAtBuild,= PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] ## This is the GUID o= f the FFS which contains the Graphics Video BIOS Table (VBT) # The VBT co= ntent is stored as a RAW section which is consumed by GOP PEI/UEFI driver.-= -=20 2.27.0.windows.1