Re: [PATCH] * MdePkg/SmBios.h: Updated newly added socket info from smbios 3.4.

Re: [PATCH] * MdePkg/SmBios.h: Updated newly added socket info from smbios 3.4.

[Chaganty, Rangasai V]

Please also update SmbiosView library in ShellPkg with the new socket types.
With that:
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>

-----Original Message-----
From: Bhargava, Avinash <avinash.bhargava@intel.com> 
Sent: Tuesday, April 20, 2021 7:39 AM
To: devel@edk2.groups.io
Cc: Ni, Ray <ray.ni@intel.com>; Chaganty; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Kumar; Kumar, Chandana C <chandana.c.kumar@intel.com>
Subject: [PATCH] * MdePkg/SmBios.h: Updated newly added socket info from smbios 3.4.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3140
Add theses socket type to MdePkg\Include\IndustryStandard\SmBios.h
-LGA1200
-LGA4189

Signed-off-by: Avinash Bhargava <avinash.bhargava@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Kumar, Chandana C <chandana.c.kumar@intel.com>
---
 MdePkg/Include/IndustryStandard/SmBios.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h
index cc023b7369..39dfe4e137 100644
--- a/MdePkg/Include/IndustryStandard/SmBios.h
+++ b/MdePkg/Include/IndustryStandard/SmBios.h
@@ -1,7 +1,7 @@
 /** @file

   Industry Standard Definitions of SMBIOS Table Specification v3.3.0.

 

-Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>

+Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.<BR>

 (C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP<BR>

 (C) Copyright 2015 - 2019 Hewlett Packard Enterprise Development LP<BR>

 SPDX-License-Identifier: BSD-2-Clause-Patent

@@ -810,7 +810,9 @@ typedef enum {
   ProcessorUpgradeSocketLGA2066   = 0x39,

   ProcessorUpgradeSocketBGA1392   = 0x3A,

   ProcessorUpgradeSocketBGA1510   = 0x3B,

-  ProcessorUpgradeSocketBGA1528   = 0x3C

+  ProcessorUpgradeSocketBGA1528   = 0x3C,

+  ProcessorUpgradeSocketLGA4189   = 0x3D,

+  ProcessorUpgradeSocketLGA1200   = 0x3E

 } PROCESSOR_UPGRADE;

 

 ///

-- 
2.28.0.windows.1

回复: [PATCH] * MdePkg/SmBios.h: Updated newly added socket info from smbios 3.4.

[gaoliming]

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
> 发送时间: 2021年4月21日 14:53
> 收件人: Bhargava, Avinash <avinash.bhargava@intel.com>;
> devel@edk2.groups.io
> 抄送: Ni, Ray <ray.ni@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Kumar, Chandana C <chandana.c.kumar@intel.com>
> 主题: RE: [PATCH] * MdePkg/SmBios.h: Updated newly added socket info
> from smbios 3.4.
> 
> Please also update SmbiosView library in ShellPkg with the new socket
types.
> With that:
> Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>
> 
> -----Original Message-----
> From: Bhargava, Avinash <avinash.bhargava@intel.com>
> Sent: Tuesday, April 20, 2021 7:39 AM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Chaganty; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Kumar; Kumar, Chandana C <chandana.c.kumar@intel.com>
> Subject: [PATCH] * MdePkg/SmBios.h: Updated newly added socket info from
> smbios 3.4.
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3140
> Add theses socket type to MdePkg\Include\IndustryStandard\SmBios.h
> -LGA1200
> -LGA4189
> 
> Signed-off-by: Avinash Bhargava <avinash.bhargava@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Kumar, Chandana C <chandana.c.kumar@intel.com>
> ---
>  MdePkg/Include/IndustryStandard/SmBios.h | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> b/MdePkg/Include/IndustryStandard/SmBios.h
> index cc023b7369..39dfe4e137 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -1,7 +1,7 @@
>  /** @file
> 
>    Industry Standard Definitions of SMBIOS Table Specification v3.3.0.
> 
> 
> 
> -Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>
> 
> +Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.<BR>
> 
>  (C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP<BR>
> 
>  (C) Copyright 2015 - 2019 Hewlett Packard Enterprise Development LP<BR>
> 
>  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> @@ -810,7 +810,9 @@ typedef enum {
>    ProcessorUpgradeSocketLGA2066   = 0x39,
> 
>    ProcessorUpgradeSocketBGA1392   = 0x3A,
> 
>    ProcessorUpgradeSocketBGA1510   = 0x3B,
> 
> -  ProcessorUpgradeSocketBGA1528   = 0x3C
> 
> +  ProcessorUpgradeSocketBGA1528   = 0x3C,
> 
> +  ProcessorUpgradeSocketLGA4189   = 0x3D,
> 
> +  ProcessorUpgradeSocketLGA1200   = 0x3E
> 
>  } PROCESSOR_UPGRADE;
> 
> 
> 
>  ///
> 
> --
> 2.28.0.windows.1