Re: [PATCH 5/7] KabylakeOpenBoard: Move ReportCpuHob library path

Re: [PATCH 5/7] KabylakeOpenBoard: Move ReportCpuHob library path

[Chiu, Chasel]

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: Chuang, SofiaX <sofiax.chuang@intel.com>
> Sent: Monday, April 19, 2021 4:44 PM
> To: devel@edk2.groups.io
> Cc: Chuang, SofiaX <sofiax.chuang@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Jeremy Soller <jeremy@system76.com>
> Subject: [PATCH 5/7] KabylakeOpenBoard: Move ReportCpuHob library path
> 
> From: SofiaX Chuang <sofiax.chuang@intel.com>
> 
> Move ReportCpuHob library from MinPlatformPkg to IntelSiliconPkg.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Jeremy Soller <jeremy@system76.com>
> ---
>  .../KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc  | 11 ++++++++---
>  .../KabylakeRvp3/OpenBoardPkg.dsc                     | 11 ++++++++---
>  2 files changed, 16 insertions(+), 6 deletions(-)
> 
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> index 862e6a6655..302cb679b5 100644
> --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> @@ -1,7 +1,7 @@
>  ## @file
> 
>  #  The main build description file for the GalagoPro3 board.
> 
>  #
> 
> -# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.<BR>
> 
> +# Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.<BR>
> 
>  #
> 
>  # SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  #
> 
> @@ -38,7 +38,8 @@
>    #
> 
>    # Include PCD configuration for this board.
> 
>    #
> 
> -  !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
> 
> 
> +  !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
> 
> +
> 
>    !include OpenBoardPkgPcd.dsc
> 
>    !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
> 
> 
> 
> @@ -160,7 +161,11 @@
> 
> DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDe
> bugLibReportStatusCode.inf
> 
>    SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf
> 
> 
> SetCacheMtrrLib|$(PLATFORM_PACKAGE)/Library/SetCacheMtrrLib/SetCacheM
> trrLibNull.inf
> 
> -
> ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHob
> Lib/ReportCpuHobLib.inf
> 
> +
> 
> +  #######################################
> 
> +  # Silicon Package
> 
> +  #######################################
> 
> +
> ReportCpuHobLib|IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.i
> nf
> 
> 
> 
>    #######################################
> 
>    # Platform Package
> 
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> index 0b30da8f96..8523ab3f4f 100644
> --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> @@ -1,7 +1,7 @@
>  ## @file
> 
>  #  The main build description file for the KabylakeRvp3 board.
> 
>  #
> 
> -# Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.<BR>
> 
> +# Copyright (c) 2017 - 2021, Intel Corporation. All rights reserved.<BR>
> 
>  #
> 
>  # SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  #
> 
> @@ -37,7 +37,8 @@
>    #
> 
>    # Include PCD configuration for this board.
> 
>    #
> 
> -  !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
> 
> 
> +  !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
> 
> +
> 
>    !include OpenBoardPkgPcd.dsc
> 
>    !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
> 
> 
> 
> @@ -201,6 +202,11 @@
> 
> SecBoardInitLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/SecBoardInitLibN
> ull/SecBoardInitLibNull.inf
> 
> 
> 
>  [LibraryClasses.common.PEIM]
> 
> +  #######################################
> 
> +  # Silicon Package
> 
> +  #######################################
> 
> +
> ReportCpuHobLib|IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.i
> nf
> 
> +
> 
>    #######################################
> 
>    # Platform Package
> 
>    #######################################
> 
> @@ -212,7 +218,6 @@
> 
> TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLib/Pei
> TestPointCheckLib.inf
> 
>  !endif
> 
> 
> SetCacheMtrrLib|$(PLATFORM_PACKAGE)/Library/SetCacheMtrrLib/SetCacheM
> trrLibNull.inf
> 
> -
> ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHob
> Lib/ReportCpuHobLib.inf
> 
> 
> 
>    #######################################
> 
>    # Board Package
> 
> --
> 2.27.0

Re: [PATCH 7/7] MiniPlatformPkg: Move ReportCpuHob library path

[Chiu, Chasel]

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: Chuang, SofiaX <sofiax.chuang@intel.com>
> Sent: Monday, April 19, 2021 4:44 PM
> To: devel@edk2.groups.io
> Cc: Chuang, SofiaX <sofiax.chuang@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Dong, Eric <eric.dong@intel.com>
> Subject: [PATCH 7/7] MiniPlatformPkg: Move ReportCpuHob library path
> 
> From: SofiaX Chuang <sofiax.chuang@intel.com>
> 
> Move ReportCpuHob library from MinPlatformPkg to IntelSiliconPkg.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> ---
>  Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc               | 2 +-
>  .../PlatformInit/PlatformInitPei/PlatformInitPreMem.inf        | 3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> index 707686055c..35cbd40abb 100644
> --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> @@ -94,7 +94,7 @@
>    #
> 
> 
> FspWrapperPlatformLib|MinPlatformPkg/FspWrapper/Library/PeiFspWrapperPl
> atformLib/PeiFspWrapperPlatformLib.inf
> 
> 
> ReportFvLib|MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiReportFvLi
> b.inf
> 
> -
> ReportCpuHobLib|MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/Repo
> rtCpuHobLib.inf
> 
> +
> ReportCpuHobLib|IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.i
> nf
> 
> 
> TestPointCheckLib|MinPlatformPkg/Test/Library/TestPointCheckLib/PeiTestPoin
> tCheckLib.inf
> 
>    TestPointLib|MinPlatformPkg/Test/Library/TestPointLib/PeiTestPointLib.inf
> 
> 
> SetCacheMtrrLib|MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMtrrLibNul
> l.inf
> 
> diff --git
> a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
> Mem.inf
> b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
> Mem.inf
> index e37bcba560..fb997838ef 100644
> ---
> a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
> Mem.inf
> +++
> b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
> Mem.inf
> @@ -1,7 +1,7 @@
>  ### @file
> 
>  # Component information file for the Platform Init Pre-Memory PEI module.
> 
>  #
> 
> -# Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.<BR>
> 
> +# Copyright (c) 2017 - 2021, Intel Corporation. All rights reserved.<BR>
> 
>  #
> 
>  # SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  #
> 
> @@ -33,6 +33,7 @@
>    MinPlatformPkg/MinPlatformPkg.dec
> 
>    MdeModulePkg/MdeModulePkg.dec
> 
>    MdePkg/MdePkg.dec
> 
> +  IntelSiliconPkg/IntelSiliconPkg.dec
> 
> 
> 
>  [Pcd]
> 
>    gMinPlatformPkgTokenSpaceGuid.PcdFspWrapperBootMode          ##
> CONSUMES
> 
> --
> 2.27.0

Re: [PATCH 6/7] WhiskeylakeOpenBoard: Move library path

[Chiu, Chasel]

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: Chuang, SofiaX <sofiax.chuang@intel.com>
> Sent: Monday, April 19, 2021 4:44 PM
> To: devel@edk2.groups.io
> Cc: Chuang, SofiaX <sofiax.chuang@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>
> Subject: [PATCH 6/7] WhiskeylakeOpenBoard: Move library path
> 
> From: SofiaX Chuang <sofiax.chuang@intel.com>
> 
> Move ReportCpuHob library from MinPlatformPkg to IntelSiliconPkg.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
>  .../WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc      | 7 ++++---
>  .../WhiskeylakeURvp/OpenBoardPkg.dsc                       | 7 ++++---
>  2 files changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
> index fb493973e2..ee2aedd978 100644
> --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
> +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
> @@ -1,7 +1,7 @@
>  ## @file
> 
>  #  The main build description file for the UpXtreme board.
> 
>  #
> 
> -#  Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
> 
> +#  Copyright (c) 2020 - 2021, Intel Corporation. All rights reserved.<BR>
> 
>  #
> 
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  #
> 
> @@ -39,7 +39,8 @@
>    #
> 
>    # Include PCD configuration for this board.
> 
>    #
> 
> -  !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
> 
> 
> +  !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
> 
> +
> 
>    !include OpenBoardPkgPcd.dsc
> 
>    !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
> 
> 
> 
> @@ -160,6 +161,7 @@
>    # Silicon Initialization Package
> 
>    #######################################
> 
> 
> SiliconInitLib|$(PLATFORM_SI_PACKAGE)/Library/PeiSiliconInitLib/PeiSiliconInitL
> ib.inf
> 
> +
> ReportCpuHobLib|IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.i
> nf
> 
> 
> 
>    #######################################
> 
>    # Platform Package
> 
> @@ -172,7 +174,6 @@
> 
> TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLib/Pei
> TestPointCheckLib.inf
> 
>  !endif
> 
> 
> SetCacheMtrrLib|$(PLATFORM_PACKAGE)/Library/SetCacheMtrrLib/SetCacheM
> trrLibNull.inf
> 
> -
> ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHob
> Lib/ReportCpuHobLib.inf
> 
> 
> 
>    #######################################
> 
>    # Board Package
> 
> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.
> dsc
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.
> dsc
> index 9a1f107faf..b69cc8deb0 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.
> dsc
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.
> dsc
> @@ -1,7 +1,7 @@
>  ## @file
> 
>  #  The main build description file for the WhiskeylakeURvp board.
> 
>  #
> 
> -#  Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.<BR>
> 
> +#  Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.<BR>
> 
>  #
> 
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  #
> 
> @@ -39,7 +39,8 @@
>    #
> 
>    # Include PCD configuration for this board.
> 
>    #
> 
> -  !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
> 
> 
> +  !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
> 
> +
> 
>    !include OpenBoardPkgPcd.dsc
> 
>    !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
> 
> 
> 
> @@ -160,6 +161,7 @@
>    # Silicon Initialization Package
> 
>    #######################################
> 
> 
> SiliconInitLib|$(PLATFORM_SI_PACKAGE)/Library/PeiSiliconInitLib/PeiSiliconInitL
> ib.inf
> 
> +
> ReportCpuHobLib|IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.i
> nf
> 
> 
> 
>    #######################################
> 
>    # Platform Package
> 
> @@ -172,7 +174,6 @@
> 
> TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLib/Pei
> TestPointCheckLib.inf
> 
>  !endif
> 
> 
> SetCacheMtrrLib|$(PLATFORM_PACKAGE)/Library/SetCacheMtrrLib/SetCacheM
> trrLibNull.inf
> 
> -
> ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHob
> Lib/ReportCpuHobLib.inf
> 
> 
> 
>    #######################################
> 
>    # Board Package
> 
> --
> 2.27.0

Re: [PATCH 2/7] CometlakeOpenBoard: Move ReportCpuHob library path

[Chiu, Chasel]

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: Chuang, SofiaX <sofiax.chuang@intel.com>
> Sent: Monday, April 19, 2021 4:44 PM
> To: devel@edk2.groups.io
> Cc: Chuang, SofiaX <sofiax.chuang@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Kethi Reddy, Deepika
> <deepika.kethi.reddy@intel.com>; Esakkithevar, Kathappan
> <kathappan.esakkithevar@intel.com>
> Subject: [PATCH 2/7] CometlakeOpenBoard: Move ReportCpuHob library path
> 
> From: SofiaX Chuang <sofiax.chuang@intel.com>
> 
> Move ReportCpuHob library from MinPlatformPkg to IntelSiliconPkg.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
> Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
> ---
>  .../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc      | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git
> a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
> b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
> index 6de834565a..44a1bd54d6 100644
> ---
> a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
> +++
> b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
> @@ -1,7 +1,7 @@
>  ## @file
> 
>  #  The main build description file for the CometlakeURvp board.
> 
>  #
> 
> -#  Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
> 
> +#  Copyright (c) 2020 - 2021, Intel Corporation. All rights reserved.<BR>
> 
>  #
> 
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  #
> 
> @@ -161,6 +161,7 @@
>    # Silicon Initialization Package
> 
>    #######################################
> 
> 
> SiliconInitLib|$(PLATFORM_SI_PACKAGE)/Library/PeiSiliconInitLib/PeiSiliconInitL
> ib.inf
> 
> +
> ReportCpuHobLib|IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.i
> nf
> 
> 
> 
>    #######################################
> 
>    # Platform Package
> 
> @@ -173,7 +174,6 @@
> 
> TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLib/Pei
> TestPointCheckLib.inf
> 
>  !endif
> 
> 
> SetCacheMtrrLib|$(PLATFORM_PACKAGE)/Library/SetCacheMtrrLib/SetCacheM
> trrLibNull.inf
> 
> -
> ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHob
> Lib/ReportCpuHobLib.inf
> 
> 
> 
>    #######################################
> 
>    # Board Package
> 
> --
> 2.27.0

Re: [PATCH 2/7] CometlakeOpenBoard: Move ReportCpuHob library path

[Kathappan Esakkithevar]

Reviewed-by: Esakkithevar, Kathappan <Kathappan.Esakkithevar@intel.com>
Please update BZ ID in commit messages

> -----Original Message-----
> From: Chiu, Chasel <chasel.chiu@intel.com>
> Sent: Monday, April 19, 2021 2:31 PM
> To: Chuang, SofiaX <sofiax.chuang@intel.com>; devel@edk2.groups.io
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Chaganty,
> Rangasai V <rangasai.v.chaganty@intel.com>; Kethi Reddy, Deepika
> <deepika.kethi.reddy@intel.com>; Esakkithevar, Kathappan
> <kathappan.esakkithevar@intel.com>
> Subject: RE: [PATCH 2/7] CometlakeOpenBoard: Move ReportCpuHob library
> path
> 
> 
> Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> 
> > -----Original Message-----
> > From: Chuang, SofiaX <sofiax.chuang@intel.com>
> > Sent: Monday, April 19, 2021 4:44 PM
> > To: devel@edk2.groups.io
> > Cc: Chuang, SofiaX <sofiax.chuang@intel.com>; Chiu, Chasel
> > <chasel.chiu@intel.com>; Desimone, Nathaniel L
> > <nathaniel.l.desimone@intel.com>; Chaganty, Rangasai V
> > <rangasai.v.chaganty@intel.com>; Kethi Reddy, Deepika
> > <deepika.kethi.reddy@intel.com>; Esakkithevar, Kathappan
> > <kathappan.esakkithevar@intel.com>
> > Subject: [PATCH 2/7] CometlakeOpenBoard: Move ReportCpuHob library
> > path
> >
> > From: SofiaX Chuang <sofiax.chuang@intel.com>
> >
> > Move ReportCpuHob library from MinPlatformPkg to IntelSiliconPkg.
> >
> > Cc: Chasel Chiu <chasel.chiu@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> > Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
> > Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
> > ---
> >  .../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc      | 4
> ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git
> >
> a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg
> .dsc
> >
> b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg
> .dsc
> > index 6de834565a..44a1bd54d6 100644
> > ---
> >
> a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg
> .dsc
> > +++
> >
> b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg
> .dsc
> > @@ -1,7 +1,7 @@
> >  ## @file
> >
> >  #  The main build description file for the CometlakeURvp board.
> >
> >  #
> >
> > -#  Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
> >
> > +#  Copyright (c) 2020 - 2021, Intel Corporation. All rights
> > +reserved.<BR>
> >
> >  #
> >
> >  #  SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> >  #
> >
> > @@ -161,6 +161,7 @@
> >    # Silicon Initialization Package
> >
> >    #######################################
> >
> >
> > SiliconInitLib|$(PLATFORM_SI_PACKAGE)/Library/PeiSiliconInitLib/PeiSil
> > SiliconInitLib|iconInitL
> > ib.inf
> >
> > +
> >
> ReportCpuHobLib|IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLi
> > ReportCpuHobLib|b.i
> > nf
> >
> >
> >
> >    #######################################
> >
> >    # Platform Package
> >
> > @@ -173,7 +174,6 @@
> >
> >
> TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLib
> /P
> > TestPointCheckLib|ei
> > TestPointCheckLib.inf
> >
> >  !endif
> >
> >
> >
> SetCacheMtrrLib|$(PLATFORM_PACKAGE)/Library/SetCacheMtrrLib/SetCac
> heM
> > trrLibNull.inf
> >
> > -
> >
> ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpu
> Hob
> > Lib/ReportCpuHobLib.inf
> >
> >
> >
> >    #######################################
> >
> >    # Board Package
> >
> > --
> > 2.27.0

Re: [PATCH 1/7] IntelSiliconPkg/ReportCpuHobLib: Add ReportCpuHobLib

[Ni, Ray]

Sofia,
Several comments:
1. Please don't use hardcode value 0x80000000. Use the macro in MdePkg/.../Cpuid.h
2. Please don't use hardcode value 0x80000008. Use the macro and data structure in MdePkg/.../Cpuid.h
3. Please add "EFIAPI"
+VOID
+ReportCpuHob (
+  VOID
+  );
4. Can you please try to remove the IntelSiliconPkg.dec from below?
+[Packages]
+  MdePkg/MdePkg.dec
+  IntelSiliconPkg/IntelSiliconPkg.dec

> -----Original Message-----
> From: Chuang, SofiaX <sofiax.chuang@intel.com>
> Sent: Monday, April 19, 2021 4:44 PM
> To: devel@edk2.groups.io
> Cc: Chuang, SofiaX <sofiax.chuang@intel.com>; Ni, Ray <ray.ni@intel.com>;
> Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
> Subject: [PATCH 1/7] IntelSiliconPkg/ReportCpuHobLib: Add
> ReportCpuHobLib
> 
> From: SofiaX Chuang <sofiax.chuang@intel.com>
> 
> Add ReportCpuHobLib
> 
> Signed-off-by: SofiaX Chuang <sofiax.chuang@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> ---
>  .../Include/Library/ReportCpuHobLib.h         | 23 +++++++++++++
>  .../Intel/IntelSiliconPkg/IntelSiliconPkg.dec |  6 +++-
>  .../Library/ReportCpuHobLib/ReportCpuHobLib.c | 33
> +++++++++++++++++++
>  .../ReportCpuHobLib/ReportCpuHobLib.inf       | 27 +++++++++++++++
>  4 files changed, 88 insertions(+), 1 deletion(-)
>  create mode 100644
> Silicon/Intel/IntelSiliconPkg/Include/Library/ReportCpuHobLib.h
>  create mode 100644
> Silicon/Intel/IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.c
>  create mode 100644
> Silicon/Intel/IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.inf
> 
> diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Library/ReportCpuHobLib.h
> b/Silicon/Intel/IntelSiliconPkg/Include/Library/ReportCpuHobLib.h
> new file mode 100644
> index 0000000000..9ca18146ed
> --- /dev/null
> +++ b/Silicon/Intel/IntelSiliconPkg/Include/Library/ReportCpuHobLib.h
> @@ -0,0 +1,23 @@
> +/** @file
> 
> +
> 
> +  Report CPU HOB library
> 
> +
> 
> +  This library report the CPU HOB with Physical Address bits.
> 
> +
> 
> +Copyright (c) 2021, Intel Corporation. All rights reserved.<BR>
> 
> +SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> +
> 
> +**/
> 
> +
> 
> +#ifndef _REPORT_CPU_HOB_LIB_H_
> 
> +#define _REPORT_CPU_HOB_LIB_H_
> 
> +
> 
> +#include <PiPei.h>
> 
> +#include <Uefi.h>
> 
> +
> 
> +VOID
> 
> +ReportCpuHob (
> 
> +  VOID
> 
> +  );
> 
> +
> 
> +#endif
> 
> diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec
> b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec
> index 4a2cbca5c1..2461ab8e06 100644
> --- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec
> +++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec
> @@ -3,7 +3,7 @@
>  #
> 
>  # This package provides common open source Intel silicon modules.
> 
>  #
> 
> -# Copyright (c) 2016 - 2020, Intel Corporation. All rights reserved.<BR>
> 
> +# Copyright (c) 2016 - 2021, Intel Corporation. All rights reserved.<BR>
> 
>  # SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  #
> 
>  ##
> 
> @@ -42,6 +42,10 @@
>    #
> 
>    AslUpdateLib|Include/Library/AslUpdateLib.h
> 
> 
> 
> +  ## @libraryclass Provides services to report CPU hob
> 
> +  #
> 
> +  ReportCpuHobLib|Include/Library/ReportCpuHobLib.h
> 
> +
> 
>  [Guids]
> 
>    ## GUID for Package token space
> 
>    # {A9F8D54E-1107-4F0A-ADD0-4587E7A4A735}
> 
> diff --git
> a/Silicon/Intel/IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.c
> b/Silicon/Intel/IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.c
> new file mode 100644
> index 0000000000..1a3d60366d
> --- /dev/null
> +++
> b/Silicon/Intel/IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.c
> @@ -0,0 +1,33 @@
> +/** @file
> 
> +  Source code file for Report CPU HOB library.
> 
> +
> 
> +Copyright (c) 2021, Intel Corporation. All rights reserved.<BR>
> 
> +SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> +
> 
> +**/
> 
> +
> 
> +#include <PiPei.h>
> 
> +#include <Library/BaseLib.h>
> 
> +#include <Library/HobLib.h>
> 
> +
> 
> +VOID
> 
> +ReportCpuHob (
> 
> +  VOID
> 
> +  )
> 
> +{
> 
> +  UINT8                         PhysicalAddressBits;
> 
> +  UINT32                        RegEax;
> 
> +
> 
> +  AsmCpuid (0x80000000, &RegEax, NULL, NULL, NULL);
> 
> +  if (RegEax >= 0x80000008) {
> 
> +    AsmCpuid (0x80000008, &RegEax, NULL, NULL, NULL);
> 
> +    PhysicalAddressBits = (UINT8) RegEax;
> 
> +  } else {
> 
> +    PhysicalAddressBits = 36;
> 
> +  }
> 
> +
> 
> +  ///
> 
> +  /// Create a CPU hand-off information
> 
> +  ///
> 
> +  BuildCpuHob (PhysicalAddressBits, 16);
> 
> +}
> 
> diff --git
> a/Silicon/Intel/IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.in
> f
> b/Silicon/Intel/IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.in
> f
> new file mode 100644
> index 0000000000..ae7871ad4e
> --- /dev/null
> +++
> b/Silicon/Intel/IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.in
> f
> @@ -0,0 +1,27 @@
> +### @file
> 
> +# Component information file for the Report CPU HOB library.
> 
> +#
> 
> +# Copyright (c) 2021, Intel Corporation. All rights reserved.<BR>
> 
> +#
> 
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> +#
> 
> +###
> 
> +
> 
> +[Defines]
> 
> +  INF_VERSION                    = 0x00010005
> 
> +  BASE_NAME                      = ReportCpuHobLib
> 
> +  FILE_GUID                      = 0A1C9D6B-44BE-4FD7-A4A2-D0E68D436848
> 
> +  VERSION_STRING                 = 1.0
> 
> +  MODULE_TYPE                    = PEIM
> 
> +  LIBRARY_CLASS                  = ReportCpuHobLib
> 
> +
> 
> +[LibraryClasses]
> 
> +  BaseLib
> 
> +  HobLib
> 
> +
> 
> +[Packages]
> 
> +  MdePkg/MdePkg.dec
> 
> +  IntelSiliconPkg/IntelSiliconPkg.dec
> 
> +
> 
> +[Sources]
> 
> +  ReportCpuHobLib.c
> 
> --
> 2.27.0

Re: [PATCH 3/7] TigerlakeOpenBoard: Move ReportCpuHob library path

[Heng Luo]

Reviewed-by: Heng Luo <heng.luo@intel.com>

> -----Original Message-----
> From: Chuang, SofiaX <sofiax.chuang@intel.com>
> Sent: Monday, April 19, 2021 4:44 PM
> To: devel@edk2.groups.io
> Cc: Chuang, SofiaX <sofiax.chuang@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Luo, Heng <heng.luo@intel.com>
> Subject: [PATCH 3/7] TigerlakeOpenBoard: Move ReportCpuHob library path
> 
> From: SofiaX Chuang <sofiax.chuang@intel.com>
> 
> Move ReportCpuHob library from MinPlatformPkg to IntelSiliconPkg.
> 
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Heng Luo <heng.luo@intel.com>
> ---
>  .../Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc  | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git
> a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc
> b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc
> index a4265a839c..1adf634034 100644
> --- a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc
> +++
> b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc
> @@ -89,7 +89,6 @@
> 
> 
> 
> PciSegmentLib|$(PLATFORM_SI_PACKAGE)/Library/BasePciSegmentMultiSegLib
> Pci/BasePciSegmentMultiSegLibPci.inf
> 
>    PciLib|MdePkg/Library/BasePciLibPciExpress/BasePciLibPciExpress.inf
> 
> -
> ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHob
> Lib/ReportCpuHobLib.inf
> 
> 
> 
>    #
> 
>    # Silicon Init Package
> 
> @@ -115,6 +114,7 @@
>    #
> 
>    # Silicon Init Package
> 
>    #
> 
> +
> ReportCpuHobLib|IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.i
> nf
> 
>    !include $(PLATFORM_SI_PACKAGE)/SiPkgPeiLib.dsc
> 
> 
> 
>    #
> 
> --
> 2.27.0

Re: [PATCH 3/7] TigerlakeOpenBoard: Move ReportCpuHob library path

[Chaganty, Rangasai V]

Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>

-----Original Message-----
From: Chuang, SofiaX <sofiax.chuang@intel.com> 
Sent: Monday, April 19, 2021 1:44 AM
To: devel@edk2.groups.io
Cc: Chuang, SofiaX <sofiax.chuang@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Luo, Heng <heng.luo@intel.com>
Subject: [PATCH 3/7] TigerlakeOpenBoard: Move ReportCpuHob library path

From: SofiaX Chuang <sofiax.chuang@intel.com>

Move ReportCpuHob library from MinPlatformPkg to IntelSiliconPkg.

Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Heng Luo <heng.luo@intel.com>
---
 .../Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc
index a4265a839c..1adf634034 100644
--- a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc
+++ b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc
@@ -89,7 +89,6 @@
 

   PciSegmentLib|$(PLATFORM_SI_PACKAGE)/Library/BasePciSegmentMultiSegLibPci/BasePciSegmentMultiSegLibPci.inf

   PciLib|MdePkg/Library/BasePciLibPciExpress/BasePciLibPciExpress.inf

-  ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf

 

   #

   # Silicon Init Package

@@ -115,6 +114,7 @@
   #

   # Silicon Init Package

   #

+  ReportCpuHobLib|IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.inf

   !include $(PLATFORM_SI_PACKAGE)/SiPkgPeiLib.dsc

 

   #

-- 
2.27.0