From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web08.731.1615490945935222588 for ; Thu, 11 Mar 2021 11:29:06 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=x4gGkfCU; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: rangasai.v.chaganty@intel.com) IronPort-SDR: ByNN+U5rd578c9kCtkxEGhtJe6vI8pNfnOp8JYtGAgGHF61O/7SnLZzA8BGzMOnMax4WSuuIrL 0sEE2XkC0lIA== X-IronPort-AV: E=McAfee;i="6000,8403,9920"; a="185369998" X-IronPort-AV: E=Sophos;i="5.81,241,1610438400"; d="scan'208";a="185369998" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2021 11:29:05 -0800 IronPort-SDR: W/U+8G1wX13jDUhQKml+8gWc322uz83LqbXmZwkMpesBkhNH6gLg8/tAcwa0KqvM7Ee/vx2F3A S4JyHju1igvA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,241,1610438400"; d="scan'208";a="370653178" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga003.jf.intel.com with ESMTP; 11 Mar 2021 11:29:04 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 11 Mar 2021 11:29:04 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 11 Mar 2021 11:29:04 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Thu, 11 Mar 2021 11:29:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mDDj4NmW5Q7pvFhdKBvKEpAuZ4QVJuz67RHgtDPbn6lUeasB8Stnt0fX9VNx+Opy8zRhJVu8BMZgbWGj9IWvZPQ5FhlUjagJlv+1eqrSGRjo4iYGszIx8vKmaVmzYQp1zOYuYAHOiJ5fd4ntBmJ90jqWAM28D+YubyM5i0NlAQhflhbw2YWZ2baFiStJDvC1SXDpYNKPMF8LUikEgaq/iawX59XmbAbl/uhy86v8cCEhl8IOINv8K6yFfTf007qTp0z/1dxRd1tmiENZncfYZZsu65YJIwyz0lLWwbceWoBtFYLMDUoajOyclOByDW2WzFXgCTFXjSl0omsaZiSCGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i2VXYLwoMNNW8Zzu8N1G1rbRbckQk0h8nC3mi2/Wksk=; b=KH0ZI1lGz9r5DAMCocd8AeLzbUbeBw2CaaNdSfQxN2DdPhyrpzvu0UqueAKAFIKNZLNrfHu/ghILUPvInDrDniCENFR3rExfjh4LE8IKDR/AI0Nk27/THb+qbVS9aZ/W2h9HmR8oI+qFGl/yfV746+Z2s75/SjhTV9Z0mWjg3eY2Vre+7DjPXdyTCCKe2N9Y5iXqvP3XMszFY+ugb81zF+az0G+DWk9/zP3fh769r88orO7B4IAstp4wWlXgOVZGzSY6z4j7sz3aZ9ux6ET/vbiz/DuzfXLT/dHIJIxUnyKa92eZHiabKMIdtCvS1wjuQbDCqiz3ThYIWYc19oDWEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i2VXYLwoMNNW8Zzu8N1G1rbRbckQk0h8nC3mi2/Wksk=; b=x4gGkfCUaCaEuITOfm15rVcvp+GXt+8tlfsJ96gqW8NmzfLdPWsWLkCRfhVTyqP6b+Xq/23xIJBsOBQH5KUH9KRMLk7YiCDdtbDpeDQ1FSl30nYAuPswovKBNsaYBRzT6wdJlfR0TjkPhU8f8/4q2FgH3gJE5H9xpncxwc1xCik= Received: from DM6PR11MB4476.namprd11.prod.outlook.com (2603:10b6:5:201::24) by DM5PR1101MB2154.namprd11.prod.outlook.com (2603:10b6:4:4e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.18; Thu, 11 Mar 2021 19:29:02 +0000 Received: from DM6PR11MB4476.namprd11.prod.outlook.com ([fe80::4167:e5c7:e700:aab9]) by DM6PR11MB4476.namprd11.prod.outlook.com ([fe80::4167:e5c7:e700:aab9%6]) with mapi id 15.20.3912.028; Thu, 11 Mar 2021 19:29:02 +0000 From: "Chaganty, Rangasai V" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Oram, Isaac W" , Liming Gao , Michael Kubacki Subject: Re: [edk2-platforms] [PATCH v1 0/9] IpmiFeaturePkg: Add IPMI transport drivers Thread-Topic: [edk2-platforms] [PATCH v1 0/9] IpmiFeaturePkg: Add IPMI transport drivers Thread-Index: AQHXDwvY8yGl/NYblky72rYwHEl7Bqp/L1Qg Date: Thu, 11 Mar 2021 19:29:02 +0000 Message-ID: References: <20210302022804.8641-1-nathaniel.l.desimone@intel.com> In-Reply-To: <20210302022804.8641-1-nathaniel.l.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.45.159.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 45df7d65-c87e-49c2-e5d7-08d8e4c3ed3b x-ms-traffictypediagnostic: DM5PR1101MB2154: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ScOby7XRyeq60GO58/LsIEkO2a5y253awYQoNTi8qQBO28huVQQ2++EDOPk0rvZHMpnThdyYRVVwguSHcM7AuxBJDV0TDNfIK8g3Doi54oVbmU/KPisL00VnHEDoX4bU6kCy4RcX8EKAIAH6/Txl6ritGW9ev4Dxlmv57+HjKlgO/9E0pupgPODDmlYogJ2z8Ts7/75EEPViBgYlJdlteTTnTC/gs8+hzEj/B9ga0RhCkcXomWX9JXCZQ64pf14tXCV4wZR2RCvSt19dsQZFNF4+nVODpvP+AUzV0uLNCWLJJILFvBZvstvcOXD1zxCIsqMTC9CLo7IH7TFD9xLsyEB/gIbnwweOKVmOSgaIW3ItdNl1tPAVTttP7qhOT6as7IJezpaMbafbKZtZxeHihtkShSLEagNgupaQuQbNfaBPeyPfYJXYec4eU3OxhDdzMKCysUwmdXIM9gPNPSx7gFhnT4NGdUTTGmUqEQMNRCRSSNsvMQ1xvNDQtvUfBCc0NOjJ/UY3O2+AHauNLDIMj32sDv96/Pfoj1hUA2DyMpyQf9nmsxyUlCGNpOqaWisWWpgTRGxxDqKxlSS7ROR0Lx2au0ltsFvvlmfZHnzIzPE= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4476.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(376002)(346002)(39860400002)(366004)(136003)(478600001)(33656002)(55016002)(26005)(66446008)(966005)(8676002)(86362001)(8936002)(83380400001)(316002)(66556008)(76116006)(52536014)(5660300002)(66946007)(186003)(4326008)(2906002)(66476007)(7696005)(71200400001)(6506007)(110136005)(9686003)(53546011)(64756008)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?LWYH7zyj6FHjeBlIzYsV4xdoDU/fjmkkFMUm7AuFiLIHAebBs/fi+n65wD83?= =?us-ascii?Q?AIBQfLfw75bKkffG4OIf6a7ZnnTAByCOGg8uToSumQ+ojXeLK8CgbimD2Huk?= =?us-ascii?Q?efTdgQki6XInBCetYxX0AInzWk202fguE8NXyd0B15IJPEcOMPrR5EUO+9GV?= =?us-ascii?Q?R7g3Z7kwhtL9v3fI88SoRTjsmcUuB6fkLfiKvYS2XyIK9GAQgIdbh5GbY2vO?= =?us-ascii?Q?Ot1PPFhA7NhEgpJYrAyvaSUtqLTO42/Wzb+HZf2kvRAGUubh+rItGNMEvC6O?= =?us-ascii?Q?IIMRFyDJQ/E5hEJLC+0ccN8dKNbUO7cG8vVAP8iFXhqWefM0MxYKxK9C2vrd?= =?us-ascii?Q?Lh7OUeQa31L0I2dm58S4qBOaGzHAAVI+DNQSVwhFjSDgFb+F8nZaqDphZ4Wd?= =?us-ascii?Q?S5JTZxDw+5jUwazkcSI9vIpv6YmPRCxGlW6PopjUEyVlXmNO0+fcQsqodZTp?= =?us-ascii?Q?idnJ28I8CA0HvZM5meaqbDGXWhNP7l7N2LBpYEU7Tecs2VTwcoVlhVI+lVBA?= =?us-ascii?Q?Ke3pRaZvtML1NHFwTkZYHeS7LvrP9ucXB0TTdJK8fhoe3MUQVhRwn45rm/Ow?= =?us-ascii?Q?/t6HX4IuxCDjX+OaHviJwwnZ58G94df12nZc8KHgcXNBW+XU6IpK4M4kQV8h?= =?us-ascii?Q?oq7KMl3RliClj0AduPp++gdQ2piX1mJ9H+SRWs5aQMtXUPB9N/UAtGspkf44?= =?us-ascii?Q?Z5PoXcocoM9vcDYdUrA9sSe69NPT5OpbHhxz+n2WoiHRuNpp7Z7ph8KBxFXO?= =?us-ascii?Q?RWh8PDtmSYi4HedRo5teBGHOAMyqlgf51brnotusihi9LZnNY2awkfe9m7Jy?= =?us-ascii?Q?g1dZd0UrZMV2pqb2ONVc6MY1PsLtoWH9AFjZF0dB0LkArtCXJw9cJTk9Ttte?= =?us-ascii?Q?zDk1ZhelG+FECfD0r7WM0hk5LZ+DWpd6BSCXH05K+MuhjPjkkZTkoXSg3hN7?= =?us-ascii?Q?2VhlR6b5RNjcSi28putDLrGZLI1qG5vdTYaIBv/ZQC4yvcxwzjIEP3kYvUbu?= =?us-ascii?Q?g6dVzafVjllYmaocFUsaKilxFntHEBqnvoK3Il5kICpkU1OhxEJdIG0pRH5x?= =?us-ascii?Q?OfkmFJPzyF1Qbah+T3MVg7OG5h+3cA6FkZTUP0JT80Y9qebQttHdlISwfPW4?= =?us-ascii?Q?Q8kB+yGjO+BX8eZuiaHpXFjE/K3ACtWy7Ys6lc6Uz7kvceTMvkOU9d7GUKh/?= =?us-ascii?Q?8KnZfXD6Jwtj4D4YMtM4A6/NItuCXLkHTHl6nZviz0g5T50tpGvcHsz6Y6wu?= =?us-ascii?Q?fTRnKXO2JMLuz12Qa1wTM1SvZkff7DzZGiU0JavD4tKh+x/M688oGACpP4UY?= =?us-ascii?Q?1GsmKEh0zb2N+Lrswo27Msdw?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4476.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45df7d65-c87e-49c2-e5d7-08d8e4c3ed3b X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2021 19:29:02.2066 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yLvmZ7m8S531l+7+D+0XliTbDgR3SnrjTSI0speq8TvMSt5P3+GLCKCFebWPToC4i5Z3oUSpn/reqEkYxJoAGVBT72DC2n0zs9uE8r7Dhb8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2154 Return-Path: rangasai.v.chaganty@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Overall structure looks good. For the series: Reviewed-by: Sai Chaganty There are few, rather general comments which I think can be queued up as on= -going improvement after the initial check-in. 1. Copyright year for newly added files should begin with the current year = // this is probably should be taken care before the first checkin 2. Ensure new GUIDs are created for newly added modules and interfaces, to = avoid any potential conflicts.=20 3. Null instance libraries (e.g. IpmiBaseLibNull.inf) has classes defined t= hat are not necessarily in use (e.g DebugLib). While it may not be a functi= onal failure, it's a good practice to declare only those classes that are b= eing used in the implementation.=20 4. ReadMe needs to be filled out completely.=20 5. Function description are found to be placed after the function (e.g. Upd= ateErrorStatus(), IpmiSendCommandToBmc() in IpmiBmc.c). The description com= ment block should precede the function. 6. Found instances where return status is marked as "Status" in description= . Suggest to add possible return values in the function description=20 7. Found cases where we have two APIs with different names but with similar= implementation - e.g. IpmiSendCommandToBmc() and PeiIpmiSendCommandToBmc()= . Can these be converged? 8. Please check and address relative path issue in . inf (e.g. GenericIpmi.= inf) 9. In IpmiInit.c, Please remove the following, if not applicable #ifdef FAST_VIDEO_SUPPORT #include #endif 10. Consider adding .fdf definition under \Include that lists the IPMI modu= les to be dispatched. This will simplify the integration of this feature on= a platform.=20 11. Need to make sure package build is working. Regards, Sai -----Original Message----- From: Desimone, Nathaniel L =20 Sent: Monday, March 01, 2021 6:28 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chaganty, Rangasai V ; Liming Gao ; Michael Kubac= ki Subject: [edk2-platforms] [PATCH v1 0/9] IpmiFeaturePkg: Add IPMI transport= drivers From: Isaac Oram REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3242 Implement an open source generic IPMI transport driver. Provides the ability to communicate with a BMC over IPMI in MinPlatform boa= rd packages. New changes: 1. Added GenericIpmi 2. Added IPMI base libs 3. Added transport PPI and protocol 4. Updated IPMI command request and response data size from UINT8 to UINT32 in IPMI transport layer to be compatible with EDK2 industry standard IPMI commands. 6. Added the completion code in the first byte of all IPMI response data to be compatible with EDK2 industry standard IPMI commands. Cc: Sai Chaganty Cc: Liming Gao Cc: Michael Kubacki Signed-off-by: Isaac Oram Co-authored-by: Nate DeSimone Isaac Oram (9): IpmiFeaturePkg: Add IPMI driver Include headers IpmiFeaturePkg: Add IpmiBaseLib and IpmiCommandLib IpmiFeaturePkg: Add IpmiInit drivers IpmiFeaturePkg: Add GenericIpmi driver common code IpmiFeaturePkg: Add GenericIpmi PEIM IpmiFeaturePkg: Add GenericIpmi DXE Driver IpmiFeaturePkg: Add GenericIpmi SMM Driver IpmiFeaturePkg: Add IPMI driver build files Maintainers.txt: Add IpmiFeaturePkg maintainers .../GenericIpmi/Common/IpmiBmc.c | 297 +++++++++++ .../GenericIpmi/Common/IpmiBmc.h | 44 ++ .../GenericIpmi/Common/IpmiBmcCommon.h | 179 +++++++ .../GenericIpmi/Common/IpmiHooks.c | 96 ++++ .../GenericIpmi/Common/IpmiHooks.h | 81 +++ .../GenericIpmi/Common/IpmiPhysicalLayer.h | 29 ++ .../GenericIpmi/Common/KcsBmc.c | 483 ++++++++++++++++++ .../GenericIpmi/Common/KcsBmc.h | 236 +++++++++ .../GenericIpmi/Dxe/GenericIpmi.c | 46 ++ .../GenericIpmi/Dxe/GenericIpmi.inf | 66 +++ .../IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c | 452 ++++++++++++++++ .../GenericIpmi/Pei/PeiGenericIpmi.c | 362 +++++++++++++ .../GenericIpmi/Pei/PeiGenericIpmi.h | 138 +++++ .../GenericIpmi/Pei/PeiGenericIpmi.inf | 58 +++ .../GenericIpmi/Pei/PeiIpmiBmc.c | 277 ++++++++++ .../GenericIpmi/Pei/PeiIpmiBmc.h | 38 ++ .../GenericIpmi/Pei/PeiIpmiBmcDef.h | 156 ++++++ .../GenericIpmi/Smm/SmmGenericIpmi.c | 208 ++++++++ .../GenericIpmi/Smm/SmmGenericIpmi.inf | 53 ++ .../IpmiFeaturePkg/Include/IpmiFeature.dsc | 9 +- .../Include/Library/IpmiBaseLib.h | 50 ++ .../Include/Library/IpmiCommandLib.h | 19 +- .../Include/Ppi/IpmiTransportPpi.h | 68 +++ .../Include/Protocol/IpmiTransportProtocol.h | 75 +++ .../IpmiFeaturePk= g/Include/ServerManagement.h | 337 ++++++++++++ .../IpmiFeaturePkg/Include/SmStatusCodes.h | 98 ++++ .../IpmiFeaturePkg/IpmiFeaturePkg.dec | 22 +- .../IpmiFeaturePkg/IpmiInit/DxeIpmiInit.c | 4 +- .../IpmiFeaturePkg/IpmiInit/DxeIpmiInit.inf | 6 +- .../IpmiFeaturePkg/IpmiInit/PeiIpmiInit.c | 4 +- .../IpmiFeaturePkg/IpmiInit/PeiIpmiInit.inf | 4 +- .../Library/IpmiBaseLib/IpmiBaseLib.c | 155 ++++++ .../Library/IpmiBaseLib/IpmiBaseLib.inf | 28 + .../Library/IpmiBaseLibNull/IpmiBaseLibNull.c | 76 +++ .../IpmiBaseLibNull/IpmiBaseLibNull.inf | 36 ++ .../Library/IpmiCommandLib/IpmiCommandLib.inf | 4 +- .../IpmiCommandLib/IpmiCommandLibNetFnApp.c | 7 +- .../IpmiCommandLibNetFnChassis.c | 51 +- .../IpmiCommandLibNetFnStorage.c | 7 +- .../IpmiCommandLibNetFnTransport.c | 7 +- .../Library/PeiIpmiBaseLib/PeiIpmiBaseLib.c | 111 ++++ .../Library/PeiIpmiBaseLib/PeiIpmiBaseLib.inf | 30 ++ .../Library/SmmIpmiBaseLib/SmmIpmiBaseLib.c | 180 +++++++ .../Library/SmmIpmiBaseLib/SmmIpmiBaseLib.inf | 29 ++ .../IpmiFeaturePkg/Readme.md | 4 +- Maintainers.txt | 6 + 46 files changed, 4694 insertions(+), 32 deletions(-) create mode 100644 = Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Common/IpmiBm= c.c create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Gener= icIpmi/Common/IpmiBmc.h create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Gener= icIpmi/Common/IpmiBmcCommon.h create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Gener= icIpmi/Common/IpmiHooks.c create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Gener= icIpmi/Common/IpmiHooks.h create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Gener= icIpmi/Common/IpmiPhysicalLayer.h create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Gener= icIpmi/Common/KcsBmc.c create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Gener= icIpmi/Common/KcsBmc.h create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Gener= icIpmi/Dxe/GenericIpmi.c create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Gener= icIpmi/Dxe/GenericIpmi.inf create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Gener= icIpmi/Dxe/IpmiInit.c create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Gener= icIpmi/Pei/PeiGenericIpmi.c create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Gener= icIpmi/Pei/PeiGenericIpmi.h create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Gener= icIpmi/Pei/PeiGenericIpmi.inf create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Gener= icIpmi/Pei/PeiIpmiBmc.c create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Gener= icIpmi/Pei/PeiIpmiBmc.h create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Gener= icIpmi/Pei/PeiIpmiBmcDef.h create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Gener= icIpmi/Smm/SmmGenericIpmi.c create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Gener= icIpmi/Smm/SmmGenericIpmi.inf create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Inclu= de/Library/IpmiBaseLib.h create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Inclu= de/Ppi/IpmiTransportPpi.h create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Inclu= de/Protocol/IpmiTransportProtocol.h create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Inclu= de/ServerManagement.h create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Inclu= de/SmStatusCodes.h create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Libra= ry/IpmiBaseLib/IpmiBaseLib.c create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Libra= ry/IpmiBaseLib/IpmiBaseLib.inf create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Libra= ry/IpmiBaseLibNull/IpmiBaseLibNull.c create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Libra= ry/IpmiBaseLibNull/IpmiBaseLibNull.inf create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Libra= ry/PeiIpmiBaseLib/PeiIpmiBaseLib.c create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Libra= ry/PeiIpmiBaseLib/PeiIpmiBaseLib.inf create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Libra= ry/SmmIpmiBaseLib/SmmIpmiBaseLib.c create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Libra= ry/SmmIpmiBaseLib/SmmIpmiBaseLib.inf -- 2.27.0.windows.1