public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Chiu, Chasel" <chasel.chiu@intel.com>
Subject: Re: [edk2-platforms] [patch V3 25/35] Silicon/CoffeelakeSiliconPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
Date: Fri, 26 Mar 2021 22:15:00 +0000	[thread overview]
Message-ID: <DM6PR11MB4476EB0C37087A87A2827BD5B6619@DM6PR11MB4476.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210326083922.24340-26-dandan.bi@intel.com>

Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>  

-----Original Message-----
From: Bi, Dandan <dandan.bi@intel.com> 
Sent: Friday, March 26, 2021 1:39 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
Subject: [edk2-platforms] [patch V3 25/35] Silicon/CoffeelakeSiliconPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246

MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc.

So update platform dsc to consume MdeLibs.dsc.inc for RegisterFilterLibNull which will be consumed by IoLib and BaseLib.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
V3:
Update plaftom dsc to consume the MdeLibs.dsc.inc outside the common [LibraryClasses] section since we can specify different [LibraryClasses] section for libary instances in MdeLibs.dsc.inc.
---
 Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc b/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc
index 2f25bdb35e..c5f10492ed 100644
--- a/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc
+++ b/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc
@@ -77,10 +77,12 @@ [Defines]
   #
   # Definition for Build Flag
   #
   !include $(PLATFORM_SI_PACKAGE)/SiPkgBuildOption.dsc
 
+!include MdePkg/MdeLibs.dsc.inc
+
 [LibraryClasses.common]
   #
   # Entry point
   #
   PeiCoreEntryPoint|MdePkg/Library/PeiCoreEntryPoint/PeiCoreEntryPoint.inf
--
2.18.0.windows.1


  reply	other threads:[~2021-03-26 22:15 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26  8:38 [edk2-platforms] [patch V3 00/35] Consume MdeLibs.dsc.inc for RegisterFilterLib Dandan Bi
2021-03-26  8:38 ` [edk2-platforms] [patch V3 01/35] Drivers/ASIX: " Dandan Bi
2021-03-26  8:38 ` [edk2-platforms] [patch V3 02/35] Drivers/DisplayLink: " Dandan Bi
2021-03-26  8:38 ` [edk2-platforms] [patch V3 03/35] Drivers/OptionRomPkg: " Dandan Bi
2021-03-26  8:38 ` [edk2-platforms] [patch V3 04/35] Features/Debugging: " Dandan Bi
2021-03-26  8:38 ` [edk2-platforms] [patch V3 05/35] Features/Network: " Dandan Bi
2021-03-26  8:38 ` [edk2-platforms] [patch V3 06/35] Features/OutOfBandManagement: " Dandan Bi
2021-03-26  8:38 ` [edk2-platforms] [patch V3 07/35] Features/PowerManagement: " Dandan Bi
2021-03-26  8:38 ` [edk2-platforms] [patch V3 08/35] Features/SystemInformation: " Dandan Bi
2021-03-26  8:38 ` [edk2-platforms] [patch V3 09/35] Features/UserInterface: " Dandan Bi
2021-03-26  8:38 ` [edk2-platforms] [patch V3 10/35] Platform/AMD: " Dandan Bi
2021-03-26  8:38 ` [edk2-platforms] [patch V3 11/35] Platform/ARM: " Dandan Bi
2021-03-26  8:38 ` [edk2-platforms] [patch V3 12/35] Platform/BeagleBoard: " Dandan Bi
2021-03-26  8:39 ` [edk2-platforms] [patch V3 13/35] Platform/BoardModulePkg: " Dandan Bi
2021-03-26  8:39 ` [edk2-platforms] [patch V3 14/35] Platform/MinPlatformPkg: " Dandan Bi
2021-03-26  8:39 ` [edk2-platforms] [patch V3 15/35] Platform/QuarkPlatformPkg: " Dandan Bi
2021-03-26  8:39 ` [edk2-platforms] [patch V3 16/35] Platform/Vlv2TbltDevicePkg: " Dandan Bi
2021-03-26  8:39 ` [edk2-platforms] [patch V3 17/35] Platform/LeMaker: " Dandan Bi
2021-03-26  8:39 ` [edk2-platforms] [patch V3 18/35] Platform/Qemu: " Dandan Bi
2021-03-26  8:39 ` [edk2-platforms] [patch V3 19/35] Platform/RaspberryPi: " Dandan Bi
2021-03-26  8:39 ` [edk2-platforms] [patch V3 20/35] Platform/RISC-V: " Dandan Bi
2021-03-29  1:58   ` Abner Chang
2021-03-26  8:39 ` [edk2-platforms] [patch V3 21/35] Platform/SiFive: " Dandan Bi
2021-03-29  1:58   ` Abner Chang
2021-03-26  8:39 ` [edk2-platforms] [patch V3 22/35] Platform/Socionext: " Dandan Bi
2021-03-26 16:47   ` [edk2-devel] " Michael D Kinney
2021-03-26  8:39 ` [edk2-platforms] [patch V3 23/35] Platform/SoftIron: " Dandan Bi
2021-03-26  8:39 ` [edk2-platforms] [patch V3 24/35] Silicon/Hisilicon: " Dandan Bi
2021-03-26 16:43   ` [edk2-devel] " Michael D Kinney
2021-03-26  8:39 ` [edk2-platforms] [patch V3 25/35] Silicon/CoffeelakeSiliconPkg: " Dandan Bi
2021-03-26 22:15   ` Chaganty, Rangasai V [this message]
2021-03-26  8:39 ` [edk2-platforms] [patch V3 26/35] Silicon/IntelSiliconPkg: " Dandan Bi
2021-03-26 22:12   ` Chaganty, Rangasai V
2021-03-26  8:39 ` [edk2-platforms] [patch V3 27/35] Silicon/KabylakeSiliconPkg: " Dandan Bi
2021-03-26 22:11   ` Chaganty, Rangasai V
2021-03-26  8:39 ` [edk2-platforms] [patch V3 28/35] Silicon/QuarkSocPkg: " Dandan Bi
2021-03-26  8:39 ` [edk2-platforms] [patch V3 29/35] Silicon/TigerlakeSiliconPkg: " Dandan Bi
2021-03-26 16:22   ` Chaganty, Rangasai V
2021-03-26 18:07     ` [edk2-devel] " Michael D Kinney
2021-03-26 22:06       ` Chaganty, Rangasai V
2021-03-26 22:10   ` Chaganty, Rangasai V
2021-03-26  8:39 ` [edk2-platforms] [patch V3 30/35] Silicon/Marvell: " Dandan Bi
2021-03-26 16:46   ` [edk2-devel] " Michael D Kinney
2021-03-26  8:39 ` [edk2-platforms] [patch V3 31/35] Silicon/NXP: " Dandan Bi
2021-03-26 16:44   ` [edk2-devel] " Michael D Kinney
2021-03-26  8:39 ` [edk2-platforms] [patch V3 32/35] Silicon/Openmoko: " Dandan Bi
2021-03-26  8:39 ` [edk2-platforms] [patch V3 33/35] Silicon/RISC_V: " Dandan Bi
2021-03-29  1:59   ` Abner Chang
2021-03-26  8:39 ` [edk2-platforms] [patch V3 34/35] Silicon/Synopsys/DesignWare: " Dandan Bi
2021-03-26  8:39 ` [edk2-platforms] [patch V3 35/35] Silicon/TexasInstruments: " Dandan Bi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB4476EB0C37087A87A2827BD5B6619@DM6PR11MB4476.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox