From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.34259.1618240763603436997 for ; Mon, 12 Apr 2021 08:19:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=HvJjd0pX; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: rangasai.v.chaganty@intel.com) IronPort-SDR: 4mPM/0JORCEuLRbcPO6DE5Qh42ZddiTfVvLkdMa+PHfmQeI0WKbrgiJuukPeR3HtVfSfTIbxZv 1WQ0PRmlXVJg== X-IronPort-AV: E=McAfee;i="6200,9189,9952"; a="174313594" X-IronPort-AV: E=Sophos;i="5.82,216,1613462400"; d="scan'208";a="174313594" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2021 08:19:22 -0700 IronPort-SDR: /ptcXb4GgmpD5hbtvIGWhgDhxhbC62MVA4cbbuuwAFiOuSgSCVDlRwghxb4ZcUonv9ZGpdfHfm c7qgZk6eo2Kw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,216,1613462400"; d="scan'208";a="451509402" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga002.fm.intel.com with ESMTP; 12 Apr 2021 08:19:22 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 12 Apr 2021 08:19:21 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 12 Apr 2021 08:19:21 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 12 Apr 2021 08:19:21 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 12 Apr 2021 08:19:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lrsmqRNATF7kT4rTvrSwBs4Evfo9KR8uxhOmaX4OxdsVaL+SEmV0Rk30adK+E4cM2LECo87VLiP/HhCb81mxk5QP0iI3Uj+daymUifrDWTIhv6ATQtG7YdLyoQD1mI4ot6nKdYqjhmAgORpaZlJAiizrWSoDXbRjDpW/nQbmnMfss2NftGeldbeGuTg1zkICG4Tge6PjB/EUoC0HGRQ/2WgF9OP7xLrF9W5lWCCZ37Wb23ngLs19Qqu0Iz28l1L/4n2eV4imBCoPVQz4jmh/5x1wPNpTKAxRVmN9N5PLE0eQA3NHvGn2e6GcOs8mMvoVlUOLk3UfAK034kZ5N4zTsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dae/qW5Io8jhVrbh6rX4LpTc/Ko1juQpcs909ZY1Bxk=; b=BL77N5HKruroDhkyoEo8zhKdy6G09qXkmfS/QMt00HJaYTGRckvqlD+T9jaqId/d/cq65rh5R4eogGMzvjwKtFVHwdwcoKHc8PEQE8GXll3CbpIpvhTg/nd9FOkuKFDOuCA1ZvXtN8YKvN5IC/QJxIKwqf70JhVfxE3ZxSHcn9XIFAzoEFHR/zE9WkVXJkPCbCGEU1Mrfr0eiUYHEgGuzyJjBLUasC41lx3xCklIyzkQMsoJBaK25X1T4dZMByNxBTay9Qgdcn/+NdOVudiJMmfLcfHuX0ElYtJ5ztKc2sMKucCkTTiRzHoNqguxMbHTsQfLACMXxY9uwyxZ9lzMFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dae/qW5Io8jhVrbh6rX4LpTc/Ko1juQpcs909ZY1Bxk=; b=HvJjd0pXsNf7lQugs47NM3m1qu8i81tT0pcRHseEw6wA4IsPXAs8UY7wdfaVieOVAQEBkjoNzTzvETy8bZA4vMQCU0PLlnMVNGcp0D0kRNQ1Sr8EB46np+7J7jF209y9vVAeXVcWW/GAvoLD+3D5nfjCwEF0DP2s1w/N8jgKfhI= Received: from DM6PR11MB4476.namprd11.prod.outlook.com (2603:10b6:5:201::24) by DM5PR11MB1548.namprd11.prod.outlook.com (2603:10b6:4:c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.21; Mon, 12 Apr 2021 15:19:20 +0000 Received: from DM6PR11MB4476.namprd11.prod.outlook.com ([fe80::4167:e5c7:e700:aab9]) by DM6PR11MB4476.namprd11.prod.outlook.com ([fe80::4167:e5c7:e700:aab9%6]) with mapi id 15.20.4020.022; Mon, 12 Apr 2021 15:19:20 +0000 From: "Chaganty, Rangasai V" To: "Ni, Ray" , "devel@edk2.groups.io" Subject: Re: [PATCH] IntelSiliconPkg/ShadowMicrocode: Fix build failure Thread-Topic: [PATCH] IntelSiliconPkg/ShadowMicrocode: Fix build failure Thread-Index: AQHXL3g3TvCr+7qjU02+i2sOozP2s6qw/2vw Date: Mon, 12 Apr 2021 15:19:20 +0000 Message-ID: References: <20210412084525.1655-1-ray.ni@intel.com> In-Reply-To: <20210412084525.1655-1-ray.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.45.159.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 006ca49e-65d2-49d1-a54a-08d8fdc6586c x-ms-traffictypediagnostic: DM5PR11MB1548: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:215; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4mRbPm/HHByDKXYe1cQGprfW7ngHIo9HE0XZYVa5+IuSznM5BIv/TcjAUKYh8McpkdBh9+zuNfdKZkz+58hliJvO6zp27a9bAVRrYXtur+MkLdm59IM0C/gKmEnqEWiK2eQ+pLMH5LEoAtEzc2jy7ElH1jURhd4jgS0Zz/EY3TWDXue3Nk20rqDpbT7CEmb5L0eaPNHxvONs/nhHyFVHyWD8Mcpbju9wbQNYftVGy2Bkvrdhw1JLX6N8bVvYFh008kdyitb8R8aWyi7RovTdkgTNWbS2O2Jw8sZt8KxCVC+QjinpgBxIcG5H+u6ezxd1xVMKtPtJiVudNB32u5xoEP6nilJ+RGALEqT+J1WEcKVPOW4Qq+wtLxxAaqgPAhUtg1C9j7M8QixuEwRKx1mwHTDNAfNBR/Ye+TndzWUMJ+KgPyM43tDFWUSZI76/hIL7Hju+nJhfChRQKuuHCgRF4FlwPh12qRyyJeTb85MqBKam/TMl180yuL5d9Jz2tgLS5TDrecrFHXGECIt2he4yIajJlduD24F9cyBt3aRg/CQ1sEKBGzwk9hZWm0HzLMDWcCpqD6Ar+WXHLXCFYAVVVbilcyahTPNdAxtWsOqSyIQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4476.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(346002)(39860400002)(136003)(396003)(366004)(186003)(478600001)(2906002)(26005)(110136005)(8936002)(9686003)(86362001)(55016002)(7696005)(83380400001)(76116006)(316002)(64756008)(66946007)(66556008)(66476007)(52536014)(5660300002)(38100700002)(71200400001)(33656002)(66446008)(8676002)(6506007)(53546011);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?qp041+nDbuiLJbxGgPkE+YIiOqOMv8oJf3W541rKXezj1s8jCB2HG082hmdR?= =?us-ascii?Q?DH7cR+6MqPbYVdmv4Lgz+X7O9hOT+GzbBNPp0W+xsprkj/EOSILfQAZioJwd?= =?us-ascii?Q?HuFLcAQNcdkRY3q61hWOM6uvmeXuAtHTN/gIYmiOF/3nySX4HHBpTmjeCdxG?= =?us-ascii?Q?AH9N8KWt07xzXTLBDi9g9jml8SQoOKi1Gon/yvEI8dJgeRwknR1SeBXxLeAg?= =?us-ascii?Q?thC0NBkFdK8lUeMAru0W6UOm7uUbey4ETbKpqfmzRxUYTQs+kyOHBp4m4aob?= =?us-ascii?Q?+AdDKSkggbYw4zOw78GOAEVL+4HRFupK+r4W0iTLVVNhtvT9SXORe1v3SYpN?= =?us-ascii?Q?eyCWszUau67NrCnFZ+c5cSeSGnvMQQz86vALvKfbDh32f8khi+5k6U56egcg?= =?us-ascii?Q?pelpsI1ZeRaoERXlw3DvmGubgZn8QvzWlxaALEdZkn+KO7baEHUd2LIskO+4?= =?us-ascii?Q?CFZ4fVwDJv5qrrzSKpv8Nx3HPk6iLw7hWVtYC3iV7jymJeK4WaL45VBhTpnB?= =?us-ascii?Q?PKirSqb9MDXMaXs24bdpgK7JN32xHqTQndbHHcLLBAGOhWK+1vnMbXbsuAhE?= =?us-ascii?Q?0tG9cZMk2lrold9QqNfuPw5Yncfam59x0L3ZjwsF0tFqBTsavUl2hRjek6eV?= =?us-ascii?Q?8MNXcb0i/JTt0s+3S4KucT1M23sQAieS6/RlqWAkRuy7yZ+nUvEoKhVCG47A?= =?us-ascii?Q?yXHTLWDruGwyKufs9rWIiHMmh2eerBd51vhEm6BfswJpOhMA1elLhfBLbq+T?= =?us-ascii?Q?9j3jxWYMZ6+qfhPbBloy8HnSAskbUaWNzksyVnEUzA++VtS9N9gTvNgYn2s5?= =?us-ascii?Q?xOGrZUbgsCsHzz0GlN80SElmSav1qRKDTRWzTDX7DFLRbDgNFqb3MbQWvl0Q?= =?us-ascii?Q?hPtYCq9zJTzlUrrJIottacYURBZ+xpGSKomGvt96Cwn5832606t+BTGA+c7P?= =?us-ascii?Q?X/g78vE2+RDu80na2eeqxhAyz50AdBg7WveIjIUu6j/lilY6uT2MY65ElO7h?= =?us-ascii?Q?O76dnyaCphrDEPmoOXOXfXmabTrfHtYedpNV1aUhQY1/3DZ4Fqb3FoMORnGu?= =?us-ascii?Q?i0mkHvqMSXexGNJhHEpYFJadnf+F+bnAL1IVD4sC+sLpQbLRLAy8cylk+aO/?= =?us-ascii?Q?hf8CGM2HdIVsuQTlubX2VUqyAyfiMR+HRk+p3ujYxv5OIMkSwjxuF+5O4sMU?= =?us-ascii?Q?6GOmG1CNosJphewIFHXsxyOSvt5X/cicyDiLIy8nDSldv7w5uh8HOAxoNOrY?= =?us-ascii?Q?EKgSc3nTyl5aboyYXvGq/s3ua7gBl58IRGmH24l0aPux4o5ApLr5d9ANH03i?= =?us-ascii?Q?ehM=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4476.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 006ca49e-65d2-49d1-a54a-08d8fdc6586c X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2021 15:19:20.1012 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: peq0gTiuY9wNbYfuXNFjf7RZNeQx0S1i9cav5Aaz1GUR/4keCzH2Mo5bp/xJrwOfPzucF1jX0Gz2G70BjmEi1b8pS+s3CBh2/MsNu7A1mrw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1548 Return-Path: rangasai.v.chaganty@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sai Chaganty =20 -----Original Message----- From: Ni, Ray =20 Sent: Monday, April 12, 2021 1:45 AM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V Subject: [PATCH] IntelSiliconPkg/ShadowMicrocode: Fix build failure The commit 7e4c6f982a0accd5aa86337b46d20199db989aeb updated ShadowMicrocode module to consume MicrocodeLib. But the change caused the build failure. The patch fixed the build failure and also verified the change in real plat= form. Signed-off-by: Ray Ni Cc: Rangasai V Chaganty --- .../Feature/ShadowMicrocode/ShadowMicrocodePei.c | 3 +-- Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMi= crocodePei.c b/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/Shadow= MicrocodePei.c index 4e4b69a0ca..7f4a3f8fbd 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocode= Pei.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicroc +++ odePei.c @@ -291,7 +291,6 @@ ShadowMicrocode ( UINTN MaxPatchNumber; CPU_MICROCODE_HEADER= *MicrocodeEntryPoint; UINTN Pat= chCount;- UINTN DataSize; UINTN = TotalSize; UINTN TotalLoadSiz= e; @@ -342,7 +341,7 @@ ShadowMicrocode ( if (FitEntry[Index].Type =3D=3D FIT_TYPE_01_MICROCODE) { Microco= deEntryPoint =3D (CPU_MICROCODE_HEADER *) (UINTN) FitEntry[Index].Address; = TotalSize =3D GetMicrocodeLength (MicrocodeEntryPoint);- if (IsV= alidMicrocode (MicrocodeEntryPoint, TotalSize, MicrocodeCpuId, CpuIdCount, = FALSE)) {+ if (IsValidMicrocode (MicrocodeEntryPoint, TotalSize, 0, Mi= crocodeCpuId, CpuIdCount, FALSE)) { PatchInfoBuffer[PatchCount].Add= ress =3D (UINTN) MicrocodeEntryPoint; PatchInfoBuffer[PatchCount].S= ize =3D TotalSize; TotalLoadSize +=3D TotalSize;diff --git a/Sil= icon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc b/Silicon/Intel/IntelSilicon= Pkg/IntelSiliconPkg.dsc index edc79c9b9c..5e0de7e19a 100644 --- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc +++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc @@ -39,6 +39,7 @@ MicrocodeFlashAccessLib|IntelSiliconPkg/Feature/Capsule/Library/Microcod= eFlashAccessLibNull/MicrocodeFlashAccessLibNull.inf PeiGetVtdPmrAlignment= Lib|IntelSiliconPkg/Library/PeiGetVtdPmrAlignmentLib/PeiGetVtdPmrAlignmentL= ib.inf TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMe= asurementLibNull.inf+ MicrocodeLib|UefiCpuPkg/Library/MicrocodeLib/Microco= deLib.inf [LibraryClasses.common.PEIM] PeimEntryPoint|MdePkg/Library/Pei= mEntryPoint/PeimEntryPoint.inf--=20 2.27.0.windows.1