From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.6541.1574133048478467566 for ; Mon, 18 Nov 2019 19:10:48 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Tqx0N8+0; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: michael.a.kubacki@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Nov 2019 19:10:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,322,1569308400"; d="scan'208";a="380871329" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga005.jf.intel.com with ESMTP; 18 Nov 2019 19:10:47 -0800 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 18 Nov 2019 19:10:47 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 18 Nov 2019 19:10:47 -0800 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.55) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 18 Nov 2019 19:10:47 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V2suooxMSyC+qBIi1v1eTatQO61m6Ap5j2Po4NFb7mstb0NnKqejgfJzgxd1KYt0km3Qtpqdxogbsf/8Ui8rHo8p44p1/tqA9w1eeq8dJTaXZ08t42epVE9xtIJOxlk4LrKTDJ9rUAbJ350SAr1069wsLUZTPwirNw6B2aVxLLPkajZaMXfcHZJC8WKePhjStAbKIiSr068oVKLu1na97jQjM0AIPhc0ME+dMcwHLpbAOJtksfLs1RbCPcN9Si22+0z/cCUZi10m/ESnqR6aE4Pr7/8VTJLZcp5yaeTuYUNaYKeQU8KO8bTU1yH4xELjsI6j9IG0oRy84YhW/NBAJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hX3wkAjIl+YmwyXkZzGdeqqCLYHhhPmqWTK6c+Owq/4=; b=gg3q0Ceh9a+QLVKWl8mFAibuEx07G32kwSXnOrxJ7iqGrlYpEcMBjxzAB0RSwPnQfnF+ut2jZFZbTUr44z25AlehWa1ACf50DuCCUEnBYw8ZhyvAyUpQgWwYSzz6L1S3XZyCKHrjcwJDbDUVh7Nk+TRKxA+H8F54qJsABXM4g184WVlgtQiDC/efA4t/U9z/p/kOCVTZT2D0I9F47sTUpBcmZJMyDdYcoEF+Mjv6Ehh232V/64SmuHxHm8i2o2jiX3j13p90tBSSmMqeQTxMceX2QwJQnZsWuo9LIOnuReo2ZBoWvUj+9gll5Ko7aHX1o37iW1/dAaHl8upTP0jHeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hX3wkAjIl+YmwyXkZzGdeqqCLYHhhPmqWTK6c+Owq/4=; b=Tqx0N8+0v23uYDsIVIFrE0YdplC1IrWaExHj5lfg8YbYuFKPnzrD/Lr77CGswc1+oPZmZmTwL5k7GFdPI7cmbYS64qmqHammCP/zD3S2vADojdxuVGa4cBrYSsi23w5U0PDtNrkSWSgtRw1vTFIWhc/8vqQZRhkPXrXqERJ+9W0= Received: from DM6PR11MB4491.namprd11.prod.outlook.com (52.132.251.211) by DM6PR11MB3388.namprd11.prod.outlook.com (20.176.121.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2451.29; Tue, 19 Nov 2019 03:10:30 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::b086:dd55:812b:d27f]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::b086:dd55:812b:d27f%7]) with mapi id 15.20.2451.031; Tue, 19 Nov 2019 03:10:30 +0000 From: "Kubacki, Michael A" To: "Gao, Liming" , "devel@edk2.groups.io" CC: "Bi, Dandan" , "Wang, Jian J" , "Wu, Hao A" Subject: Re: [edk2-devel] [PATCH V1 1/1] MdeModulePkg PeiCore: Improve PeiInstallPeiMemory() description Thread-Topic: [edk2-devel] [PATCH V1 1/1] MdeModulePkg PeiCore: Improve PeiInstallPeiMemory() description Thread-Index: AQHVnnxUqKXTzZv2UE2K5TuCm4CouqeR0LuA Date: Tue, 19 Nov 2019 03:10:30 +0000 Message-ID: References: <20191118072103.2436-1-michael.a.kubacki@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E542C6F@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E542C6F@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGFlMmZkMzctOTBjNS00ZmQ2LTlmNGEtZDUyMTMyMzQzMDNkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoialdiVXpkNXM1Q0hBMmpzTFB3R04ydmwyTUVVR0tZXC9cL3A0V3lvUHIzXC81c1hjXC9Sbzc0ZytmU1wvNEVBQUQyeU5GIn0= dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 55476bec-9295-470c-ce08-08d76c9e08e6 x-ms-traffictypediagnostic: DM6PR11MB3388: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 022649CC2C x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(366004)(136003)(39860400002)(346002)(376002)(189003)(199004)(13464003)(966005)(52536014)(8936002)(54906003)(4326008)(316002)(26005)(102836004)(305945005)(7736002)(2906002)(186003)(53546011)(6506007)(86362001)(6116002)(66066001)(476003)(76176011)(7696005)(71190400001)(71200400001)(229853002)(6306002)(9686003)(6436002)(14444005)(256004)(55016002)(478600001)(33656002)(2501003)(66446008)(11346002)(446003)(3846002)(486006)(74316002)(14454004)(66476007)(66556008)(66946007)(25786009)(107886003)(81166006)(81156014)(6246003)(5660300002)(8676002)(76116006)(99286004)(110136005)(64756008)(25903002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM6PR11MB3388;H:DM6PR11MB4491.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1smlIrjv3kDFMhGQp2amH2sdsgPrUd/s/k8Jpef0OvviYS7FwwsFMnVeD43+1P6/8BzYq4eRLHHpS6kfnIuaNYGOX4yWXQjPPzoQXFq4TwIV2NT9Yh0aKjojTPBT1A7MSPKkUAA9LxOmFxfAT8IDCU1zpzgWa/N0jPU6ZH8bPL+Xdurj9X0T6ojlEJBljNxdqShLYtigG6qw2DyU8yYV329glXW4RcxbKLSxOdijZfkRjTp2l+FT6j5SnMFiTrDEspMBwlYXlZJE3j+Cs+HKHhmE8ilKLFXvjkTdQLtM8XSIKx7ZNKDZnc+fjoaMFNyBPLO+Ue5Jh0K4P866JaCUqb6fmsawc0Z7G4sIO9q5dlFjLsXe5rukc7kr8MZoYfAVrs2UlZcoGbGNKSPxlQTCk0GCK83RJti0FPSpXbsRqLDEOqx4e6lxQhM7jO2CrqX5 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 55476bec-9295-470c-ce08-08d76c9e08e6 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Nov 2019 03:10:30.4791 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: k9ipNvbEtdQhsGhGXel2yPJYhqWTvlNDuf6XxR7BemTzR9ABQ5P9B0HtKRp0bpmdnEeijfBFtJdgcrzMOUj00k+EgLg+n/m19W84i6vDj6Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3388 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes, I missed that one. I will send it out in a V2. Thanks, Michael > -----Original Message----- > From: Gao, Liming > Sent: Monday, November 18, 2019 5:55 PM > To: devel@edk2.groups.io; Kubacki, Michael A > > Cc: Bi, Dandan ; Wang, Jian J > ; Wu, Hao A > Subject: RE: [edk2-devel] [PATCH V1 1/1] MdeModulePkg PeiCore: Improve > PeiInstallPeiMemory() description >=20 > Michael: > Will you also plan to update EFI_PEI_INSTALL_PEI_MEMORY definition in > MdePkg\Include\Pi\PiPeiCis.h based on PI1.7? >=20 > Thanks > Liming > >-----Original Message----- > >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > >Kubacki, Michael A > >Sent: Monday, November 18, 2019 3:21 PM > >To: devel@edk2.groups.io > >Cc: Bi, Dandan ; Gao, Liming > >; Wang, Jian J ; Wu, Hao A > > > >Subject: [edk2-devel] [PATCH V1 1/1] MdeModulePkg PeiCore: Improve > >PeiInstallPeiMemory() description > > > >Updates the function description for PeiInstallPeiMemory () to be more > >helpful. The description is based on that given in the PI Specification > >Version 1.7. > > > >Cc: Dandan Bi > >Cc: Liming Gao > >Cc: Jian J Wang > >Cc: Hao A Wu > >Signed-off-by: Michael Kubacki > >--- > > MdeModulePkg/Core/Pei/PeiMain.h | 23 ++++++++++++++---- > > MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 25 > >+++++++++++++------- > > 2 files changed, 35 insertions(+), 13 deletions(-) > > > >diff --git a/MdeModulePkg/Core/Pei/PeiMain.h > >b/MdeModulePkg/Core/Pei/PeiMain.h > >index f2aa97c664..14dfb20d05 100644 > >--- a/MdeModulePkg/Core/Pei/PeiMain.h > >+++ b/MdeModulePkg/Core/Pei/PeiMain.h > >@@ -898,13 +898,26 @@ InitializeMemoryServices ( > > ); > > > > /** > >+ Registers the found memory configuration with the PEI Foundation. > > > >- Install the permanent memory is now available. > >- Creates HOB (PHIT and Stack). > >+ This service enables PEIMs to register the permanent memory > >configuration that has been initialized > >+ with the PEI Foundation. The result of this call-set is the creation > >+ of the > >appropriate Hand-Off Block > >+ (HOB) describing the physical memory. > > > >- @param PeiServices An indirect pointer to the EFI_PEI_SERVICES t= able > >published by the PEI Foundation. > >- @param MemoryBegin Start of memory address. > >- @param MemoryLength Length of memory. > >+ The usage model is that the PEIM that discovers the permanent memory > >shall invoke this service. > >+ This routine will store discovered memory information in the > >+ PeiCore's > >private data, and set the > >+ SwitchStackSignal flag. After the PEIM who discovered memory is > >dispatched, the PeiDispatcher will > >+ migrate temporary memory to permanent memory. > >+ > >+ The memory reported is a single contiguous run. It should be enough > >+ to > >allocate a PEI stack and > >+ some HOB list. The full memory map will be reported using the > >+ appropriate > >memory HOBs. The > >+ PEI Foundation will follow up with an installation of > >EFI_PEI_PERMANENT_MEMORY_INSTALLED_PPI. > >+ > >+ Any invocations of this service after the first invocation which > >+ returns > >EFI_SUCCESS will be ignored. > >+ > >+ @param[in] PeiServices An indirect pointer to the EFI_PEI_SERVIC= ES > table > >published by the PEI Foundation. > >+ @param[in] MemoryBegin Start of memory address. > >+ @param[in] MemoryLength Length of memory. > > > > @return EFI_SUCCESS Always success. > > > >diff --git a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c > >b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c > >index 706837890f..b6ac876145 100644 > >--- a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c > >+++ b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c > >@@ -1,7 +1,7 @@ > > /** @file > > EFI PEI Core memory services > > > >-Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
> >+Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
> > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > **/ > >@@ -55,17 +55,26 @@ InitializeMemoryServices ( } > > > > /** > >+ Registers the found memory configuration with the PEI Foundation. > > > >- This function registers the found memory configuration with the PEI > >Foundation. > >+ This service enables PEIMs to register the permanent memory > >configuration that has been initialized > >+ with the PEI Foundation. The result of this call-set is the creation > >+ of the > >appropriate Hand-Off Block > >+ (HOB) describing the physical memory. > > > > The usage model is that the PEIM that discovers the permanent memory > >shall invoke this service. > >- This routine will hold discoveried memory information into PeiCore's > >private data, > >- and set SwitchStackSignal flag. After PEIM who discovery memory is > >dispatched, > >- PeiDispatcher will migrate temporary memory to permenement memory. > >+ This routine will store discovered memory information in the > >+ PeiCore's > >private data, and set the > >+ SwitchStackSignal flag. After the PEIM who discovered memory is > >dispatched, the PeiDispatcher will > >+ migrate temporary memory to permanent memory. > > > >- @param PeiServices An indirect pointer to the EFI_PEI_SERVICE= S table > >published by the PEI Foundation. > >- @param MemoryBegin Start of memory address. > >- @param MemoryLength Length of memory. > >+ The memory reported is a single contiguous run. It should be enough > >+ to > >allocate a PEI stack and > >+ some HOB list. The full memory map will be reported using the > >+ appropriate > >memory HOBs. The > >+ PEI Foundation will follow up with an installation of > >EFI_PEI_PERMANENT_MEMORY_INSTALLED_PPI. > >+ > >+ Any invocations of this service after the first invocation which > >+ returns > >EFI_SUCCESS will be ignored. > >+ > >+ @param[in] PeiServices An indirect pointer to the EFI_PEI_SERVIC= ES > table > >published by the PEI Foundation. > >+ @param[in] MemoryBegin Start of memory address. > >+ @param[in] MemoryLength Length of memory. > > > > @return EFI_SUCCESS Always success. > > > >-- > >2.16.2.windows.1 > > > > > > >=20