From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web08.6766.1651211017118085268 for ; Thu, 28 Apr 2022 22:43:37 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=V2LEEB0A; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: zhuoran.chao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651211017; x=1682747017; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=pghDclmA7AL3vSNmzX7guqEJ50ion7P50cetd0ja7D8=; b=V2LEEB0ATP2KhumWcrC0V6fw/MjtFub8eZ/F2ZLepPCkJMWxjvjXR+mi RzKF8Z/Ty4mxDFLnZes8CqzGjVNbZ0lgVRWh0uHGKzTwSWeKFMCgjIWn5 yCJLmHt1nmvE+m2bKxxoNzV7dHkMLN3EBAv1h/VrJ+2lUhzQAnDa6FE4W Gs2tzCchVairznKBZnjDWU6yM9VAyzHuIzexUqyk4bi2mvMuUajjjjIuA t9SNm6aj9qslCqtcUz5PUjHXrAueKopmgNFG9ueTXrkjaFta2QsCgtwFi UPR/9XfWh7+T/CoAiSVKAjvMrcDrmjEWih9EJs/yBtIUOwckxByX7CcVv Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10331"; a="327033144" X-IronPort-AV: E=Sophos;i="5.91,297,1647327600"; d="scan'208";a="327033144" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2022 22:43:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,297,1647327600"; d="scan'208";a="731883052" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga005.jf.intel.com with ESMTP; 28 Apr 2022 22:43:36 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 28 Apr 2022 22:43:36 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 28 Apr 2022 22:43:35 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 28 Apr 2022 22:43:35 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.43) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 28 Apr 2022 22:43:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gUa61D/bljkghGc78HSAdvzfEb+IC19Rf1Gzn1gif3l73TeMuZeuuoJCgyS09zdYgpiZ0XZeMwfK08TpLH8PiU27U+8aLqz/FhHdRhLWyhlwSxM96Cfqx0IsSqwDt0v8dL7TKKs6IaPPXtgox/4GqpZje+CpMx80/PPD78yk2CdGJK/SPAIVtKxpJRUEjLu902gtgAWq8eoPdUNnZVcomJ14VdjIqQfwq4vQHWJrjg6sGnFidRO2o17Xhm7OODgkKD/aLvfPEarYSgkIRgzv33ceRUy9cPemDfOi8rnPpnAvMZVk/0sTta7JiyAH51jefQOCYTY87p0QHEXxzSCqGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ztV5jrTeZm+UZjxoMiyucOgf8b6J3Qvza4sCXBHWJ8I=; b=aBnpdngFlVmRFu6s44s66eu4xmZQAklILx1UHr26jnWN8T8XLqUTyn+p+YKjmLlM5ER9kXmfPdsulOPISZIBiasFeP4NAuhTP+mTv25fRWKc3CThodbr/fF9vqjUVd4pXwFTQ3ENXyeVqbgeKY1UBxtjJwPAMUAfj464J5JL+vumblE+d0XoJukgIbx8Tk34YgnuekEWIB4DzBcvZHuWDyLyBjZA+snW5HhwWpmbvXCnPKOS4Nfah+ykyPPqyJfuTWV/FBxuULGj54drHhGhwQBOL9yYfZvo5/vfVpNtJXzJLgy4mhEtJuC6GoPBPXq3fdCSaJP8YOgt/OqUrj67Pw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4596.namprd11.prod.outlook.com (2603:10b6:5:2a6::17) by BN6PR11MB1748.namprd11.prod.outlook.com (2603:10b6:404:101::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Fri, 29 Apr 2022 05:43:27 +0000 Received: from DM6PR11MB4596.namprd11.prod.outlook.com ([fe80::488d:b611:d980:c65c]) by DM6PR11MB4596.namprd11.prod.outlook.com ([fe80::488d:b611:d980:c65c%4]) with mapi id 15.20.5206.013; Fri, 29 Apr 2022 05:43:27 +0000 From: "Zhuoran Chao" To: "devel@edk2.groups.io" , "Gao, Liming" CC: "Ni, Ray" Subject: Re: [PATCH] PcAtChipsetPkg: Change the flow of PcRtcInit() Thread-Topic: [PATCH] PcAtChipsetPkg: Change the flow of PcRtcInit() Thread-Index: AQHYWLu2iOTFh0VfO0WyKOqMSkV2Ta0GZItA Date: Fri, 29 Apr 2022 05:43:27 +0000 Message-ID: References: <06d8bbd206495c31f5e7aaebc979b338af4264dd.1650900008.git.zhuoran.chao@intel.com> In-Reply-To: <06d8bbd206495c31f5e7aaebc979b338af4264dd.1650900008.git.zhuoran.chao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2eacc4d4-7cfb-4dc6-b8e0-08da29a32f4b x-ms-traffictypediagnostic: BN6PR11MB1748:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: scfm1T7wjEg/vCPjGi+V0xfndCvQl4h3nIyRwGcYQsuObVZDZX4q8jKQZkeIlCEyL2G5A5pJSQ+AmVRcl9v7IkuR2yrjLFwh33k5RAZSWHYrd1QIYNnwSbtOppQcFyKpkl7Unc1Nbt6q88ZBe9u8cZXWapaB9F3pi6DEqT3hJUxOU4kQUPRbZ21wXdlJH65uvfl9NKDYFTbDidw/AO9+F+v2unfzYsb9DKPFONDJqpABZP8CkCLb6H7YOu4Kgh+ux6O6scCLUu7Rgg64HIkd4W6oAdaqVo20dwDOTkoOj+S7pUbdfc+IpyOHhtSv64NbR4AgpBd4kcFUObtkmhA+ZUTtu9mWAOqE4wovwBHdSMSpnFVGlLWnphTCJwjeawywTxrvwTNjoAUoOtvHLO9q4FB46ds8XTjtpFS1bCl7ymiVIG+Q6ynzpjQ7QvUBBX2LE+zM5tSqLX7vCja1GHjin2ZxNR9tIvZVQwtt6GaLAYFBGl4GdLWJjafYl1W+//w0Wkpy0K9sG+2srxYoaQDdE8qyESmx7yA/3Wzh4UYrDPJEXLeX6V5C2YmCjj2h3uzKM3Oc+CYz27r9EDKjntsgIkaOmP/+bwFKX1T39VXPsRk3OX7U3K7rwCNzk6e9FZszR9bqFDWedAN+sFzqd/dyuUr5nnqRvMs6Edv//TWwTjFhIdHe3QOrNWETdxbYLRt7EoTMfqcBe+CEu0ltj9nFB5gYb43EiRn/EEaUI1KkI8Y7Zg9flSAQv3BYNX9XS3aqsIKLOfkxBKUanqXMhgbYzyM7oJ0q2aHdaYAKV6eWmCo= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4596.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(6029001)(366004)(33656002)(5660300002)(508600001)(9686003)(6506007)(26005)(8936002)(53546011)(52536014)(7696005)(2906002)(71200400001)(86362001)(38100700002)(82960400001)(38070700005)(122000001)(83380400001)(186003)(55016003)(107886003)(4326008)(110136005)(66946007)(76116006)(66446008)(66476007)(66556008)(64756008)(8676002)(316002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uwydKYAZ9z8vQVqgT8bB8s829IxmvMAU7cBjkpImMiKH9goXh0JTyNO/d7JO?= =?us-ascii?Q?o1+x9NWGwRdRcktaxyV1IVpJiyfskydefmN7YC1QqQrX21YJ9LWF8/Wmv+3k?= =?us-ascii?Q?LgJ8b0eg/IbrEjUwE/2itl5NDSQMaaFoTaanqM5K45JPOI2TSaqI7BSBjfSH?= =?us-ascii?Q?97FlaLEsk3c0rtqO7AJpKjgQm1C6+PoG/Lf9s0nCP87iiI4/sW5QTIvVMwGZ?= =?us-ascii?Q?VdXzvc/prxK3Gm1LcBr5ldVf3F/bcE8HI7tviKRHr643CrOobI9Qfs+0gfv8?= =?us-ascii?Q?aU0tN3VXa50uxWt54wsygt0Tgc+Cd1e0H1UDP1am6o5KFax1+PL0GFeGLtSj?= =?us-ascii?Q?g16dz8tAcU5pQXjgDSu3YTtT4YmF7/cvKxEvelfGnixoyeZS5W3bEIH36dAf?= =?us-ascii?Q?hzV1TEy9RenHn3/gXz126zImwlWKD6V3QqEocwMHg8zkrZQNERiUAbyvBHeK?= =?us-ascii?Q?uK0saDCXyWUKdcd4ZF3BLbXPE/1lSJcCcR+td7u8kGFSU1fXQoDbNow1dzLa?= =?us-ascii?Q?8RtJfrKTubyg9Ft2CqvjzoaYILZO3yzxS6GjRhp/W0MuiLvsXtCs0pOaiTgI?= =?us-ascii?Q?y8SpcdmSzziaCvHyd+C+p1RdoOXHIzBkJM7UJEnAJpxl0VRBsCsdRtUmJSV9?= =?us-ascii?Q?+I4Yici6WsfHdzjd5hiZY51+DiAhxQpDVYItTcpZn3Yi1UowFhhx1YrTQvqK?= =?us-ascii?Q?yTCXQI8WCJLGQV9Y5nCdlfxG0GaSNf7YnIsY7ExYyhVnk6aTzhHs/bVqcyWr?= =?us-ascii?Q?gW30alZSwvGKVcT2SAvURJUC4Te/LHHv0VKUVy6nedWy1zMuUA2OFSSCjzGX?= =?us-ascii?Q?xgE18kUTShwjwq+ywJv90eW6CRKAiDvfKuFtRzrJKWW1FSQ5yGjb5pgAnAQ+?= =?us-ascii?Q?/l/bp58vfBQ/bqGoR3hQjjEczNpuNGJHCIwe2X7d2MU4lKoEKKVMXHNG6JuF?= =?us-ascii?Q?2et7MH6PUgquLFdt0HXUSB9svSZqXBajUiz93nNPd511VLyn8/QERpQLC0o+?= =?us-ascii?Q?2E5RvawQk9oYQx/3cF2Cx1C+vfyNl/tfCiejed7qey2wHg8AQ4rIOomnhqHH?= =?us-ascii?Q?MPAEf0yjX/jNQwS6p//y/wNjjisV4TyQG0wgjlvc5zM9DPtaIf9AlzMujxNs?= =?us-ascii?Q?pKnIh2MKPlSgta76fu4gBVa0BVM9TzJ7yqwAA7V4pATXdifWEr7nThi0MZ5t?= =?us-ascii?Q?RoUyM3XWqaiZ5K6jW1Jmmgf79qJx3cmXIEvL1eAGlKtHwQ8oZLUC4ISEoI9c?= =?us-ascii?Q?VELlwBEkg9jub9FgoOrG67QbrVci4FEvkMnC/RH1zG0AtHi8R4VAXTg61+2a?= =?us-ascii?Q?p2iSn8GtZWKOru9qxuvqnHXMJyzVcSiGtmKWKJDCV/l106RZCSV5KXRs/YGP?= =?us-ascii?Q?JaZbYJpgctF6LA2DhF5Lm9rSnpxvNYeibx4PDeg6FkTJrysjAszd3Nmie4ee?= =?us-ascii?Q?d88kn9xefkvmeHS4sf7u305G9/NQa0COW1lXd6iqwMP7AG137KL9H1sx9Za8?= =?us-ascii?Q?D2V7wk1UdeLZiI1Gc5/G5wzxg0OEtT9ApbcdXHAvUeVmh6H8eWeZB297l0Fi?= =?us-ascii?Q?WsCWUHChYnVPYL5jOEuYMQZCFXhHiry+fPL5EU0W8/TrsN1qwjvfG3iMjnTk?= =?us-ascii?Q?KT07sqQfaYi329mqCBiaW3bp1CyfdodHIIwlKZeUKc8clNu27bgqsOT830ik?= =?us-ascii?Q?cYOFsO/Kxmd/ZNI98FjLGjXREDYnQXF96vjHDyDml7HGb22LXPUbck520Mxe?= =?us-ascii?Q?4+4oYykbeQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4596.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2eacc4d4-7cfb-4dc6-b8e0-08da29a32f4b X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2022 05:43:27.6090 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9X+V/vHnjuW3siWqWD2EeqVG3Kzn186eOpE4A4/A4w+64KsX8D+yk70QevxZQa5oBW6FicA5TyNONTJ2P3WJSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1748 Return-Path: zhuoran.chao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Liming: Could you help to give a nudge on the below issue because it is related to = a bug fixing of Intel server platform enabling team. Thanks Zhuoran -----Original Message----- From: Chao, Zhuoran =20 Sent: Monday, April 25, 2022 11:47 PM To: devel@edk2.groups.io Cc: Chao, Zhuoran ; Ni, Ray Subject: [PATCH] PcAtChipsetPkg: Change the flow of PcRtcInit() REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3913 The original flow of PcRtcInit() is like: 1. Guarantee atomic accesses to the RTC time registers and read out the value. 2. Program RTC register B. (adopt 12h mode or 24h mode. Current bios code sets RTC to 24h mode by default). 3. Then function ConvertRtcTimeToEfiTime converts the RTC time value to their 24h mode by checking the hour format bit (1:24h mode,0:12h mode). And here lies the problem: Step3 will fail to adjust the value if Step2 alr= eady sets RTC to 24h mode. The hour value in 12h mode will not be converted= to its 24h mode. The solution is to program RTC register B a little later when all the origi= nal RTC registers' value is retrieved, adjusted and validated. Cc: Ray Ni Signed-off-by: Zhuoran Chao --- PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c b/PcAtChips= etPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c index 0fbfa4bcee..ea56a66267 100644 --- a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c +++ b/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c @@ -269,13 +269,6 @@ PcRtcInit ( Time.Month =3D RtcRead (RTC_ADDRESS_MONTH); Time.Year =3D RtcRead (RTC_ADDRESS_YEAR); =20 - // - // Set RTC configuration after get original time - // The value of bit AIE should be reserved. - // - RegisterB.Data =3D FixedPcdGet8 (PcdInitialValueRtcRegisterB) | (Registe= rB.Data & BIT5); - RtcWrite (RTC_ADDRESS_REGISTER_B, RegisterB.Data); - // // Release RTC Lock. // @@ -330,6 +323,13 @@ PcRtcInit ( Time.Daylight =3D 0; } =20 + // + // Set RTC configuration after get original time // The value of bit=20 + AIE should be reserved. + // + RegisterB.Data =3D FixedPcdGet8 (PcdInitialValueRtcRegisterB) |=20 + (RegisterB.Data & BIT5); RtcWrite (RTC_ADDRESS_REGISTER_B,=20 + RegisterB.Data); + // // Reset time value according to new RTC configuration // -- 2.31.1.windows.1