From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id DF8EAAC0BA2 for ; Thu, 1 Feb 2024 06:58:08 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=8UKeVbCURAulpa851Uu9rqaC0WyRj42tlVssmz/brEI=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706770687; v=1; b=JmsvxStmfjyOlRhhH7KMGCUOKejOILQ7geYj2zVRjkT8Y6+5G7hKzgF03lZ5qdHq+zOeahuh bg/QmbcpJwKIjxKjklHdxJJ/HbxB4xT6oyvOUcLBt6NaCe5RkqW/0NbW9y7KtemCibn8Vw84gUa me486M1ScS0Uv1svryAMFJls= X-Received: by 127.0.0.2 with SMTP id WiojYY7687511xe94b3JQ2Ez; Wed, 31 Jan 2024 22:58:07 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by mx.groups.io with SMTP id smtpd.web11.10140.1706770686595787520 for ; Wed, 31 Jan 2024 22:58:06 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10969"; a="13744" X-IronPort-AV: E=Sophos;i="6.05,234,1701158400"; d="scan'208";a="13744" X-Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2024 22:58:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10969"; a="932101277" X-IronPort-AV: E=Sophos;i="6.05,234,1701158400"; d="scan'208";a="932101277" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 31 Jan 2024 22:58:06 -0800 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 31 Jan 2024 22:58:05 -0800 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 31 Jan 2024 22:58:05 -0800 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 31 Jan 2024 22:58:05 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dWCMfSKbqCXgH9pVjWSJrXFrWPrBUIOgOATxlLBEZJ5oShLMUIxdBzLuutw6eslBDz/SBO5j8bW0NU6a2d3cAZvdYiNlkxuBDBCP7aG77V5ODwOxprisav02En/UehIydC8MqnsV4mdbA8dZ1OVBvcgMBsfqFwMGYgmTHaQ+CmTRWOjIdSgGZZC5wE/DJDEQcJDMxPh7naMRUeb1EBU56soOPUTwHxHWQgL2PT4gSQnU+OkYPnG8FOAXJEvN0VWiKCmq7tdyLzJQS0zOeLMti2Fp/n/hVB7pgbMl6n9Mh03t3EC0nfYMtdSasTouBn5kiApy/SKWRcOCytmSkuVqow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F3nLn7xay6NhmfihpGOSx+DsWsSuEEM50f5qk90aPNI=; b=BiPtZwDnn+hr7pvJBu5bYsBVGch3ZeMKgHFLTb0XTbu9cBVVLk1fg7bTLOgW9D/To9FG8UTKG1E/APShKo1TJUe6U8bVseukqHbeBbHeRTziy4eWcWj57XMfcOmsGfUNEv7O8L182i5GJt+W8nx67jzw5NhIbrnAIoUwcwDX+Gc2MFRM5ZjkpGPMWxmhJLPG453wWs5Z0GHshd7bVFxs1/PAUoBxM9qnSlil91krbfOLdIykH8iwlZrpsIeGTftHTVdnZFwcRyYkQ+eCkAuU2rfmR1wQ1IJKriWpSx+ReCnqNMrF/z7d7F8pMmgvwhLhcRH+YF7IFZzSlifKG0FodQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from DM6PR11MB4627.namprd11.prod.outlook.com (2603:10b6:5:2a2::19) by BY1PR11MB8031.namprd11.prod.outlook.com (2603:10b6:a03:529::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.24; Thu, 1 Feb 2024 06:58:03 +0000 X-Received: from DM6PR11MB4627.namprd11.prod.outlook.com ([fe80::9bf6:20bd:a5f9:8e51]) by DM6PR11MB4627.namprd11.prod.outlook.com ([fe80::9bf6:20bd:a5f9:8e51%2]) with mapi id 15.20.7249.023; Thu, 1 Feb 2024 06:58:03 +0000 From: "Huang, Jenny" To: "devel@edk2.groups.io" , "Sheng, W" CC: "Ni, Ray" , "Chaganty, Rangasai V" , "Chiang, Chris" Subject: Re: [edk2-devel] [PATCH] IntelSiliconPkg/VTd: Remove ASSERT in VTdSetAttribute Thread-Topic: [edk2-devel] [PATCH] IntelSiliconPkg/VTd: Remove ASSERT in VTdSetAttribute Thread-Index: AQHaUnYHe2/7m4bx+Euw5g+1CEdb3bD1EvVg Date: Thu, 1 Feb 2024 06:58:03 +0000 Message-ID: References: <17AEBB0C10223E55.21687@groups.io> In-Reply-To: <17AEBB0C10223E55.21687@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4627:EE_|BY1PR11MB8031:EE_ x-ms-office365-filtering-correlation-id: d9a10eef-3f39-4579-4c44-08dc22f322b7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: cKY3CWdTXMk/akJYyH1dQAtECAQ/eJOBx/S9FbGwbOc6F0FW0qdDQGDGzDUnbMRtI98I2PmbREY1tLhDvXhQENknZ2ts4Ql1gCuCHSsDUgbUVV3da/Sol0035/e7HlnVyVG7thtK+GBnTQB1EhXkMZ+5xP/3F5PJCo0DWTTknr1q44nZ7Qlc4EZiY5wwcrQU/Mlul5XwaD6ljoil2frYjqC/iIthoNpsBMpL+KGK+NR17iGXOvUS3njmRGHgnsxDTlgyvquiMHva7nxP1+EQe4aGbiIBkrWptFbtDwRDN3DggCq+ZqUaKAt56WOmYCRP3JlNPpjgVQKDw4r6hKJixWjV+d3yeCczcNp5XCAGbTow0Mt+5ktn7B8teUSUbYzvjVTaV4PcSrFZy/KQI6ScS5YE7TwxghGNAm8Oj3GklQEvrhb8wO/McCnWafUPxkkDXh2OlcQs6vGsMGxcHBx6/M2vwR7CAeUabw8Jjo+yxIa7hsPbO88oc11fk4O87WKWX/aHBGVCofEol51/zYhUx9VCb/at1Y/Sn+X1y+uBof6VFBZSASCjsXbH9XNFcAIIYUpGqx8fjmJe+f+xzpwEdUIQJunkC6bl0fiAkOAda2bo6jMUrg+TsG3ezN7VaFigDyXq3hfy/qTbFMPdS8azHQuqLzI1hv+CzE9j9E9xeZQ= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Rpdu1KwfgIo1yW2baKtGwsD7jP/w78ez4mBnMIB5rAXkLy7cMIl/JHJk31Mr?= =?us-ascii?Q?384x7BhEeVkA8HGx3/3izoaGVShxdvhTISsx0iTVFruZMQ0zKoOJ35XIkHXY?= =?us-ascii?Q?770tEIkxVW0PMCgCBSjy4ClHPY1AxIU/gu3dd5wIHWTxfilm6ID3WKt+VzIr?= =?us-ascii?Q?dT0Wn8GcBbsUY3ArQtLIDetuNOOK+HsCG0ftxc9pq8u4Ydwsjy3Wd0v9qTdh?= =?us-ascii?Q?b/BxSIKaPm2YjWe+tyd4so2b2tAIZC5WSilr8ykWrxb+jbNI/Rh0qKxRnhlo?= =?us-ascii?Q?+d3t65px2qJKX8RfdZXYVqE1nHAXnODARcZLsVoz1UlS14wcH1K+9kDAmic7?= =?us-ascii?Q?RiCQJf2EfbeHIC/EwZysr8ynKBmndkbAt0Hk4bhXDAFa9+dd10IVxgQ8QMfP?= =?us-ascii?Q?74FAt+FIATdSidJU872lfvCLk3I8DR+mhrneza/UZEkvfFbCxyh+MvVseCPP?= =?us-ascii?Q?Wo8P4IUyR09fMwRLxfEwflklBwFeXwd83wkV2cbgdyBeNBK7vjifPpc8asP0?= =?us-ascii?Q?BOU1cNFMG360GWPmwUEJgn+yMnV4liGNmeOrMza33qKxTjhOru6i9uDZoPbf?= =?us-ascii?Q?Q9fIOb3EXm1geDvgojbhK6AaEuKyqou0HTls4Lm2rqBAzIVEpUKzDCwx2UbS?= =?us-ascii?Q?DBu5ebfRdUiA8xtACHFYODe5EdroHZeTYg3cAhAwWAaH2M35CKtPQ9MODeZB?= =?us-ascii?Q?lr6k6Mq+WNUN2DeCfQLyTCoW1wOiQDUDFPFz+Bv66QHtizqLqIHoqvJTQWqf?= =?us-ascii?Q?euhGNYpIb27ctCWTiW0AjkHuLPqdOurj1ycIuVt1dP0Rzg5DCkwRGEZHFEAy?= =?us-ascii?Q?gw+AYZaz2SJzSyAjCThfDVZWuH7EtUsjOw2xqscQfZCQ5DDzM4SGbHfrPFIq?= =?us-ascii?Q?/BlFey/1voIyn31moL//d3NA4jEdpqwVpwGtnY5gJIYczsKOIVYVI2BqLWk/?= =?us-ascii?Q?Ywxg1Uw1aEbLOoylzjP04SZawrjSveOwvLK6iyxFhjItTRwYe5N4nhXNea6G?= =?us-ascii?Q?eJ8YTTGUbWbXQ1Ns31T+tyOCiW4zR1TbyAlhnuQA9ahzogQrCl0yGgnBryCB?= =?us-ascii?Q?E8zQKGgSczVEd2p/TAHeZN6lSoLyyXMzHD5J7/1O3QP4p2uKYjN1piCAZCi8?= =?us-ascii?Q?heq3zjiWjBMhul2OMnLNHJEXRtzCMlfXDoSWruNfhsDDY2YQ9YdXiue4AGZ5?= =?us-ascii?Q?ZjY0lSsKMlKtmAliEqAWVc0Yut7FLAnWhXuFcfGGUhiyj5C6EAy8px/ODcL5?= =?us-ascii?Q?2KewSG2GB2PGyYCfxLxgvon4MZCK4o5JiScbCatSjVZZ0RqH0qrsOu1WuCQs?= =?us-ascii?Q?eDAuOdj6AhlJaJTgsUh2r03M5+rNjkzIJR8ICwigEh+vY1jyBPofTU8dQNAC?= =?us-ascii?Q?ZA8/3kAde0THe68yjqxEl59DyrRvoYQaMeeCB3Vmk6/ud8bo0ZdWd+zkYnEJ?= =?us-ascii?Q?A0qTgACaMyMOZY9cfA820FCPKd5kekaTh+g1UrMqMvnfmlOvsue+towoWTsi?= =?us-ascii?Q?tXzgoyF+byAhc7M7oQI9JbfKi8+Qd4JKkRHRYredyuWrUvKbABuQk1VadySW?= =?us-ascii?Q?C+SOX1WRFseksWuGC5JUL4HqM+9dYL7J7ukbNj1Z?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4627.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9a10eef-3f39-4579-4c44-08dc22f322b7 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2024 06:58:03.4158 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: b9H+w4AOf3b3wnUs2eUia6rX6zjFfo91S9aH7F38fTmcCTKQAZj4WpVfvv0mZudbHinIPdqZ3sjkhExOiKhCxg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR11MB8031 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jenny.huang@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 38MOCJVYwpFZp5Juc1pTRrCOx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=JmsvxStm; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by : Jenny Huang -----Original Message----- From: devel@edk2.groups.io On Behalf Of Sheng, W Sent: Monday, January 29, 2024 1:43 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V ; Huang, Jenny ; Chiang, Chris Subject: [edk2-devel] [PATCH] IntelSiliconPkg/VTd: Remove ASSERT in VTdSetA= ttribute When PcdVTdPolicyPropertyMask BIT2 is set and ACPI DMAR table is not ready,= It is no need to hit an assert, and just returns EFI_NOT_READY. Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Jenny Huang Cc: Chiang Chris Signed-off-by: Sheng Wei --- .../Feature/VTd/IntelVTdCoreDxe/IntelVTdCoreDxe.c | 1 - .../Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.c | 1 - 2 files changed, 2 deletions(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/Inte= lVTdCoreDxe.c b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/I= ntelVTdCoreDxe.c index 8449b288..27821782 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/IntelVTdCor= eDxe.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/IntelVTd +++ CoreDxe.c @@ -253,7 +253,6 @@ VTdSetAttribute ( // // Force no IOMMU access attribute request recording before DMAR tab= le is installed. // - ASSERT_EFI_ERROR (EFI_NOT_READY); return EFI_NOT_READY; } Status =3D RequestAccessAttribute (Segment, SourceId, DeviceAddress, L= ength, IoMmuAccess); diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTd= Dxe.c b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.c index a6287be2..d7aa106f 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVTdDxe. +++ c @@ -252,7 +252,6 @@ VTdSetAttribute ( // // Force no IOMMU access attribute request recording before DMAR tab= le is installed. // - ASSERT_EFI_ERROR (EFI_NOT_READY); return EFI_NOT_READY; } Status =3D RequestAccessAttribute (Segment, SourceId, DeviceAddress, L= ength, IoMmuAccess); -- 2.26.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114676): https://edk2.groups.io/g/devel/message/114676 Mute This Topic: https://groups.io/mt/104026555/2558558 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [w.sheng@intel.com] -=3D-=3D-=3D-=3D-=3D-=3D -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114934): https://edk2.groups.io/g/devel/message/114934 Mute This Topic: https://groups.io/mt/104026555/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-