Re: [edk2-devel] [PATCH] IntelSiliconPkg/VTd: Print Flags field in DeviceScopeEntry

Re: [edk2-devel] [PATCH] IntelSiliconPkg/VTd: Print Flags field in DeviceScopeEntry

[Huang, Jenny]

Reviewed by Jenny Huang <jenny.huang@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sheng, W
Sent: Wednesday, October 11, 2023 1:37 AM
To: devel@edk2.groups.io
Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Huang, Jenny <jenny.huang@intel.com>
Subject: [edk2-devel] [PATCH] IntelSiliconPkg/VTd: Print Flags field in DeviceScopeEntry

Flags field is defined in Device Scope Structure since VT-d spec 4.0.
Print Device Scope Structure Flags field when dump DMAR table.

Change-Id: I37365ea4c1e6cfa0a1842a5830761367777b7d2c
Signed-off-by: Sheng Wei <w.sheng@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Cc: Jenny Huang <jenny.huang@intel.com>
---
 .../Library/IntelVTdPeiDxeLib/IntelVTdPeiDxeLib.c             | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Silicon/Intel/IntelSiliconPkg/Library/IntelVTdPeiDxeLib/IntelVTdPeiDxeLib.c b/Silicon/Intel/IntelSiliconPkg/Library/IntelVTdPeiDxeLib/IntelVTdPeiDxeLib.c
index 1e65115cb..d58c4cdcf 100644
--- a/Silicon/Intel/IntelSiliconPkg/Library/IntelVTdPeiDxeLib/IntelVTdPeiDxeLib.c
+++ b/Silicon/Intel/IntelSiliconPkg/Library/IntelVTdPeiDxeLib/IntelVTdPeiDxeLib.c
@@ -137,6 +137,10 @@ VtdLibDumpDmarDeviceScopeEntry (
     "      Length ............................................. 0x%02x\n",

     DmarDeviceScopeEntry->Length

     ));

+  VTDLIB_DEBUG ((DEBUG_INFO,

+    "      Flags .............................................. 0x%02x\n",

+    DmarDeviceScopeEntry->Flags

+    ));

   VTDLIB_DEBUG ((DEBUG_INFO,

     "      Enumeration ID ..................................... 0x%02x\n",

     DmarDeviceScopeEntry->EnumerationId

-- 
2.26.2.windows.1



-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109519): https://edk2.groups.io/g/devel/message/109519
Mute This Topic: https://groups.io/mt/101892832/2558558
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [w.sheng@intel.com]
-=-=-=-=-=-=




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109970): https://edk2.groups.io/g/devel/message/109970
Mute This Topic: https://groups.io/mt/101892832/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH] IntelSiliconPkg/VTd: Print Flags field in DeviceScopeEntry

[Sheng Wei]

Flags field is defined in Device Scope Structure since VT-d spec 4.0.
Print Device Scope Structure Flags field when dump DMAR table.

Change-Id: I37365ea4c1e6cfa0a1842a5830761367777b7d2c
Signed-off-by: Sheng Wei <w.sheng@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Cc: Jenny Huang <jenny.huang@intel.com>
---
 .../Library/IntelVTdPeiDxeLib/IntelVTdPeiDxeLib.c             | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Silicon/Intel/IntelSiliconPkg/Library/IntelVTdPeiDxeLib/IntelVTdPeiDxeLib.c b/Silicon/Intel/IntelSiliconPkg/Library/IntelVTdPeiDxeLib/IntelVTdPeiDxeLib.c
index 1e65115cb..d58c4cdcf 100644
--- a/Silicon/Intel/IntelSiliconPkg/Library/IntelVTdPeiDxeLib/IntelVTdPeiDxeLib.c
+++ b/Silicon/Intel/IntelSiliconPkg/Library/IntelVTdPeiDxeLib/IntelVTdPeiDxeLib.c
@@ -137,6 +137,10 @@ VtdLibDumpDmarDeviceScopeEntry (
     "      Length ............................................. 0x%02x\n",
     DmarDeviceScopeEntry->Length
     ));
+  VTDLIB_DEBUG ((DEBUG_INFO,
+    "      Flags .............................................. 0x%02x\n",
+    DmarDeviceScopeEntry->Flags
+    ));
   VTDLIB_DEBUG ((DEBUG_INFO,
     "      Enumeration ID ..................................... 0x%02x\n",
     DmarDeviceScopeEntry->EnumerationId
-- 
2.26.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109519): https://edk2.groups.io/g/devel/message/109519
Mute This Topic: https://groups.io/mt/101892832/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-