[PATCH] IntelSiliconPkg/Vtd: Resolve parameter transfer errors

[PATCH] IntelSiliconPkg/Vtd: Resolve parameter transfer errors

[Sheng Wei]

Fix the capsule update assert caused by function call errors.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Cc: Jenny Huang <jenny.huang@intel.com>
Cc: Robert Kowalewski <robert.kowalewski@intel.com>
Signed-off-by: Sheng Wei <w.sheng@intel.com>
---
 .../Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdReg.c  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdReg.c b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdReg.c
index dd0c49698..f05ca6ae5 100644
--- a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdReg.c
+++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdReg.c
@@ -737,7 +737,7 @@ DumpVtdIfError (
     if (HasError) {
       REPORT_STATUS_CODE (EFI_ERROR_CODE, PcdGet32 (PcdErrorCodeVTdError));
       DEBUG((DEBUG_INFO, "\n#### ERROR ####\n"));
-      DumpVtdRegs (Num);
+      DumpVtdRegs (mVtdUnitInformation[Num].VtdUnitBaseAddress);
       DEBUG((DEBUG_INFO, "#### ERROR ####\n\n"));
       //
       // Clear
-- 
2.26.2.windows.1

Re: [PATCH] IntelSiliconPkg/Vtd: Resolve parameter transfer errors

[Huang, Jenny]

Reviewed by Jenny Huang <jenny.huang@intel.com>

-----Original Message-----
From: Sheng, W <w.sheng@intel.com> 
Sent: Wednesday, July 12, 2023 10:52 PM
To: devel@edk2.groups.io
Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Huang, Jenny <jenny.huang@intel.com>; Kowalewski, Robert <robert.kowalewski@intel.com>
Subject: [PATCH] IntelSiliconPkg/Vtd: Resolve parameter transfer errors

Fix the capsule update assert caused by function call errors.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Cc: Jenny Huang <jenny.huang@intel.com>
Cc: Robert Kowalewski <robert.kowalewski@intel.com>
Signed-off-by: Sheng Wei <w.sheng@intel.com>
---
 .../Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdReg.c  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdReg.c b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdReg.c
index dd0c49698..f05ca6ae5 100644
--- a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdReg.c
+++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdReg.c
@@ -737,7 +737,7 @@ DumpVtdIfError (
     if (HasError) {
       REPORT_STATUS_CODE (EFI_ERROR_CODE, PcdGet32 (PcdErrorCodeVTdError));
       DEBUG((DEBUG_INFO, "\n#### ERROR ####\n"));
-      DumpVtdRegs (Num);
+      DumpVtdRegs (mVtdUnitInformation[Num].VtdUnitBaseAddress);
       DEBUG((DEBUG_INFO, "#### ERROR ####\n\n"));
       //
       // Clear
-- 
2.26.2.windows.1

Re: [PATCH] IntelSiliconPkg/Vtd: Resolve parameter transfer errors

[Robert Kowalewski]

Reviewed by Robert Kowalewski <robert.kowalewski@intel.com>

-----Original Message-----
From: Huang, Jenny <jenny.huang@intel.com> 
Sent: Thursday, July 13, 2023 8:01 AM
To: Sheng, W <w.sheng@intel.com>; devel@edk2.groups.io
Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Kowalewski, Robert <robert.kowalewski@intel.com>
Subject: RE: [PATCH] IntelSiliconPkg/Vtd: Resolve parameter transfer errors

Reviewed by Jenny Huang <jenny.huang@intel.com>

-----Original Message-----
From: Sheng, W <w.sheng@intel.com> 
Sent: Wednesday, July 12, 2023 10:52 PM
To: devel@edk2.groups.io
Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Huang, Jenny <jenny.huang@intel.com>; Kowalewski, Robert <robert.kowalewski@intel.com>
Subject: [PATCH] IntelSiliconPkg/Vtd: Resolve parameter transfer errors

Fix the capsule update assert caused by function call errors.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Cc: Jenny Huang <jenny.huang@intel.com>
Cc: Robert Kowalewski <robert.kowalewski@intel.com>
Signed-off-by: Sheng Wei <w.sheng@intel.com>
---
 .../Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdReg.c  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdReg.c b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdReg.c
index dd0c49698..f05ca6ae5 100644
--- a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdReg.c
+++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdCoreDxe/VtdReg.c
@@ -737,7 +737,7 @@ DumpVtdIfError (
     if (HasError) {
       REPORT_STATUS_CODE (EFI_ERROR_CODE, PcdGet32 (PcdErrorCodeVTdError));
       DEBUG((DEBUG_INFO, "\n#### ERROR ####\n"));
-      DumpVtdRegs (Num);
+      DumpVtdRegs (mVtdUnitInformation[Num].VtdUnitBaseAddress);
       DEBUG((DEBUG_INFO, "#### ERROR ####\n\n"));
       //
       // Clear
-- 
2.26.2.windows.1

---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach handlowych.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.