From: "Xue, Gavin" <gavin.xue@intel.com>
To: Pedro Falcato <pedro.falcato@gmail.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "sunilvl@ventanamicro.com" <sunilvl@ventanamicro.com>,
"Warkentin, Andrei" <andrei.warkentin@intel.com>,
"Wang, Yimin" <yimin.wang@intel.com>,
"Sheng, Alan" <alan.sheng@intel.com>
Subject: Re: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64
Date: Tue, 4 Jul 2023 09:39:12 +0000 [thread overview]
Message-ID: <DM6PR11MB4740C564875CBB37FE206001FE2EA@DM6PR11MB4740.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAKbZUD2zi7_oXQg=zdT8t8rv10=NXd=BYpndYQ9UvbVw8xF7xg@mail.gmail.com>
Hi Pedro,
There are 3 different include guard names for ProcessorBind.h file.
AArch64/Arm/Ebc/Ia32/X64 use __PROCESSOR_BIND_H__ (start/end with 2 underscore characters).
RISCV64 uses PROCESSOR_BIND_H__ (end with 2 underscore)
LoongArch64 uses PROCESSOR_BIND_H_ (end with 1 underscore)
From the code rule of uniform style, I think it is also a necessary change to
same include guard name.
If you still think we shouldn't have the change, I am okay to close this patch. Thanks.
Best regards,
Gavin
-----Original Message-----
From: Pedro Falcato <pedro.falcato@gmail.com>
Sent: Tuesday, July 4, 2023 1:02 AM
To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Xue, Gavin <gavin.xue@intel.com>; sunilvl@ventanamicro.com; Warkentin, Andrei <andrei.warkentin@intel.com>; Wang, Yimin <yimin.wang@intel.com>; Sheng, Alan <alan.sheng@intel.com>
Subject: Re: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64
On Fri, Jun 30, 2023 at 5:59 PM Michael D Kinney
<michael.d.kinney@intel.com> wrote:
>
> Using the same include guard define name is preferred.
>
> Why was anything other than that considered?
I don't see the point of making the include guard an actual part of
the "API". Consumers should not depend on it being named $WHATEVER.
That is a hack.
Include guards are an implementation detail and making that stable
actively stops you from doing things like using #pragma once or fixing
the __DOUBLE_UNDERSCORE_H__ stuff.
So I would vote for not changing this, downstream consumers that rely
on __PROCESSOR_BIND_H__ should be fixed, downstream.
--
Pedro
prev parent reply other threads:[~2023-07-04 9:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 7:22 [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64 Gavin Xue
2023-06-16 10:35 ` Sunil V L
2023-06-16 14:11 ` [edk2-devel] " Pedro Falcato
2023-06-16 15:51 ` Xue, Gavin
2023-06-21 14:16 ` Pedro Falcato
2023-06-22 9:58 ` Xue, Gavin
2023-06-22 15:45 ` Pedro Falcato
2023-06-27 20:29 ` Michael D Kinney
2023-06-30 9:28 ` Xue, Gavin
2023-06-30 16:59 ` Michael D Kinney
2023-07-03 9:01 ` Xue, Gavin
2023-07-03 17:01 ` Pedro Falcato
2023-07-04 9:39 ` Xue, Gavin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB4740C564875CBB37FE206001FE2EA@DM6PR11MB4740.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox