public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ashish Singhal" <ashishsingha@nvidia.com>
To: "Ni, Ray" <ray.ni@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Wang, Jian J" <jian.j.wang@intel.com>,
	"Wu, Hao A" <hao.a.wu@intel.com>,
	"Gao, Zhichao" <zhichao.gao@intel.com>
Subject: Re: [PATCH v4] MdeModulePkg: Add EDK2 Platform Boot Manager Protocol
Date: Mon, 23 Dec 2019 02:27:26 +0000	[thread overview]
Message-ID: <DM6PR12MB33246CF53E39F3D6612B1AEEBA2E0@DM6PR12MB3324.namprd12.prod.outlook.com> (raw)
In-Reply-To: <DM6PR12MB33243B9EF23699391E5906B6BA2E0@DM6PR12MB3324.namprd12.prod.outlook.com>

Please ignore patch 5. I have sent patch 6 for consideration.

Thanks
Ashish

-----Original Message-----
From: Ashish Singhal 
Sent: Sunday, December 22, 2019 7:09 PM
To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io; Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
Subject: RE: [PATCH v4] MdeModulePkg: Add EDK2 Platform Boot Manager Protocol

Done. Have submitted patch 5 for consideration.

Thanks
Ashish

-----Original Message-----
From: Ni, Ray <ray.ni@intel.com> 
Sent: Sunday, December 22, 2019 6:47 PM
To: Ashish Singhal <ashishsingha@nvidia.com>; devel@edk2.groups.io; Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
Subject: RE: [PATCH v4] MdeModulePkg: Add EDK2 Platform Boot Manager Protocol

External email: Use caution opening links or attachments


+ typedef struct _PLATFORM_BOOT_MANAGER_PROTOCOL PLATFORM_BOOT_MANAGER_PROTOCOL;

Ashish,
Please add EDKII_ prefix to the protocol structure as well: EDKII_PLATFORM_BOOT_MANAGER_PROTOCOL.
I see you already added the prefix to the GUID name.

Thanks,
Ray
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------

      reply	other threads:[~2019-12-23  2:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-18 19:10 [PATCH v4] MdeModulePkg: Add EDK2 Platform Boot Manager Protocol Ashish Singhal
2019-12-19  1:59 ` Ni, Ray
2019-12-19 14:22   ` [edk2-devel] " Wang, Sunny (HPS SW)
2019-12-19 16:38     ` Ashish Singhal
2019-12-20 11:28       ` Wang, Sunny (HPS SW)
2019-12-24  2:40         ` Ni, Ray
2019-12-24  4:37           ` Wang, Sunny (HPS SW)
2019-12-24  4:48             ` Ashish Singhal
2020-02-06  9:08               ` Wang, Sunny (HPS SW)
2019-12-23  1:46 ` Ni, Ray
2019-12-23  2:08   ` Ashish Singhal
2019-12-23  2:27     ` Ashish Singhal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR12MB33246CF53E39F3D6612B1AEEBA2E0@DM6PR12MB3324.namprd12.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox