From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by mx.groups.io with SMTP id smtpd.web10.2660.1573002429777037732 for ; Tue, 05 Nov 2019 17:07:10 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=n1 header.b=XkglOwov; spf=pass (domain: nvidia.com, ip: 203.18.50.4, mailfrom: ashishsingha@nvidia.com) Received: from hkpgpgate102.nvidia.com (Not Verified[10.18.92.77]) by nat-hk.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 06 Nov 2019 09:07:07 +0800 Received: from HKMAIL102.nvidia.com ([10.18.16.11]) by hkpgpgate102.nvidia.com (PGP Universal service); Tue, 05 Nov 2019 17:07:07 -0800 X-PGP-Universal: processed; by hkpgpgate102.nvidia.com on Tue, 05 Nov 2019 17:07:07 -0800 Received: from HKMAIL101.nvidia.com (10.18.16.10) by HKMAIL102.nvidia.com (10.18.16.11) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 6 Nov 2019 01:07:06 +0000 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (104.47.40.50) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 6 Nov 2019 01:07:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P7E1rs+Bk9w3acpv6qCyaGcVrBkcWNKfsE9R1iMm/alDlI/7rodzjZcWZy+Abbdf3FQYA/UozBAol9CXJOHs1L2u9s66QkYcc+XkrtTtVDmd6uikTkvFKymB4DDin4MLTxpDaqP4Q2VAQc7Hy4Tdqnh1mFz4LfJbGwXN7I1H3VmMRccaYNSqIgM+iZaZpk6oNWvnaYHTph0QxWrYsDr64WaalWL+B0Vu0J28gBzFw9yBCpXy7XWjaXUfMLC+jue8O03hX9lvFdkefmflHkTW4y50tYUcGSoFd6JooJx9p8jTpbjIMUT9QIgWAwGd9Khx8LfJf+M7bxeMWNyj3sgq0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UqRuUf205mhnh6V0/ceTE51sKHsRVw5XzrqgMOkPQFU=; b=SvE3pDGBkxSIDHUZ6RMZckW6Q3eSDMpfmyWZgQUHUHBnjsRL5e68T8rrf2ThVNhQzm8H83x5RXQVYT15l/voH9SNyo2m2KquYRJ81SJdVV/f3IFqAC8NxfwgmQfQDHIYcvlEpADAfK8tiQ61RNkQY/mPYyc6cFOcnDuuLqiqVHkiZi+6shS+tjCeYgKe44htUogkhzLP2pLNz9JLrLDqMf/iVSj4lgWzGjbYefASA2virEpS1Mjp+AnRf+1Qze+uds7dRnsxCKzEyrk39R4GB/N8cmInsWlUvFnlMl3E+bMgUz56tBFM6g9p3GybMjvdkdxvXDuqDKnZmIDzekRm/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB3324.namprd12.prod.outlook.com (20.178.31.154) by DM6PR12MB2988.namprd12.prod.outlook.com (20.178.199.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.20; Wed, 6 Nov 2019 01:07:04 +0000 Received: from DM6PR12MB3324.namprd12.prod.outlook.com ([fe80::b53a:559d:9ca3:8ad1]) by DM6PR12MB3324.namprd12.prod.outlook.com ([fe80::b53a:559d:9ca3:8ad1%6]) with mapi id 15.20.2408.024; Wed, 6 Nov 2019 01:07:03 +0000 From: "Ashish Singhal" To: Laszlo Ersek , Andrew Fish , "Jeff Brasen" CC: "devel@edk2.groups.io" , "Ni, Ray" , "Wang, Jian J" , "Wu, Hao A" , "Gao, Zhichao" , Mike Kinney Subject: Re: [edk2-devel] [PATCH] Support skipping automatic BM enumeration Thread-Topic: [edk2-devel] [PATCH] Support skipping automatic BM enumeration Thread-Index: AQHVjtTHCLhtaIcUyUSCzPyxqDHpbqd0il+AgAddNoCAAAtAEIAAG3QAgAAAwxCAAAUjgIAAA/WwgAALDQCAAD03AIAAdMEAgAAMtNuAAB2BAIAAX7ww Date: Wed, 6 Nov 2019 01:07:03 +0000 Message-ID: References: <1b91c052-f64c-1dca-98ff-a2777afd7f77@redhat.com> <734D49CCEBEEF84792F5B80ED585239D5C34F98A@SHSMSX104.ccr.corp.intel.com> <6766B443-E14A-4F57-984E-5A865FB22CC9@apple.com> <37D801DD-41E8-452E-9F24-ADF52BFDB676@apple.com> <72ce1d71-2a65-a6c0-1dd8-7628429c5a3c@redhat.com> In-Reply-To: <72ce1d71-2a65-a6c0-1dd8-7628429c5a3c@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Enabled=True; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SiteId=43083d15-7273-40c1-b7db-39efd9ccc17a; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Owner=ashishsingha@nvidia.com; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SetDate=2019-11-06T01:07:01.5543599Z; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Name=Unrestricted; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Application=Microsoft Azure Information Protection; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_ActionId=f0b9ea9f-c6aa-4d5d-89a4-056a9aacfcd7; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Extended_MSFT_Method=Automatic authentication-results: spf=none (sender IP is ) smtp.mailfrom=ashishsingha@nvidia.com; x-originating-ip: [8.46.90.104] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 39806e7a-8841-4a6c-ff56-08d76255a27f x-ms-traffictypediagnostic: DM6PR12MB2988:|DM6PR12MB2988: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 02135EB356 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(136003)(346002)(39860400002)(376002)(396003)(366004)(13464003)(199004)(189003)(6636002)(54906003)(8936002)(486006)(7736002)(99286004)(71190400001)(71200400001)(305945005)(76176011)(186003)(7696005)(102836004)(53546011)(14454004)(6506007)(74316002)(6436002)(25786009)(478600001)(81166006)(81156014)(3846002)(2906002)(6116002)(33656002)(66066001)(8676002)(66946007)(55016002)(256004)(9686003)(6246003)(476003)(446003)(11346002)(64756008)(52536014)(14444005)(86362001)(66446008)(66556008)(316002)(229853002)(26005)(110136005)(66476007)(5660300002)(76116006)(4326008);DIR:OUT;SFP:1101;SCL:1;SRVR:DM6PR12MB2988;H:DM6PR12MB3324.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nvidia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xgImdArMtJ9oXp26SRz8E3mUk3oRhef07MhjYpR97Dz3/7Y+LKpXStc4Af6uE1+aBIUDAouklB4qUFtkYcY6Wt56OnUE3O4142On574BWz+eAtltCKn8cF94drKlaCh/g0RKEGNGaQGQ5GO0xWDHeJnX3OEBsLq3ozML1YYdFFIMKqhB5TFFw9HmrUvFZAH7mLxg3ujmFyHQaHmNpG3JwZ/c37/k9zydqCSPsSMaSVzuDTYF/mK2Xh7mIDMJKB5WHPyAeu+z1/nTK0ndbmAlLBr7kERAHMAxpmImSAiypEIk3BzRbevUtv3xHz3J7C8Tmecp+4lUUylOfRIXxWGwCO5m1MECimbI/Xfna5HeS+WlkDPP5zYccHnerk550mgxG2xS7R10HmLHDL0gzd7r9Ew62PA7GNip4aahsRDUXXdsztN4asX6A9Igydg1iFQW MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 39806e7a-8841-4a6c-ff56-08d76255a27f X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Nov 2019 01:07:03.2695 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: azk56766jYtK71GOwV8WJYDQXmIPfch25w2dTzL8fkpnFzTw0COvHb5eXQiByWvCTGPP7sqgiRhv9LvQOYywbA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2988 Return-Path: ashishsingha@nvidia.com X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1573002427; bh=8/ukXbNsVMxUYpM39th5gfpKzvI64OAXZR+YNKm7qQs=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:msip_labels: authentication-results:x-originating-ip:x-ms-publictraffictype: x-ms-office365-filtering-correlation-id:x-ms-traffictypediagnostic: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-forefront-prvs: x-forefront-antispam-report:received-spf: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:MIME-Version: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg: Content-Language:Content-Type:Content-Transfer-Encoding; b=XkglOwovsVC/i9YKpJUFtbek4qB/LlH2kDBG0FtQrupaZdKBC+KrMinOeSl9HFaf+ RQfohmDZAfltRQPi4zE6hcQ989xLwoLIeF1DNB/wI3I1dUqD576B10odQh5XqgGFP6 qzrQoSXD+drh0+xxw1r6wIpChOt0n9HdW7pCGj9o4WRH5vRtV61uBqETchMNuZQxBA t2UoNrsqsTCdMmE5I06EeBewgVjxFZ9s2++G90ENoejEkkP7C8eS2wlY+nspw942FK cI9ZX4dLHxQofy2/1amQS7Y7QFpp9ofabyXv/BaADEYQMcdm+AXmP64z5RADUSgWcR LBWCbMl/PbQHg== Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reconciling the email chain from devel.io portal as it does not send emai= l to individual participants. On Nov 5, 2019, at 5:19 PM, Jeff Brasen wrote: Wouldn't having a variable that we create and delete on every boot put un= necessary stress on the SPI-NOR that the variable store lives on? What about the alternative approach where we allow the platform code to m= odify the attributes of the auto created variable to disable it with hidd= en/!active but still match for detection purposes so that it doesn't dele= te and recreate the modified variable each boot? That way all the logic o= n what to disable can still be in the platform code and all the existing = logic in the boot manager can stay basically the same? What changes every boot that forces the variable to need to get modified?= =20 I would assume the NOR driver is smart enough to not update a variable th= at is not changing.=20 The custom BDS could could only create the variable for this device if it= =20does not exist.=20 Thanks, Andrew Fish Thanks, Jeff -----Original Message----- From: Laszlo Ersek =20 Sent: Tuesday, November 5, 2019 12:24 PM To: Ashish Singhal ; Andrew Fish Cc: devel@edk2.groups.io; Ni, Ray ; Wang, Jian J ; Wu, Hao A ; Gao, Zhichao ; Mike Kinney Subject: Re: [edk2-devel] [PATCH] Support skipping automatic BM enumerati= on On 11/05/19 19:00, Ashish Singhal wrote: > I agree that I can use the platform boot manager protocol to modify=20 > the boot variable and give the custom optional data I need, but that=20 > would not stop UefiBootManagerLib from creating another boot option=20 > with mBmAutoCreateBootOptionGuid as the optional data on the next=20 > bootup which I would have to delete every time in the platform boot=20 > manager driver. >>From a purely pragmatic perspective, I would act exactly like you describ= e above. I'm not saying that this is the cleanest design, or that it has = the best performance. However, it also does not introduce technical debt = -- it's not a "wrong" thing to do --, and (from past experience) keeping it 100% in platform code produces the least amount of= =20friction, and allows for the smoothest development. Extending UefiBoot= ManagerLib has always been an uphill battle. Thanks Laszlo -------------------------------------------------------------------------= ---------- This email message is for the sole use of the intended recipient(s) and m= ay contain confidential information. Any unauthorized review, use, disclosure or di= stribution is prohibited. If you are not the intended recipient, please contact the= =20sender by reply email and destroy all copies of the original message. -------------------------------------------------------------------------= ----------