External email: Use caution opening links or attachments
Hi Jeff,
Thanks for this.
This set looks good to me, with a slight question mark wrt behaviour
compatibility with previous versions for 3/4.
(I think it's fine, but I'm a bear of very little brain, and it's been
several years since I reviewed this code, and even longer since I
really interacted with Android.
^
| shameless plug for more EmbeddedPkg reviewer volunteers.)
I've added Jun Nie, who wrote the original version of this code, to
see if he has any comments.
1-2/4 are obviously unproblematic, and I could merge those ahead of
time if preferred. You can add
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
for those if there are any further revisions of the set.
Best Regards,
Leif
On Mon, Sep 13, 2021 at 23:18:47 +0000, Jeff Brasen wrote:
> Added support for using loadfile2 approach for passing ramdisk to linux.
> Created patch series for general error handling improvments based on
> review feedback.
> If ACPI tables are in system table or PCD is defined the LoadFile2 method
> of passing initrd will be used.
>
> [v3]
> -Code review cleanup
> -Removed duplicate header file
> -Added change to allow FDT to install if UpdateDtb function is not defined
> -Added specific ACPI check
> -Moved install functions to subfunctions
>
> [v2]
> -Added review feedback
> -General improvements to error handling
>
> [v1]
> - Intial revision
>
>
> Jeff Brasen (4):
> EmbeddedPkg: Remove duplicate libfdt.h include
> EmbeddedPkg: AndroidBootImgBoot error handling updates
> EmbeddedPkg: Install FDT if UpdateDtb is not present
> EmbeddedPkg: Add LoadFile2 for linux initrd
>
> EmbeddedPkg/EmbeddedPkg.dec | 1 +
> .../AndroidBootImgLib/AndroidBootImgLib.inf | 4 +
> .../AndroidBootImgLib/AndroidBootImgLib.c | 275 +++++++++++++++---
> 3 files changed, 233 insertions(+), 47 deletions(-)
>
> --
> 2.17.1
>