From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com [40.107.102.88]) by mx.groups.io with SMTP id smtpd.web10.6246.1632410443283591727 for ; Thu, 23 Sep 2021 08:20:43 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=selector2 header.b=Jl0aQPC9; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.102.88, mailfrom: jbrasen@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hsaq6r8SskNOYStjRz7SFjMTGc9y0wbp/mk8/2ecIcTD3Ik4053wO4MUJY0Et3gqxeyD8b3INA9i83m2r9EF4q6AThs9xNkky8eAA+PVPXE8CA9HIU0G1XuI5pMEp4RRjlrIXzFclAcNvpQzExcWba23LhiYYuuU4b5aKa2FR5PUnVqpFYeMrebE/NGfEKHq6LPK+KTyl5fU8BWNu75nG7CrzJZkYWy0JI8UnIncGt/XQ5l7B0eyDaYx6NrbC3NX4NPvQJ+VkkbB1PjAjyDIVemnIysNkMdPpUGbTjz7N7fabmTPmmXyrid4wjUDNDFqPY2iXTiBQ//Sicuo5ScEyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=N27j7tIsJg6RQkcn4CGkl4txHb4nI1NlChtaPrAyegw=; b=MwXoceqqdT5Ol/ILVJur4vfqNTbMMAvR8i2coRAElKgW4hf+wa8jsUJw4fVcReiVuvDIN6bZuSRAoYK6XHNh5H/swWIk1d/vt+SBis3E2nVWAisPQ9lgC4o6IHIVUY8f2UTh7SP3ppT/86GH7Ykm9kKVvcmxXENNDpdWZws1xPsnQyZrvyEQOcsJjuQgoD36HSSnV6CSuilFu4pm3rjbF3Bfffx7y14ARgkqFIQAoN+AYmQbHEQGv+VvsCTQNiPi70DhgDydYv8BH0C3CACQ7Z4kNpLcAPluiN7T57y+BVQElz9t6dhXvl4KU84TL5wP4QSPI2HU3CtGCFoK50a4jA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N27j7tIsJg6RQkcn4CGkl4txHb4nI1NlChtaPrAyegw=; b=Jl0aQPC9xdOrHOTVviGCpIgqX3ZuXGC9q8jWIfaf+pj4vAu6NI58Z6U4Qz7voKRNosX1dz8ZbaJQ5i0iSlLvCHUtfk2LsOU/4k0MQoJ4xvRvyN1mSJ78C1yoU2XEWgdkL9XvytZw9gN0oNR0liG2lzr7MXzKRLj879ut2VomR6XHzxbhg91mJQ1Nvx4/WMGNNGSH1JMJuj1SDQzL56KqgjzxdsXoJtUfO10M/mZSgni1fp/UXetC22CIOWxioAGhWX2oVk+OK0p2o+iXa7XDIadX6IK0fZUYhLky/MPsId+84fUfQxsFL4f8uFLQZATl1BQ3r4QY/Ttl+noLBjW2tA== Received: from DM6PR12MB3340.namprd12.prod.outlook.com (2603:10b6:5:3d::24) by DM6PR12MB4531.namprd12.prod.outlook.com (2603:10b6:5:2a4::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13; Thu, 23 Sep 2021 15:20:42 +0000 Received: from DM6PR12MB3340.namprd12.prod.outlook.com ([fe80::68ed:797b:18d4:848c]) by DM6PR12MB3340.namprd12.prod.outlook.com ([fe80::68ed:797b:18d4:848c%3]) with mapi id 15.20.4544.015; Thu, 23 Sep 2021 15:20:41 +0000 From: "Jeff Brasen" To: Leif Lindholm CC: "devel@edk2.groups.io" , "daniel.schaefer@hpe.com" , "abner.chang@hpe.com" , "ardb+tianocore@kernel.org" , Jun Nie Subject: Re: [PATCH v3 0/4] AndroidBootImgLib improvements Thread-Topic: [PATCH v3 0/4] AndroidBootImgLib improvements Thread-Index: AQHXqPXBNs0khKNEzUWnxYBc56ObZKujoLoAgAAfOqeACvp2w4ACybsAgABGZhA= Date: Thu, 23 Sep 2021 15:20:41 +0000 Message-ID: References: <20210914150058.nb5z4hz2a3e7ndts@leviathan> <20210923110618.ty67i6wlyco63blr@leviathan> In-Reply-To: <20210923110618.ty67i6wlyco63blr@leviathan> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ec1e25a8-87eb-4d65-31f7-08d97ea5b4e9 x-ms-traffictypediagnostic: DM6PR12MB4531: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pez1pcuqZ9bSi49NXbwP8hfm5v5/tYfdA41N+hUDG9Fch0V4HLZ7npfga3t9ITIijil/2cFZCPXeE3yAajzYL2LwZWUjxvqVrXdYnHfheK0+MQYaFLiKpPD3lPWA3SWmjJigB4I52Goc33U/soEUKoX+NRN9hpBmzTKo8KxRgnoV1AESkldbm0nZjPyJBp4em0Sq9n3meNmGFuFWFqquCy8+gAadz3ncBOKr3pCU4mQaklSPC76ZRWznUQWpjRZjb95jnvteS5RDiZORstjpf6Vsaghb2+q+zIpIVNgX5/yVZeJnN37cQ45tRm1r6gIoZ2/ew4Za5CUS4YNUXl0qCvpasmAKPVpP7zxyRhPtC86Zi28MQdJy7IgJ1kud49m/NNlX78JqqO7IBIVVba7+GX0G+6XJdS/HGVxl9kSAngQekdmqHKkHqnq28uQAfIXwfD8YnKXUNNVYS3FvDkdNoYTNMtm6Og096lMamLefBZY4glOh+0PWaQutNn4sPNl130Tx7UG8t9ZDiXxKXaIKiJcmYuXWcuXbR3fhLICYYZX++2iedm+PHwlJQ5vGyeuCER9tLMOBb/sfiUt//L6+Bf/vNy6pQwTKUxl7pDTRoPof5MKO2B6vseOdrD6sJUMxEg8JMrkwMAV+hOz3jytN/Ud07bW5Co8+jGwOzRfUh+dQUL+1wkLVCorBULpfBlRDRgzbhzLYIFPcBbalFibl5w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB3340.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(19627235002)(76116006)(66946007)(316002)(64756008)(66556008)(6506007)(66476007)(5660300002)(7696005)(8936002)(53546011)(4326008)(6916009)(54906003)(66446008)(71200400001)(33656002)(86362001)(186003)(9686003)(508600001)(52536014)(8676002)(38070700005)(55016002)(26005)(38100700002)(83380400001)(122000001)(2906002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tAN+l/crg0bH00jOOLzbYPqHnQMX6Mp5z+2BPbLoBNNYtshAgPHdFk6DlsOS?= =?us-ascii?Q?eH9yq1BCKiVmt8HooH/p43O4WHSAC45EZEf8q7AuQR8Slsvw8r5LwjOMbDax?= =?us-ascii?Q?r9MXpZsj71k4RT8NGfRWLMa5nSYsIfGA5KkHMpmLycvcVDyUwjABYXRlAObx?= =?us-ascii?Q?w/GN3A/y/qVkoMixJNvhpQEM336NkGuFpf/cybClk04gxg0GICB7WKI5XaOD?= =?us-ascii?Q?Np4F3Stkp0Rr7yEhR1qHZcNo43w7vNTf95E2vU3L1foLWVLfN4z7YzBABkbV?= =?us-ascii?Q?ybgoWSuPmGuHKXpNWHylRn/rSlQqL99E9TBHqEIENR2BJUXKKONHbyLEkPgJ?= =?us-ascii?Q?Yj7ytz8167AZfB5Wvt+i+63W73G5iDPtQicIGN9K9xe8Zv66bXtl3rZ+H6Rl?= =?us-ascii?Q?Fn6xBqO7BFIALXSEUuHg5mOaXrE/wo6+wgSC1EiyBt8+9rKUPU1ZDWIjOqYc?= =?us-ascii?Q?mGpeoLzjwLSrvFfH3l/PQLn/49lka55sqoRQHvfaoiC+6c4V08/7yy+Tp25b?= =?us-ascii?Q?q56gmW0mYgzDed0jpY+bmUqi1N//MdbOPCJG+h9BZJoDNKJz13bOvENWFeTP?= =?us-ascii?Q?t88wqMTDY0xtI/FR7eQtsl+RUET21NGo2wkGUHJustoKJl5AY2ZOJQYpgZjW?= =?us-ascii?Q?DmfyJ4t7vuBm1wp6/7AY7XVMiZs53zPCk3+CTpmtwlQfdycJPa2i/4nH5o2O?= =?us-ascii?Q?xuYqZmouYMyL31ZSDACs/fyGiFbEec9B8DlgTqqnImysyPeFRI3Ub1urI4CX?= =?us-ascii?Q?VWTuNmnWRf5U2xdQBL0pIHoTfzQXvYzylDswPWVCrhPzJEI4g96jCSpnsL1V?= =?us-ascii?Q?T/8Mopfzj48jGDPGChqDC9zq0wLZzIrsZW6V0aj6ogx8DzhY9S3Pmyt+Ug1x?= =?us-ascii?Q?q5rOzQ5ZlY5kUxYHViOmiv5JMMdyglfWQHoPljhQjL+6MJLAAovn6AbF454U?= =?us-ascii?Q?fvm0M8gZzMCLD1fnzMzDBPZVZHdufiHqqiwT5XrmkH10OiUOuMCRic34Iazy?= =?us-ascii?Q?ZGu0J5nAyubTJ+Ys1pm/fd49c5TU8YgOJtvxK24Uo5DqEwpyl5miZzSGW1jo?= =?us-ascii?Q?ZVZsgOWXLINT4VYKZqmQTx6AKp5yuzWzSlCincHgahA9dXz0mZrni+riAsCi?= =?us-ascii?Q?5Vs5LofROnyfOkZ2XzeqBqfyrcZciCjiWBRz0s7TjjPvx2hCUdOkRwt4NF7d?= =?us-ascii?Q?ALaqnkcBpydja2Y9M9sbF3rru8AK35MwxmqSm7dujoiQuV1sleZcnrWtm9n8?= =?us-ascii?Q?caRCVg+RroQoChy8+QtZcGwYRAad2PUUFqeG19rX7KPfyLX5nace1OAVpG0p?= =?us-ascii?Q?hEw=3D?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3340.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ec1e25a8-87eb-4d65-31f7-08d97ea5b4e9 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2021 15:20:41.8511 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: n5GfK57MjA8okl2I4tfWOc/SsKIT32v7wsCry7iMFJ53iGUp/6O5hu5aBzJ1QSScJg0yHfrzF2n/FDeHO/ihHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4531 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable That looks like something I missed and looks good, do you need me to make a= v4 or will you just add that in. When I built I just used our application = that has the guid in our inf so missed this. >>From my looking at it AndroidFastBootApp doesn't seem to use this lib. > -----Original Message----- > From: Leif Lindholm > Sent: Thursday, September 23, 2021 5:06 AM > To: Jeff Brasen > Cc: devel@edk2.groups.io; daniel.schaefer@hpe.com; > abner.chang@hpe.com; ardb+tianocore@kernel.org; Jun Nie > > Subject: Re: [PATCH v3 0/4] AndroidBootImgLib improvements >=20 > External email: Use caution opening links or attachments >=20 >=20 > Hi Jeff, >=20 > I was about to say "no more issues", and then I went to build EmbeddedPkg= , > and it turns out this fails in Applications/AndroidBootApp due to the mis= sing > dependency on gEfiLoadFile2ProtocolGuid in AndroidBootImgLib.inf. >=20 > (Why this doesn't break AndroidFastbootApp build as well is not immediate= ly > obvious to me.) >=20 > Would you like to figure out why, or would you prefer me to just fold in >=20 > diff --git a/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.inf > b/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.inf > index affde50f617a..8eefeef4f915 100644 > --- a/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.inf > +++ b/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.inf > @@ -39,6 +39,7 @@ [Packages] > [Protocols] > gAndroidBootImgProtocolGuid > gEfiLoadedImageProtocolGuid > + gEfiLoadFile2ProtocolGuid >=20 > [Guids] > gEfiAcpiTableGuid >=20 > ? >=20 > / > Leif >=20 > On Tue, Sep 21, 2021 at 16:32:58 +0000, Jeff Brasen wrote: > > Jun/Others, > > > > Any additional comments on this patch series? > > > > > > Thanks, > > > > Jeff > > > > ________________________________ > > From: Jeff Brasen > > Sent: Tuesday, September 14, 2021 10:57 AM > > To: Leif Lindholm > > Cc: devel@edk2.groups.io ; > > daniel.schaefer@hpe.com ; > abner.chang@hpe.com > > ; ardb+tianocore@kernel.org > > ; Jun Nie > > Subject: Re: [PATCH v3 0/4] AndroidBootImgLib improvements > > > > So for patch 3: This is only a change if mAndroidBootImg->UpdateDtb =3D= =3D > NULL. > > > > This seemed like a bug as we would not add the initrd values nor would = we > use the fdt from the BootImg if that is where the device tree was sourced > from. > > > > It seems like either we should require UpdateDtb to be implemented > (which seems to cause greater compatibility issues) or we install the dev= ice > tree we have if that function isn't implemented. > > > > As far as merging goes I am fine either way. Our particular flow won't = hit > this path as we don't have a device tree in the bootimg (use the system > config table) and we will have the new pcd set, but this seemed like a bu= g > while I looking at this code. > > > > > > Thanks, > > > > Jeff > > > > ________________________________ > > From: Leif Lindholm > > Sent: Tuesday, September 14, 2021 9:00 AM > > To: Jeff Brasen > > Cc: devel@edk2.groups.io ; > > daniel.schaefer@hpe.com ; > abner.chang@hpe.com > > ; ardb+tianocore@kernel.org > > ; Jun Nie > > Subject: Re: [PATCH v3 0/4] AndroidBootImgLib improvements > > > > External email: Use caution opening links or attachments > > > > > > Hi Jeff, > > > > Thanks for this. > > This set looks good to me, with a slight question mark wrt behaviour > > compatibility with previous versions for 3/4. > > (I think it's fine, but I'm a bear of very little brain, and it's been > > several years since I reviewed this code, and even longer since I > > really interacted with Android. > > ^ > > | shameless plug for more EmbeddedPkg reviewer volunteers.) > > > > I've added Jun Nie, who wrote the original version of this code, to > > see if he has any comments. > > > > 1-2/4 are obviously unproblematic, and I could merge those ahead of > > time if preferred. You can add > > Reviewed-by: Leif Lindholm for those if there are > > any further revisions of the set. > > > > Best Regards, > > > > Leif > > > > On Mon, Sep 13, 2021 at 23:18:47 +0000, Jeff Brasen wrote: > > > Added support for using loadfile2 approach for passing ramdisk to lin= ux. > > > Created patch series for general error handling improvments based on > > > review feedback. > > > If ACPI tables are in system table or PCD is defined the LoadFile2 > > > method of passing initrd will be used. > > > > > > [v3] > > > -Code review cleanup > > > -Removed duplicate header file > > > -Added change to allow FDT to install if UpdateDtb function is not > > > defined -Added specific ACPI check -Moved install functions to > > > subfunctions > > > > > > [v2] > > > -Added review feedback > > > -General improvements to error handling > > > > > > [v1] > > > - Intial revision > > > > > > > > > Jeff Brasen (4): > > > EmbeddedPkg: Remove duplicate libfdt.h include > > > EmbeddedPkg: AndroidBootImgBoot error handling updates > > > EmbeddedPkg: Install FDT if UpdateDtb is not present > > > EmbeddedPkg: Add LoadFile2 for linux initrd > > > > > > EmbeddedPkg/EmbeddedPkg.dec | 1 + > > > .../AndroidBootImgLib/AndroidBootImgLib.inf | 4 + > > > .../AndroidBootImgLib/AndroidBootImgLib.c | 275 +++++++++++++++- > -- > > > 3 files changed, 233 insertions(+), 47 deletions(-) > > > > > > -- > > > 2.17.1 > > >