Are we looking for any other reviews on this?

Thanks,

Jeff

From: Jeff Brasen <jbrasen@nvidia.com> =
Sent: Tuesday, September 22, 2020 4:13 PM
To: Bi, Dandan <dandan.bi@intel.com>; devel@edk2.groups.io
Cc: Dong, Eric <eric.dong@intel.com>
Subject: Re: [PATCH] MdeModulePkg/HiiDatabase: Do not modify CONST s= tring

Thanks = Dandan, are we waiting for any additional reviews on this change?

&n= bsp;

Thanks,

Jeff

From: Bi, Dandan <dandan.bi@intel.com>
Sent: Monday, September 14, 2020 8:15 AM
To: Jeff Brasen <jbrasen@nv= idia.com>; devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Dong, Eric <eric.dong@= intel.com>
Subject: RE: [PATCH] MdeModulePkg/HiiDatabase: Do not modify CONST s= tring

External email: Use c= aution opening links or attachments

Reviewed-by: Dandan Bi <dandan.bi= @intel.com>

Thanks,
Dandan
> -----Original Message-----
> From: Jeff Brasen <jbrasen@nv= idia.com>
> Sent: Saturday, September 12, 2020 1:09 AM
> To: devel@edk2.groups.io > Cc: Bi, Dandan <dandan.bi@in= tel.com>; Dong, Eric <eric= .dong@intel.com>;
> Jeff Brasen <jbrasen@nvidia.c= om>
> Subject: [PATCH] MdeModulePkg/HiiDatabase: Do not modify CONST string<= br> >
> Update function behavior to not modify the incoming string that is mar= ked as
> CONST in the prototype.
>
> Signed-off-by: Jeff Brasen <j= brasen@nvidia.com>
> ---
> .../Universal/HiiDatabaseDxe/ConfigRouting.c   &n= bsp;     | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> index 2cad6d29f4..d492b769d5 100644
> --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> @@ -5497,7 +5497,6 @@ HiiBlockToConfig (
>    UINTN        = ;            &n= bsp;          Index; &nbs= p; UINT8           &= nbsp;           &nbs= p;       *TemBuffer;   CHAR16
> *TemString;- CHAR16       &nb= sp;            =           TemChar;  = TmpBuffer =3D NULL; @@ -
> 5564,10 +5563,13 @@ HiiBlockToConfig (
>    //   // Copy <ConfigHdr> and an addi= tional '&' to <ConfigResp>   //-
> TemChar =3D *StringPtr;- *StringPtr =3D '\0';- AppendToMul= tiString(Config,
> ConfigRequest);- *StringPtr =3D TemChar;+ TemString =3D Al= locateCopyPool
> (sizeof (CHAR16) * (StringPtr - ConfigRequest + 1), ConfigRequest);+&n= bsp; if
> (TemString =3D=3D NULL) {+    return EFI_OUT_OF_RESOURC= ES;+ }+
> TemString[StringPtr - ConfigRequest] =3D '\0';+ AppendToMultiStr= ing(Config,
> TemString);+ FreePool (TemString);    // &nb= sp; // Parse each <RequestElement> if
> exists--
> 2.25.1