From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2F9A07803DA for ; Mon, 23 Oct 2023 15:30:34 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ePbeSmOAJKYwfBjI1syoqN1MQsyJCsKH6/2lgiplJkM=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698075032; v=1; b=B5hf1FIrg6LNlfGAEU3uSQ10XK+Bl4CooD9o96wL/a2O0AIkGorxNViuA1EpCNDtGN7kI3IM fVlIJSLQK+Qac/KnK0hQ+L67Wn4JWV4Covs0KdDBtu37kTVEwA1JdDWmFJyx9X6696ULTUWzdWZ 5GJB3qIJZTdOmNni0iomjFAk= X-Received: by 127.0.0.2 with SMTP id aUzNYY7687511xK2a1fpGRSN; Mon, 23 Oct 2023 08:30:32 -0700 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.72]) by mx.groups.io with SMTP id smtpd.web11.124068.1698075032275647023 for ; Mon, 23 Oct 2023 08:30:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nPLhScdFqk0/vCi1Y8BUaNeeI7KySa0xnHSp/sXwWXiJF16IOp0t78ALZ6OlCxydSffPM7UwqDZhdwxLMutkjWg+sHmQWZ53SPYxYp8zpvZ4Q8dOIxXWpTClpFfJia6or04huMog+25DEEcWmjAg0cqxVMXg89EmN8kVlZc43fjZGUxzrQ59kkWcuSPDNcgalyHWzGRw/o+VbgjUVrhbChl6wZ5ItiDyxeMTOtw3Dt13jDVxrFsLHmNrbG02E6uAjplBMHBc33eDbhRuidaTUFx4+ZSG2N4YyVbNA4X+zvk+wVkjcGhCsJ/j6iqc2N7yw8h2VLaPSBzB69tVbJlL5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0wAogn8DrslwKxVcYbQRMlPaTI4iUKGQEUpWut1kiGY=; b=DZ6LwmwhOtw8sRHKPK56oOdpHzFOJzLkPxtomVc0+VwblxHCehb79hET/dJqYCuW5H0gxwgru6NhmfgFpGV77UBQFOisD4198Wl8N4+km19Y/ISIZNworfFVl7oWmyGYBJLcGggN5jl8D/tWzkzF44gbbH5E2iorP9sBKvAxabu9GUbYlo0uzbBNkPh2G9CBWjEsU2MKQBJBJxknlOgXaSK292AByEdZjIx6y4XKe4Wr+zejLSrCCsdiJP/0h5uCuMzrVpAprgwHeTTa0784VabajeZFvjcFJYdoSO/+xh2/rEjSxfc3to1sq8JTwE3RjYAMVdTRGgwdTvZu2AqZ6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from DM6PR12MB3371.namprd12.prod.outlook.com (2603:10b6:5:116::27) by CY8PR12MB8243.namprd12.prod.outlook.com (2603:10b6:930:78::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.26; Mon, 23 Oct 2023 15:30:30 +0000 X-Received: from DM6PR12MB3371.namprd12.prod.outlook.com ([fe80::87f1:f2ba:c75d:ef3e]) by DM6PR12MB3371.namprd12.prod.outlook.com ([fe80::87f1:f2ba:c75d:ef3e%4]) with mapi id 15.20.6907.025; Mon, 23 Oct 2023 15:30:30 +0000 From: "Jeshua Smith via groups.io" To: Pierre Gondois , Sami Mujawar , "devel@edk2.groups.io" CC: "ardb+tianocore@kernel.org" , "quic_llindhol@quicinc.com" , "michael.d.kinney@intel.com" , "gaoliming@byosoft.com.cn" , "zhiguang.liu@intel.com" , "zhichao.gao@intel.com" , "Anshuman.Khandual@arm.com" , "Matteo.Carlini@arm.com" , "Akanksha.Jain2@arm.com" , "Sibel.Allinson@arm.com" , "nd@arm.com" Subject: Re: [edk2-devel] [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support Thread-Topic: [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support Thread-Index: AQHZ7WIQQeOPXv++v02eXNw90ga5/LAm7aAAgDDCe5A= Date: Mon, 23 Oct 2023 15:30:30 +0000 Message-ID: References: <20230922143516.4764-1-sami.mujawar@arm.com> <794c2b6e-2ab8-30ff-ec43-7cf281fe8968@arm.com> In-Reply-To: <794c2b6e-2ab8-30ff-ec43-7cf281fe8968@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR12MB3371:EE_|CY8PR12MB8243:EE_ x-ms-office365-filtering-correlation-id: b46c5813-5e97-43b8-7339-08dbd3dcfd9f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: p2qmYE1JctYC/yPBa2BZTP4EdxHgUSc5eaGuczAmK3+FLaf/qAljTeCC/ThUFd9DTL2ulnzuN3Rsvq9XqQNivNtGhsuYct0j7A2kbGU+uz78TeCUtZmWQjFnoJwiBtUFsq739x0QK2oPrU7iVAs1cG41do5gAerYLZtX1CQ6Xn5/6B1lZpi0Lo0KNHSgbjoI2qufwXKOU8EeT9IJmlbum2M/Z+S5+RkyRGf8N6z+Eq9mUR4trox3zgbLlUwDoDDRQku7UNYRrOqXNU5zvQ8H8bTGE4DRpsZPS0DyluFP5V78zp66brLbash0C6SntWYApIZEJhV29CadremFf7JA3GJeNfSigSepKBODkuOJ2xTqy26MUzcr2axsXbpMDsfUknMJqkEmm2NeJ9PsoAxyMFLHQW5wkW43WQE/ARE81CK33CgrG4+bgrYxxJxXj7TsvCSHxcPu/xA1AN/3nptFXsj7vAjWdPXmgOsV9A4CMIgaew4tcG2KRh9BBbFCVLa1imlStdUExSE2FpPawq+zqninmdVBjmf6M1DTbRcCm518xfIG8U/xm3+Iu9ZNzyZ1egbGnDJY6R3AMv//UN7NP1DZQ/ZA9UY0N4W9siO1xzI= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FT2NRHJz8cWSyk9bsGyjcVd2v/Cz5NE4X5u5IAlfmw4Fs+x2m27R3rF1C4Qy?= =?us-ascii?Q?yIibOJjDBoOBod9VFyh1YSW4b5eVYPHmUm4bUZebwxYrrXsrkexc0yRSUTIK?= =?us-ascii?Q?h1vnAtxDNlcJe4FseirY29M1PxG+8RVugAHQzmftAbHoLfCfi9IutdA4psEH?= =?us-ascii?Q?bzKIT6WGRG1RpiPDoguBVOwdpfLLCoRbOpGv+DzAQvlkUJrusAKFQ8ISJjVZ?= =?us-ascii?Q?VpjEfx4PBI37tR3tRiMDc1RvpRCp8pK8a/CZHD8v9JcFz65dPLSX0bEVUwpC?= =?us-ascii?Q?Lxxo2Sfqg1YRDn8Cnktxkk7aEFVEcyhHM7QTbYAUGYImhDUOjN9X2Ygl7Nme?= =?us-ascii?Q?ze1Shdi27iZC4tdnp31sUDWoUFrkVIKX68ssteRXc/EFdvzrsuVMfUfwWjtv?= =?us-ascii?Q?jjE/oZ3kY62jsiGqoM52ARLjA5x0y1u1HCvlMXb3tzQXCqNFNt6mR4+emWRi?= =?us-ascii?Q?v8B7gOBsny/+Q3RoS0O0PuvVhPOBB7j9ZgQheCaDZvKtFvkgjXgWGGGukS5r?= =?us-ascii?Q?vUzPKKDsVqRw7fhrEOSzJWwZJ6zMqg9f6cJBkFeP8zWESjpXvtv8o1VW9w86?= =?us-ascii?Q?axya2+7CgssKPfGfZn968cqD1XG0BsDH2LqEPGo1p1tnsJ2qCJjTAMEE0+CO?= =?us-ascii?Q?vrTc2kSxdtQnWkhidV2yFKVKoSr+oJNurLAtiJgcnGEU5tv8i+yxIbX3E1Tf?= =?us-ascii?Q?xxtheYnPQpdeyrcntJAaGQmZhIGMKcqFsi7drskdyklELQWI/GyctQT3eYHg?= =?us-ascii?Q?uExalsYqW6HBrBlbKoaejtMWOJaNjZKFciuSuEIxrT1M+sJe/umT1E4n9+Dr?= =?us-ascii?Q?Fjjxc7XS/Vuqf724uToBwPvJva9yttGRnf4+HbIhfx8/gcurQw9/34UemLOk?= =?us-ascii?Q?SQA8nJzkJkaraVCOgXMPD/93Yu3VLIsMXc+4zICyDdJOAs0PXWN02zr6dIje?= =?us-ascii?Q?5P3wjL3vIWiKFuEimPQjGqtLPlaPYwb00ZNYwNXZk3BNSYjeharJVwtRGPwC?= =?us-ascii?Q?DXGSZhr/JCgIWn3J8WJ6tv2UI3O2F0w4O7TPrBGL4Q7ggYwsV/c9jgLnhKoE?= =?us-ascii?Q?odLP77BDsyk+njtoopaUj9fBuRE3WIeJoiHxcd6nA/y0Rg/FasavvSj4O/Fl?= =?us-ascii?Q?vyZjQBFO9yrsSI6AlALCligov/FWv1rJE6TOSaMmY0wbkRKgKNQNJDRljbTs?= =?us-ascii?Q?oZE/Lz0ogBjSUZ1d69mygQ5fxdBxz8dl2JluBiRQFbAXhaWv7tjrywa1kX6M?= =?us-ascii?Q?8LPZBTW9oP69v6692TpKOW9lrhzkbQGXdaMnZRYaby5C+ZdC5ZnbLIHv3xJq?= =?us-ascii?Q?G6yfa615OyOz0qZ5cpC82JyqVgFltrDE7StYJPwF2BVPczslIfA2BO4jExSC?= =?us-ascii?Q?i8Mmqex1hQdtRHTgDIwCmnTYR9InAciBECkL8z1UCsRUeriWGFc4siq0Sp+Z?= =?us-ascii?Q?Bc7V+LWnsarh6eOmypaAuFU528oCThJhGtsTpWiL6TGRF35uk79rTraD4tbY?= =?us-ascii?Q?TNtA0HsdgiZBVHwCAXrMquneZg+as+Ukcib00h7lhmy2bBVN5TstuloJ5uuf?= =?us-ascii?Q?zJ8EljqWOmqAvPEvXsR9JbKSaeuWfRVKY2l+CEe9?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3371.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b46c5813-5e97-43b8-7339-08dbd3dcfd9f X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2023 15:30:30.4402 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OfO3VCQ6LhnlpmFYXkIt87bmvb/sMtH/DY6yHhkBYT8tymj2TiBeeChptFg49AtF792yKLkqdto07gUqBqnpCA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8243 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jeshuas@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: rLK0NigPtI9zvlFbLZotxin3x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=B5hf1FIr; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io This series has received: Reviewed-by: Pierre Gondois And also For 1-2,12-13: Reviewed-by: Leif Lindholm Can this be merged? -----Original Message----- From: Pierre Gondois Sent: Friday, September 22, 2023 8:51 AM To: Sami Mujawar ; devel@edk2.groups.io Cc: ardb+tianocore@kernel.org; quic_llindhol@quicinc.com; michael.d.kinney@= intel.com; gaoliming@byosoft.com.cn; zhiguang.liu@intel.com; zhichao.gao@in= tel.com; Anshuman.Khandual@arm.com; Matteo.Carlini@arm.com; Akanksha.Jain2@= arm.com; Sibel.Allinson@arm.com; Jeshua Smith ; nd@arm.= com Subject: Re: [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE = support External email: Use caution opening links or attachments Hi Sami, Thanks for the update: Reviewed-by: Pierre Gondois Regards, Pierre On 9/22/23 16:35, Sami Mujawar wrote: > This patch series provides the following updates: > - The patches 1 & 2 add the new fields introduced > in MADT (APIC table) by ACPI 6.5 and the patch > 7/11 updates the Acpiview MADT parser accordingly. > - The patches 3, 4 & 5 adds TRBE support to the MADT > table generator in DynamicTablesPkg. > - Patch 6/11 updates the FADT ACPI revision to 6.5. > - The patches 8, 9 & 10 add support to generate ETE > device nodes. > - The 3rd last last patch series fixes a bug wherein > the CPC token was incorrectly referenced. > - The last 2 patches in the series introduce helper > functions to detect if TRBE and ETE features are > supported. > > Updates from v2 patch series: > - Updated patch 5 to removed superfluous initialisation > of TRBE interrupt field for ACPI 6.4. > - Patch 12/13 introduces a helper function in ArmLib to > detect if TRBE is supported. > - Patch 13/13 introduces a helper function in ArmLib to > detect if ETE is supported. > > Updates from v1 patch series: > - Fixed issue with setting TRBE interrupt in patch 5/11. > > The changes can be seen at: > https://github.com/samimujawar/edk2/tree/2620_ete_dev_fvp_v3 > > Sami Mujawar (13): > MdePkg: MADT: Add Online capable flag in GICC > MdePkg: MADT: Add TRBE interrupt to GICC > DynamicTablesPkg: Add TRBE interrupt to GICC object > DynamicTablesPkg: Add TRBE interrupt to GICC object parser > DynamicTablesPkg: Update MADT generator for ACPI 6.5 > DynamicTablesPkg: Update FADT generator to ACPI 6.5 > ShellPkg: Acpiview: Update MADT parser for TRBE interrupt > DynamicTablesPkg: Add an ET info object to Arm namespace > DynamicTablesPkg: Add an ET info object parser > DynamicTablesPkg: Add ETE device to CPU node in AML > DynamicTablesPkg: Fix referencing of CPC token > ArmPkg/ArmLib: Add ArmHasTrbe () helper function > ArmPkg/ArmLib: Add ArmHasEte () helper function > > ArmPkg/Include/Chipset/AArch64.h = | 4 + > ArmPkg/Include/Library/ArmLib.h = | 25 +++ > ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c = | 31 ++++ > DynamicTablesPkg/Include/ArmNameSpaceObjects.h = | 32 +++- > DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c = | 108 +++++------ > DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c = | 79 ++++---- > DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopo= logyGenerator.c | 188 +++++++++++++++++++- > DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopo= logyGenerator.h | 11 +- > DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObje= ctParser.c | 11 +- > MdePkg/Include/IndustryStandard/Acpi65.h = | 4 +- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c = | 48 ++++- > 11 files changed, 442 insertions(+), 99 deletions(-) > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109931): https://edk2.groups.io/g/devel/message/109931 Mute This Topic: https://groups.io/mt/101522262/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-