From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 85C37D80A5F for ; Tue, 1 Aug 2023 15:38:14 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Tt+YDUqKRNs5zH1ocDxO2mKi8GnuG/Cj1rOGx3LMnKk=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:X-Received:X-Received:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:x-ms-publictraffictype:x-ms-traffictypediagnostic:x-ms-office365-filtering-correlation-id:x-ms-exchange-senderadcheck:x-ms-exchange-antispam-relay:x-microsoft-antispam-message-info:x-ms-exchange-antispam-messagedata-chunkcount:x-ms-exchange-antispam-messagedata-0:MIME-Version:X-OriginatorOrg:X-MS-Exchange-CrossTenant-AuthAs:X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-Network-Message-Id:X-MS-Exchange-CrossTenant-originalarrivaltime:X-MS-Exchange-CrossTenant-fromentityheader:X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:X-MS-Exchange-CrossTenant-userprincipalname:X-MS-Exchange-Transport-CrossTenantHeadersStamped:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubsc ribe-Post:List-Unsubscribe:X-Gm-Message-State:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1690904293; v=1; b=hmMo146Bn6a4gxlwqxOYNaiXwhZIJdnHe5tX+daXm3+L9NJZOeZtnpqNQAhW/RzyNepXgEeV jx3B2njJ4hwhJYbYBpX7GqNBs4tNF+zWKH36Y9ZcaJOCPUFD8K+tdnSdDBSbeZ1RHhYpczyYqZN bOITHcdz1BOwtAziwtJtWE0o= X-Received: by 127.0.0.2 with SMTP id PKLLYY7687511x3D8Sbuu7cm; Tue, 01 Aug 2023 08:38:13 -0700 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.41]) by mx.groups.io with SMTP id smtpd.web11.16306.1690904292503976618 for ; Tue, 01 Aug 2023 08:38:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C1nhh4i0nm4xuYhdeqwmuRtU6i2NtQT3LSeEeBQF8MzcIbZgOeFZN5H+syn0K6tVMV2bmGQBzqb5Xp102NJmR35c0QuDZbw52p10LNdW2uLgTP/L1xY54VHmsIUnV84uNZEog7SrdZQQ31cs/+s6PgHttwzsqofwrFQ6gK6U9k3i6IZQlLrRML8U4tWBJEvD3UfrRz4mNWMy7Qg8YbkCGykLnZ/o66mkPXob001SzUkEfJK792xvq0LSY+0BMK1YsG8V0cgLvmuJj9X+K2pYvbs9iFEtfqkWwS+geYstQIwHyYHrEYS2NoJcywaOR4hvaBwoog7tXwShrdCJTVMDYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zojhdzk+JHNws+17zo5i7EqrQ6UgtEsO36BoTISgieI=; b=mIX8T7TNMPmGe1mzFwpTK6xbINElA3KRGjPWqJ+yrBK+P9UfXOs6hwz3FuL0AILpTtNnqg/3jVAhlm4R5RNWI1zh28EVAxWfO9oc7n0679nwms/0hjzPgKqiAOWu7X+T68Sd6In2ZB/fiy/2FPMpx//yU4tRhVbdipMjwP/1Gv/Jl8gmeZdZxiKTju5TiqHbleylyKWNLR3EwYQCGVLpvNS0QrmBZNkEK76RYke+iFn1JPYgHONpownWeZTLMwl85CWmRwR2wdKqp0OKYPv8GQPHhevccrJw9RuuH3xoXeosSHBpkmhZq8zalyy7cfyn6keoRTEri0FJfRLfDoKGIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from DM6PR12MB3371.namprd12.prod.outlook.com (2603:10b6:5:116::27) by PH7PR12MB5758.namprd12.prod.outlook.com (2603:10b6:510:1d1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.42; Tue, 1 Aug 2023 15:38:09 +0000 X-Received: from DM6PR12MB3371.namprd12.prod.outlook.com ([fe80::ed2:99a4:2e77:89bc]) by DM6PR12MB3371.namprd12.prod.outlook.com ([fe80::ed2:99a4:2e77:89bc%5]) with mapi id 15.20.6631.043; Tue, 1 Aug 2023 15:38:09 +0000 From: "Jeshua Smith via groups.io" To: "devel@edk2.groups.io" , "sami.mujawar@arm.com" CC: "ardb+tianocore@kernel.org" , "thomas.abraham@arm.com" , "Pierre.gondois@arm.com" , "Anshuman.Khandual@arm.com" , "Matteo.Carlini@arm.com" , "Akanksha.Jain2@arm.com" , "Sibel.Allinson@arm.com" , "nd@arm.com" Subject: Re: [edk2-devel] [PATCH edk2-platforms v1 2/3] Platform/ARM: FVP: Specify TRBE interrupt in MADT GICC Thread-Topic: [edk2-devel] [PATCH edk2-platforms v1 2/3] Platform/ARM: FVP: Specify TRBE interrupt in MADT GICC Thread-Index: AQHZvuM1NXXCdqsudkGGJJ5vWaKM3q/Vnf6Q Date: Tue, 1 Aug 2023 15:38:09 +0000 Message-ID: References: <20230725103105.8068-1-sami.mujawar@arm.com> <20230725103105.8068-3-sami.mujawar@arm.com> In-Reply-To: <20230725103105.8068-3-sami.mujawar@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR12MB3371:EE_|PH7PR12MB5758:EE_ x-ms-office365-filtering-correlation-id: d79e9563-869a-46e8-8614-08db92a54ed1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: YiURevsPAmbpWchYYmj0fy2uY+UYQ+rg3qa/8+IKeLS9tVabNvjIHUUhqff0nI66h0DMbgC0RkX7eHig1HVk6XwHyVntcLCd9LNLe2GtCCIhogfW4DrHQ3wP8jjNnIYC4AduLDs6x2c3u9z9nSxL9NFeil/f0+ONjcR2hqph2SpFBMXRYOPHjY268irm+IuGsfbNs9UaCkDecVEHIz/2oJf1k22ygjBohPaYLs6gnMcDXoBFC+GxLSWCSoE2YaAJG2xP/SSjyaNaZiVQs4THUcuLuvV/Yp+1EPsmm/wr49RuWKAuem8CYkPPjWZJLDg/oWkpnEgbS8MD9KR+mP/LeyVkQg7UYgCht9XapAzy3okiu0YJhDyNHhbrt1rJMqv6zz+cbq+cwlEWyalpoddpdTM/fki2diApSMa3zKAhH+vRUmrTARa43NNYcYfypEfvSKX+oFksTZGji2so+Jxik/8+IPP6IouOk6Ia0uBrVdaJyIKtJgcI/IjPRim2S0yn4aGQtQHWLox26w2Y0+RueAxBdm2h5LHQ19Oo3l7hCZ8//4LxA41O7lB7leqH+gNKooFfsRPOa54AyjM6Z/4ZmEYrC7OSRmfAWNRpGawjdRg= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?s4oT3jCV5Q423ixRzk84IVloG+4XSv8Ex6ChOo1V0NKIaI3G5hXJ5PNu57IJ?= =?us-ascii?Q?A2zCglI1zKroxjOzoId+A7NI1yhb22h9Q2BM/gDe2ziy5JAoULP65dFFr6tQ?= =?us-ascii?Q?akubXbgpIrG5y5q9xnIK8WgZ5PCNwOeEYfgCHijQXJadd7qxMYvAL85iK48C?= =?us-ascii?Q?YZWY/a2l1R358REkM6HHmN1o7UKJMbK6X2e8uUMHbBslaVX5CI+GIKCtszih?= =?us-ascii?Q?0I7MhlCXf5rJnHSa+MC4WpCxn9ElRRiT9mKD+YLq547k0cgjMlJAXSVEudut?= =?us-ascii?Q?uh5c+NvoKk9nUY+xEIlQ2wAdOm0/6Fz88k9CgovLE4+ijQKC1kqQth25wwcg?= =?us-ascii?Q?e0YAUuqNjD+0U8iIAbmxofYMj+Rwqf3ovs9WROIajyHm6Ly0wpyeS0wKspzc?= =?us-ascii?Q?fIRKh7MP9q2XcadWo9GwH4wPSanafghknToCzJCwXOnZ8F6RFkikLOsmHjNx?= =?us-ascii?Q?u5wveWOl9eLljkv5EJ1KoW/lDRHZNRQNWXxKFAubLTHMSBDRI/MBfbd0BAVG?= =?us-ascii?Q?SrfqDAq+/yprFw2yAraU+8+HyQj58HSUWD1QEiV7JtpaOFC1ZLoKorm+SKGD?= =?us-ascii?Q?3/pFhJuhW1TBFK3xf2B6RWzlpcvlAJQ2LUqkp5/y2JvSCOQIuS0aUK9PrZ3G?= =?us-ascii?Q?/4gm9IHmuaDkNnPwXmppVOWWFFMGaAszgC9OJq8YrPx9D000vIEGnpKonuQ4?= =?us-ascii?Q?RrzWmf5Nc3LFtQyEjkckga0iwxKaDrUS/i4W+G9KTj90F4gMxh0xqOfKx3Jk?= =?us-ascii?Q?72tUpgtx+a6s8QR7IztveJqKoiwzKDW4h+oRH+mpjB7qycgqB9T2spgzzVfM?= =?us-ascii?Q?VNd14Ub8w+Fgi50JkXOWZqt6mqNpMkPdtbqBrrwlhK0LwZY7Bj2pCqUPThIB?= =?us-ascii?Q?U7bTyECPCgCjXgtauDaqp9ENXUOqe4sjLmUZUQNU+solrJdMdGSYNfuAHreu?= =?us-ascii?Q?/qcuKPLok30ogjZUemQh9P/Ke0f2UUjBn6MQJZhJghrg0mkusuKQrHwMOGZ+?= =?us-ascii?Q?swwbOEl55tOfuMPEm3K1gGih8awxvizcYDDhV0DTgzbfP1lfkbbrR7fhWbhV?= =?us-ascii?Q?OBe+QnrPjscjpSda7YJOUelm6h74V8GNO3BGMlA5QraiHFrUfdPDpvrVPzhy?= =?us-ascii?Q?GgGr2CHn9d89NFmqMoKokKp6qJ1OnQ9ADBduau/Mhp+jNZ7YhVV0LstMWWwO?= =?us-ascii?Q?1P0mfhjeMcs0BydFySFxmHOkKVwVhZyyDtLpnov+cIWWrx+Unj13tgS/Vzg3?= =?us-ascii?Q?A+43kEL5Y7eyfBIluGixAHn+AIEL3PHByLwOOxDNQuhV+qnGUv/F1ygTvdZV?= =?us-ascii?Q?8bUzsJIqn2+yv677TN14p6CIhqMZVjs4uVwXQzX4qU8Xi6pv+AZHb0Qu3UfG?= =?us-ascii?Q?eLfZnqD93z+sSeVXkrdsk/kFVoHzDkzfLauhNoU2hfD5iT1UOfCWZBWbHEiH?= =?us-ascii?Q?tQm5pKrWenOGxoZuSsgZUT7xxpbI9BdTRD7Dw9xpfQP2K00GGKm+VD1h14OK?= =?us-ascii?Q?uI0xMQ2IVISrfAtl+yR6DTWCok3c9m09SAuzGRqWZUn0S0fH9xK99sTpVbGM?= =?us-ascii?Q?8GKN7qkuQs8Hvq56zNePRVLXJQehzcpMnTHLiw8P+M481RLbOWfS+vH6a57+?= =?us-ascii?Q?bJbCUDA2O1Q8xab6MugzGpaW+XqQj0GWd94gUQ2yopvt?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3371.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d79e9563-869a-46e8-8614-08db92a54ed1 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Aug 2023 15:38:09.2617 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: whmIls9ZIuz6hnMvpN9tgOX2/hEfVWLiNPBVoXMzGdQSRDn37EyYfL5XZUwEMPjj6UKhhVfnZa6Ynss8LY4e+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5758 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jeshuas@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ssoPMPAGax5s1qVdC7w0N8rNx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=hmMo146B; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") This comment in the code looks wrong: + // TRBE Interrupt is PPI 13 on FVP model. + TrbeInterrupt =3D 31; -----Original Message----- From: devel@edk2.groups.io On Behalf Of Sami Mujawar= via groups.io Sent: Tuesday, July 25, 2023 4:31 AM To: devel@edk2.groups.io Cc: Sami Mujawar ; ardb+tianocore@kernel.org; thomas.= abraham@arm.com; Pierre.gondois@arm.com; Anshuman.Khandual@arm.com; Matteo.= Carlini@arm.com; Akanksha.Jain2@arm.com; Sibel.Allinson@arm.com; nd@arm.com Subject: [edk2-devel] [PATCH edk2-platforms v1 2/3] Platform/ARM: FVP: Spec= ify TRBE interrupt in MADT GICC External email: Use caution opening links or attachments When TRBE is enabled the FVP model uses the PPI 15 (i.e. INT ID 31) as the = TRBE interrupt. Ref: https://www.kernel.org/doc/Documentation/ devicetree/bindings/arm/arm,trace-buffer-extension.yaml Therefore, check the debug feature register ID_AA64DFR0_EL1.TraceBuffer fie= ld to see if TRBE is enabled and configure the TRBE interrupt in the GICC s= tructure in the MADT ACPI table. Note: To enable TRBE support in the FVP REvC model 1. Build TF-A with the C= TX_INCLUDE_AARCH32_REGS=3D0 build flag set, otherwise this results in an exception when booting TF-A. 2. Set the model parameters to enable TRBE -C cluster0.has_trbe=3D1 -C cluster1.has_trbe=3D1 Signed-off-by: Sami Mujawar --- Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/Conf= igurationManager.c | 39 ++++++++++++++++---- Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/Conf= igurationManagerDxe.inf | 3 +- 2 files changed, 33 insertions(+), 9 deletions(-) diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationMan= agerDxe/ConfigurationManager.c b/Platform/ARM/VExpressPkg/ConfigurationMana= ger/ConfigurationManagerDxe/ConfigurationManager.c index 4df2d6cdae58df344804a8b41208a3adb8ee0110..03393905be1c627b7cdbaa0efed= 33e920072c8cb 100644 --- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe= /ConfigurationManager.c +++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager +++ Dxe/ConfigurationManager.c @@ -1,7 +1,7 @@ /** @file Configuration Manager Dxe - Copyright (c) 2017 - 2021, Arm Limited. All rights reserved.
+ Copyright (c) 2017 - 2023, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -15,6 +15,7 @@ #include #include #include +#include #include #include #include @@ -37,8 +38,8 @@ EDKII_PLATFORM_REPOSITORY_INFO VExpressPlatRepositoryInfo= =3D { { // FADT Table { - EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE_SIGNATURE, - EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE_REVISION, + EFI_ACPI_6_5_FIXED_ACPI_DESCRIPTION_TABLE_SIGNATURE, + EFI_ACPI_6_5_FIXED_ACPI_DESCRIPTION_TABLE_REVISION, CREATE_STD_ACPI_TABLE_GEN_ID (EStdAcpiTableIdFadt), NULL }, @@ -51,8 +52,8 @@ EDKII_PLATFORM_REPOSITORY_INFO VExpressPlatRepositoryInfo= =3D { }, // MADT Table { - EFI_ACPI_6_3_MULTIPLE_APIC_DESCRIPTION_TABLE_SIGNATURE, - EFI_ACPI_6_3_MULTIPLE_APIC_DESCRIPTION_TABLE_REVISION, + EFI_ACPI_6_5_MULTIPLE_APIC_DESCRIPTION_TABLE_SIGNATURE, + EFI_ACPI_6_5_MULTIPLE_APIC_DESCRIPTION_TABLE_REVISION, CREATE_STD_ACPI_TABLE_GEN_ID (EStdAcpiTableIdMadt), NULL }, @@ -109,15 +110,15 @@ EDKII_PLATFORM_REPOSITORY_INFO VExpressPlatRepository= Info =3D { }, // Boot architecture information - { EFI_ACPI_6_3_ARM_PSCI_COMPLIANT }, // BootArchFlags + { EFI_ACPI_6_5_ARM_PSCI_COMPLIANT }, // BootArchFlags #ifdef HEADLESS_PLATFORM // Fixed feature flag information - { EFI_ACPI_6_3_HEADLESS }, // Fixed feature flags + { EFI_ACPI_6_5_HEADLESS }, // Fixed feature flags #endif // Power management profile information - { EFI_ACPI_6_3_PM_PROFILE_ENTERPRISE_SERVER }, // PowerManagement Pro= file + { EFI_ACPI_6_5_PM_PROFILE_ENTERPRISE_SERVER }, // PowerManagement Pro= file /* GIC CPU Interface information GIC_ENTRY (CPUInterfaceNumber, Mpidr, PmuIrq, VGicIrq, EnergyEfficien= cy) @@ -474,6 +475,9 @@ InitializePlatformRepository ( ) { EDKII_PLATFORM_REPOSITORY_INFO * PlatformRepo; + UINT64 DbgFeatures; + UINTN Index; + UINT16 TrbeInterrupt; PlatformRepo =3D This->PlatRepoInfo; @@ -491,6 +495,25 @@ InitializePlatformRepository ( PlatformRepo->GicCInfo[6].MPIDR =3D GET_MPID_MT (1, 2, 0); PlatformRepo->GicCInfo[7].MPIDR =3D GET_MPID_MT (1, 3, 0); } + + TrbeInterrupt =3D 0; + DbgFeatures =3D ArmReadIdAA64Dfr0 (); + DEBUG (( + DEBUG_INFO, + "Debug Feature Register 0 - ID_AA64DFR0_EL1 =3D 0x%lx\n", + DbgFeatures + )); + + // The ID_AA64DFR0_EL1.TraceBuffer field identifies support for FEAT_TRB= E. + if (((DbgFeatures >> 44) & 0xF) !=3D 0) { + // TRBE Interrupt is PPI 13 on FVP model. + TrbeInterrupt =3D 31; + } + + for (Index =3D 0; Index < PLAT_CPU_COUNT; Index++) { + PlatformRepo->GicCInfo[Index].TrbeInterrupt =3D TrbeInterrupt; } + return EFI_SUCCESS; } diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationMan= agerDxe/ConfigurationManagerDxe.inf b/Platform/ARM/VExpressPkg/Configuratio= nManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf index b53daf51d4b1afd45e41d0debb0b9f084f135f6a..dd08f8597768d4de62941c5fd74= e329c431582b0 100644 --- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe= /ConfigurationManagerDxe.inf +++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager +++ Dxe/ConfigurationManagerDxe.inf @@ -1,7 +1,7 @@ ## @file # Configuration Manager Dxe # -# Copyright (c) 2017 - 2021, Arm Limited. All rights reserved.
+# Copyright (c) 2017 - 2023, Arm Limited. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent ## @@ -34,6 +34,7 @@ [Pac= kages] Platform/ARM/VExpressPkg/ArmVExpressPkg.dec [LibraryClasses] + ArmLib ArmPlatformLib PrintLib UefiBootServicesTableLib -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107426): https://edk2.groups.io/g/devel/message/107426 Mute This Topic: https://groups.io/mt/100347409/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-