public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Jeshua Smith" <jeshuas@nvidia.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"sami.mujawar@arm.com" <sami.mujawar@arm.com>,
	Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH] Platform/Sgi: Add VariableFlashInfoLib to fix missing dependency
Date: Fri, 16 Dec 2022 15:56:08 +0000	[thread overview]
Message-ID: <DM6PR12MB3371A43114DAB22A8B45107ADBE69@DM6PR12MB3371.namprd12.prod.outlook.com> (raw)
In-Reply-To: <25627.1671186532908215767@groups.io>

[-- Attachment #1: Type: text/plain, Size: 2061 bytes --]

It looks like that function call takes a double as a parameter, which is a type of floating point number. I’m guessing that’s why the compiler is complaining that the ‘+nofp’ feature can’t be used with that function.

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sami Mujawar via groups.io
Sent: Friday, December 16, 2022 3:29 AM
To: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [edk2-platforms][PATCH] Platform/Sgi: Add VariableFlashInfoLib to fix missing dependency

External email: Use caution opening links or attachments

Hi Vijay,

Thank you for this patch.
This patch as such looks ok to me but I am getting a build the following failure when openssl library is being built.

build -a AARCH64 -p Platform\ARM\SgiPkg\PlatformStandaloneMm2.dsc -t GCC5 -b DEBUG  -n 1 -D EDK2_OUT_DIR=Build\ArmSgiPlatStmm2 -D SECURE_STORAGE_ENABLE
...
"D:\linaro_toolchain\gcc-arm-11.2-2022.02-mingw-w64-i686-aarch64-none-elf\bin\aarch64-none-elf-gcc"  @w:\edk2-maintenance\Build\SgiMmStandalone\DEBUG_GCC5\AARCH64\CryptoPkg\Library\OpensslLib\OpensslLib\OUTPUT\cc_resp.txt  -c -o w:\ekd2-maintenance\Build\SgiMmStandalone\DEBUG_GCC5\AARCH64\CryptoPkg\Library\OpensslLib\OpensslLib\OUTPUT\openssl\crypto\rand\drbg_lib.obj  w:\edk2-maintenance\edk2\CryptoPkg\Library\OpensslLib\openssl\crypto\rand\drbg_lib.c
w:\edk2-maintenance\edk2\CryptoPkg\Library\OpensslLib\openssl\crypto\rand\drbg_lib.c: In function 'drbg_add':
w:\edk2-maintenance\edk2\CryptoPkg\Library\OpensslLib\openssl\crypto\rand\drbg_lib.c:999:12: error: '+nofp' feature modifier is incompatible with the use of floating-point types
  999 | static int drbg_add(const void *buf, int num, double randomness)
      |            ^~~~~~~~
NMAKE : fatal error U1077: 'D:\linaro_toolchain\gcc-arm-11.2-2022.02-mingw-w64-i686-aarch64-none-elf\bin\aarch64-none-elf-gcc.EXE' : return code '0x1'
Stop.
...

This may not be related to your patch, but can you check, please?

Regards,

Sami Mujawar


[-- Attachment #2: Type: text/html, Size: 4876 bytes --]

      reply	other threads:[~2022-12-16 15:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-20 16:53 [edk2-platforms][PATCH] Platform/Sgi: Add VariableFlashInfoLib to fix missing dependency Vijayenthiran Subramaniam
2022-12-16 10:28 ` [edk2-devel] " Sami Mujawar
2022-12-16 15:56   ` Jeshua Smith [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR12MB3371A43114DAB22A8B45107ADBE69@DM6PR12MB3371.namprd12.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox