From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id CE0C0D8118F for ; Tue, 9 Jan 2024 16:55:29 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=8u/vV57b7fKmfYL3fKAheGtn7A4Co2LI3sgS6WBt0B4=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1704819328; v=1; b=unIJ2wTLA8DFSmQDU5XnLOj2UR4PgIxzwcNp1Y9llBUEsi2h9DIlt0d2iLYN0Vq501JDKEuL VY8AYtZweDgNnmqQE9HGT3/SZrRUH8kczGPqFF3l5Z9ZMXA5/qv7YhazYgml9WP2XeTGTbIoA4Z lPkPMwcAVtJaUcoLs16+d6NE= X-Received: by 127.0.0.2 with SMTP id PIqkYY7687511xZPPsAY6z4f; Tue, 09 Jan 2024 08:55:28 -0800 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.63]) by mx.groups.io with SMTP id smtpd.web10.21938.1704819327857055192 for ; Tue, 09 Jan 2024 08:55:27 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XT201m25ZbZRAH6qgyAHK0u2it1In7F3SWS0R2uYSqrLMObk+rU8QJys0bcoW91g1c3x7v1LSHtpts+S23YzPKQhaiglsFZup/YVcZTdW6bxQH6UiMV6bQUisZi3ANQUIggLXThxnS+qhsvMcRY0VMGryX8XCQw0L27KkPSwDQxyj1+fo/Fnh8LWtT1R+vGURXVxoqn5kf7bzBA4H9zSNFkZPy/vHXPDU7DyaYFZAuKV6QjiX8873PyaffHhycJEtFafOVDGvtPVroUM/6CJ9c0mq0mLYYvfmgiGmgGtirqoTTm3pLHtRIoWezI3AELQEO8NQE89VKB4TSCSriho1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RfXrCk3QIPvOgfRl2D14Gy++jubfVl2zEzi5KlzGOhc=; b=BjhS99GjgBV8xaaS1UjIVYjYh1N/zERe+ZBSm/Vtgq3JmCMoTaqeRARr2pu3r/JGS5Ji3bpp35HmcyfXq5anGZcpaG5H14iOu4y8vFHy1rp2LxnQnIOV2BVpMLj9/9BIElYQ0OMiWLzAdXGp+NtxEu3dkntHnlHArgBc51yZ1ZGIyfa/HbpFb1HnlKAmtGx4KNs8LinSswMZy7J3C3EkEcCHtXbRBqPcYbPnCcAhHEB68O6Su7Vbnmv+YY27BILVJx9WahH1nWRzjKsaIia3Wqfvl5RVlMpiaRu5bnjeGi23+02y5eq9EPfuBpGT8fZlal/spglVmigs7PRUT9U99g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from DM6PR12MB3371.namprd12.prod.outlook.com (2603:10b6:5:116::27) by BY5PR12MB4036.namprd12.prod.outlook.com (2603:10b6:a03:210::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.23; Tue, 9 Jan 2024 16:55:23 +0000 X-Received: from DM6PR12MB3371.namprd12.prod.outlook.com ([fe80::741f:14b7:f08a:f988]) by DM6PR12MB3371.namprd12.prod.outlook.com ([fe80::741f:14b7:f08a:f988%4]) with mapi id 15.20.7159.020; Tue, 9 Jan 2024 16:55:23 +0000 From: "Jeshua Smith via groups.io" To: Pierre Gondois , "devel@edk2.groups.io" CC: "ardb+tianocore@kernel.org" , "quic_llindhol@quicinc.com" , "Sami.Mujawar@arm.com" , Shanker Donthineni , Vikram Sethi , Ashish Singhal Subject: Re: [edk2-devel] [PATCH] DynamicTablesPkg/SSDT: Remove incorrect root node check Thread-Topic: [PATCH] DynamicTablesPkg/SSDT: Remove incorrect root node check Thread-Index: AQHaQl5XHLyznuslBU2y/chizegSBrDRJSkAgAB43QCAAAtdgIAABmWQ Date: Tue, 9 Jan 2024 16:55:23 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR12MB3371:EE_|BY5PR12MB4036:EE_ x-ms-office365-filtering-correlation-id: fb1a262b-f396-4abc-3fcc-08dc1133c5b7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: zyNdq0ISWtj1AV8nrgGnT1GR/WmcqAt9shUijTD3/TEZVtx8Y2xWnx2gKiHk3Rb3oF73I020jjnV0IIMmrkEXrLa0wHqGGlIH0Tc5jZPexVaGl4GkQMRkkdPTko7/fbQ15lSPIZNF12ncP3P3CBfRSjjCUDn+P/LqXDaeUom3oVO8L75YUcKFyNedN+C3656Q0buLPY4dSnQqEOz6jD84nFUQ1zPK4+CxBZ4tWHsA10fsfB099TbWSdGwNoFVB5TLiGHJHwxQnwYHdTBBUHIrFc1rX4zhKkQ8Bi2Vvo36CoyyroSY7/V1dqpx9x9twshai6CsbcuKI/CHrsj5O5v0e+fa+fL1wBVzl4dKidoWGrtID1kWvpR5eeZHTsZiSdoRRCrsCCpa2ZQgaA7/kF6wMjnnyfCDnz3YfSiJbUG47mC7lnxNtJd//nO7MOb6lFW1pvUfEv71EMZgaOIptWnJtvzv2rcSvAmV4Dx5By8Y4XVvOgxZ5y6h8tRIbgXRh7EHYmwrFu87wvrm8mp9VXDATX5Nd0ewdpKkYQBe91LOwcx1nfqvQGMEaHP8sygwyL+ean3ZfWLFQdivkZm6SXr27WAGvK2OvGs+BD4FjPhayr25PyVp+E+qJmVZVXhkKqw x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GLGEdfBFII8vX4fSidIJ1femP/AzzPUtGQnm7MOzJuvmWKPaZc0MUfJGFuG0?= =?us-ascii?Q?zFXe/GqTFimI4Pu31tohaIHplyVZE1fvdyIQjH+cbPlWUzbo5gsUeLnoYeBi?= =?us-ascii?Q?fxbjWsQGnxqBgLV+ExDIAam0odh/sWgd6UImqfiTwXUXmIFWRfnPn9BtpNNH?= =?us-ascii?Q?8OPWwU9Y/Uv2yIR0cRh4LRnWxMVdXNbfmuHx1S7XVUnotH5/nlXjqlNvIeDd?= =?us-ascii?Q?5nO8qpDcOu4Jop7om1eR143lV0SLvugyJl4EeCpvDHj29OtyX77iKqtgJCNp?= =?us-ascii?Q?nOIr4Y6TPgho9ZOXnermQl+6I1lvzNLo6TWn+SLGE5puioaRZwfFOY59DET5?= =?us-ascii?Q?SdyUu4g/VtJ/lgoVC7AOByt4rAIbkim9dwZCjeWVKoIjibwi8Hles7DN7EOA?= =?us-ascii?Q?U/z0zBe7svIah5nwRQ++R7U/WeS8g9h/JhHXZusMgy+gGGK1RSIYn2TJU4YC?= =?us-ascii?Q?5dqizbjBUxr21GDfhKVFIg7uTMIM/ERm6lYLuRAcMcjpC3zp2Rinv2i1j2Sb?= =?us-ascii?Q?31rZsXxzFITzE6CDbvkZwRmp3O76SNDvbh42rLWO4JaSFYeq1rHM1+TMlfxW?= =?us-ascii?Q?TmncdFd3mc/EZUMBF40OpfpzmTwO8h6a4uqa0AwqVoaIb9ouOYGk7FzfO24s?= =?us-ascii?Q?y8zzYZ4jnaLwnQwLi4T9MFlZonyJp5EriUPfWfykwq4cybv5bgpXs1aLrb1q?= =?us-ascii?Q?tuAd3knfS+PZkhrGA/Yn9DpgNaD26Hgx4e5qokn8w6O0OJE2DjK427vv7Z9a?= =?us-ascii?Q?UDOORXPjXPJhOItUQ3uCrccqHewudURqJG33eqT7UlsJwg95UBGub3N8kuPi?= =?us-ascii?Q?LD2xAlp1SQlicxGtbF3r1ZXS22bsX/W2FZwCxQlAiTEwYMwq4w98nh2b4tL9?= =?us-ascii?Q?zYNq3i9PXM4LtRPKa7UCDNLjiCgvmwrQQM6Jg/RG3uw7Dn/MPNMZyBKJ02kH?= =?us-ascii?Q?jlKYjPbDhUTjxthbQFvJ/IId14QlzPdQg5IPq2N9fU+sW04yBdahDB/YZ+AZ?= =?us-ascii?Q?Xo+aW+D/P0XMY7OrSq12tWH/R5xx8NX7Sy3br55IDhmkcEbRkcoxNsAzdJBA?= =?us-ascii?Q?DDvAVkB+ejkXhU/691Urf2HdktGMKKF8CLSkoEvwaVknQ0MxhXCEeK1eLyKf?= =?us-ascii?Q?0etcKgk/yVGK9Y+JxO/0LO7XiVoUL9ceo7ZPWg/augXlHKAg9n9MtV6YbMM5?= =?us-ascii?Q?z/I1wKfaBuh4Tu4xo2g2Zt5/+730s++pmMUwR07oQ5VHBTgEwU01eo/EFwDb?= =?us-ascii?Q?LhsLNZ7O8elG06cluQBG96dl37TvpLfDGXGfwGEyJ2ena5OoKRjznZohTT6n?= =?us-ascii?Q?ZxAF0DUbPtHteozaLxWNI4BaciU0gAhvNYSa/CTE5fVkbi4ZnJreDss5e0iJ?= =?us-ascii?Q?FfOPBkTWfcI5EoHIj7HyxUp/ZIBNJf8AV1kMQ4aMGqbPeH6jRTXVC6HMs0aV?= =?us-ascii?Q?pEwNHjXgbfCMDSU+0nsGXsS1hdJ2OEWrcxTAN44AlXlv2W9OyqAOvgjPt/qq?= =?us-ascii?Q?6Q9GOcHFzWaQPb8cfdG0yZ7tvjcBUNGaVfNfdvkt4SMxMzgYg8O6yGLPZDKx?= =?us-ascii?Q?vma9YHU0u0cJnnr7WxbTv0ds18yd/lLzf8ZxlmAM?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3371.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb1a262b-f396-4abc-3fcc-08dc1133c5b7 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jan 2024 16:55:23.7717 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xA//WJPh6D1qjA/bjQ92gPV1MeMD48LKCObShVVZzmRdljdshbDt0Ql7Ip20pddggDYpRqDQ9AvxMuTG/CLoyw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4036 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jeshuas@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: xA25CYkVG8AtYQQ5Dgzt00lhx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=unIJ2wTL; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") > > Two physical packages are on a multi-chip module and share resources on > the module. The module then plugs into the baseboard/motherboard. >=20 > Is it possible to elaborate on the resource being shared ? In our specific case the problem is related to the PPTT's "Identical Implem= entation" flag. We need a top level node above the physical package nodes t= o be able to set the "Identical Implementation" flag to indicate that all o= f the procs in all of the child packages are the same identical implementat= ion. Without this (ie. forcing each physical package to be its own root nod= e) Linux will fail to load the SPE driver when there are multiple identical= packages because it detects that some of the procs have a different root n= ode than other procs, implying that the packages don't have identical imple= mentations. > Does it fall into the subject of this thread ? Some resources might be as= well > described in other ACPI tables. The thread you linked looks like it is about non-processor resources, and t= herefore wasn't in scope for PPTT. I don't think this is related. > > Note: While investigating this we noticed that another vendor also has = a > similar PPTT topology to what is being flagged as invalid, so either that= vendor > isn't using EDK2 or they have done something to avoid this check without > submitting a patch to EDK2. >=20 > This check is only present in the DynamicTablesPkg, so it shouldn't be to= o > restrictive. Ah, correct. If they're not using DynamicTablesPkg to generate the PPTT/SSD= T, then they wouldn't hit this. > If the platform is known to use it, is it possible to share which platfor= m it is ? We see the topology in question (ie. a root node is a parent node to physic= al package nodes) in Ampere's two-socket Altra PPTT. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113485): https://edk2.groups.io/g/devel/message/113485 Mute This Topic: https://groups.io/mt/103603398/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-