From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8604BAC1534 for ; Wed, 10 Jan 2024 21:56:28 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=CkVD5LPhaUyTgVKlCk1sMi64JpcJNcqfGWM0JXp/wd8=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1704923787; v=1; b=S2ZQ8i25Kf+gnScXN/z7cptrVskSIqu7xUN3qN0uLx6ZDemtU/Gdxs/6MhVgSE/OCe0711Qk VGMbIToccHe8bWEH1Ik7PtH4SDTTGoXqXr134JNOzTOsqpm2KrUfzxTXNTgQtaJHbcQrXClegp/ 2li6uOVbD9RcEOOujVnFRhtg= X-Received: by 127.0.0.2 with SMTP id 6x3oYY7687511xFwGEzoIS5j; Wed, 10 Jan 2024 13:56:27 -0800 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.46]) by mx.groups.io with SMTP id smtpd.web11.6626.1704923786588329359 for ; Wed, 10 Jan 2024 13:56:26 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TDsHBsCD3lYyigkzzE0zSiyTrEcfoIW6DVeBbbwS+k72Fha76UQ+ip03PIkp67PoFJNCGIm9bAHgKkJdt25fh5dNHqM1aOHw549x1DKlX5pkM7FousstJoNvuhkSaqGXD/MdrNRDTexWaswB+FsEfz3kroFe/RSnuNlt8Z5sznry7dhXEwetbLljFtJOVAiZ90CNXMLVwo343Tjr2Uw8dr4DV1ppyrzJz7Pb5eoZeK9HIfMUahKxW00tDDbpq0RUEQrWTKnK8kGGt4vZF+XiotMHigV7/ybiT2ZapdbhdsiuMInvVYsEUSLBPBCXf+Rl22X/EHwpwILtXdpVrij0jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uHGPou43r1hLzjTB+jxpPVrooNXN4khKGhpiIL0PAyE=; b=oMWw73ECeJ3hwnIIKpzo5t0iHDihLJMn4T9o0P4gonLYiygkmKC/yfJGBm/AYex03KbP3NVRsIuYshSa5BapO/6Rpehy4UOgNHq+Awhs6D+En/meSygsYEexYMXWxK40DFp3CiFjwPPGnQvXum/JWajSAnB9dLH+Oh3xsyL03OmFd+Js+1MgYxMUj6brYcmvBc9jQCZjG9eimUffMrsQ2HFMj78abmG/X6HZyh2c6N7OdqKXIcKTLndQnTYh08kNhBvZIcdRliXQglC0lZ6FcLLoQHM2JA/KHeHnX3qBWYoyUo51ct5VeulWGTk/TBcVeqJCBJM/jhO/iN5lLmskdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from MW4PR12MB7357.namprd12.prod.outlook.com (2603:10b6:303:219::16) by CH3PR12MB7572.namprd12.prod.outlook.com (2603:10b6:610:144::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.23; Wed, 10 Jan 2024 21:56:22 +0000 X-Received: from DM6PR12MB3371.namprd12.prod.outlook.com (2603:10b6:5:116::27) by MW4PR12MB7357.namprd12.prod.outlook.com (2603:10b6:303:219::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.23; Wed, 10 Jan 2024 21:56:21 +0000 X-Received: from DM6PR12MB3371.namprd12.prod.outlook.com ([fe80::741f:14b7:f08a:f988]) by DM6PR12MB3371.namprd12.prod.outlook.com ([fe80::741f:14b7:f08a:f988%4]) with mapi id 15.20.7159.020; Wed, 10 Jan 2024 21:56:20 +0000 From: "Jeshua Smith via groups.io" To: Sunil V L CC: "devel@edk2.groups.io" , Ard Biesheuvel , Leif Lindholm , Pierre Gondois , Sami Mujawar , Andrei Warkentin , Laszlo Ersek , AbdulLateef Attar , Jeff Brasen Subject: Re: [edk2-devel] [RFC PATCH v1 00/20] DynamicTablesPkg: Prepare to add RISC-V support Thread-Topic: [edk2-devel] [RFC PATCH v1 00/20] DynamicTablesPkg: Prepare to add RISC-V support Thread-Index: AQHaQxkZuzPvDyJmAUKRRBOecDnxOrDRzFmQgACmFoCAAR/qUA== Date: Wed, 10 Jan 2024 21:56:20 +0000 Message-ID: References: <20240109162944.528006-1-sunilvl@ventanamicro.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR12MB3371:EE_|MW4PR12MB7357:EE_|CH3PR12MB7572:EE_ x-ms-office365-filtering-correlation-id: 825523e0-fcf5-471f-75f2-08dc1226fae8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: NXGm8JtStu1xGxlhjOV2HQM7i56ysEPGNi1oxKWzEjQqOYpsPlAK82wt2t955PlX3BtGoCpGUBbcie611qOhN15u7RKGCpTT/zFrj8sG35b1pCS2ULKIyTxAr4w9qxtY0+064AEotAM3QvEy1IJeHzuw7u6u1GmbnjiFNfjzYitcd78ZADR7/oWhLWj9nvz9/6rMyUnOp77IfcmVW6aQzfwkPoaq9OIMOZQLDpFTIypmCyNjQmlyllZHDidjuvguvOtY6mxi6VsbMODViEvNoROIlKjWjEVEHmVx3PhmepspJcxki80S2nXkdiXc0uubUvpn87O9uBAUDEiSBhfb0uZsJjFVTu7kj8am4woN4lk2JAybClQM/UrgTzUntczAXgyrF7Y7Vgm5is2TqTP+2EHvB0F2gIhg8jibNCG++mN2xp3E+Yu2xBUeNJ9jjHZBFhhl9hLkFfcBghN3TewiNAKRZi/0/FFySp+oFv+HH0BwQq6ThxRfOUF5VQLjG7xBxrNXDoVjdq8lu1ZQK7SdcKdk9UBtlptCHq815SW9mgVrwpPbEXL9pAr6sOBtOVdUgJ92WSV00H/WP4D8WZZQgAsJTXzr9QzDGq5sUeaRS5//Ibz5Kd8e5cVlNbuPKfH9 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WyL5O5P82Td9voqbbR7IEQiiCb5Gay0B6LbYuE2U9FwdJt+KcZtSRDFqHDys?= =?us-ascii?Q?cHd7dOVmAo0R0TbjM3BxRUwKah5frgr++MPDV2bBOOqHiMEmvg56wllb3azd?= =?us-ascii?Q?9z/BO+wcs0TwZQRXYLF1AGlhAe26zbzGtUPzXt0I02a4P3s15HkSnH93W1WZ?= =?us-ascii?Q?OugLuvSYjqcxm7XYBy+M+hKW4emZ2qJa1Q49vYo9AgNcLfnnSrnsYOCNn8XE?= =?us-ascii?Q?n0GaHL12suQ5ZoKlkst2Vxk+YEewV74VehvcbKm7TmQoNubQ3+kgIAFLaynU?= =?us-ascii?Q?g6i8RnTZ70YajuOUjVi+8TbuVRD17hsN3iroKGn76l4xjsTMpSW0aQLfgUd8?= =?us-ascii?Q?61yxBplloE3mEC7zcUh7E/Xp+ZcVjsGH+0+4sGAOltxHkLSlT4PU5BfjhZO/?= =?us-ascii?Q?OKeo8KYAIkNOlRuWkwjVPAJ18CFXNPH2DtGF6dsXwwA1wB9U+o9RKV/1zwhH?= =?us-ascii?Q?nnCy8iK1WiUEbS46xkfQuHzFZi1hzlomerHeHJySNH3KThRE+xPAkEmdceAy?= =?us-ascii?Q?BQ8oDxdZ+FyUsplz4ZA6WDZ25IrvTT4Bq2KOhMMeIWv+Py5LeEYHhumXuxMm?= =?us-ascii?Q?wsdjiRSS9iPbyRezk6MwTbGsT0TYmn/AM6ZGfrxzQ7y0PxQ94raXBugIJhlI?= =?us-ascii?Q?x455POaNwcdTEyjQltu1VGuEadKhGIE6og3sxSIuSB7mheqwvZ+dV5lqqnZ+?= =?us-ascii?Q?os8PQVI+hojHaII5kHp8ldaNfDuSNF0jBzLGVif78fecYsbr4FoE9xGONjS1?= =?us-ascii?Q?JuhwG6U9sMmBB5nI6q6H2pvxfRX4lX1yZQiIY9hcagr/WdFTj7lnCab4ljeV?= =?us-ascii?Q?6mxSHpLT+SGIxbkmnhlBdYj8E81M4WPyMW2shBdQ5uNPUf0oALGlgxejqaiq?= =?us-ascii?Q?PE4CBGlbIW0PLEbuq6wdYoMiCCBrRU/s7d/Rw8FPiIQ04nNGT+XKVJU6dl3C?= =?us-ascii?Q?jozs8Por37KsMyIZXKKuyPQzeb5AlY9E7k5mQ8aDvAGb2ezmWNBihvhB5u/V?= =?us-ascii?Q?7HSWHBEo6XC5hnjdclS59hTrSK/5xG8URRo5jSQirVgklXnqLGNkZe9fEb4Z?= =?us-ascii?Q?W+NuonGDctCtGhfcc2WqCBExOUai15gHSfaoI18US46qhu+B7gtg3FcjeswJ?= =?us-ascii?Q?qWlwWigXiPswkWMEArs0pl6e34mVCbC8CRNBWdYmya6CZczcmc0B034pzgKk?= =?us-ascii?Q?1QEzpalkJgbaTpCmetxKHMsE0Z+ef4REcUCS0ySNYQkMESJ+WPCJFiIDp2S+?= =?us-ascii?Q?+8Kveih7x7ZXjQLVOsBAr4+BljenCaki58Gc0OdaPa34DCWFDglJsJOn4zwC?= =?us-ascii?Q?GeNB0LT9VKbkKBrujcTPjuPw+WIRHzA9SEom8NuxnoNoOv9ggGBh+agso46b?= =?us-ascii?Q?IynjWiu85nJoDshGvfjxCbWIssd4/HoQ27mts0pKG3dcOAKMngH+uQF1UMo4?= =?us-ascii?Q?kUEHU2A8lzq9zd4ZR3qvfas3rpMaTWxsTFBVTj9n03MagYKbAU/QVH3PVy5i?= =?us-ascii?Q?cXiSYhr7aClZ1++gGUlT7QYXfRzXVhUVTXKwdKL5zoR1BOU+7TdbiaRG1yVB?= =?us-ascii?Q?w1Ibk6viu2jUtbIcyYrz5boUD3JMLhUB8ADEGNo1?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3371.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 825523e0-fcf5-471f-75f2-08dc1226fae8 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2024 21:56:20.7239 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YIvWNrl+zhLYg+JIzSH5jV5N/DIggFz5ThBvLt0nbXNgi+giMGwR6oYU6FhG8LuYWMg6CECgEfmHwm+AisNqPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7572 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jeshuas@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 9tAWdzTcLR0o5IyhxgxnKw3fx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=S2ZQ8i25; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io > > It looks like instead of moving the common code to > EObjNameSpaceStandard namespace or a new (Arch? Common?) namespace, > you're renaming the entire EObjNameSpaceArm namespace to > EObjNameSpaceArch. It seems to me that if ARM code vs. common code is > being separated out, then the EObjNameSpaceArm namespace should > continue to be used for the ARM-specific code and a common namespace > should be used for the common code. >=20 > I agree. I started with separating common things into new common space an= d > create one for risc-v. However, I dropped that approach for two reasons. >=20 > 1) The commit "b2bbe3df5470 DynamicTablesPkg: Remove PPTT ID structure > from ACPI 6.4 generator" when removed one of the enums from > ArmObjectID, didn't change the other values for other enums but reserved = the > removed one. So, I thought there may be some assumptions which will break > if the enum value changes. I'm not familiar with why that was done. Hopefully someone else can comment= . I do know that edk2/DynamicTablesPkg/Library/Common/TableHelperLib/Config= urationManagerObjectParser.c has arrays (StdNamespaceObjectParser and ArmNa= mespaceObjectParser) that need to be kept in sync with all of the namespace= enums, but other than that I'm not aware of any places that need to be cha= nges when the enums are changed. > 2) DynamicPlatformRepositoryInfo structure has ArmCmObjList and > ArmCmObjArray. With separate spaces for Arm, RiscV and Common, list > management needs some redesign and I was not sure it is worth it. >=20 > Hence, I thought a single list of all possible Obj Ids for all architectu= res and > common things would be a good trade off. But I can go back to that approa= ch > in v2 if above issues are fine. Hopefully ARM can give input on the best direction before you make more cha= nges. The DynamicPlatRepo currently only supports the ARM namespace, but co= mments such as "only Arm objects are supported for now." (line 144) seem to= imply that support for more namespaces was considered. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113542): https://edk2.groups.io/g/devel/message/113542 Mute This Topic: https://groups.io/mt/103622702/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-