From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::541; helo=mail-pg1-x541.google.com; envelope-from=haojian.zhuang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6D48C21959CB2 for ; Wed, 15 Aug 2018 18:50:10 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id h12-v6so1295122pgs.3 for ; Wed, 15 Aug 2018 18:50:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:thread-topic:thread-index:date:message-id :references:in-reply-to:accept-language:content-language :mime-version; bh=nw0bQZkpcTmzRjU5icTeE4mMGvuQikbq1V9XzTIKf5M=; b=jm+v7+MZUZ61DLe3HJUWPS18pGmPJ/O7F6loDmXbRzcKMhw7QSlWFq/0QChE9rb/vl AgT6jB0VgI/P2HwYuXoRnD4EDiuQvFskvPo9pObCIT2Mnf5hoj3uAeadOBQH6ruQfGJo ky7+C9auPUa2CUDPPpoZ82Iakh0GZjEkv247M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:thread-topic:thread-index :date:message-id:references:in-reply-to:accept-language :content-language:mime-version; bh=nw0bQZkpcTmzRjU5icTeE4mMGvuQikbq1V9XzTIKf5M=; b=sF5On3tteIYNGosZqWtHAanJCJMlQaH0k6kKadrI/nJsD3hdmE36tk+LP/aI8F05mq jVGYtNpo5Y2BPdTqWWo9OVjotMGalZxuO6fMaXSCxQfhBPVvRpFFAtr0qsP9HgkggmBv ofntZH2lAkvHKpO2ShdkUq3LBgAk87mGupT1KhE5lWS47ee8tTs2sDAoG2WJeuEGC8lb Mgv/qDmXXOrLRJOyqNHcp8KUdZBSKwifIHl64rDWqJUrVXie19HMhrFJCaFdeeHuxlnd J9Ei9KdPqKURza33PRSpO2AM32IgDAmC+DhvydrOETeGpYL+xSRdpR/vTi8KYOw6avXp EvgA== X-Gm-Message-State: AOUpUlFm1yFn0T/ymlGFh2XBr0wdzbVY7Wvix/Ikjj/oAMTfZHW+bBDb dKWZpXaLX72EUtuGQDi/bQWnCM/VBGk= X-Google-Smtp-Source: AA+uWPxepXfUFsPLHJYwUtbN8t0h9mxVhj9AeLQkU0guFzh3C7SpsJZc0seJNjdEj+gHfc3+22dJLQ== X-Received: by 2002:a62:95d1:: with SMTP id c78-v6mr30372314pfk.130.1534384210112; Wed, 15 Aug 2018 18:50:10 -0700 (PDT) Received: from DM6PR15MB2508.namprd15.prod.outlook.com ([52.96.4.133]) by smtp.gmail.com with ESMTPSA id i25-v6sm48367101pfi.150.2018.08.15.18.50.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Aug 2018 18:50:09 -0700 (PDT) From: Haojian Zhuang To: Leif Lindholm CC: "edk2-devel@lists.01.org" , Ard Biesheuvel Thread-Topic: [edk2][PATCH v1 edk-platforms 1/3] Silicon/Hi3660: fix LDO9_VSET register definition Thread-Index: AQHUMItyMrDLeVUDE0W2uQPKYUWxtaTA1uOAgADO3+M= X-MS-Exchange-MessageSentRepresentingType: 2 Date: Thu, 16 Aug 2018 01:50:07 +0000 Message-ID: References: <1533890975-13055-1-git-send-email-haojian.zhuang@linaro.org> <1533890975-13055-2-git-send-email-haojian.zhuang@linaro.org>, <20180815132927.33dhuiefcxo2dz4b@bivouac.eciton.net> In-Reply-To: <20180815132927.33dhuiefcxo2dz4b@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-Exchange-Organization-SCL: -1 X-MS-TNEF-Correlator: X-MS-Exchange-Organization-RecordReviewCfmType: 0 MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.27 Subject: Re: [PATCH v1 edk-platforms 1/3] Silicon/Hi3660: fix LDO9_VSET register definition X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Aug 2018 01:50:10 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Fixed. Best Regards Haojian ________________________________ From: Leif Lindholm Sent: Wednesday, August 15, 2018 9:29:27 PM To: Haojian Zhuang Cc: edk2-devel@lists.01.org; Ard Biesheuvel Subject: Re: [edk2][PATCH v1 edk-platforms 1/3] Silicon/Hi3660: fix LDO9_VS= ET register definition Hi Haojian, On Fri, Aug 10, 2018 at 04:49:33PM +0800, Haojian Zhuang wrote: > Fix the LDO9_VSET register definition in PMIC. Could you add some more detail to the commit message, please?: What register was accidentally read/written before? Does this change resolve a user-visible issue or just a hypothetical one? / Leif > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Haojian Zhuang > --- > Silicon/Hisilicon/Hi3660/Include/Hi3660.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Silicon/Hisilicon/Hi3660/Include/Hi3660.h b/Silicon/Hisilico= n/Hi3660/Include/Hi3660.h > index 5fbf32267657..6e0587f7783a 100644 > --- a/Silicon/Hisilicon/Hi3660/Include/Hi3660.h > +++ b/Silicon/Hisilicon/Hi3660/Include/Hi3660.h > @@ -58,7 +58,7 @@ > #define USB3OTG_PHY_CR_CAP_ADDR (1 << 0) > > #define PMU_REG_BASE 0xFFF34000 > -#define PMIC_LDO9_VSET_REG (PMU_REG_BASE + (0x068 <= < 2)) > +#define PMIC_LDO9_VSET_REG (PMU_REG_BASE + (0x06b <= < 2)) > #define LDO9_VSET_MASK (7 << 0) > > #define PMIC_LDO16_ONOFF_ECO_REG (PMU_REG_BASE + (0x078 <= < 2)) > -- > 2.7.4 >