From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 03028740041 for ; Fri, 28 Jul 2023 05:42:56 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=lFGQx4/lIgOM2HGaefP8AdBsYibOvAzJ7M/eFsgYF0w=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:X-IronPort-AV:X-IronPort-AV:X-Received:X-ExtLoop1:X-IronPort-AV:X-IronPort-AV:X-Received:X-Received:X-Received:X-Received:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:X-Received:X-Received:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:x-ms-publictraffictype:x-ms-traffictypediagnostic:x-ms-office365-filtering-correlation-id:x-ms-exchange-senderadcheck:x-ms-exchange-antispam-relay:x-microsoft-antispam-message-info:x-ms-exchange-antispam-messagedata-chunkcount:x-ms-exchange-antispam-messagedata-0:MIME-Version:X-MS-Exchange-CrossTenant-AuthAs:X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-Network-Message-Id:X-MS-Exchange-CrossTenant-originalarrivaltime:X-MS-Exchange-CrossTenant-fromentityheader:X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:X-MS-Exchange-CrossTenant-userprincipalname:X-MS-Exchange-Transport-CrossTenantHeaders Stamped:X-OriginatorOrg:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:X-Gm-Message-State:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1690522975; v=1; b=v7syoRY/tvHkgU02sCIl+SakHFyLuq0AKka35HhOm1+2XFWgRTccjMHAq0rd8dkqZZEr8a7a R3hBpyj/msL8QFz7M2mSlmolsSx6Ah7aQ4T3Jpl5mTFdQDd0DeBfEitS/5awC4MyyFEBLpQlDsP IhWraV04wi4GTPYb8JmD4Gq4= X-Received: by 127.0.0.2 with SMTP id k2bjYY7687511xlRREOpTE3v; Thu, 27 Jul 2023 22:42:55 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.26714.1690522974551242553 for ; Thu, 27 Jul 2023 22:42:55 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10784"; a="365972226" X-IronPort-AV: E=Sophos;i="6.01,236,1684825200"; d="scan'208";a="365972226" X-Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2023 22:42:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10784"; a="1057995830" X-IronPort-AV: E=Sophos;i="6.01,236,1684825200"; d="scan'208";a="1057995830" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga005.fm.intel.com with ESMTP; 27 Jul 2023 22:42:53 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 27 Jul 2023 22:42:53 -0700 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Thu, 27 Jul 2023 22:42:53 -0700 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Thu, 27 Jul 2023 22:42:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TVedF/WGBV+CY6D28I1Q4Dz36i/nw8iPYScZgK2EOWN39pwiK49667V4dHuQncQsZy+c5ubpa/3Xf8cRtm/1ZqY3Mja8Yd73gKTylDrjWO4HDm931wKmVIa/muvIdLmj5s1/vgw1LDQPaLyv964/FIUdVO+4eV1RsTqBCXfG7KiM7V8cCw8tpWFic4Ynt4vIFGnw58m6yDuVtS4aZ29SfqYmtgIKTHnNTPFf1SS78az0r50ZUr2gZeDJ7djiT9nVlT9l9HuNRpgeMpEuElsDtE146KZwwdoX4gtCoLaRRWLJW08EdLACpC5yvh/P7kOL2BcNXga86CNES0VGabWYAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PSXEs1QeVpihP9mr0FtMPWWOsZfpbSRT0oBbbs5ZPZE=; b=TOQGCRIPV72TQNqh7yfE1vuRfs6Fv1BvoEyBr1l2beep5J0VjT3e7yg1+FShtrTrIpLwOtx3rRFQzHqVIgEfzxr3bsB6A26TkT4yab91maMgIpru+gLyQ71ope5hUcyFzi2QEjLuObUVowhdsmcXkAxMBuHTD4hoK1d3P95ep6uLDP9tEKjwjc7uRa0d66AG6rAoEtOXiTAr5USzkJ3oLmGV0at0tkfh/uZewqBJR0ovfWG/ZvX2+Fi0Kaa80lYpl9UrH925ih10ucD1oguKWKH9lEhrbnJMor2M/c2Pi0TxYYCz1o9JiY5NW0IKCtzNXNAaTgqoDJdUx7Q8bitMXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from DM8PR11MB5623.namprd11.prod.outlook.com (2603:10b6:8:25::20) by IA1PR11MB6148.namprd11.prod.outlook.com (2603:10b6:208:3ec::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Fri, 28 Jul 2023 05:42:51 +0000 X-Received: from DM8PR11MB5623.namprd11.prod.outlook.com ([fe80::a823:227f:31ed:a5b4]) by DM8PR11MB5623.namprd11.prod.outlook.com ([fe80::a823:227f:31ed:a5b4%4]) with mapi id 15.20.6631.026; Fri, 28 Jul 2023 05:42:50 +0000 From: "Zeng, Star" To: "Xie, Yuanhao" CC: "Dong, Eric" , "Ni, Ray" , "Kumar, Rahul R" , Gerd Hoffmann , "devel@edk2.groups.io" , "Zeng, Star" Subject: Re: [edk2-devel] [Patch V4 2/4] UefiCpuPkg: Add PcdFirstTimeWakeUpAPsBySipi Thread-Topic: [Patch V4 2/4] UefiCpuPkg: Add PcdFirstTimeWakeUpAPsBySipi Thread-Index: AQHZwRL2jP+w119yqUGHXqQoCoBWkq/OpM3ggAAE1dA= Date: Fri, 28 Jul 2023 05:42:50 +0000 Message-ID: References: <20230728051805.6250-1-yuanhao.xie@intel.com> <20230728051805.6250-3-yuanhao.xie@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8PR11MB5623:EE_|IA1PR11MB6148:EE_ x-ms-office365-filtering-correlation-id: 30a8080f-a5b6-4e1a-1854-08db8f2d7b20 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: x3XLViE6pVioW0xEPczCTJHqF65M97tp/ofdqKlciHGyxGzvE+F6wctJeAjCp4ddFob7kTassJ7CRWTTnf3t2SWy7/d/kIJeriH33SrohDoPhuyBc2w+oZRWk8G9afjE6QWoYPlKdY9Cvtwnr2zSAmv4UxA04XibF74d/GifY7PoPmcmR94UBwDMlk5iWtM7y9RxBVquJWBjRUD81Dwr9LJJsJYBAUxbZja7BJUwFHULbXbCC4+PUKhIqsox6WB+ZB/xm6swWU1W0lvXYOeAVRXBjYn2saxMgQLUyAdUgj+sL0Bh7nsF6VLCSwOH0Q97dGWu0tYAX571X/aHSd8Xf2FLh2o0Z+3OAK/Rx579jmaYjQQ5w4t/IuRg1/gvu6a8C49r4hwzExfYjpyZGdZ1++gXo2Sxz6uE9bmcbdBZ+Kte4I1i8jQRSH0jZTR7KeqDKKDXJ6XMFTBh/FoNDC8V7X5rs0B4INwwQ9+MxGXEDJRD/F+acB743WMRig/MDtB5Z27YLrVMTVRaDVD8vZxnq9utK1gVO7biaAKU+dmWxVKLCncWrzbjxoX7ou+iGCe2Gk/ElSKbZM5rjbL/QbYyltOpVBz+ALly1mPUdOLkAEHLBQehhG3slJkddh95mMBGiDiMzV8/OicRTDGmdSnXUA== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5k2bz74yGeTHJYYYu+FgaT79Bu2QqeNfenCAGGNsxn8NaJZXt/N8ZGVqbNTZ?= =?us-ascii?Q?vAVTjb6rywTikKzAYzIrnXlaqi9tyVruP3DsoImftbnWTSrb/HKi5pQ/9IdK?= =?us-ascii?Q?tXyxkraPIeYjzU/l7DLqTvb1BbeaMln5amRYCW0OAdKubAN/uRXreiNFzV9s?= =?us-ascii?Q?D+6yakjk7OjOTg0fwwAY2/y5xdkpeZCArL7L+Fqkpy6/GeDaHpZC/OMB425w?= =?us-ascii?Q?dl7RzRYTDolG39vVocPtyOLvad2T5AwQDydYDldEMniuGQcgz+7Q2ugh2Qwa?= =?us-ascii?Q?T38x5v0c7bAwKnXaR7rDK4NFYOw5+/NpyQD2WzXhKT975AVXTKEzPuTxMLCO?= =?us-ascii?Q?6xZCQ5+Cg2hp+ykUwht1+wpVGoSGkHPJ6f4oZBNFuj3UTImEM/JEMYpB6kQ9?= =?us-ascii?Q?bsZNVUke9x8tVEqDPkARNz4D4UqEQ/A8wG5SqZ+UMYM17q7Z6aO++pu3S1kU?= =?us-ascii?Q?arXluPlYVXRv2HNMQz5GHTGsQqge3aYNp6CuTpfKUC3/nxduXiCMkFtAXFT/?= =?us-ascii?Q?GN53ApK2Q443nwe+dEsmsPq12y/NE7L2AAAoGmvxDR6ZfyJp2J4KdO81RIFo?= =?us-ascii?Q?UpFcbCYg06Emg9cmELCsoduTwPnRcYKwYMG4myC8UVUmkPB+iV83/AolNFQ9?= =?us-ascii?Q?BjXBTvBv0EMqU2mvvDYq/a/oxK7j3DIup+T2LUIDeK7MEM0IOdGaW/HBupNi?= =?us-ascii?Q?lZdy2sX1LQlQN/hLVdO1bIRvN7aa/qzpER5bXR+cAk/ZgkrYsmEBZ1MKEKq7?= =?us-ascii?Q?m/4n2CEGvXul2iAoHc4dN4YOBvhDXmdc3ojQNRKgKoGCu5PW2lzyp6kGKtcl?= =?us-ascii?Q?WtxmRwp/7aHyBJwjvVe4gykBmGumy1anPgmWw6yNpmeUkKm1OgUNak5tfDXU?= =?us-ascii?Q?L6o+gcPwmO6jfNyBs6djJ6sCedF69ORCwWuKAOZqOpYdacQcGQdn1nAe6VF/?= =?us-ascii?Q?ScRmReSWAh8Ize0nXZMxV2HpIy9kQZFwDEgYhfEAPq+UP4TnAB2lPsZ9Ylj1?= =?us-ascii?Q?CRmKzkRvwHtx45plgkRfW/WSS7/yDiLKhyLcASyvJcNWQS4PVsGR4M6piiVs?= =?us-ascii?Q?0mN2+fPRKtkOHIgjqZeKxX9uShaP5vthQyoGk7ncJ+j1/CAV77BvTZpOlUIR?= =?us-ascii?Q?Ho2dXLeMfKBbCT3cJ380PiIU6zZUyP7GrdfXJsB/u6llIiBTWyDv0bYKmyjj?= =?us-ascii?Q?YjtZ6cnoEsaGGA0Kpg85uNKz7x6ZdMr1D7dsDxZP7eeUiSuYmD3S8tAk1bDa?= =?us-ascii?Q?Ubml+bzbUrrOK+qnx/V6WS9RVKzVKUQxH1P6QyEl0hst8a2YkXzoqJ4oEmpV?= =?us-ascii?Q?zjhmSTLayEECkw3Xj+FmtOsKnJeZAV1L1Oz7ZgE2JZAP6k0GBFuSsxCY/xG2?= =?us-ascii?Q?OYmlofis0uo5YW4qwAW/OfMEll949aghGuGINNvV5qJz+wLwVRjSOingoUVx?= =?us-ascii?Q?STfJ2446F87P1GyLsaeY6anK+WoH2JIe6PzwjjYWAo81uY0dixZSuIyb5XM7?= =?us-ascii?Q?Yc1K2R3BiCtDhP97NNwWJgasDHKiqeTBhmpj0/PRnCB6yMZ1PSJ3pXvCenqt?= =?us-ascii?Q?LiwUUQb8T0iupU9Xh1NDn1DTOARRvUGomAhXRvzu?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5623.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 30a8080f-a5b6-4e1a-1854-08db8f2d7b20 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2023 05:42:50.4839 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DIAXGI+7s9GwIKczJe7ir0mshomGHC7JrCX+MzKottULdOHbERIg4+VFR6eQXAK/dkmNRb2nuU/WGxIOZTpWqw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6148 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,star.zeng@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: BtIE4XDKxXiUinwx5scrAeDfx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="v7syoRY/"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Would like to highlight it is for first time. " Determining Whether APs Awakened from SIPI or INIT-SIPI-SIPI" to "Determi= ning APs first time wakeup by SIPI or INIT-SIPI-SIPI" or similar. " BSP Broadcast Method" -> " BSP Broadcast Method for first time AP wakeup"= or similar. Thanks, Star -----Original Message----- From: Xie, Yuanhao =20 Sent: Friday, July 28, 2023 1:24 PM To: Zeng, Star Cc: Dong, Eric ; Ni, Ray ; Kumar, Ra= hul R ; Gerd Hoffmann ; devel@e= dk2.groups.io Subject: RE: [Patch V4 2/4] UefiCpuPkg: Add PcdFirstTimeWakeUpAPsBySipi Hi Star, Could you please review this patch, I have made updates to the comments for= : Do we really want to mention OVMF specifically in UefiCpuPkg.dec PCD defin= ition ? Those comments may be better to be in OVMF dsc PCD override. =20 Thanks for the feedback Yuanhao -----Original Message----- From: Xie, Yuanhao Sent: Friday, July 28, 2023 1:18 PM To: devel@edk2.groups.io Cc: Dong, Eric ; Ni, Ray ; Kumar, Ra= hul R ; Gerd Hoffmann ; Xie, Yu= anhao Subject: [Patch V4 2/4] UefiCpuPkg: Add PcdFirstTimeWakeUpAPsBySipi Add PcdFirstTimeWakeUpAPsBySipi to check if it is in the OVMF environment = and necessary to wake up APs by INIT-SIPI-SIPI. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Yuanhao Xie Reviewed-by: Ray Ni --- UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 + UefiCpuPkg/Library/M= pInitLib/PeiMpInitLib.inf | 1 + UefiCpuPkg/UefiCpuPkg.dec | 11 +++++++++++ 3 files changed, 13 insertions(+) diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf b/UefiCpuPkg/Lib= rary/MpInitLib/DxeMpInitLib.inf index 7d45d3ad4d..55e46d4a1f 100644 --- a/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf +++ b/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf @@ -81,6 +81,7 @@ gUefiCpuPkgTokenSpaceGuid.PcdCpuApStatusCheckIntervalInMicroSeconds ## = CONSUMES gUefiCpuPkgTokenSpaceGuid.PcdGhcbHypervisorFeatures ## = CONSUMES gUefiCpuPkgTokenSpaceGuid.PcdSevEsWorkAreaBase ## = SOMETIMES_CONSUMES + gUefiCpuPkgTokenSpaceGuid.PcdFirstTimeWakeUpAPsBySipi ## = CONSUMES gEfiMdeModulePkgTokenSpaceGuid.PcdCpuStackGuard ## = CONSUMES gEfiMdeModulePkgTokenSpaceGuid.PcdGhcbBase ## = CONSUMES gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr ## = CONSUMES diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf b/UefiCpuPkg/Lib= rary/MpInitLib/PeiMpInitLib.inf index 83e9028d0f..bc3d716aa9 100644 --- a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf +++ b/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf @@ -66,6 +66,7 @@ gUefiCpuPkgTokenSpaceGuid.PcdCpuApTargetCstate ## SOME= TIMES_CONSUMES gUefiCpuPkgTokenSpaceGuid.PcdSevEsWorkAreaBase ## SOME= TIMES_CONSUMES gUefiCpuPkgTokenSpaceGuid.PcdGhcbHypervisorFeatures ## CONS= UMES + gUefiCpuPkgTokenSpaceGuid.PcdFirstTimeWakeUpAPsBySipi ## CON= SUMES gEfiMdeModulePkgTokenSpaceGuid.PcdGhcbBase ## CONS= UMES gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr ## CONS= UMES =20 diff --git a/UefiCpuPkg/UefiCpuPkg.dec b/UefiCpuPkg/UefiCpuPkg.dec index e7= 726a605c..fcfbd618dc 100644 --- a/UefiCpuPkg/UefiCpuPkg.dec +++ b/UefiCpuPkg/UefiCpuPkg.dec @@ -214,6 +214,17 @@ # @Prompt Configure the SEV-ES work area base gUefiCpuPkgTokenSpaceGuid.PcdSevEsWorkAreaSize|0x0|UINT32|0x30002006 =20 + ## Determining Whether APs Awakened from SIPI or INIT-SIPI-SIPI. + # Following a power-up or RESET of an MP system, The APs complete a #=20 + minimal self-configuration, then wait for a startup signal (a SIPI #=20 + message) from the BSP processor. + # + # TRUE - Broadcast SIPI. + # FALSE - Broadcast INIT-SIPI-SIPI. + # + # @Prompt BSP Broadcast Method. + =20 + gUefiCpuPkgTokenSpaceGuid.PcdFirstTimeWakeUpAPsBySipi|TRUE|BOOLEAN|0x3 + 0002007 + [PcdsFixedAtBuild, PcdsPatchableInModule] ## This value is the CPU Local APIC base address, which aligns the addre= ss on a 4-KByte boundary. # @Prompt Configure base address of CPU Local APIC -- 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107323): https://edk2.groups.io/g/devel/message/107323 Mute This Topic: https://groups.io/mt/100405492/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-