From: "Zeng, Star" <star.zeng@intel.com>
To: "Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>,
"S, Ashraf Ali" <ashraf.ali.s@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Chiu, Chasel" <chasel.chiu@intel.com>,
"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH] [IntelFsp2Pkg]: Fix GCC Compiler warning
Date: Fri, 10 Mar 2023 01:30:59 +0000 [thread overview]
Message-ID: <DM8PR11MB56236B9F59DB7F125E73F535E3BA9@DM8PR11MB5623.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MW4PR11MB5776DE278F2197DA4D470556B6BA9@MW4PR11MB5776.namprd11.prod.outlook.com>
Reviewed-by: Star Zeng <star.zeng@intel.com> with typo defination -> definition fixed in commit message.
-----Original Message-----
From: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
Sent: Friday, March 10, 2023 8:27 AM
To: S, Ashraf Ali <ashraf.ali.s@intel.com>; devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: RE: [PATCH] [IntelFsp2Pkg]: Fix GCC Compiler warning
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>
-----Original Message-----
From: S, Ashraf Ali <ashraf.ali.s@intel.com>
Sent: Thursday, March 09, 2023 8:06 AM
To: devel@edk2.groups.io
Cc: S, Ashraf Ali <ashraf.ali.s@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: [PATCH] [IntelFsp2Pkg]: Fix GCC Compiler warning
Function defination should match with declaration.
[-Wlto-type-mismatch]
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Signed-off-by: Ashraf Ali S <ashraf.ali.s@intel.com>
---
IntelFsp2Pkg/Library/BaseFspPlatformLib/FspPlatformNotify.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/IntelFsp2Pkg/Library/BaseFspPlatformLib/FspPlatformNotify.c b/IntelFsp2Pkg/Library/BaseFspPlatformLib/FspPlatformNotify.c
index 795bb28c0f..a5a51c804c 100644
--- a/IntelFsp2Pkg/Library/BaseFspPlatformLib/FspPlatformNotify.c
+++ b/IntelFsp2Pkg/Library/BaseFspPlatformLib/FspPlatformNotify.c
@@ -296,6 +296,7 @@ FspTempRamExitDone2 (
**/
VOID
+EFIAPI
FspWaitForNotify (
VOID
)
--
2.38.1.windows.1
next prev parent reply other threads:[~2023-03-10 1:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 16:05 [PATCH] [IntelFsp2Pkg]: Fix GCC Compiler warning Ashraf Ali S
2023-03-09 17:06 ` Chiu, Chasel
2023-03-10 0:21 ` Nate DeSimone
2023-03-10 0:27 ` Chaganty, Rangasai V
2023-03-10 1:30 ` Zeng, Star [this message]
2023-03-10 3:20 ` Chiu, Chasel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8PR11MB56236B9F59DB7F125E73F535E3BA9@DM8PR11MB5623.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox