Re: [edk2-devel] [PATCH v1 1/1] MdePkg/Include/IndustryStandard/SmBios.h: Add New Intel Processor family for SMBIOS Type 4 from SMBIOS 3.7.0

["Zeng, Star" <star.zeng@intel.com>]

Reviewed-by: Star Zeng <star.zeng@intel.com>

BTW: You'd better to have a separated patch to also update https://github.com/tianocore/edk2/blob/master/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c#L1713.

-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn> 
Sent: Tuesday, September 5, 2023 10:29 AM
To: devel@edk2.groups.io; Bhargava, Avinash <avinash.bhargava@intel.com>
Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Zeng, Star <star.zeng@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
Subject: 回复: [edk2-devel] [PATCH v1 1/1] MdePkg/Include/IndustryStandard/SmBios.h: Add New Intel Processor family for SMBIOS Type 4 from SMBIOS 3.7.0

Avi:
  The change is good.  Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
  
  But, I have one minor comment. Please see below. 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Avinash
> 发送时间: 2023年9月2日 2:21
> 收件人: devel@edk2.groups.io
> 抄送: avinashbhargava <avinash.bhargava@intel.com>; Zhiguang Liu 
> <zhiguang.liu@intel.com>; Dandan Bi <dandan.bi@intel.com>; Star Zeng 
> <star.zeng@intel.com>; Zhichao Gao <zhichao.gao@intel.com>
> 主题: [edk2-devel] [PATCH v1 1/1]
> MdePkg/Include/IndustryStandard/SmBios.h: Add New Intel Processor 
> family for SMBIOS Type 4 from SMBIOS 3.7.0
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4547
> 
> Add New Intel Processor family for SMBIOS Type 4 from SMBIOS 3.7.0 Hex 
> value - 16h Name - Intel® Processor

[Liming] Please remove non ascii char ® in the commit message. 

Thanks
Liming
> 
> Signed-off-by: avinashbhargava <avinash.bhargava@intel.com>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> ---
>  MdePkg/Include/IndustryStandard/SmBios.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> b/MdePkg/Include/IndustryStandard/SmBios.h
> index 40bdc9a937c0..56cec615a010 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -554,6 +554,7 @@ typedef enum {
>    ProcessorFamilyM2                              = 0x13,
> 
>    ProcessorFamilyIntelCeleronM                   = 0x14,
> 
>    ProcessorFamilyIntelPentium4Ht                 = 0x15,
> 
> +  ProcessorFamilyIntel                           = 0x16,
> 
>    ProcessorFamilyAmdDuron                        = 0x18,
> 
>    ProcessorFamilyK5                              = 0x19,
> 
>    ProcessorFamilyK6                              = 0x1A,
> 
> --
> 2.37.3.windows.1
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108273): https://edk2.groups.io/g/devel/message/108273
Mute This Topic: https://groups.io/mt/101162402/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-