[edk2-devel] [PATCH V2 0/2] Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0

[edk2-devel] [PATCH V2 0/2] Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0

[Eduardo Cuevas Farfan]

Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0 to edk2 sources

Eduardo Cuevas Farfan (2):
  MdePkg: Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0
  ShellPkg: Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0

 MdePkg/Include/IndustryStandard/SmBios.h      | 12 +++++--
 .../SmbiosView/QueryTable.c                   | 34 ++++++++++++++++++-
 2 files changed, 43 insertions(+), 3 deletions(-)

-- 
2.26.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107694): https://edk2.groups.io/g/devel/message/107694
Mute This Topic: https://groups.io/mt/100667108/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH V2 1/2] MdePkg: Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0

[Eduardo Cuevas Farfan]

This patch adds below definitions from SMBIOS 3.7.0 into Smbios.h
- ProcessorUpgradeSocketAM5
- ProcessorUpgradeSocketSP5
- ProcessorUpgradeSocketSP6
- ProcessorUpgradeSocketBGA883
- ProcessorUpgradeSocketBGA1190
- ProcessorUpgradeSocketBGA4129
- ProcessorUpgradeSocketLGA4710
- ProcessorUpgradeSocketLGA7529

Signed-off-by: Eduardo Cuevas Farfan <eduardo.cuevas.farfan@intel.com>
---
 MdePkg/Include/IndustryStandard/SmBios.h | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h
index 89985bb4186b..fb6ed2dee051 100644
--- a/MdePkg/Include/IndustryStandard/SmBios.h
+++ b/MdePkg/Include/IndustryStandard/SmBios.h
@@ -1,7 +1,7 @@
 /** @file
   Industry Standard Definitions of SMBIOS Table Specification v3.6.0.
 
-Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2006 - 2023, Intel Corporation. All rights reserved.<BR>
 (C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP<BR>
 (C) Copyright 2015 - 2019 Hewlett Packard Enterprise Development LP<BR>
 Copyright (c) 2022, AMD Incorporated. All rights reserved.<BR>
@@ -863,7 +863,15 @@ typedef enum {
   ProcessorUpgradeSocketLGA1211   = 0x45,
   ProcessorUpgradeSocketLGA2422   = 0x46,
   ProcessorUpgradeSocketLGA5773   = 0x47,
-  ProcessorUpgradeSocketBGA5773   = 0x48
+  ProcessorUpgradeSocketBGA5773   = 0x48,
+  ProcessorUpgradeSocketAM5       = 0x49,
+  ProcessorUpgradeSocketSP5       = 0x4A,
+  ProcessorUpgradeSocketSP6       = 0x4B,
+  ProcessorUpgradeSocketBGA883    = 0x4C,
+  ProcessorUpgradeSocketBGA1190   = 0x4D,
+  ProcessorUpgradeSocketBGA4129   = 0x4E,
+  ProcessorUpgradeSocketLGA4710   = 0x4F,
+  ProcessorUpgradeSocketLGA7529   = 0x50
 } PROCESSOR_UPGRADE;
 
 ///
-- 
2.26.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107695): https://edk2.groups.io/g/devel/message/107695
Mute This Topic: https://groups.io/mt/100667109/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH V2 2/2] ShellPkg: Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0

[Eduardo Cuevas Farfan]

This patch adds below definitions from SMBIOS 3.7.0 into QueryTable.c
- ProcessorUpgradeSocketAM5
- ProcessorUpgradeSocketSP5
- ProcessorUpgradeSocketSP6
- ProcessorUpgradeSocketBGA883
- ProcessorUpgradeSocketBGA1190
- ProcessorUpgradeSocketBGA4129
- ProcessorUpgradeSocketLGA4710
- ProcessorUpgradeSocketLGA7529

Signed-off-by: Eduardo Cuevas Farfan <eduardo.cuevas.farfan@intel.com>
---
 .../SmbiosView/QueryTable.c                   | 34 ++++++++++++++++++-
 1 file changed, 33 insertions(+), 1 deletion(-)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
index 29b5a2900150..82bb7a41f0e6 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
@@ -2,7 +2,7 @@
   Build a table, each item is (Key, Info) pair.
   And give a interface of query a string out of a table.
 
-  Copyright (c) 2005 - 2021, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2005 - 2023, Intel Corporation. All rights reserved.<BR>
   (C) Copyright 2016-2019 Hewlett Packard Enterprise Development LP<BR>
   Copyright (c) 2023 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
   SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -638,6 +638,38 @@ TABLE_ITEM  ProcessorUpgradeTable[] = {
   {
     0x48,
     L"Socket BGA5773"
+  },
+  {
+    0x49,
+    L"Socket AM5"
+  },
+  {
+    0x4A,
+    L"Socket SP5"
+  },
+  {
+    0x4B,
+    L"Socket SP6"
+  },
+  {
+    0x4C,
+    L"Socket BGA883"
+  },
+  {
+    0x4D,
+    L"Socket BGA1190"
+  },
+  {
+    0x4E,
+    L"Socket BGA4129"
+  },
+  {
+    0x4F,
+    L"Socket LGA4710"
+  },
+  {
+    0x50,
+    L"Socket LGA7529"
   }
 };
 
-- 
2.26.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107696): https://edk2.groups.io/g/devel/message/107696
Mute This Topic: https://groups.io/mt/100667110/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH V2 1/2] MdePkg: Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0

[Zeng, Star]

Reviewed-by: Star Zeng <star.zeng@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Eduardo Cuevas Farfan
Sent: Friday, August 11, 2023 12:32 AM
To: devel@edk2.groups.io
Cc: Cuevas Farfan, Eduardo <eduardo.cuevas.farfan@intel.com>
Subject: [edk2-devel] [PATCH V2 1/2] MdePkg: Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0

This patch adds below definitions from SMBIOS 3.7.0 into Smbios.h
- ProcessorUpgradeSocketAM5
- ProcessorUpgradeSocketSP5
- ProcessorUpgradeSocketSP6
- ProcessorUpgradeSocketBGA883
- ProcessorUpgradeSocketBGA1190
- ProcessorUpgradeSocketBGA4129
- ProcessorUpgradeSocketLGA4710
- ProcessorUpgradeSocketLGA7529

Signed-off-by: Eduardo Cuevas Farfan <eduardo.cuevas.farfan@intel.com>
---
 MdePkg/Include/IndustryStandard/SmBios.h | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h
index 89985bb4186b..fb6ed2dee051 100644
--- a/MdePkg/Include/IndustryStandard/SmBios.h
+++ b/MdePkg/Include/IndustryStandard/SmBios.h
@@ -1,7 +1,7 @@
 /** @file

   Industry Standard Definitions of SMBIOS Table Specification v3.6.0.

 

-Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.<BR>

+Copyright (c) 2006 - 2023, Intel Corporation. All rights reserved.<BR>

 (C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP<BR>

 (C) Copyright 2015 - 2019 Hewlett Packard Enterprise Development LP<BR>

 Copyright (c) 2022, AMD Incorporated. All rights reserved.<BR>

@@ -863,7 +863,15 @@ typedef enum {
   ProcessorUpgradeSocketLGA1211   = 0x45,

   ProcessorUpgradeSocketLGA2422   = 0x46,

   ProcessorUpgradeSocketLGA5773   = 0x47,

-  ProcessorUpgradeSocketBGA5773   = 0x48

+  ProcessorUpgradeSocketBGA5773   = 0x48,

+  ProcessorUpgradeSocketAM5       = 0x49,

+  ProcessorUpgradeSocketSP5       = 0x4A,

+  ProcessorUpgradeSocketSP6       = 0x4B,

+  ProcessorUpgradeSocketBGA883    = 0x4C,

+  ProcessorUpgradeSocketBGA1190   = 0x4D,

+  ProcessorUpgradeSocketBGA4129   = 0x4E,

+  ProcessorUpgradeSocketLGA4710   = 0x4F,

+  ProcessorUpgradeSocketLGA7529   = 0x50

 } PROCESSOR_UPGRADE;

 

 ///

-- 
2.26.2.windows.1



-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107695): https://edk2.groups.io/g/devel/message/107695
Mute This Topic: https://groups.io/mt/100667109/1779220
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [star.zeng@intel.com]
-=-=-=-=-=-=




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107775): https://edk2.groups.io/g/devel/message/107775
Mute This Topic: https://groups.io/mt/100667109/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH V2 2/2] ShellPkg: Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0

[Zeng, Star]

Reviewed-by: Star Zeng <star.zeng@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Eduardo Cuevas Farfan
Sent: Friday, August 11, 2023 12:32 AM
To: devel@edk2.groups.io
Cc: Cuevas Farfan, Eduardo <eduardo.cuevas.farfan@intel.com>
Subject: [edk2-devel] [PATCH V2 2/2] ShellPkg: Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0

This patch adds below definitions from SMBIOS 3.7.0 into QueryTable.c
- ProcessorUpgradeSocketAM5
- ProcessorUpgradeSocketSP5
- ProcessorUpgradeSocketSP6
- ProcessorUpgradeSocketBGA883
- ProcessorUpgradeSocketBGA1190
- ProcessorUpgradeSocketBGA4129
- ProcessorUpgradeSocketLGA4710
- ProcessorUpgradeSocketLGA7529

Signed-off-by: Eduardo Cuevas Farfan <eduardo.cuevas.farfan@intel.com>
---
 .../SmbiosView/QueryTable.c                   | 34 ++++++++++++++++++-
 1 file changed, 33 insertions(+), 1 deletion(-)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
index 29b5a2900150..82bb7a41f0e6 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
@@ -2,7 +2,7 @@
   Build a table, each item is (Key, Info) pair.

   And give a interface of query a string out of a table.

 

-  Copyright (c) 2005 - 2021, Intel Corporation. All rights reserved.<BR>

+  Copyright (c) 2005 - 2023, Intel Corporation. All rights reserved.<BR>

   (C) Copyright 2016-2019 Hewlett Packard Enterprise Development LP<BR>

   Copyright (c) 2023 NVIDIA CORPORATION & AFFILIATES. All rights reserved.

   SPDX-License-Identifier: BSD-2-Clause-Patent

@@ -638,6 +638,38 @@ TABLE_ITEM  ProcessorUpgradeTable[] = {
   {

     0x48,

     L"Socket BGA5773"

+  },

+  {

+    0x49,

+    L"Socket AM5"

+  },

+  {

+    0x4A,

+    L"Socket SP5"

+  },

+  {

+    0x4B,

+    L"Socket SP6"

+  },

+  {

+    0x4C,

+    L"Socket BGA883"

+  },

+  {

+    0x4D,

+    L"Socket BGA1190"

+  },

+  {

+    0x4E,

+    L"Socket BGA4129"

+  },

+  {

+    0x4F,

+    L"Socket LGA4710"

+  },

+  {

+    0x50,

+    L"Socket LGA7529"

   }

 };

 

-- 
2.26.2.windows.1



-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107696): https://edk2.groups.io/g/devel/message/107696
Mute This Topic: https://groups.io/mt/100667110/1779220
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [star.zeng@intel.com]
-=-=-=-=-=-=




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107776): https://edk2.groups.io/g/devel/message/107776
Mute This Topic: https://groups.io/mt/100667110/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH V2 0/2] Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0

[Zeng, Star]

I have given review to both patches and Zhichao has given review to ShellPkg patch.
Liming, need your help to review and merge the patches. 😊


Thanks,
Star
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Eduardo Cuevas Farfan
Sent: Friday, August 11, 2023 12:32 AM
To: devel@edk2.groups.io
Cc: Cuevas Farfan, Eduardo <eduardo.cuevas.farfan@intel.com>
Subject: [edk2-devel] [PATCH V2 0/2] Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0

Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0 to edk2 sources

Eduardo Cuevas Farfan (2):
  MdePkg: Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0
  ShellPkg: Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0

 MdePkg/Include/IndustryStandard/SmBios.h      | 12 +++++--
 .../SmbiosView/QueryTable.c                   | 34 ++++++++++++++++++-
 2 files changed, 43 insertions(+), 3 deletions(-)

-- 
2.26.2.windows.1








-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107842): https://edk2.groups.io/g/devel/message/107842
Mute This Topic: https://groups.io/mt/100667108/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH V2 0/2] Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0

[gaoliming via groups.io]

This patch seems a new feature to add new definition from SMBIOS 3.7.0. It is sent and reviewed after soft feature freeze. 

Based on the release rule, it will not be merged for this stable tag 202308. It can be merged after the stable tag is created. 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Zeng, Star
> 发送时间: 2023年8月18日 11:11
> 收件人: Gao, Liming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io;
> Cuevas Farfan, Eduardo <eduardo.cuevas.farfan@intel.com>
> 抄送: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; Zeng, Star
> <star.zeng@intel.com>
> 主题: Re: [edk2-devel] [PATCH V2 0/2] Add ProcessorUpgradeSocket
> definitions from SMBIOS 3.7.0
> 
> I have given review to both patches and Zhichao has given review to ShellPkg
> patch.
> Liming, need your help to review and merge the patches. 😊
> 
> 
> Thanks,
> Star
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Eduardo
> Cuevas Farfan
> Sent: Friday, August 11, 2023 12:32 AM
> To: devel@edk2.groups.io
> Cc: Cuevas Farfan, Eduardo <eduardo.cuevas.farfan@intel.com>
> Subject: [edk2-devel] [PATCH V2 0/2] Add ProcessorUpgradeSocket
> definitions from SMBIOS 3.7.0
> 
> Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0 to edk2 sources
> 
> Eduardo Cuevas Farfan (2):
>   MdePkg: Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0
>   ShellPkg: Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0
> 
>  MdePkg/Include/IndustryStandard/SmBios.h      | 12 +++++--
>  .../SmbiosView/QueryTable.c                   | 34
> ++++++++++++++++++-
>  2 files changed, 43 insertions(+), 3 deletions(-)
> 
> --
> 2.26.2.windows.1
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107844): https://edk2.groups.io/g/devel/message/107844
Mute This Topic: https://groups.io/mt/100816116/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH V2 0/2] Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0

[Zeng, Star]

Got it, thanks Liming. So we need wait until 2023-08-25, then you can help merge the patches. 😊

-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn> 
Sent: Friday, August 18, 2023 3:03 PM
To: devel@edk2.groups.io; Zeng, Star <star.zeng@intel.com>; Cuevas Farfan, Eduardo <eduardo.cuevas.farfan@intel.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
Subject: 回复: [edk2-devel] [PATCH V2 0/2] Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0

This patch seems a new feature to add new definition from SMBIOS 3.7.0. It is sent and reviewed after soft feature freeze. 

Based on the release rule, it will not be merged for this stable tag 202308. It can be merged after the stable tag is created. 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Zeng, Star
> 发送时间: 2023年8月18日 11:11
> 收件人: Gao, Liming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; 
> Cuevas Farfan, Eduardo <eduardo.cuevas.farfan@intel.com>
> 抄送: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang 
> <zhiguang.liu@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; Zeng, 
> Star <star.zeng@intel.com>
> 主题: Re: [edk2-devel] [PATCH V2 0/2] Add ProcessorUpgradeSocket 
> definitions from SMBIOS 3.7.0
> 
> I have given review to both patches and Zhichao has given review to 
> ShellPkg patch.
> Liming, need your help to review and merge the patches. 😊
> 
> 
> Thanks,
> Star
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Eduardo 
> Cuevas Farfan
> Sent: Friday, August 11, 2023 12:32 AM
> To: devel@edk2.groups.io
> Cc: Cuevas Farfan, Eduardo <eduardo.cuevas.farfan@intel.com>
> Subject: [edk2-devel] [PATCH V2 0/2] Add ProcessorUpgradeSocket 
> definitions from SMBIOS 3.7.0
> 
> Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0 to edk2 
> sources
> 
> Eduardo Cuevas Farfan (2):
>   MdePkg: Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0
>   ShellPkg: Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0
> 
>  MdePkg/Include/IndustryStandard/SmBios.h      | 12 +++++--
>  .../SmbiosView/QueryTable.c                   | 34
> ++++++++++++++++++-
>  2 files changed, 43 insertions(+), 3 deletions(-)
> 
> --
> 2.26.2.windows.1
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107846): https://edk2.groups.io/g/devel/message/107846
Mute This Topic: https://groups.io/mt/100818401/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH V2 0/2] Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0

[Zeng, Star]

Liming,

Need your help to review and merge this patch series after the code freeze.

Thanks,
Star
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Zeng, Star
Sent: Friday, August 18, 2023 7:34 PM
To: Gao, Liming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; Cuevas Farfan, Eduardo <eduardo.cuevas.farfan@intel.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: Re: [edk2-devel] [PATCH V2 0/2] Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0

Got it, thanks Liming. So we need wait until 2023-08-25, then you can help merge the patches. 😊

-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Friday, August 18, 2023 3:03 PM
To: devel@edk2.groups.io; Zeng, Star <star.zeng@intel.com>; Cuevas Farfan, Eduardo <eduardo.cuevas.farfan@intel.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
Subject: 回复: [edk2-devel] [PATCH V2 0/2] Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0

This patch seems a new feature to add new definition from SMBIOS 3.7.0. It is sent and reviewed after soft feature freeze. 

Based on the release rule, it will not be merged for this stable tag 202308. It can be merged after the stable tag is created. 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Zeng, Star
> 发送时间: 2023年8月18日 11:11
> 收件人: Gao, Liming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; 
> Cuevas Farfan, Eduardo <eduardo.cuevas.farfan@intel.com>
> 抄送: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang 
> <zhiguang.liu@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; Zeng, 
> Star <star.zeng@intel.com>
> 主题: Re: [edk2-devel] [PATCH V2 0/2] Add ProcessorUpgradeSocket 
> definitions from SMBIOS 3.7.0
> 
> I have given review to both patches and Zhichao has given review to 
> ShellPkg patch.
> Liming, need your help to review and merge the patches. 😊
> 
> 
> Thanks,
> Star
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Eduardo 
> Cuevas Farfan
> Sent: Friday, August 11, 2023 12:32 AM
> To: devel@edk2.groups.io
> Cc: Cuevas Farfan, Eduardo <eduardo.cuevas.farfan@intel.com>
> Subject: [edk2-devel] [PATCH V2 0/2] Add ProcessorUpgradeSocket 
> definitions from SMBIOS 3.7.0
> 
> Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0 to edk2 
> sources
> 
> Eduardo Cuevas Farfan (2):
>   MdePkg: Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0
>   ShellPkg: Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0
> 
>  MdePkg/Include/IndustryStandard/SmBios.h      | 12 +++++--
>  .../SmbiosView/QueryTable.c                   | 34
> ++++++++++++++++++-
>  2 files changed, 43 insertions(+), 3 deletions(-)
> 
> --
> 2.26.2.windows.1
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 










-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108052): https://edk2.groups.io/g/devel/message/108052
Mute This Topic: https://groups.io/mt/101006072/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH V2 1/2] MdePkg: Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0

[gaoliming via groups.io]

Eduardo:
  The patch is good to me. Reviewed-by: Liming Gao
<gaoliming@byosoft.com.cn>

  Besides, I have one minor comment. Please see the below.

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Eduardo
> Cuevas Farfan
> 发送时间: 2023年8月11日 0:32
> 收件人: devel@edk2.groups.io
> 抄送: Eduardo Cuevas Farfan <eduardo.cuevas.farfan@intel.com>
> 主题: [edk2-devel] [PATCH V2 1/2] MdePkg: Add ProcessorUpgradeSocket
> definitions from SMBIOS 3.7.0
> 
> This patch adds below definitions from SMBIOS 3.7.0 into Smbios.h
> - ProcessorUpgradeSocketAM5
> - ProcessorUpgradeSocketSP5
> - ProcessorUpgradeSocketSP6
> - ProcessorUpgradeSocketBGA883
> - ProcessorUpgradeSocketBGA1190
> - ProcessorUpgradeSocketBGA4129
> - ProcessorUpgradeSocketLGA4710
> - ProcessorUpgradeSocketLGA7529
> 
> Signed-off-by: Eduardo Cuevas Farfan <eduardo.cuevas.farfan@intel.com>
> ---
>  MdePkg/Include/IndustryStandard/SmBios.h | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> b/MdePkg/Include/IndustryStandard/SmBios.h
> index 89985bb4186b..fb6ed2dee051 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -1,7 +1,7 @@
>  /** @file
> 
>    Industry Standard Definitions of SMBIOS Table Specification v3.6.0.
> 
[Liming] Please also update the version to v3.7.0

Thanks
Liming
> 
> 
> -Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.<BR>
> 
> +Copyright (c) 2006 - 2023, Intel Corporation. All rights reserved.<BR>
> 
>  (C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP<BR>
> 
>  (C) Copyright 2015 - 2019 Hewlett Packard Enterprise Development LP<BR>
> 
>  Copyright (c) 2022, AMD Incorporated. All rights reserved.<BR>
> 
> @@ -863,7 +863,15 @@ typedef enum {
>    ProcessorUpgradeSocketLGA1211   = 0x45,
> 
>    ProcessorUpgradeSocketLGA2422   = 0x46,
> 
>    ProcessorUpgradeSocketLGA5773   = 0x47,
> 
> -  ProcessorUpgradeSocketBGA5773   = 0x48
> 
> +  ProcessorUpgradeSocketBGA5773   = 0x48,
> 
> +  ProcessorUpgradeSocketAM5       = 0x49,
> 
> +  ProcessorUpgradeSocketSP5       = 0x4A,
> 
> +  ProcessorUpgradeSocketSP6       = 0x4B,
> 
> +  ProcessorUpgradeSocketBGA883    = 0x4C,
> 
> +  ProcessorUpgradeSocketBGA1190   = 0x4D,
> 
> +  ProcessorUpgradeSocketBGA4129   = 0x4E,
> 
> +  ProcessorUpgradeSocketLGA4710   = 0x4F,
> 
> +  ProcessorUpgradeSocketLGA7529   = 0x50
> 
>  } PROCESSOR_UPGRADE;
> 
> 
> 
>  ///
> 
> --
> 2.26.2.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#107695):
> https://edk2.groups.io/g/devel/message/107695
> Mute This Topic: https://groups.io/mt/100667109/4905953
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaoliming@byosoft.com.cn]
> -=-=-=-=-=-=
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108076): https://edk2.groups.io/g/devel/message/108076
Mute This Topic: https://groups.io/mt/101025757/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-