From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.5711.1634192785866309261 for ; Wed, 13 Oct 2021 23:26:26 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=wDKZyVV6; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: ray.ni@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10136"; a="207723442" X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="207723442" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 23:26:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="527402553" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga008.fm.intel.com with ESMTP; 13 Oct 2021 23:26:25 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 23:26:25 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 23:26:24 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 13 Oct 2021 23:26:24 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 13 Oct 2021 23:26:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T1lm68IYYp3sbQz2kn3G0p+rBNufRaaSO1mVfciiiy8qzAkAGiXUrl0C8rsY1ja3aWYXRlLhTuGlDw7mrVmZSZdS4IKNPGb/9mLzyFrXa3Hew8fC86Sw1QfAxak9j4v50ZhcOjD3GDg2pV+XmhdEIJyHqB/T8Es/q9226dOQgzRipcNFwSocEACJrIslvlpZaakD4pRsUsZkiYzz13Fcd6qjnDB+Hzr5w5xu/TsK/5XlCzRd6hC2chdirs4MrIkjJ5saXGimjcvqhSIm1lD9QhAY9CJi02K/Vo/irlz9ijpF+pvdbhZdh8JJfyqo+gYR0aedHPHJtdi7qHb/kQb8oQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s3s5WRQZ0Nye7FDdS3UW/KY8YwZYKapANICtBjUIWEQ=; b=n+6KPQ5bNKs4d0TnCCwivLpGUWsHHukAAiF5LHn2ZonPI8pKlmH6ZCZy9mdHXjoqUzu1pITG09apKyJZlWEFEhhnKEidyHgErwMGzQ8gIkNsG4y1ITS7Brs7GEvdeKD0h4eLIqP0xrEtcgoQlYFuyqI0U+ImLeslxWySAZQiMbJMkgoZM7V+eDu+2FNCJlN9uIVMBi+6skjTL4ZFzJFy+ltGCqubbKLCUfC48vJmBC1KXy8BriJROsZatLWVyAtRl5RLrP5Nd4f99Qm0MrweckEm1HAgip45tVQ92mKxcGKvxLrb6ltvvwuggMegn+pB9pVhyIFayNbEgx+Xuv/K0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s3s5WRQZ0Nye7FDdS3UW/KY8YwZYKapANICtBjUIWEQ=; b=wDKZyVV6uERU4tmd+cy9iq09f6gjJpBmfQi1j4VC7um+VboE5ac8/f6aX8JvvJVsYhLhBSAvmrnPBfPJTTbfmK9DhDFZYHHzNZGrsvHG9rcPNpkAuECKN+KowTIVAe+IVIUS1/pN+1dRVUqbDCfN8XHysJrbPcLoZx5zAjuy1H4= Received: from DM8PR11MB5688.namprd11.prod.outlook.com (2603:10b6:8:23::12) by DM5PR11MB1291.namprd11.prod.outlook.com (2603:10b6:3:14::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Thu, 14 Oct 2021 06:26:23 +0000 Received: from DM8PR11MB5688.namprd11.prod.outlook.com ([fe80::f070:be68:1c12:5aa8]) by DM8PR11MB5688.namprd11.prod.outlook.com ([fe80::f070:be68:1c12:5aa8%3]) with mapi id 15.20.4608.016; Thu, 14 Oct 2021 06:26:23 +0000 From: "Ni, Ray" To: "Czajkowski, Maciej" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" Subject: Re: [edk2platforms][PATCH v1 1/1] IntelSiliconPkg: Add IntelDieInfoProtocol Thread-Topic: [edk2platforms][PATCH v1 1/1] IntelSiliconPkg: Add IntelDieInfoProtocol Thread-Index: AQHXu49xnifrZUfvnE283d0TOBz2jqvSD4EQ Date: Thu, 14 Oct 2021 06:26:23 +0000 Message-ID: References: <20211007152420.878-1-maciej.czajkowski@intel.com> <20211007152420.878-2-maciej.czajkowski@intel.com> In-Reply-To: <20211007152420.878-2-maciej.czajkowski@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1e7b05e7-429f-41bf-b1a5-08d98edb8b69 x-ms-traffictypediagnostic: DM5PR11MB1291: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3276; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HzYcwXZidDLhWErt0oMRWPxQSsEtU5KF8CIueFH/u6/h31OOslywZB+byhjho3TuQR7jCRo8mOY/91PTA09qz5myDJzhRw5hSVG/X356P+eF6mRH6NeIU8QqIfXQfAryYuGms7g2E6aI00RrydN24WlTb+V61k3Kk4lV082Zt9lHB7KXpdgC8FBN8t5cSX72gnA1sXj9jKpio16drPz1DAkR36pCW+MZR9s2mIXru5HCPj4g1crORTTzE2uEmCOrodOCEL0Ul7yrPx23eqSojSsSRYg1OxUyspIWKBoOtRxFtfIfoImKXcQU3e2v3PvOgQD3iXkn2S7EB87NQe39A1AUCT2tP+vaZd+7GrZDofbxxyCc5m/gx23Wf2veAPsr4sT6orflvVwVeJYy+pgbXkvJq8585wgLobt8OzzO6I9NkH7ZRtrqTRWszhTx963XzNGhe7DrVRl6xNM9XMdtIAcv1ozzld0DLetOzrCN7bgANl9B0xnSXPsKURQBoUEYaB0sPS9/RtGtVCcfNMKyXrdCK+NYiKuxZCvwTaWOiSa6SuEovzN8jRe25kynBqqcAabOLbT9N9Gl4RIke111ZoMN3lJi/z0v9jRni5/7Oy49JHLMlNhqYB5C1q9uT4+UjfeJlnHXCVoOXrYGkeJ41NbJH2rFRJijXcRG+rx9bvAQx51Hl4cRxKAUBj5pmn7JNqkM8Y7B0Tt6OPHImQuayg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM8PR11MB5688.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(82960400001)(8676002)(6506007)(7696005)(55016002)(508600001)(71200400001)(4326008)(316002)(38100700002)(122000001)(9686003)(5660300002)(4744005)(38070700005)(186003)(52536014)(107886003)(33656002)(86362001)(2906002)(76116006)(66946007)(66476007)(66556008)(64756008)(110136005)(8936002)(26005)(66446008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?i87JD4sfmbxBzQhPRCbHW36Bgq51IWlQDik7kO2RK8o9EB3wEoVvwozuOxId?= =?us-ascii?Q?A6EnPczgKdYXvDUlBO5z6I0gCJOyV5YVoErzh5YEtsfq4ZaiBEGa3qhh6JUB?= =?us-ascii?Q?zQWYdbycd4lwhXWMA7Hhng+BnnMIkI9wqRgbGgw25i9ow7MAl4uSRTY7KdCx?= =?us-ascii?Q?3LUCe6OFEDxyjkTmDX0XDxFB4wR3lHZAqQjx/9obj+DKeMm/Y9x17iVj6xrs?= =?us-ascii?Q?JhEChUkgFV7uxBGZx6o9Rly3e+YYnGJ+p9xOGfr0YYoZUoS4Xz1DsIv9AOVQ?= =?us-ascii?Q?IvrwbbzMehIYuimLemb4PmTDHAa3EV+9YGgbu8+r+k0+iPoW6wuuUrueVvN3?= =?us-ascii?Q?NMowah6qdwdtkY4+10kKriXbbUM/4ik1+TbEhoIgeOeIfHQv/U2DyIfgXVCm?= =?us-ascii?Q?u8emwBIy54jceKmlzdAYJ+CoVDNvURw4AaZKfuoL5U5VwfZlUGGBu4l+QERc?= =?us-ascii?Q?uev5AA+Vt69zII5JdXxdl7QpuR/bYntYm78Qq/VNWYhCz5gkJYN9tiehVNR7?= =?us-ascii?Q?5bdfdsWj9EqJmr2i6+moqHPtOMHAKsFK1cFhDNGGcZsc//OZOzFn5SsE5xgD?= =?us-ascii?Q?S34gHfElCDo7Uzv/1POub2LrhN6yBM22dTc7BKd5ZE+Wmg8H/WYL3j+gfAhr?= =?us-ascii?Q?NSSMBIn0sOUrziA2lS4LodI2BZg5D/BDszY+VNgjyUMgLU7hsrfRMYV6L/RK?= =?us-ascii?Q?wosmlwNDRMlFUS9L5ckzwuWdAdl7oVEpUahbOK2SsUL2UG7n7Jp+cSteWCyy?= =?us-ascii?Q?z0fkctkmxqkA0ExMS+AP0HpC27i6xv6F55J47iYxeZMhNpLwjtCjYxcrB+QI?= =?us-ascii?Q?+WjuuEzuts6e4ojMnu3EjcxTKC3OfFDOlEvKfcrt2kSVOp+6NNTZdqzrl/Oy?= =?us-ascii?Q?c90ejoDaTUPKm9edQP8wJ7G6Vn3TzH1hPaIW7QykOly+wQLxwTraW8aAvUlr?= =?us-ascii?Q?bmNJ4BTYD31EOcsuNeXBZOJXuEkGowh4XAuyvl9BcoMdGXDUQgBa/nmpbRLl?= =?us-ascii?Q?nW1r2hxyan/SsNU8sg2mkDimxybXqYPPKHs5x76zlTeewZZlCzgoGIaz7Xqx?= =?us-ascii?Q?l7Bu7uYO0X7GD5F/3eA4J+RM2RB21gMnYHBAX+yuGKgXz6EEqhK9a77xsVUJ?= =?us-ascii?Q?VNjhcZ3XYURd9osOj+hvPBI7u6ts3gzxRByDj+hVoG55qocAPLsYxWDao+Li?= =?us-ascii?Q?/YyLqE3km09lAqYsYY92YqSbT1OgTY2lfbC0ifWLEdMsnDQgr9TbAkhoOWPl?= =?us-ascii?Q?LNl6S5Tgcd9VG1TrPUeciX/2gY6EbNOFt79QmaeKHDRege8Y838tKsp2blpp?= =?us-ascii?Q?ktgwYLhCRvX3TjSyQEAheYcl?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5688.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e7b05e7-429f-41bf-b1a5-08d98edb8b69 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2021 06:26:23.6691 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: r8IlRpMod9cTw49bpq0Bf900q8HDIi4rycKK1b6sgBOcf2YVpaR2ScjJ/jZojaDs6I/GaS6OA5fpMNrUUKNh6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1291 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable +#define DIE_INFO_CPU_GUID \ +{ 0x6E5AF2E3, 0x5D84, 0x48F2, { 0x84, 0x28, 0x99, 0xE4, 0x93, 0x4F, 0x51, = 0xE4 }} 1. What's the difference between SOC and CPU? + UINT32 DieIndex; 2. What the purpose of "DieIndex"? + INTEL_DIE_INFO_GET_DIE_NAME_STR GetNameStr; + INTEL_DIE_INFO_GET_STEPPING_STR GetSteppingStr; + INTEL_DIE_INFO_GET_SKU_STR GetSkuStr; 3. Have you considered to use data fields such as "CONST CHAR8 * DieName, S= tepping, Sku" instead of the methods?