From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id EF0117803D8 for ; Fri, 15 Mar 2024 09:28:54 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=y3Zc4q6w0p/K+fBXbRCvgo5ctbMjgrJaozR/pGeSrJU=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1710494933; v=1; b=cjAEyug77seNdh72lZI04eRPyr1t//5brgstaEagy2FvpqqW4ezR7Oaulia5sen3BaP8nzw1 eJ912b2atWlT2xcZPCK0L+x+icbrgJyfr7Z8X6DbmYYRsL4o52oEYlJHkaPZl7mydLsUtv6h3Qi PZlhP3Vq5vFhgt60m4DjktsatYBL3FMKDCiItGfhTbJDNwdC177IZE0IC/FKtPmJCUEVkbj2BkV fNsHPtbAFKpHWheKXVJgqdm0OsOtxk9E+o90/flozr3oEmWFeBkDSDNGFs7G6ZNp+Sjsy4kMPKI uzGxPn7CNVlnuky6F23v7bY8FEmPCC4dcMQJEArHJKR2g== X-Received: by 127.0.0.2 with SMTP id N2uqYY7687511xmcXD5nqFLf; Fri, 15 Mar 2024 02:28:53 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by mx.groups.io with SMTP id smtpd.web11.17391.1710494932964747504 for ; Fri, 15 Mar 2024 02:28:53 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,11013"; a="5217030" X-IronPort-AV: E=Sophos;i="6.07,128,1708416000"; d="scan'208";a="5217030" X-Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2024 02:28:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,128,1708416000"; d="scan'208";a="12650403" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa009.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 Mar 2024 02:28:53 -0700 X-Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 15 Mar 2024 02:28:52 -0700 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 15 Mar 2024 02:28:52 -0700 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 15 Mar 2024 02:28:52 -0700 X-Received: from DS0PR11MB7681.namprd11.prod.outlook.com (2603:10b6:8:f0::11) by BL1PR11MB5285.namprd11.prod.outlook.com (2603:10b6:208:309::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.18; Fri, 15 Mar 2024 09:28:49 +0000 X-Received: from DS0PR11MB7681.namprd11.prod.outlook.com ([fe80::f3f0:21d3:e516:5ba3]) by DS0PR11MB7681.namprd11.prod.outlook.com ([fe80::f3f0:21d3:e516:5ba3%4]) with mapi id 15.20.7386.015; Fri, 15 Mar 2024 09:28:48 +0000 From: "Guo, Gua" To: "Wang, BruceX" , "devel@edk2.groups.io" CC: "Dong, Guo" , "Rhodes, Sean" , "Lu, James" Subject: Re: [edk2-devel] [PATCH v1 1/1] UefiPayloadPkg: Cleanup ProcessLibraryConstructorList() Thread-Topic: [PATCH v1 1/1] UefiPayloadPkg: Cleanup ProcessLibraryConstructorList() Thread-Index: AQHadroh5V2m0f+0MkuvABmcf866RrE4iNOg Date: Fri, 15 Mar 2024 09:28:48 +0000 Message-ID: References: <20240315092042.1644-1-brucex.wang@intel.com> <20240315092042.1644-2-brucex.wang@intel.com> In-Reply-To: <20240315092042.1644-2-brucex.wang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DS0PR11MB7681:EE_|BL1PR11MB5285:EE_ x-ms-office365-filtering-correlation-id: bd9211a9-947f-4ab8-ee91-08dc44d251c5 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: o+1GRs9WuLWfAJzFAgCeGhIV+7Ib1JaoENOf/3R04ox7ww1qzUBUu1mD4BnOkinO62MGgcvd4J6fFNN0vozxWxcZJM6bLXl79z3B0ClO1wfDJHRBUg+Atmq4iI2Ek3JhOtPYhC19Ui0NR9OdsSNkCWQHJa6/wYD0N5xBa/T3o80P6bPqOFRibqYw1y0lsEmu8KCc/ZqmRLSEAMX+kET7F3r9wZtaTFDa1wc1ZkRwYMQNh5CUPr2X3Y/y2IhnFPRD8oAFIgzq6Z9H5dQ8DopkGUqmsck93izwdqvbovDpEg49yVhe4ZNAxGtt/C2iAHaQO7gWTH4AtfBbHoWt0AJs5PNtmqi9CQ157/HDCJA3bYJ4pAxHcad2mpSawhYLyvrFJUXfynxodeqwH7SDMn+9iOmV53S3G9BtssEi2UjDkuxxUWdSEImpv3hbL1kZbgbL4Lp4+c9bnpgPY0lT6bF4JtfR7Q6GerKjC2mOQvfgPJMwI8wvwSd5s9JLbrOzkQO23TSdVEdm8I1uN736OVY8AWpgQOS4fn3zd5vtZwNnDu0IpwVEkC0zTSL3z3jvtWkyx4CJuBq4iMxIzkJxIbr+6WyafjH4YICPg9SuvLk2mGptLxPafzy5AOISemQkxwOafqYoCiWV0Y6lo1fZAPWsixsinFmJPpGJtSc96mfSZweqgEzOXwvfenGGAGR1wFWGHZC5OGg3CpPRtJY3RT8EGIge95B4Ts7zmhKSEGS32YM= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?v2MDzygrqwP0VSrw/r7gmabX2gETFGBhldkubwFUHlIHYZ5ZlYdkkxPru3y2?= =?us-ascii?Q?okxVsTdDhVD579ok+oJM1B86TAtdowOSJ/PeW3wxMyAGT5xeYhM30bE5AZSY?= =?us-ascii?Q?YGINqZAr/JU51+C0EMXollAVmjrrqTfzw9IJvMW62s7OJOpDV1GKf7RhQvhE?= =?us-ascii?Q?g/Am5y5fL0oRTKmOV5ICAugTB+iC2fSX0xqYzL3NadQmxojva/wo97mmsHVJ?= =?us-ascii?Q?87geX16TouFDLHrw7St///GC9uB6cwZ0J12dPoz+x8vE5pAQraSERQCUeRe9?= =?us-ascii?Q?5fYKBh5G1U8ytb8U+kE4p8NYq8dBldR7jlQ2InZ3rffh75nnmVEJi39kSR9u?= =?us-ascii?Q?gcA1Pa/20yhFwqsF4h5YCZo3G7NVLGuN6dC94u0ih0qY6sTtJnZe8Y42Jd0d?= =?us-ascii?Q?qmogL4YI9L/EIP/V8S1PUxDqXxJCJ3YYiMvNnbGflEZzB0DH/xuVW2VlPsS4?= =?us-ascii?Q?VEunUAaTb8TCCoFrgD2+C4RivU5c06DQycqCIkSP0sdmRq1LmOAqv4X6GvcC?= =?us-ascii?Q?1AuegrCQM6lBkmoBWjEyVluF69D38XwhaHfuaDptBJV5GwutkEiT2jL07OUF?= =?us-ascii?Q?ZYIwfL5n4vo7LMGax7aauei25Al4YPVx9hySrqBEUMm2TjQ3YXF2qD/fYm1F?= =?us-ascii?Q?27UgCZtravn8e+RJqXBRu4RBcF9LexW3OErT8S6ppn2pQPOql+MBvY+xXxcK?= =?us-ascii?Q?VAK5swK/hte85QbyQ/+MgFpxX9mpvaHbOMPOVXO/9Zzk4vaAnyGDUu03xfYe?= =?us-ascii?Q?P+i32gsiOqGouPhlhq0SS/6AT6bIRvPdLE5itHm3XMOGZcpPddQZfVA62F1Z?= =?us-ascii?Q?YkaIma4WEg1FP0T6244/0XVPPZaXRAazNjOgUv7dRdj+O4pFd+R2mun0Jpbs?= =?us-ascii?Q?lqWVvsv7Z4tY/AjzR7qEFVteGtQLYFTOKsOBN6cbS3oPGWomKkabSy/HgyaB?= =?us-ascii?Q?oE/gZ7e9kcUwrT/KIf32/9WmnIjmTosdPr6fU6RFtc2FJF9ZlAcp+jVUjS3d?= =?us-ascii?Q?3GTZVJ2Movs9s/mvRQvgd/fmc1Bimkxu0FWm+IX953deBzCPzDuN4+v/Gr2v?= =?us-ascii?Q?WdlMPGOekC/D5jGjxYEKCKjT/iI/Yi0dF2uVt5HYzSaV/T18lEuMEJCFX1sk?= =?us-ascii?Q?LgUSVrIL1R5XudPzwM9wF/LpGZN81H/S/3RMyrjEtoBhihTyVxcUASybO2w1?= =?us-ascii?Q?zbgU23Oq0teptBUbCgczFf9GYnsyq1aOdBYf+/I7V4VvHqY7OvtmJldqs/Mw?= =?us-ascii?Q?Ws4fDhJp8AhlAlvfUWrdlHwQ82kc5xmkq2ttR0/vHrVztyfGswBmx/zLAbam?= =?us-ascii?Q?ixnGj0G7/PtP63qJsNzGwqUaM7mM2T484sYGeDAukbPP+zJw/iprjtiHnPI9?= =?us-ascii?Q?xK64X56pwEc+NHMu2sFK2QAm1kPawXYR5WiEzAcHrD0if9f3vHpXp/SZcveL?= =?us-ascii?Q?YTxcs4jMuB3FcSoFxvh62zUqd/GAkH5coMSFU2MgcHedCsxJmBDpDpn9RWK7?= =?us-ascii?Q?JG9HaWgeSLG5UQdS6Yov1sNTVdWXjIGWP896tVLMmyPwJ+fG1fLcDfMXssDi?= =?us-ascii?Q?C/7+XdDMVywTkJkveJ9Hnaj6fQaF8sY2xfuFcFxw?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7681.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bd9211a9-947f-4ab8-ee91-08dc44d251c5 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2024 09:28:48.5014 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Sq6Z6X/OpqQC3O/iY109Awlicqy/pRZoryfBwfB8NTSqzs4KA7rtRuNMyFWCxUlEL/DH2n9j8dLr1Xa9OLMnJw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5285 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 15 Mar 2024 02:28:53 -0700 Reply-To: devel@edk2.groups.io,gua.guo@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: jpiI675IW1kzarLalCn5LBjux7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=cjAEyug7; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Gua Guo -----Original Message----- From: Wang, BruceX =20 Sent: Friday, March 15, 2024 5:21 PM To: devel@edk2.groups.io Cc: Wang, BruceX ; Dong, Guo ; R= hodes, Sean ; Lu, James ; Guo, G= ua Subject: [PATCH v1 1/1] UefiPayloadPkg: Cleanup ProcessLibraryConstructorLi= st() From: Bruce Wang ProcessLibraryConstructorList() no needs to be called manually after INF ve= rsion greater or equal to 1.30. Cc: Guo Dong Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Signed-off-by: BruceX Wang --- UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.c | 2 -- UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c | 2 -- UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c | 2 -- 3 files changed, 6 deletions(-) diff --git a/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.c b/U= efiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.c index eb0b325369..58a7e8190f 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.c +++ b/UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.c @@ -616,8 +616,6 @@ _ModuleEntryPoint ( mHobList =3D (VOID *)BootloaderParameter; DxeFv =3D NULL;- // Cal= l constructor for all libraries- ProcessLibraryConstructorList (); DEBU= G ((DEBUG_INFO, "Entering Universal Payload...\n")); DEBUG ((DEBUG_INFO, = "sizeof(UINTN) =3D 0x%x\n", sizeof (UINTN)));diff --git a/UefiPayloadPkg/Ue= fiPayloadEntry/UefiPayloadEntry.c b/UefiPayloadPkg/UefiPayloadEntry/UefiPay= loadEntry.c index 030a5baed9..7c65869563 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c +++ b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c @@ -434,8 +434,6 @@ _ModuleEntryPoint ( UniversalSerialPort->RegisterStride =3D (UINT8)SerialPortInfo.RegWidt= h; } - // The library constructors might depend on serial port, so call = it after serial port hob- ProcessLibraryConstructorList (); DEBUG ((DEBU= G_INFO, "sizeof(UINTN) =3D 0x%x\n", sizeof (UINTN))); // Build HOB based= on information from Bootloaderdiff --git a/UefiPayloadPkg/UefiPayloadEntry= /UniversalPayloadEntry.c b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayload= Entry.c index f37c00fad7..019b6b3d8b 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c +++ b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c @@ -462,8 +462,6 @@ _ModuleEntryPoint ( mHobList =3D (VOID *)BootloaderParameter; DxeFv =3D NULL;- // Cal= l constructor for all libraries- ProcessLibraryConstructorList (); DEBU= G ((DEBUG_INFO, "Entering Universal Payload...\n")); DEBUG ((DEBUG_INFO, = "sizeof(UINTN) =3D 0x%x\n", sizeof (UINTN)));--=20 2.39.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116791): https://edk2.groups.io/g/devel/message/116791 Mute This Topic: https://groups.io/mt/104944095/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-