I’ve added push label, it will be merged tomorrow.
From: Lean Sheng Tan <sheng.tan@9elements.com>
Sent: Monday, June 10, 2024 11:28 PM
To: Witt, Sebastian <sebastian.witt@siemens.com>
Cc: Guo, Gua <gua.guo@intel.com>; devel@edk2.groups.io; Rhodes, Sean <sean@starlabs.systems>; Lu, James <james.lu@intel.com>; Dong, Guo <guo.dong@intel.com>
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size > 16MB
Hi Gua/ Dong Guo,
Do you know how to proceed?
https://github.com/tianocore/edk2/pull/5732
Does the patch submitter have to actively rebase its patch?
Best Regards,
Lean Sheng Tan
9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
Registered office: Bochum
Commercial register: Amtsgericht Bochum, HRB 17519
Management: Sebastian German, Eray Bazaar
On Thu, 6 Jun 2024 at 15:38, Witt, Sebastian <sebastian.witt@siemens.com> wrote:
Done here: https://github.com/tianocore/edk2/pull/5732
Regards,
Sebastian
From: Guo, Gua <gua.guo@intel.com>
Sent: Wednesday, 5 June 2024 16:22
To: Tan, Lean Sheng <sheng.tan@9elements.com>; devel@edk2.groups.io; Witt, Sebastian (DI FA CTR IPC PRC2) <sebastian.witt@siemens.com>; Rhodes, Sean <sean@starlabs.systems>; Lu, James <james.lu@intel.com>; Dong, Guo <guo.dong@intel.com>
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size > 16MB
Please send PR also.
From: Lean Sheng Tan <sheng.tan@9elements.com>
Sent: Wednesday, June 5, 2024 10:18:27 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Witt, Sebastian <sebastian.witt@siemens.com>; Guo, Gua <gua.guo@intel.com>; Rhodes, Sean <sean@starlabs.systems>; Lu, James <james.lu@intel.com>; Dong, Guo <guo.dong@intel.com>
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size > 16MB
+ edk2 payload maintainers
Best Regards,
Lean Sheng Tan
9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
Registered office: Bochum
Commercial register: Amtsgericht Bochum, HRB 17519
Management: Sebastian German, Eray Bazaar
On Mon, 3 Jun 2024 at 23:20, Witt, Sebastian via groups.io <sebastian.witt=siemens.com@groups.io> wrote:
Fix calculation of first section in FileFindSection for FILE2 headers in UefiPayloadEntry module.
Signed-of-by: Sebastian Witt <sebastian.witt@siemens.com>
---
UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c b/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c
index 898d610951..9cb6edefcf 100644
--- a/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c
+++ b/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c
@@ -211,13 +211,14 @@ FileFindSection (
if (IS_FFS_FILE2 (FileHeader)) {
FileSize = FFS_FILE2_SIZE (FileHeader);
+ Section = (EFI_COMMON_SECTION_HEADER *)(((EFI_FFS_FILE_HEADER2 *)FileHeader) + 1);
} else {
FileSize = FFS_FILE_SIZE (FileHeader);
+ Section = (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1);
}
FileSize -= sizeof (EFI_FFS_FILE_HEADER);
- Section = (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1);
Index = 0;
while (Index < FileSize) {
if (Section->Type == SectionType) {
--
2.39.2
