From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5C5237803D2 for ; Tue, 20 Feb 2024 15:29:05 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=uqEj73rV8W8LiT+e5zINHJNgek8GzRSFW2iHT4JpTV4=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708442944; v=1; b=sFZqnADdY4J4Mowk3JbogbCzSWSWHzpGFwgz38BslJ4wSKmbNKCOcDZN0AY6Bapeto+N1RZv yPVgJfkIOfTZEVg5GR7w+1SWtw19gmWiF+8WcGEO9oCn5Q7VB7B4FzSSut9KH7oXN/MZeoS8Mel CjkAf2WvPwKCbqW3mpflT0UE= X-Received: by 127.0.0.2 with SMTP id tkFzYY7687511xmxS5I08MUg; Tue, 20 Feb 2024 07:29:04 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mx.groups.io with SMTP id smtpd.web10.15791.1708442943279125676 for ; Tue, 20 Feb 2024 07:29:03 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10990"; a="19985965" X-IronPort-AV: E=Sophos;i="6.06,174,1705392000"; d="scan'208";a="19985965" X-Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Feb 2024 07:29:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,174,1705392000"; d="scan'208";a="27961645" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 Feb 2024 07:29:02 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 20 Feb 2024 07:29:01 -0800 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 20 Feb 2024 07:29:01 -0800 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 20 Feb 2024 07:29:00 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M1/ltAcP5G9Sx/fD0K0UO+SYahAQiFp9vwASCauo21i73NhQ2aK2clJStKRFc02PVwS7s4SDttxzgrgNclJWP2fbZusdfPBGoufmSUNrhhDOPj8vUp6IvAjELX2qprDiAe1w4ImV/dvrxOrOpJ5OxMwFY+NqHfaUJgxTRyvtcqySSpPqDi2yTjewKt6U0Al6jerAFVKT9/SQ1JRBmbesR3JfiqftprAfXnmbHG7Q4sU3h7VvLTBQoSubAq6i/P/eIvee5JJniBDF/o/Mt7XOzd+P1H0OhcdQJxzlsSmE8ofmk/0mQ8zwQVux3KeedqEBSEjEOMPFXG/8PZqrGqSt2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D3BAQ66rLghLPm3+BPM1jjSXUd+w1mYB6Yg3iJjYu2U=; b=GMa5/SFM7q+8rgLhrLJWYCN5Nng+l9XKb/63ab39/CtYcHq+2vQdGu5Acpuf/oQz9q7s9FWaKYmLChZ7nfiMOmSnY7Ml26XAJbMMRrocbve6ka/FAfSDoQMSMNo9Bp1e03/eY3xiiTCzmMfmb9dM+0f/bF0B5cLugLW4QDwGOxMv2/Ut9qk5xtM8IZuglfzWjbVJsGmy4O5rDuKyc4f01wa4BIVOjpq2AynnHrxY+6/FaFEQktp7z+sjWZ8pGspllOqzbqeBvZmd/gdkxBE/dAIfgCZo0zLrwEVZX3MZYA6QtuklUG/at6/e7WSheKkEb/w72uXKGVvasCYccFX9lA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from DS0PR11MB7681.namprd11.prod.outlook.com (2603:10b6:8:f0::11) by MW4PR11MB6667.namprd11.prod.outlook.com (2603:10b6:303:1ea::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.39; Tue, 20 Feb 2024 15:28:58 +0000 X-Received: from DS0PR11MB7681.namprd11.prod.outlook.com ([fe80::d9fd:f2c3:d9ae:6c03]) by DS0PR11MB7681.namprd11.prod.outlook.com ([fe80::d9fd:f2c3:d9ae:6c03%6]) with mapi id 15.20.7292.036; Tue, 20 Feb 2024 15:28:55 +0000 From: "Guo, Gua" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: Liming Gao , "Prakashan, Krishnadas Veliyathuparambil" , "K N, Karthik" Subject: Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/TraceHubDebugSysTLib: Use wider type for loop comparisons Thread-Topic: [PATCH v1 1/1] MdeModulePkg/TraceHubDebugSysTLib: Use wider type for loop comparisons Thread-Index: AQHaZBE/fbvNMI+U/0m2iAU8ANUvrbETWrmw Date: Tue, 20 Feb 2024 15:28:54 +0000 Message-ID: References: <20240220152626.238-1-mikuback@linux.microsoft.com> In-Reply-To: <20240220152626.238-1-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DS0PR11MB7681:EE_|MW4PR11MB6667:EE_ x-ms-office365-filtering-correlation-id: 3a5711c8-ba09-4495-68c3-08dc3228a647 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: j5eXo427/hidGXDvJLPldPV+LMd18LYkDbeLq7e1zehT7Ce/4Kv1M+LY7adwmi/ZoIPlM5p2t+qlw657eBNVHylX7okoVy8yvL607Ww3m0zbSUZnHSl8Ty8U2FXZr2Iv4yBEhd8XXJFcHl+JPUBma1nmKFvCtmVbIIUOBUkF7OnNK3R/Hz5c4K+IXntwAYAhjky3/1bUX8/UrG3XC2wLHeOSRaKmadl0iWsWQuB5SFLsft1KxMz7RreXCkaZ690McgCpjBoP72FOHHqBgymSfwGBozP4ExiuT9Ma0DanXODFvUcgK3ox7VG7OFPzxaSj9nN2bnAkhBZOgLLWBRK1MF0ff+HpTBsRTGNiD+eqWhQTaLiA+USl6PYLD2FKiCf2Ki/XsU9alXVLjRYqP9D/K6SlfWk07MGMJ4RjTug5VsJwvYg7AzaYRkPIBrrjfNeer+MKaa3zwGIdl7No6I5bf9s8aPQ4Yl+4IBQzfWYoAprnTvNbM6txl10IxHMjO0/6yD331jG3eYiaxtlqsr8T73GgIvenOoz+y6E+/51vEzA1RK7YoVG+v/UJbKYIO1rDY5o15MajYZ+NkDp8a5oUXQWzvAmEwy0VcRMdGNvONWbCapflpB9KoibbX7gBbwuV x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uFvoogXVYUSTBaSu7PcSdN2Ve4r3Jg+K6CBEELfmYKnCY3+5l0AOAz8VbNa5?= =?us-ascii?Q?aLfpAdMbGaCMMjzQkGIoCv2A7oTQ+mET6uaCg4TVq5A82TCwSkXStFYzmZ5c?= =?us-ascii?Q?469vgO+21ec6nbveBn2FCNOIuwpKLz2Ci5bYD6Xs2cCxQPPRtPWOyX2c3AZ1?= =?us-ascii?Q?6KUBV6TpAHTZiix++JtXtxT3yMR1xQQl0vk9lwi234EPAsfDdbVFATBCzGcF?= =?us-ascii?Q?OOYlqLyMhDT0wlW6EkRogdfuIesoKB4xd/zICexgXFFXiivlWrFE6D93XESS?= =?us-ascii?Q?BvlHDNMcj4xnWx51N4m7JGSt5sFesGv8FA0c4cjfyd8j8x5eo8kfFBwO/Qzv?= =?us-ascii?Q?n8Ov66S8PeoVmR+QwwcPyjV2HGLPtBiVmpDZy2vx5nbK5Jli3TnCbiL/UkwP?= =?us-ascii?Q?CkiFJKrrD0ChOT4M7G0ZGrV7pzgB9rcgoKKnqf5grwhp/+D7L9wPx0JRa0UI?= =?us-ascii?Q?lw8qBKJuPT/9WSuquTDUJ6Z+DnWI9DEX204H9xZ+LSUrPDqdY1JKf+pBiXQI?= =?us-ascii?Q?zoqkxlVAwrCP2UZAr9Ew2+KII0LozUYrPOAeBjfgrC/ZjZXk0Uyv1JAD+QXY?= =?us-ascii?Q?XJzZKu7iQSzOfaY1hsh9NCj+u58WrCHYdhTzltYq6SXai/8dflaCFLkdfRAz?= =?us-ascii?Q?k8Ai3cABg7PRxU/gHIeK2YlW1H/InyVd9nElg/U7SSCtqqptjkyiFnXEp1Pb?= =?us-ascii?Q?9wdrNeoqYqYqQIe50VxRnmOb8dvTvAIzeQ8AJI9ZFD17pEFfed2nsFj2cdTZ?= =?us-ascii?Q?pg9tK4my32yiZo8aCIlp0E9knjcK/GZY2t8amSyHxuYJTxR+kksK+uxERMeW?= =?us-ascii?Q?Rbs7Nqb5AOD3JbhOWfOcKO8jSTGRmAWEAZN+oklkLkNnxpZxXP97Zk/oexgA?= =?us-ascii?Q?p0OQk9ylKd05tebiKR/aHATKvbeWC6K38oOI79uZV3fPOaUZyvcRrWzT2sNv?= =?us-ascii?Q?C+pQ6xxDjMawDYYdRBCycf8M0CzG64tIkf8VdjTDQLS+dvKF/4SFlnSV19uk?= =?us-ascii?Q?fyNAmhkK8Er88ELfvJZKWHszDwvAY/41P2FCJZsRmZCNBfIzT6OL/V7E1tDZ?= =?us-ascii?Q?S64DGZLjf1aG2Yf1h+mEyoC1JkED6IHiabM7LbjRq5dlQuIXyJFHvmep1Bze?= =?us-ascii?Q?gvT15ssKZzAYueA8fTulH6faI4NkgsizSp70zVHH1trOVwcY1m2j6yvddbVx?= =?us-ascii?Q?V2Z2ZaY6rM4rIuz1TzE4ZWYERgrrZBckQKVWwsFHTYqwdirfQQHH3hcZu3Xk?= =?us-ascii?Q?sQh79c3FldfA7pU2OyoQPGul7kbcZBB8eKdhcG/7o8tVNwIlsAWhwLk5noOF?= =?us-ascii?Q?8K+PCTMzUYv6X/ZU4/1Jy+Klt2wetxSMiS7wrHI51TjcysTWx9ZUMgo1DKvE?= =?us-ascii?Q?2sM7/P45iHCKj5BRBKcH6FVR9JJZY0lrE5Ue9HlWvfU+80LmanmrPSdmbsvb?= =?us-ascii?Q?6tSuuQfNrH6XiHpOhVQLkYw/4qkgfOkUfkwvGFcT405EW1y9L8bhq0iQBJCK?= =?us-ascii?Q?OC7e3RYHBzUZ9biaAF3hOQgHRzprju787PYd7Fy7BIuAciUiYirKxTZ4vQm1?= =?us-ascii?Q?P17T7VzeX3Avx1xxLPw=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7681.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3a5711c8-ba09-4495-68c3-08dc3228a647 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2024 15:28:54.9212 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5ZTWDnRiY0muqkF+EovHphk+S3bmTx7t29Q/HYbpOuJclR8mUwlFJDl0cied6NeyMlwsdZOYapXL0ujukUapQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6667 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gua.guo@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: lsc7Ms9pXFznjqDXkEmDcB6Ax7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=sFZqnADd; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Gua Guo -----Original Message----- From: mikuback@linux.microsoft.com =20 Sent: Tuesday, February 20, 2024 11:26 PM To: devel@edk2.groups.io Cc: Liming Gao ; Guo, Gua ; Pr= akashan, Krishnadas Veliyathuparambil ; K N, Karthik Subject: [PATCH v1 1/1] MdeModulePkg/TraceHubDebugSysTLib: Use wider type f= or loop comparisons From: Michael Kubacki Resolves a new CodeQL error due to the value being incremented in the loop = being a narrower type than the variable it is being compared against. The variable is changed to a UINT32 type so it has the same width as the ty= pe it is being compared against. Issue explanation: In a loop condition, comparison of a value of a narrow t= ype with a value of a wide type may result in unexpected behavior if the wi= der value is sufficiently large (or small). This is because the narrower va= lue may overflow. This can lead to an infinite loop. Cc: Liming Gao Cc: Gua Guo Cc: Prakashan Krishnadas Veliyathuparambil Cc: K N Karthik Signed-off-by: Michael Kubacki --- MdeModulePkg/Library/TraceHubDebugSysTLib/BaseTraceHubDebugSysTLib.c | 4= ++-- MdeModulePkg/Library/TraceHubDebugSysTLib/DxeSmmTraceHubDebugSysTLib.c | 2= +- MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApi.c | 2= +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/MdeModulePkg/Library/TraceHubDebugSysTLib/BaseTraceHubDebugSys= TLib.c b/MdeModulePkg/Library/TraceHubDebugSysTLib/BaseTraceHubDebugSysTLib= .c index 45dfd3127a4c..050210cb958b 100644 --- a/MdeModulePkg/Library/TraceHubDebugSysTLib/BaseTraceHubDebugSysTLib.c +++ b/MdeModulePkg/Library/TraceHubDebugSysTLib/BaseTraceHubDebugSysTLib +++ .c @@ -41,7 +41,7 @@ TraceHubSysTDebugWrite ( MIPI_SYST_HEADER MipiSystHeader; RETURN_STATUS Status; UINT32 DbgInstCount; - UINT16 Index; + UINT32 Index; =20 if (NumberOfBytes =3D=3D 0) { // @@ -109,7 +109,7 @@ TraceHubSysTWriteCataLog64StatusCode ( MIPI_SYST_HEADER MipiSystHeader; RETURN_STATUS Status; UINT32 DbgInstCount; - UINT16 Index; + UINT32 Index; =20 if (Guid =3D=3D NULL) { return RETURN_INVALID_PARAMETER; diff --git a/MdeModulePkg/Library/TraceHubDebugSysTLib/DxeSmmTraceHubDebugS= ysTLib.c b/MdeModulePkg/Library/TraceHubDebugSysTLib/DxeSmmTraceHubDebugSys= TLib.c index 35c239b5feae..6001f4dfd93d 100644 --- a/MdeModulePkg/Library/TraceHubDebugSysTLib/DxeSmmTraceHubDebugSysTLib.= c +++ b/MdeModulePkg/Library/TraceHubDebugSysTLib/DxeSmmTraceHubDebugSysTL +++ ib.c @@ -45,7 +45,7 @@ TraceHubSysTDebugWrite ( MIPI_SYST_HANDLE MipiSystHandle; MIPI_SYST_HEADER MipiSystHeader; RETURN_STATUS Status; - UINT16 Index; + UINT32 Index; =20 if ((mDbgInstCount =3D=3D 0) || (mThDebugInstArray =3D=3D NULL)) { return RETURN_ABORTED; diff --git a/MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApi.= c b/MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApi.c index fe946fe60c7d..035618faece5 100644 --- a/MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApi.c +++ b/MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApi.c @@ -56,7 +56,7 @@ PackThDebugInstance ( ) { UINT8 *DbgContext; - UINT16 Index; + UINT32 Index; =20 DbgContext =3D GetFirstGuidHob (&gTraceHubDebugInfoHobGuid); if (DbgContext !=3D NULL) { -- 2.40.1.vfs.0.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115656): https://edk2.groups.io/g/devel/message/115656 Mute This Topic: https://groups.io/mt/104469197/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-