From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 55D147803CF for ; Wed, 5 Jun 2024 14:22:29 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=SXjnoJQ/00+QBugsXsCeK7O5ulS9cNza9pRrT0Al3MY=; c=relaxed/simple; d=groups.io; h=From:To:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1717597349; v=1; b=AVSj0Uq6bZMR5P/ayiUH1c/wzTCbUoqidX75lb0yf9mfMHfessKQiiqy7YVuqEbk3yzFFvW8 3i+Tv9NyjLR3QUlFmkOfS/R7h+sJdVFerTK9R2NAGthI3KTbS+8X90fTVZlsFGOKs+RqD6icQiL UpzRvywj0Ejbq2XBYLggp5onr6VUlvKl4wCpEZPcKNI3n6buRjGYIdfNEEKTTfUaQvx76YKe0Tc SFr/2FrGiesWUo21KNgTLnN1HIzWW14x0VzKrYG+Z72CNu06Lz5N8aEutHkCJfd8GnmWjXb7djt q9BB49AOZ5wJ9tSqSSTQpov8gfRq+yZhwopl8nWT/oFEg== X-Received: by 127.0.0.2 with SMTP id ktktYY7687511xEmqIYgJ3t0; Wed, 05 Jun 2024 07:22:27 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by mx.groups.io with SMTP id smtpd.web11.16805.1717597347176667674 for ; Wed, 05 Jun 2024 07:22:27 -0700 X-CSE-ConnectionGUID: 4+mOLvziTma6baa9oF8FhA== X-CSE-MsgGUID: nEXNqhwzS2K4g0J1WVcBvQ== X-IronPort-AV: E=McAfee;i="6600,9927,11093"; a="24867784" X-IronPort-AV: E=Sophos;i="6.08,216,1712646000"; d="scan'208,217";a="24867784" X-Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2024 07:22:27 -0700 X-CSE-ConnectionGUID: AR95I7WZT7evJ0C3M4hvqA== X-CSE-MsgGUID: cGff1KBqRI+Tq7bTCZ2EHQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,216,1712646000"; d="scan'208,217";a="68764541" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 05 Jun 2024 07:22:26 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 5 Jun 2024 07:22:26 -0700 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 5 Jun 2024 07:22:26 -0700 X-Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.174) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 5 Jun 2024 07:22:26 -0700 X-Received: from DS0PR11MB7681.namprd11.prod.outlook.com (2603:10b6:8:f0::11) by DS0PR11MB8737.namprd11.prod.outlook.com (2603:10b6:8:1a1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.25; Wed, 5 Jun 2024 14:22:22 +0000 X-Received: from DS0PR11MB7681.namprd11.prod.outlook.com ([fe80::26ad:a28f:7035:6c90]) by DS0PR11MB7681.namprd11.prod.outlook.com ([fe80::26ad:a28f:7035:6c90%5]) with mapi id 15.20.7633.021; Wed, 5 Jun 2024 14:22:22 +0000 From: "Guo, Gua" To: "Tan, Lean Sheng" , "devel@edk2.groups.io" , "Witt, Sebastian" , "Rhodes, Sean" , "Lu, James" , "Dong, Guo" Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size > 16MB Thread-Topic: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size > 16MB Thread-Index: AQHatc3p2Qz+WurqVkuCrdys7PzbCLG5OtuAgAABAc8= Date: Wed, 5 Jun 2024 14:22:22 +0000 Message-ID: References: <81470919d07dd3968c96f378340a032778cedb34.camel@siemens.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DS0PR11MB7681:EE_|DS0PR11MB8737:EE_ x-ms-office365-filtering-correlation-id: 33dba9c1-903b-4361-1315-08dc856aea70 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?iso-8859-1?Q?6nrD44CSXi7P7/B4fk++/B9cfAZiIJOWM6RzHXFxq+m7nwkCCv4WXdGiRD?= =?iso-8859-1?Q?/Vpr780f9znVEXxO73c4z+DDsop04Otw/s4jf0F2aHTpkdZCnrxr0XN+j6?= =?iso-8859-1?Q?qxOBIZDiBrCr+EADzgW6v5ShunMA2D9ndE3K+mebAw223gOBk/D9qAxv0o?= =?iso-8859-1?Q?r3JY7lW1tDPnudLF93/42+jvouQzk4uT+pyv/2sciiqpmylJMaXQRpbJEB?= =?iso-8859-1?Q?GQbjnHoGIa17xg7uEpbmDErN93YCgy8i9MDWF6eFX1QLLc/6iGd1lzppd3?= =?iso-8859-1?Q?1qHWLiKRlBIEJ7bsUophY85YSILdDrzCPXHjQjE0xf/xaD+Egn6GoxGuuS?= =?iso-8859-1?Q?NKN/2LBwcAgGAUj+K7B2KHO7KkXvo+w5ha1HGYkOhkjf1IWe53bonoiogz?= =?iso-8859-1?Q?aD2wK2th9519SSM5E/tvHDJjMsXZkxfJfST4O2dsQq26zXHFIhvityUUr1?= =?iso-8859-1?Q?+yrYJWfZvj+R14Ppcd7GDFG57NWViBSbfrJEQ60n6soMxpYjc0/jqa0WlB?= =?iso-8859-1?Q?8/68gzINvnNZeOQ64sTC/2zRcUWSUXw9RyEqzmYsBxS+h8DvSSadhsQmY2?= =?iso-8859-1?Q?Y0Yl1CZ3XreA0NfWcOceNcyOHzZhsFr3lN3n+0/7xh//NrMKdNy5tPTFHH?= =?iso-8859-1?Q?XtwoifzEsHGXjE7Xk9bC2YFewV+NmblaLHix/zFd4AJFs99N88zHqNSqUa?= =?iso-8859-1?Q?kVPfO8qVvuG35TSsWKyDDOT0YiWfrY4Ouz0MHIebdZM2YNte51EFx1YWYc?= =?iso-8859-1?Q?uxSNJkTFPZRgpEopmMU4sDLFIf7zFEKsgolXAxTOioV80/o4RWomaQvzR4?= =?iso-8859-1?Q?C9JuqqSG2LJ2pi1iX49riz0pUbWR7g+5k7VKn3oFedIlXvV2+BgThjogUA?= =?iso-8859-1?Q?QZhV0gxwOHFeExrSRapF8dN86KsASM92+gzZoAnO7sU9EjaArhUei9FrNR?= =?iso-8859-1?Q?YP3qyRqVi1TzkWBQAHJj1z8Rfu7flx9QLr6aUu//wiVl5YTybfA1URxlAz?= =?iso-8859-1?Q?tLj/3OtO+dWWlVAgKV6fWcCENagApmro+WhEKLHkuwjVTdqVeczqHSsHuX?= =?iso-8859-1?Q?41bjrvDg1DnVxfUqui2wtVLM4K4cU4gLpN7r3hDAzteG146VlFkSyvUGdu?= =?iso-8859-1?Q?5K8fVNiRKW9ker7uXUllbPBrhnLlzNfyb3/UbKxNOBNgX7YJlsok4K0ao2?= =?iso-8859-1?Q?0Xh5XYWp1doqfvrax3bndZd8J8wA6r8xDoJs727QcDD0hrqwoq/00UDo8e?= =?iso-8859-1?Q?NS98QXfXCR4hV5aXqF1X2qFA45nbWfsuc+mlePkqiVi12Jfj5GiGOM+Nd5?= =?iso-8859-1?Q?QyF23trSyxReXfcmIK+7PRUNVXK62AylF5E4xA0Agu28qLnLzkhfFhqkuU?= =?iso-8859-1?Q?Sh3hTxqSfLZ5Z46c6q42oJvqZYB4+EjQ=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?3Er/6gh+yeGb3rioFKe91x6WfZntIoN2Fa4ONOndmHg5pdO+feqmyRzudp?= =?iso-8859-1?Q?C7M2T0nZbf8V7oYTm6qaCeXhuOfOP75ejmI7Ig3H9yGHygkIHmVY9tgNko?= =?iso-8859-1?Q?FJ49j6M9EZGWssU3Y/HJ4UMGYYxQmbmvzzPsH9Jr0wycRp1l6LIHWEyrPp?= =?iso-8859-1?Q?8njQTjAQ6qQvfxQq9ur6ddM3m4JAm2O7Wjt1A6xtPE+Ef07eyZF358o2DE?= =?iso-8859-1?Q?8pzhwM3/usCsaagVlsSWfz9I+qhWZKtQPgQ9XeBuoJJHQKV6QGo/c0F6ki?= =?iso-8859-1?Q?3Z/mwmLE2X034VkafeojNWetCr30O/IPGFvXdUQgq7QrGeBpKsXLwy5Kih?= =?iso-8859-1?Q?1W5fWMlab1VZ3yLzbylLDk3DjIZ5X2jDCpwzeHln8/r3slU2oMBNdz0u0/?= =?iso-8859-1?Q?Xbdlc6yLsekicqBjWiHs4yetRUmR72LIZPhimc8rvvTbXkEtcNdd13XgkB?= =?iso-8859-1?Q?iOZnudVcWwFyNJF10htFOhVlJi6L+NSo/N1q/lU/3g3+v7fa5nUiUbleau?= =?iso-8859-1?Q?C39cqNIzJi7gY2ZOqfjnYk6Otf3qfHrVy6PzdSbb/ljp4V4ob6t2/leeDR?= =?iso-8859-1?Q?L5M6VJpxtKoB4MkgaIdoKjXZs0jYZFsVKCBG0ZnYnshGRqby6wE2YJS4tU?= =?iso-8859-1?Q?vlJyGtYQxrreE+P+gE6b8O+E10T70iS/9vUcjf5AGoVtVFzqn4sCWIN+q2?= =?iso-8859-1?Q?DZVnvjpNyNT7sfmwFG6Q6ND3kS1q9q/nrbsUos08TWrCa1Z7RVyFDRculL?= =?iso-8859-1?Q?0Mtm/0mzHz3Jq4L1pOx2rV64AiwLeCXwOs4VL5cjjs7DCLwCBT5VeVIu/d?= =?iso-8859-1?Q?mXrwpYMYPipKt1cyu3wSyEYi/BfuSIo3U1H4t4D2MnYZEToX0bre2RpI/D?= =?iso-8859-1?Q?RUsKAe6Y5sfLfpFCaTaZW+u0MyaRikyBCJ7lT7Ao/drsoGBj3vbMFNzcOh?= =?iso-8859-1?Q?FenNTRkPOiuxaFGjalxEZnpRlKqJCavEWh3YolbZzx45vpVlJlcc5j02m3?= =?iso-8859-1?Q?CVOUIyPMbu8yjmVXFZVl5m1G9vqm/yfp86xPQZOro6wUJMsg2XCVKSKY2w?= =?iso-8859-1?Q?kuNBwLL3F6TIzE7kApljEQ9i4wIolPdnQv1AhX8cZoS+nfWwxKg7Cf9Wsl?= =?iso-8859-1?Q?K2G/SZcgRQsk3Q819xgVIChmd45yMLFs/3Yt9kQ3xIX8GL5Tum8iekmQ+4?= =?iso-8859-1?Q?Jpbo4CTouUNfURl1xZcGaKjxu1XCpACmHmEHzPL/GKxMn87NblIPsY2yYF?= =?iso-8859-1?Q?AgPrdbfiO8Cs5oHLlmujtDCt9QCuVrfhDcLsAMCrX1CdG73qRBH2SJjAru?= =?iso-8859-1?Q?5PovPj1DhqpaF48mJIwZzCLVZvYNyiz0asd9pUV0uocq+YoE9U4SJz9uHd?= =?iso-8859-1?Q?wtGTG18RBZX69KDPhWO8yBi4TO6OrDuYbiIG8c1Xa6qS9QPwcgOaZr1Nf8?= =?iso-8859-1?Q?zLIa7J5j4s9rrnrB1cNnkJIb7KQiBeog1YnEgk0p7KLctlsSlVZW0G+OyQ?= =?iso-8859-1?Q?DCzfgk2M55thYbiQsQwXfhYHSeRr7fLt1zJ9XD7nPyBe7sq6XZPAgrPOY+?= =?iso-8859-1?Q?//497sHxod1BYG1E69C9L1sh6inIWQDG+Txwqewbu8I4ywAIfs+YgLAkG4?= =?iso-8859-1?Q?LXtSmmsLldhi7CsCWPfqURSzqSmjZ7+5n4?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7681.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33dba9c1-903b-4361-1315-08dc856aea70 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jun 2024 14:22:22.5497 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: N+Fk8DmVqyEJXcyGVGqBAz8JHc4sXpljDBI3Kn6O3rmCpN0PHQcpiyuS4W70heUgZXsYlld3lEco/0+rtBOB2w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8737 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 05 Jun 2024 07:22:27 -0700 Resent-From: gua.guo@intel.com Reply-To: devel@edk2.groups.io,gua.guo@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 0EzoGAp9exqu98WLkLVwahrqx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_DS0PR11MB7681E42D855C7242CE2F7911EFF92DS0PR11MB7681namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=AVSj0Uq6; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_DS0PR11MB7681E42D855C7242CE2F7911EFF92DS0PR11MB7681namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Please send PR also. ________________________________ From: Lean Sheng Tan Sent: Wednesday, June 5, 2024 10:18:27 PM To: devel@edk2.groups.io ; Witt, Sebastian ; Guo, Gua ; Rhodes, Sean ; Lu, James ; Dong, Guo Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for paylo= ad size > 16MB + edk2 payload maintainers Best Regards, Lean Sheng Tan [http://static.9elements.com/logo-signature.png] 9elements GmbH, Kortumstra=DFe 19-21, 44787 Bochum, Germany Email: sheng.tan@9elements.com Phone: +49 234 68 94 188 Mobile: +49 176 76 113842 Registered office: Bochum Commercial register: Amtsgericht Bochum, HRB 17519 Management: Sebastian German, Eray Bazaar Data protection information according to Art. 13 GDPR On Mon, 3 Jun 2024 at 23:20, Witt, Sebastian via groups.io > wr= ote: Fix calculation of first section in FileFindSection for FILE2 headers in Ue= fiPayloadEntry module. Signed-of-by: Sebastian Witt > --- UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c b/UefiPayloadPkg= /UefiPayloadEntry/LoadDxeCore.c index 898d610951..9cb6edefcf 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c +++ b/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c @@ -211,13 +211,14 @@ FileFindSection ( if (IS_FFS_FILE2 (FileHeader)) { FileSize =3D FFS_FILE2_SIZE (FileHeader); + Section =3D (EFI_COMMON_SECTION_HEADER *)(((EFI_FFS_FILE_HEADER2 *)Fil= eHeader) + 1); } else { FileSize =3D FFS_FILE_SIZE (FileHeader); + Section =3D (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1); } FileSize -=3D sizeof (EFI_FFS_FILE_HEADER); - Section =3D (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1); Index =3D 0; while (Index < FileSize) { if (Section->Type =3D=3D SectionType) { -- 2.39.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119473): https://edk2.groups.io/g/devel/message/119473 Mute This Topic: https://groups.io/mt/106471262/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_DS0PR11MB7681E42D855C7242CE2F7911EFF92DS0PR11MB7681namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable
Please send PR also.
From: Lean Sheng Tan <sh= eng.tan@9elements.com>
Sent: Wednesday, June 5, 2024 10:18:27 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Witt, Sebasti= an <sebastian.witt@siemens.com>; Guo, Gua <gua.guo@intel.com>; = Rhodes, Sean <sean@starlabs.systems>; Lu, James <james.lu@intel.co= m>; Dong, Guo <guo.dong@intel.com>
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore fo= r payload size > 16MB
 
+ edk2 payload maintainers 

Best Regards,
Lean = Sheng Tan



9elements GmbH, Kortumstra=DFe 19-21, 44787 Bochum, Germany

Registered office: Bochum
Commercial register: Amtsgericht Bo= chum, HRB 17519
Management: Sebastian German, Eray = Bazaar


On Mon, 3 Jun 2024 at 23:20, Witt, = Sebastian via groups.io <sebastian.witt=3Dsiemens.com@groups.io> wrote:

Fix calculation of first section in FileFindSection for FILE2 headers in Ue= fiPayloadEntry module.

Signed-of-by: Sebastian Witt <sebastian.witt@siemens.com>
---
 UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c b/UefiPayloadPkg= /UefiPayloadEntry/LoadDxeCore.c
index 898d610951..9cb6edefcf 100644
--- a/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c
+++ b/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c
@@ -211,13 +211,14 @@ FileFindSection (

   if (IS_FFS_FILE2 (FileHeader)) {
     FileSize =3D FFS_FILE2_SIZE (FileHeader);
+    Section =3D (EFI_COMMON_SECTION_HEADER *)(((EFI_FFS_FILE_HEA= DER2 *)FileHeader) + 1);
   } else {
     FileSize =3D FFS_FILE_SIZE (FileHeader);
+    Section =3D (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1);    }

   FileSize -=3D sizeof (EFI_FFS_FILE_HEADER);

-  Section =3D (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1);
   Index   =3D 0;
   while (Index < FileSize) {
     if (Section->Type =3D=3D SectionType) {
--
2.39.2






_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#119473) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_DS0PR11MB7681E42D855C7242CE2F7911EFF92DS0PR11MB7681namp_--