* [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size > 16MB @ 2024-06-03 15:51 Witt, Sebastian via groups.io 2024-06-05 14:18 ` Lean Sheng Tan 0 siblings, 1 reply; 7+ messages in thread From: Witt, Sebastian via groups.io @ 2024-06-03 15:51 UTC (permalink / raw) To: devel@edk2.groups.io Fix calculation of first section in FileFindSection for FILE2 headers in UefiPayloadEntry module. Signed-of-by: Sebastian Witt <sebastian.witt@siemens.com> --- UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c b/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c index 898d610951..9cb6edefcf 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c +++ b/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c @@ -211,13 +211,14 @@ FileFindSection ( if (IS_FFS_FILE2 (FileHeader)) { FileSize = FFS_FILE2_SIZE (FileHeader); + Section = (EFI_COMMON_SECTION_HEADER *)(((EFI_FFS_FILE_HEADER2 *)FileHeader) + 1); } else { FileSize = FFS_FILE_SIZE (FileHeader); + Section = (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1); } FileSize -= sizeof (EFI_FFS_FILE_HEADER); - Section = (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1); Index = 0; while (Index < FileSize) { if (Section->Type == SectionType) { -- 2.39.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119435): https://edk2.groups.io/g/devel/message/119435 Mute This Topic: https://groups.io/mt/106471262/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size > 16MB 2024-06-03 15:51 [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size > 16MB Witt, Sebastian via groups.io @ 2024-06-05 14:18 ` Lean Sheng Tan 2024-06-05 14:22 ` Guo, Gua 0 siblings, 1 reply; 7+ messages in thread From: Lean Sheng Tan @ 2024-06-05 14:18 UTC (permalink / raw) To: devel, sebastian.witt, Guo, Gua, Sean Rhodes, Lu, James, Dong, Guo [-- Attachment #1: Type: text/plain, Size: 2110 bytes --] + edk2 payload maintainers Best Regards, *Lean Sheng Tan* 9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany Email: sheng.tan@9elements.com Phone: *+49 234 68 94 188 <+492346894188>* Mobile: *+49 176 76 113842 <+4917676113842>* Registered office: Bochum Commercial register: Amtsgericht Bochum, HRB 17519 Management: Sebastian German, Eray Bazaar Data protection information according to Art. 13 GDPR <https://9elements.com/privacy> On Mon, 3 Jun 2024 at 23:20, Witt, Sebastian via groups.io <sebastian.witt= siemens.com@groups.io> wrote: > > Fix calculation of first section in FileFindSection for FILE2 headers in > UefiPayloadEntry module. > > Signed-of-by: Sebastian Witt <sebastian.witt@siemens.com> > --- > UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c > b/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c > index 898d610951..9cb6edefcf 100644 > --- a/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c > +++ b/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c > @@ -211,13 +211,14 @@ FileFindSection ( > > if (IS_FFS_FILE2 (FileHeader)) { > FileSize = FFS_FILE2_SIZE (FileHeader); > + Section = (EFI_COMMON_SECTION_HEADER *)(((EFI_FFS_FILE_HEADER2 > *)FileHeader) + 1); > } else { > FileSize = FFS_FILE_SIZE (FileHeader); > + Section = (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1); > } > > FileSize -= sizeof (EFI_FFS_FILE_HEADER); > > - Section = (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1); > Index = 0; > while (Index < FileSize) { > if (Section->Type == SectionType) { > -- > 2.39.2 > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119472): https://edk2.groups.io/g/devel/message/119472 Mute This Topic: https://groups.io/mt/106471262/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- [-- Attachment #2: Type: text/html, Size: 4988 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size > 16MB 2024-06-05 14:18 ` Lean Sheng Tan @ 2024-06-05 14:22 ` Guo, Gua 2024-06-05 23:08 ` Guo Dong 2024-06-06 13:38 ` Witt, Sebastian via groups.io 0 siblings, 2 replies; 7+ messages in thread From: Guo, Gua @ 2024-06-05 14:22 UTC (permalink / raw) To: Tan, Lean Sheng, devel@edk2.groups.io, Witt, Sebastian, Rhodes, Sean, Lu, James, Dong, Guo [-- Attachment #1: Type: text/plain, Size: 2660 bytes --] Please send PR also. ________________________________ From: Lean Sheng Tan <sheng.tan@9elements.com> Sent: Wednesday, June 5, 2024 10:18:27 PM To: devel@edk2.groups.io <devel@edk2.groups.io>; Witt, Sebastian <sebastian.witt@siemens.com>; Guo, Gua <gua.guo@intel.com>; Rhodes, Sean <sean@starlabs.systems>; Lu, James <james.lu@intel.com>; Dong, Guo <guo.dong@intel.com> Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size > 16MB + edk2 payload maintainers Best Regards, Lean Sheng Tan [http://static.9elements.com/logo-signature.png] 9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany Email: sheng.tan@9elements.com<mailto:sheng.tan@9elements.com> Phone: +49 234 68 94 188<tel:+492346894188> Mobile: +49 176 76 113842<tel:+4917676113842> Registered office: Bochum Commercial register: Amtsgericht Bochum, HRB 17519 Management: Sebastian German, Eray Bazaar Data protection information according to Art. 13 GDPR<https://9elements.com/privacy> On Mon, 3 Jun 2024 at 23:20, Witt, Sebastian via groups.io<http://groups.io> <sebastian.witt=siemens.com@groups.io<mailto:siemens.com@groups.io>> wrote: Fix calculation of first section in FileFindSection for FILE2 headers in UefiPayloadEntry module. Signed-of-by: Sebastian Witt <sebastian.witt@siemens.com<mailto:sebastian.witt@siemens.com>> --- UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c b/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c index 898d610951..9cb6edefcf 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c +++ b/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c @@ -211,13 +211,14 @@ FileFindSection ( if (IS_FFS_FILE2 (FileHeader)) { FileSize = FFS_FILE2_SIZE (FileHeader); + Section = (EFI_COMMON_SECTION_HEADER *)(((EFI_FFS_FILE_HEADER2 *)FileHeader) + 1); } else { FileSize = FFS_FILE_SIZE (FileHeader); + Section = (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1); } FileSize -= sizeof (EFI_FFS_FILE_HEADER); - Section = (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1); Index = 0; while (Index < FileSize) { if (Section->Type == SectionType) { -- 2.39.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119473): https://edk2.groups.io/g/devel/message/119473 Mute This Topic: https://groups.io/mt/106471262/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- [-- Attachment #2: Type: text/html, Size: 6121 bytes --] ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size > 16MB 2024-06-05 14:22 ` Guo, Gua @ 2024-06-05 23:08 ` Guo Dong 2024-06-06 13:38 ` Witt, Sebastian via groups.io 1 sibling, 0 replies; 7+ messages in thread From: Guo Dong @ 2024-06-05 23:08 UTC (permalink / raw) To: Guo, Gua, Tan, Lean Sheng, devel@edk2.groups.io, Witt, Sebastian, Rhodes, Sean, Lu, James [-- Attachment #1: Type: text/plain, Size: 3355 bytes --] Reviewed-by: Guo Dong <guo.dong@intel.com<mailto:guo.dong@intel.com>> From: Guo, Gua <gua.guo@intel.com> Sent: Wednesday, June 5, 2024 7:22 AM To: Tan, Lean Sheng <sheng.tan@9elements.com>; devel@edk2.groups.io; Witt, Sebastian <sebastian.witt@siemens.com>; Rhodes, Sean <sean@starlabs.systems>; Lu, James <james.lu@intel.com>; Dong, Guo <guo.dong@intel.com> Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size > 16MB Please send PR also. ________________________________ From: Lean Sheng Tan <sheng.tan@9elements.com<mailto:sheng.tan@9elements.com>> Sent: Wednesday, June 5, 2024 10:18:27 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; Witt, Sebastian <sebastian.witt@siemens.com<mailto:sebastian.witt@siemens.com>>; Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; Rhodes, Sean <sean@starlabs.systems<mailto:sean@starlabs.systems>>; Lu, James <james.lu@intel.com<mailto:james.lu@intel.com>>; Dong, Guo <guo.dong@intel.com<mailto:guo.dong@intel.com>> Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size > 16MB + edk2 payload maintainers Best Regards, Lean Sheng Tan [http://static.9elements.com/logo-signature.png] 9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany Email: sheng.tan@9elements.com<mailto:sheng.tan@9elements.com> Phone: +49 234 68 94 188<tel:+492346894188> Mobile: +49 176 76 113842<tel:+4917676113842> Registered office: Bochum Commercial register: Amtsgericht Bochum, HRB 17519 Management: Sebastian German, Eray Bazaar Data protection information according to Art. 13 GDPR<https://9elements.com/privacy> On Mon, 3 Jun 2024 at 23:20, Witt, Sebastian via groups.io<http://groups.io> <sebastian.witt=siemens.com@groups.io<mailto:siemens.com@groups.io>> wrote: Fix calculation of first section in FileFindSection for FILE2 headers in UefiPayloadEntry module. Signed-of-by: Sebastian Witt <sebastian.witt@siemens.com<mailto:sebastian.witt@siemens.com>> --- UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c b/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c index 898d610951..9cb6edefcf 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c +++ b/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c @@ -211,13 +211,14 @@ FileFindSection ( if (IS_FFS_FILE2 (FileHeader)) { FileSize = FFS_FILE2_SIZE (FileHeader); + Section = (EFI_COMMON_SECTION_HEADER *)(((EFI_FFS_FILE_HEADER2 *)FileHeader) + 1); } else { FileSize = FFS_FILE_SIZE (FileHeader); + Section = (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1); } FileSize -= sizeof (EFI_FFS_FILE_HEADER); - Section = (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1); Index = 0; while (Index < FileSize) { if (Section->Type == SectionType) { -- 2.39.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119490): https://edk2.groups.io/g/devel/message/119490 Mute This Topic: https://groups.io/mt/106471262/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- [-- Attachment #2: Type: text/html, Size: 11716 bytes --] ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size > 16MB 2024-06-05 14:22 ` Guo, Gua 2024-06-05 23:08 ` Guo Dong @ 2024-06-06 13:38 ` Witt, Sebastian via groups.io 2024-06-10 15:28 ` Lean Sheng Tan via groups.io 1 sibling, 1 reply; 7+ messages in thread From: Witt, Sebastian via groups.io @ 2024-06-06 13:38 UTC (permalink / raw) To: Guo, Gua, Tan, Lean Sheng, devel@edk2.groups.io, Rhodes, Sean, Lu, James, Dong, Guo [-- Attachment #1.1: Type: text/plain, Size: 3111 bytes --] Done here: https://github.com/tianocore/edk2/pull/5732 Regards, Sebastian From: Guo, Gua <gua.guo@intel.com> Sent: Wednesday, 5 June 2024 16:22 To: Tan, Lean Sheng <sheng.tan@9elements.com>; devel@edk2.groups.io; Witt, Sebastian (DI FA CTR IPC PRC2) <sebastian.witt@siemens.com>; Rhodes, Sean <sean@starlabs.systems>; Lu, James <james.lu@intel.com>; Dong, Guo <guo.dong@intel.com> Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size > 16MB Please send PR also. ________________________________ From: Lean Sheng Tan <sheng.tan@9elements.com> Sent: Wednesday, June 5, 2024 10:18:27 PM To: devel@edk2.groups.io <devel@edk2.groups.io>; Witt, Sebastian <sebastian.witt@siemens.com>; Guo, Gua <gua.guo@intel.com>; Rhodes, Sean <sean@starlabs.systems>; Lu, James <james.lu@intel.com>; Dong, Guo <guo.dong@intel.com> Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size > 16MB + edk2 payload maintainers Best Regards, Lean Sheng Tan [Image removed by sender.] 9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany Email: sheng.tan@9elements.com<mailto:sheng.tan@9elements.com> Phone: +49 234 68 94 188<tel:+492346894188> Mobile: +49 176 76 113842<tel:+4917676113842> Registered office: Bochum Commercial register: Amtsgericht Bochum, HRB 17519 Management: Sebastian German, Eray Bazaar Data protection information according to Art. 13 GDPR<https://9elements.com/privacy> On Mon, 3 Jun 2024 at 23:20, Witt, Sebastian via groups.io<http://groups.io/> <sebastian.witt=siemens.com@groups.io<mailto:siemens.com@groups.io>> wrote: Fix calculation of first section in FileFindSection for FILE2 headers in UefiPayloadEntry module. Signed-of-by: Sebastian Witt <sebastian.witt@siemens.com<mailto:sebastian.witt@siemens.com>> --- UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c b/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c index 898d610951..9cb6edefcf 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c +++ b/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c @@ -211,13 +211,14 @@ FileFindSection ( if (IS_FFS_FILE2 (FileHeader)) { FileSize = FFS_FILE2_SIZE (FileHeader); + Section = (EFI_COMMON_SECTION_HEADER *)(((EFI_FFS_FILE_HEADER2 *)FileHeader) + 1); } else { FileSize = FFS_FILE_SIZE (FileHeader); + Section = (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1); } FileSize -= sizeof (EFI_FFS_FILE_HEADER); - Section = (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1); Index = 0; while (Index < FileSize) { if (Section->Type == SectionType) { -- 2.39.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119507): https://edk2.groups.io/g/devel/message/119507 Mute This Topic: https://groups.io/mt/106471262/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- [-- Attachment #1.2: Type: text/html, Size: 11171 bytes --] [-- Attachment #2: ~WRD0002.jpg --] [-- Type: image/jpeg, Size: 823 bytes --] ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size > 16MB 2024-06-06 13:38 ` Witt, Sebastian via groups.io @ 2024-06-10 15:28 ` Lean Sheng Tan via groups.io 2024-06-10 15:31 ` Guo, Gua 0 siblings, 1 reply; 7+ messages in thread From: Lean Sheng Tan via groups.io @ 2024-06-10 15:28 UTC (permalink / raw) To: Witt, Sebastian Cc: Guo, Gua, devel@edk2.groups.io, Rhodes, Sean, Lu, James, Dong, Guo [-- Attachment #1.1: Type: text/plain, Size: 3950 bytes --] Hi Gua/ Dong Guo, Do you know how to proceed? https://github.com/tianocore/edk2/pull/5732 Does the patch submitter have to actively rebase its patch? Best Regards, *Lean Sheng Tan* 9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany Email: sheng.tan@9elements.com Phone: *+49 234 68 94 188 <+492346894188>* Mobile: *+49 176 76 113842 <+4917676113842>* Registered office: Bochum Commercial register: Amtsgericht Bochum, HRB 17519 Management: Sebastian German, Eray Bazaar Data protection information according to Art. 13 GDPR <https://9elements.com/privacy> On Thu, 6 Jun 2024 at 15:38, Witt, Sebastian <sebastian.witt@siemens.com> wrote: > Done here: https://github.com/tianocore/edk2/pull/5732 > > > > Regards, > > Sebastian > > > > *From:* Guo, Gua <gua.guo@intel.com> > *Sent:* Wednesday, 5 June 2024 16:22 > *To:* Tan, Lean Sheng <sheng.tan@9elements.com>; devel@edk2.groups.io; > Witt, Sebastian (DI FA CTR IPC PRC2) <sebastian.witt@siemens.com>; > Rhodes, Sean <sean@starlabs.systems>; Lu, James <james.lu@intel.com>; > Dong, Guo <guo.dong@intel.com> > *Subject:* Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for > payload size > 16MB > > > > Please send PR also. > ------------------------------ > > *From:* Lean Sheng Tan <sheng.tan@9elements.com> > *Sent:* Wednesday, June 5, 2024 10:18:27 PM > *To:* devel@edk2.groups.io <devel@edk2.groups.io>; Witt, Sebastian < > sebastian.witt@siemens.com>; Guo, Gua <gua.guo@intel.com>; Rhodes, Sean > <sean@starlabs.systems>; Lu, James <james.lu@intel.com>; Dong, Guo < > guo.dong@intel.com> > *Subject:* Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for > payload size > 16MB > > > > + edk2 payload maintainers > > > Best Regards, > > *Lean Sheng Tan* > > > [image: Image removed by sender.] > > 9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany > > Email: sheng.tan@9elements.com > > Phone: *+49 234 68 94 188 <+492346894188>* > > Mobile: *+49 176 76 113842 <+4917676113842>* > > > > Registered office: Bochum > > Commercial register: Amtsgericht Bochum, HRB 17519 > > Management: Sebastian German, Eray Bazaar > > > Data protection information according to Art. 13 GDPR > <https://9elements.com/privacy> > > > > > > On Mon, 3 Jun 2024 at 23:20, Witt, Sebastian via groups.io > <sebastian.witt=siemens.com@groups.io> wrote: > > > Fix calculation of first section in FileFindSection for FILE2 headers in > UefiPayloadEntry module. > > Signed-of-by: Sebastian Witt <sebastian.witt@siemens.com> > --- > UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c > b/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c > index 898d610951..9cb6edefcf 100644 > --- a/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c > +++ b/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c > @@ -211,13 +211,14 @@ FileFindSection ( > > if (IS_FFS_FILE2 (FileHeader)) { > FileSize = FFS_FILE2_SIZE (FileHeader); > + Section = (EFI_COMMON_SECTION_HEADER *)(((EFI_FFS_FILE_HEADER2 > *)FileHeader) + 1); > } else { > FileSize = FFS_FILE_SIZE (FileHeader); > + Section = (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1); > } > > FileSize -= sizeof (EFI_FFS_FILE_HEADER); > > - Section = (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1); > Index = 0; > while (Index < FileSize) { > if (Section->Type == SectionType) { > -- > 2.39.2 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119536): https://edk2.groups.io/g/devel/message/119536 Mute This Topic: https://groups.io/mt/106471262/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- [-- Attachment #1.2: Type: text/html, Size: 13113 bytes --] [-- Attachment #2: ~WRD0002.jpg --] [-- Type: image/jpeg, Size: 823 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size > 16MB 2024-06-10 15:28 ` Lean Sheng Tan via groups.io @ 2024-06-10 15:31 ` Guo, Gua 0 siblings, 0 replies; 7+ messages in thread From: Guo, Gua @ 2024-06-10 15:31 UTC (permalink / raw) To: Tan, Lean Sheng, Witt, Sebastian Cc: devel@edk2.groups.io, Rhodes, Sean, Lu, James, Dong, Guo [-- Attachment #1.1: Type: text/plain, Size: 4781 bytes --] I’ve added push label, it will be merged tomorrow. From: Lean Sheng Tan <sheng.tan@9elements.com> Sent: Monday, June 10, 2024 11:28 PM To: Witt, Sebastian <sebastian.witt@siemens.com> Cc: Guo, Gua <gua.guo@intel.com>; devel@edk2.groups.io; Rhodes, Sean <sean@starlabs.systems>; Lu, James <james.lu@intel.com>; Dong, Guo <guo.dong@intel.com> Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size > 16MB Hi Gua/ Dong Guo, Do you know how to proceed? https://github.com/tianocore/edk2/pull/5732 Does the patch submitter have to actively rebase its patch? Best Regards, Lean Sheng Tan [http://static.9elements.com/logo-signature.png] 9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany Email: sheng.tan@9elements.com<mailto:sheng.tan@9elements.com> Phone: +49 234 68 94 188<tel:+492346894188> Mobile: +49 176 76 113842<tel:+4917676113842> Registered office: Bochum Commercial register: Amtsgericht Bochum, HRB 17519 Management: Sebastian German, Eray Bazaar Data protection information according to Art. 13 GDPR<https://9elements.com/privacy> On Thu, 6 Jun 2024 at 15:38, Witt, Sebastian <sebastian.witt@siemens.com<mailto:sebastian.witt@siemens.com>> wrote: Done here: https://github.com/tianocore/edk2/pull/5732 Regards, Sebastian From: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>> Sent: Wednesday, 5 June 2024 16:22 To: Tan, Lean Sheng <sheng.tan@9elements.com<mailto:sheng.tan@9elements.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Witt, Sebastian (DI FA CTR IPC PRC2) <sebastian.witt@siemens.com<mailto:sebastian.witt@siemens.com>>; Rhodes, Sean <sean@starlabs.systems<mailto:sean@starlabs.systems>>; Lu, James <james.lu@intel.com<mailto:james.lu@intel.com>>; Dong, Guo <guo.dong@intel.com<mailto:guo.dong@intel.com>> Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size > 16MB Please send PR also. ________________________________ From: Lean Sheng Tan <sheng.tan@9elements.com<mailto:sheng.tan@9elements.com>> Sent: Wednesday, June 5, 2024 10:18:27 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; Witt, Sebastian <sebastian.witt@siemens.com<mailto:sebastian.witt@siemens.com>>; Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; Rhodes, Sean <sean@starlabs.systems<mailto:sean@starlabs.systems>>; Lu, James <james.lu@intel.com<mailto:james.lu@intel.com>>; Dong, Guo <guo.dong@intel.com<mailto:guo.dong@intel.com>> Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size > 16MB + edk2 payload maintainers Best Regards, Lean Sheng Tan [Image removed by sender.] 9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany Email: sheng.tan@9elements.com<mailto:sheng.tan@9elements.com> Phone: +49 234 68 94 188<tel:+492346894188> Mobile: +49 176 76 113842<tel:+4917676113842> Registered office: Bochum Commercial register: Amtsgericht Bochum, HRB 17519 Management: Sebastian German, Eray Bazaar Data protection information according to Art. 13 GDPR<https://9elements.com/privacy> On Mon, 3 Jun 2024 at 23:20, Witt, Sebastian via groups.io<http://groups.io/> <sebastian.witt=siemens.com@groups.io<mailto:siemens.com@groups.io>> wrote: Fix calculation of first section in FileFindSection for FILE2 headers in UefiPayloadEntry module. Signed-of-by: Sebastian Witt <sebastian.witt@siemens.com<mailto:sebastian.witt@siemens.com>> --- UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c b/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c index 898d610951..9cb6edefcf 100644 --- a/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c +++ b/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c @@ -211,13 +211,14 @@ FileFindSection ( if (IS_FFS_FILE2 (FileHeader)) { FileSize = FFS_FILE2_SIZE (FileHeader); + Section = (EFI_COMMON_SECTION_HEADER *)(((EFI_FFS_FILE_HEADER2 *)FileHeader) + 1); } else { FileSize = FFS_FILE_SIZE (FileHeader); + Section = (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1); } FileSize -= sizeof (EFI_FFS_FILE_HEADER); - Section = (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1); Index = 0; while (Index < FileSize) { if (Section->Type == SectionType) { -- 2.39.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119537): https://edk2.groups.io/g/devel/message/119537 Mute This Topic: https://groups.io/mt/106471262/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- [-- Attachment #1.2: Type: text/html, Size: 18666 bytes --] [-- Attachment #2: image001.jpg --] [-- Type: image/jpeg, Size: 823 bytes --] ^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-06-10 15:31 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-06-03 15:51 [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size > 16MB Witt, Sebastian via groups.io 2024-06-05 14:18 ` Lean Sheng Tan 2024-06-05 14:22 ` Guo, Gua 2024-06-05 23:08 ` Guo Dong 2024-06-06 13:38 ` Witt, Sebastian via groups.io 2024-06-10 15:28 ` Lean Sheng Tan via groups.io 2024-06-10 15:31 ` Guo, Gua
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
![[-- Attachment #2: image001.jpg --] [-- Type: image/jpeg, Size: 823 bytes --]](../../DS0PR11MB76814E502E87C5062CAFC894EFC62@DS0PR11MB7681.namprd11.prod.outlook.com/2-image001.jpg){kind=link}