From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id F3E16AC14EF for ; Wed, 23 Aug 2023 16:51:56 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=bUX4VqGUH04QPXr5nx4FV72svRrueqsNzFhhJ1SjmEk=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1692809515; v=1; b=fAeqfwG2TZAg45wubjsQUMo2C6LOHh3trrjD/lE5SqmOIPu9sAqJIgn3b5HWIgbxtcMXhDTe 6eckgmPHlmkB2KaNn9UXXzgIJThIyZbKBkam3nwF2oKykwkWJsxfb4McRKh16Lsq5t3UjSi7xoX 4J6hOovqyuN9qanc2G8W9VLI= X-Received: by 127.0.0.2 with SMTP id PC72YY7687511xloOSeRwIHP; Wed, 23 Aug 2023 09:51:55 -0700 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.77]) by mx.groups.io with SMTP id smtpd.web10.1842.1692809514286560727 for ; Wed, 23 Aug 2023 09:51:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LG6jSY0Wd3lVOu5mc9VHwx9lFMtvsq47ebJaBGNVJEGXltusQYldW6MvaVV4QudD8gb/6KBVaoarSYb9Ri0emGUX2GTdpbWOQ7OJJp/VGxo/MVN+Wto5nCTFtIgKq439bOaXDzK6BOq0pen94DxHe3YVTpZpKkEi2N4ISsrcwUUyM9P6G5y5bA+T+F4+tolL5/9+o5bd8yHik92Iv3ObVH/t/K2oqmsQzPo64e5oUB7e9jztoeN4o4ywdidFAJOoAzhE/EnBuVwE+944rerMAxT+sALr1WnDxVf2w/Rv5pS93QN8upVDJY5iYGgVRxNDSLhifA743RsKUrYUCIzZTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gGS66sIzmVR7DAMvSF1hsT3ER8JZCXC3KAHup2QhmZk=; b=gDcZJ2jkpRHfrf3sR+XmWMDjQV6BkVbP81Unlfq1AQUcTwNSwLZoFDvkI7boJWHITdWnkQzcpYLvdowngyRlBEz3HsRuI/ZWO9lovOg0m4sfPJjN5OaLZwVPcHkBwkzgOc/3zKzDWY9m6+P35wqcUO5sFwVLPDm/xm8LW19KXTTOvSksx83fiCpAnvmF6kRsEY2bHAhgRX4/URs/6CqzXyuDX/NiKdHwiVCrzXnT73NGzcRAaPX9LTh1csAbxrxZNatD21lmDWfecPf4XWVE3lYDyNtCaFKd14OCeQ2huAVEdRwIeImfpkkt5BnsiPAJdhnkiFFgQwR2opZ4V7l5pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none X-Received: from DS7PR10MB4974.namprd10.prod.outlook.com (2603:10b6:5:3a0::24) by DM4PR10MB6862.namprd10.prod.outlook.com (2603:10b6:8:105::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.24; Wed, 23 Aug 2023 16:51:49 +0000 X-Received: from DS7PR10MB4974.namprd10.prod.outlook.com ([fe80::2cf5:380d:d46b:7368]) by DS7PR10MB4974.namprd10.prod.outlook.com ([fe80::2cf5:380d:d46b:7368%3]) with mapi id 15.20.6699.026; Wed, 23 Aug 2023 16:51:49 +0000 From: "Sureshkumar Ponnusamy via groups.io" To: Sunny Wang , "devel@edk2.groups.io" , Abhi Singh CC: G Edhaya Chandran , Barton Gao , Samer El-Haj-Mahmoud , Felix Polyudov Subject: Re: [edk2-devel] [PATCH V1 1/1] uefi-sct/SctPkg: RouteConfig() returns EFI_ACCESS_DENIED passes with warning Thread-Topic: [EXTERNAL] RE: [edk2-devel] [PATCH V1 1/1] uefi-sct/SctPkg: RouteConfig() returns EFI_ACCESS_DENIED passes with warning Thread-Index: AQHZ1aX6mR82P9mOAUCKVU4OiGjL3K/4GJuw Date: Wed, 23 Aug 2023 16:51:49 +0000 Message-ID: References: <20230822182354.79292-1-Abhi.Singh@arm.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DS7PR10MB4974:EE_|DM4PR10MB6862:EE_ x-ms-office365-filtering-correlation-id: b4406db3-132e-4b2e-66b2-08dba3f93e58 x-ld-processed: 27e97857-e15f-486c-b58e-86c2b3040f93,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: /dq0e8hXTHmug96J+naRddaNDmcX0HBjyDTvKKI+BMMjCl/yLtbBy+PPADbjSJaFsZd5hNB2Rr+nUIPvQBYjoGZKMwQ0ZCwheEn0EDm9IdLduGm4S58lAGwKB5+lwISjGV+fa6Q3h4+hoxf3RJwDiFAUoxu83bk4ZDi9ay0dM5e5WtPl2vO+2z4Apoq0KY6KngvqPepHRAgolWIb/K0+cTHeltaDdsSN/KOJ8iAe0nHgBQTmj8M3gWsW/di60UkyjSQLG/bQYrGJYfzx1ThqqQ/BWhXfKWfcNwBnlrsBYuVs7e8Z4Ap1qCJanmhe/k6YUz5KhDI9aEOaN2cnBR+hnqzx3/quUulnY7qf4XoztcbtmrqRp+tyF9iVl3E2qF16WAMAjUwpLL7DaP1kITr0bddV0pCGGQlYCoiJoqOEsyAEP/ZRehKv6a96IAmj6lM+BQemcI/v866h8S/iCsvDDVcnQAAwPNBgy2Nx6mc6pUhI2oQvqWuODuk5A1mrWRHDV0c51r7oS78J3uJkC7ir9BUuOZxLBQmawybttk8kmoqkHpJLd++lgulVAzOKh+CKtJ48o6XwNTZebjF57uJ03YAKT3CIEAvdoq6HgFalQ5M= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VcH8ZCeyLHjOG+eouPoKTu68HTKCdAqW5tVC1gxufsAsZAc1fDA/DBxEh/8f?= =?us-ascii?Q?Q+M9mWHhvkXs6G01izP6jvIvEU6PA2QZz/qThpEy45s/lzBj9OTvcLR5W94/?= =?us-ascii?Q?DHLfExgi+7ARGtoUNzyna+WUc9Si9yU7H1/LhLYD3UcLuZk2wpjaDwwnzONn?= =?us-ascii?Q?wYTfXPfZNAH4VVjUArpwIO7Z4g0cUfOtk3Gx3l+8aWhNHO5Dlb1IxTAQZWTe?= =?us-ascii?Q?D7+kr2CYXJYeujthKplYgluCDYZo1dgOuJcpEW//HHmEnW2qcZU+qga4F7il?= =?us-ascii?Q?DJQyb0k7LXhD0/fL2pIUKpxZyaX2SJTthupkryFMsukAswDKOTFWeW6WOST4?= =?us-ascii?Q?NZeOOalWhpQftWaqMrWj5eL2Oz1JH4SXYmfQSiKcLuOSsTLzQpdI5cQklTEC?= =?us-ascii?Q?j0qGYoLXfY63ctgmuB7Z5dNvh04NqWQV47lL9XaRMKyYEijFpj4qu8C0gwTv?= =?us-ascii?Q?69/RLn/3iSp6KBMwmSOJ82BlnrvdCFmehFkR4gi+jr9z5w08RDnPbAhiUMDO?= =?us-ascii?Q?Qyaf6g3OT8c7D1zS7RMFCUI11YN9qf4bs7Si9n9a0CQm71DLWmSusZXty2DJ?= =?us-ascii?Q?cjHke1zsftcWcCuIJPd3+eI8HL7GlF+3fcAOe1AyGxb2BvxGmDPsckjc2OF/?= =?us-ascii?Q?4vMDWyWKSFDVLrZ3oDITJOBZh0j1S0+FT7+r3a28K2c1001IZir/8bGBIyZn?= =?us-ascii?Q?FSJvCa1heIJO6JvSMqa5CP1McdfjSfC77gas2+k41Cu8sC4ptUxTWcuuFnW/?= =?us-ascii?Q?0v1wxzb2d0RtKB73nZeIJspaOftohrZMNb3rKoGSQAQUc3c9qT0PPdMmLkJx?= =?us-ascii?Q?QdAORiNmEE4rA48YjpZzcsIyFpVpdYuJBopnQm4gz3S8R5v/+jlVdSKsg97/?= =?us-ascii?Q?H4YdgR4vJ8MHdsCKM0POhekB9GHRv1wnESCMw1k6utEjESZF5wCu3gDfXwXM?= =?us-ascii?Q?vxZOjMGOEghFJkHBhWpoisEVIULMgIYGjA0u32u/UJhJy1T0jC9VulxHJIoy?= =?us-ascii?Q?mLC0UgKHHZsqnn/DR65SpDbGGMasgLCMpDv8r46+jRFzjwm6ASAw4zsxxnbq?= =?us-ascii?Q?ViaTdDySTbVeyBuNWtsLx+ik6dHE/l3jAHzt3PtBB5g6SL/4bd0JuIoJJk/I?= =?us-ascii?Q?z8xqtWl9ln7cib/YwO9duH6iiCk4w5l5rFNjO1OmIPje2ScFy5OyI24lY3Eb?= =?us-ascii?Q?GODby7LQybavfqu8W67j6Zz6DB53yCHDiJn9x6lXVCJq3I+yTRa//3hr5XU/?= =?us-ascii?Q?raI2331D5o7cuPmPWev4PM6j1njCXd4/8wJTOU/zuhmHeoLtInuHMiadZp6C?= =?us-ascii?Q?m9HguRsKxGAliy7hr290bxbEVliHJdIJrpgXrvnouHrBz3BuSVmFeo5GBwks?= =?us-ascii?Q?1HsmHFcKtH4etJiJ+VNUqOnALbnmyw+QapAdFauF4yE8/EW3+cNiy2MyqHLd?= =?us-ascii?Q?mRCTJUm66EiIZr/HheojXFga/N1WHaOHfkEESOQS46dCuQES6OHTdJklrxze?= =?us-ascii?Q?TW9wYYDg0OaBhBCjk2lEwZyQPZKJUl9g8T9w6mOKtreWg9hHt8k7+WUBf+Eg?= =?us-ascii?Q?2bhY98DG0/UmAa8u8X3nYMcc0bQYkVD6p/qWcZ0h?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS7PR10MB4974.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4406db3-132e-4b2e-66b2-08dba3f93e58 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Aug 2023 16:51:49.0642 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NUQFxMZkdFHj5dayQJLYqZqOHqUTyZ6sLhrVBFHtwfzLU+ipIN2HhsF1NQg5pGlgtwcv44h7muukLKCiquAtBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6862 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sureshkumarp@ami.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: u5RaOisCqxlXariGD7YT7IIDx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=fAeqfwG2; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io The changes looks good . Thanks Abhi and Sunny. -----Original Message----- From: Sunny Wang Sent: Wednesday, August 23, 2023 5:40 AM To: devel@edk2.groups.io; Abhi Singh Cc: G Edhaya Chandran ; Barton Gao ; Samer El-Haj-Mahmoud ; Sureshkumar = Ponnusamy ; Felix Polyudov ; Sunny Wa= ng Subject: [EXTERNAL] RE: [edk2-devel] [PATCH V1 1/1] uefi-sct/SctPkg: RouteC= onfig() returns EFI_ACCESS_DENIED passes with warning **CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.** Looks good to me. Thanks for working on this, Abhi. Cc people to the email. Somehow the people you added in your commit message= haven't been automatically added to email's Cc list. I guess you might acc= identally use " --suppress-cc=3Dall" when you sent the patch out. Reviewed-by: Sunny Wang Best Regards, Sunny -----Original Message----- From: devel@edk2.groups.io On Behalf Of Abhimanyu Si= ngh via groups.io Sent: Tuesday, August 22, 2023 7:24 PM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH V1 1/1] uefi-sct/SctPkg: RouteConfig() returns= EFI_ACCESS_DENIED passes with warning REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3759 HIIConfigAccess and HIIConfigRouting Protocol RouteConfig tests assertions = store a failure when RouteConfig returns EFI_ACCESS_DENIED. In the UEFI SPE= C RouteConfig in both protocols can return EFI_ACCESS_DENIED when the actio= n violates a system policy. The tests now record a pass with warning. Cc: G Edhaya Chandran Cc: Barton Gao Cc: Carolyn Gjertsen Cc: Samer El-Haj-Mahmoud Cc: Sunny Wang Signed-off-by: Abhi Singh Change-Id: I8591c3d7b0855133141779d3c53a159129400815 --- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HI= IConfigAccessBBTestFunction.c | 2 +- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigRouting/BlackBoxTest/H= IIConfigRoutingBBTestFunction.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/Bla= ckBoxTest/HIIConfigAccessBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/E= FI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestFunction.c index b3276487bb3c..8e46b547bdfe 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTe= st/HIIConfigAccessBBTestFunction.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBo +++ xTest/HIIConfigAccessBBTestFunction.c @@ -521,7 +521,7 @@ BBTestRouteConfigFunctionTestCheckpoint1 ( ); if ( (EFI_SUCCESS =3D=3D Status) && (Progress =3D=3D Resp + SctStrLen (R= esp)) ) { AssertionType =3D EFI_TEST_ASSERTION_PASSED; - } else if ( EFI_OUT_OF_RESOURCES =3D=3D Status ) { + } else if ( (EFI_OUT_OF_RESOURCES =3D=3D Status) || (EFI_ACCESS_DENIED = =3D=3D + Status) ) { AssertionType =3D EFI_TEST_ASSERTION_WARNING; } else { AssertionType =3D EFI_TEST_ASSERTION_FAILED; diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigRouting/Bl= ackBoxTest/HIIConfigRoutingBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI= /EFI/Protocol/HIIConfigRouting/BlackBoxTest/HIIConfigRoutingBBTestFunction.= c index d4bd23d1fd82..9d7a7dcf42e2 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigRouting/BlackBoxT= est/HIIConfigRoutingBBTestFunction.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigRouting/BlackB +++ oxTest/HIIConfigRoutingBBTestFunction.c @@ -546,7 +546,7 @@ BBTestRouteConfigFunctionTestCheckpoint1 ( if ( (EFI_SUCCESS =3D=3D Status) && (Progress =3D=3D Resp2 + SctStrLen (= Resp2)) ) { AssertionType =3D EFI_TEST_ASSERTION_PASSED; - } else if ( EFI_OUT_OF_RESOURCES =3D=3D Status ){ + } else if ( (EFI_OUT_OF_RESOURCES =3D=3D Status) || (EFI_ACCESS_DENIED = =3D=3D + Status) ) { AssertionType =3D EFI_TEST_ASSERTION_WARNING; } else { AssertionType =3D EFI_TEST_ASSERTION_FAILED; -- 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107958): https://edk2.groups.io/g/devel/message/107958 Mute This Topic: https://groups.io/mt/100899969/5985097 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [Sunny.Wang@arm.com] -=3D= -=3D-=3D-=3D-=3D-=3D IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you. -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107984): https://edk2.groups.io/g/devel/message/107984 Mute This Topic: https://groups.io/mt/100899969/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-