From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 36412740051 for ; Mon, 25 Nov 2024 10:03:45 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=LekvsJLZn/7vnYgK3XrCnhL6skYlaZ7IWdSIT3ANEDw=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240830; t=1732529024; v=1; x=1732788223; b=GupU/v+oVavH7LrtC60odXtk27Uh6Wsi8zDBzHivLxoGw+DS1nUEOIR2q48ONIz4UqF0CBYv VFf/+4Ktj+xmqT4YpGU770NPsQUh4NnJut78vFvAIzq8rsGPl352PoCOJ9avMPOvOvdZHnk230N DRgNvBjGysB4r8woWEkPbaARotGBPQ3ZbJKEJuFx4gJLsZeN2wVd7I+PGVfvLn6eBjpbYechc7I LMBVO1rxiySXhRxzNKM7YfM8768I1Kjbr5/eKi4WxUQGS5DrK2bvKx3un0v9AuKtOOwpTWtK3zO pP4ZbJCOieb9oCiOYgE/lJh6xK+WLGUeYCgvGF4yitmrw== X-Received: by 127.0.0.2 with SMTP id 4v9KYY7687511x6RS7lpUJPa; Mon, 25 Nov 2024 02:03:43 -0800 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.125]) by mx.groups.io with SMTP id smtpd.web11.15757.1732529022682684436 for ; Mon, 25 Nov 2024 02:03:43 -0800 X-Received: from DS7PR10MB5375.namprd10.prod.outlook.com (2603:10b6:5:3ab::11) by CH3PR10MB7563.namprd10.prod.outlook.com (2603:10b6:610:180::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8182.21; Mon, 25 Nov 2024 10:03:38 +0000 X-Received: from DS7PR10MB5375.namprd10.prod.outlook.com ([fe80::4e81:bab3:e545:22eb]) by DS7PR10MB5375.namprd10.prod.outlook.com ([fe80::4e81:bab3:e545:22eb%5]) with mapi id 15.20.8182.019; Mon, 25 Nov 2024 10:03:37 +0000 From: "Santhosh Kumar V via groups.io" To: "Kasbekar, Saloni" , "Li, Yi1" , "devel@edk2.groups.io" , "michael.d.kinney@intel.com" CC: "Otcheretianski, Andrei" , "Clark-williams, Zachary" , "Luo, Heng" Subject: Re: [edk2-devel] [PATCH] NetworkPkg: Increase HTTP buffer size and enable TCP window scaling Thread-Topic: [EXTERNAL] Re: [edk2-devel] [PATCH] NetworkPkg: Increase HTTP buffer size and enable TCP window scaling Thread-Index: AQHZvq71BwVdg6ecwE6F78oDaqWinbANwVmAgADnw4CAAsdnAIAAP5aAgrkTnDg= Date: Mon, 25 Nov 2024 10:03:37 +0000 Message-ID: References: <20230721051759.7021-1-yi1.li@intel.com> In-Reply-To: Accept-Language: en-US, en-IN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DS7PR10MB5375:EE_|CH3PR10MB7563:EE_ x-ms-office365-filtering-correlation-id: 53344287-0e17-4394-4521-08dd0d386e75 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?Windows-1252?Q?PSjxThOIfbgsLLVwnej4zE06IBW9JqQqop1Sth9DsMeZDdjD+6OCXwa4?= =?Windows-1252?Q?lxnZ51hxUrZnfnJzsfgbgh4SxV7eUxes/3mbdThUy9sa/K4JxoL40QMj?= =?Windows-1252?Q?PA05wLZVDuYxNxaVzIXcvQnz0EfzN48yVO1N7Celt47HKvPq3IO7yDOu?= =?Windows-1252?Q?nTJ3fmEZ7RMKhFJSgrTx6cxNW5wQCYKRR0gq6jGxHvxRmgBjLFSSeLFX?= =?Windows-1252?Q?LaufFMroe8oH49lSzfXCzDuvMFwgCkr9Piff3J/gJSoF57+h0GvUcDmr?= =?Windows-1252?Q?ek6Zpzmu6fJcaprtk3cdHognrlzZ417B40mrUf7IUrR34mqG+X8954J5?= =?Windows-1252?Q?fhPS6+hqR3Yz5OBGjcXSmhcSAX9tojMPOy1JgJX6jEHbpOjrMHqmXoyy?= =?Windows-1252?Q?ddsZAq6dPnsnftsr6oxudgXE+o02NRWQl8eRcyum+LKdutePXppIzKTP?= =?Windows-1252?Q?C9dEQEpPLCpRDClmC/d+SIW80PSVEieCquLE7a+5BSxAgwsumBXV3oHO?= =?Windows-1252?Q?jVR2Aptu8N5X5Wj51xm9JGLqL38NSfxTlVA5OawE6sf7P/6KpkX8bTFh?= =?Windows-1252?Q?wkgGIO/2PrwaAtREr1N1vHAEqH0U6vo4ZbE7nHIr1FSR+6hDyP9rhHGV?= =?Windows-1252?Q?KJrOxiQadT1ti4cYXv5mSNoe62BaoL1OoGeVQjWi4drk/b5WEONWD7ke?= =?Windows-1252?Q?5qzEQIu+S0iSHZQTx37Vw1FDMqqGiaSagKKAwz73BUeegUNSJ2TiNI8G?= =?Windows-1252?Q?7Cv06SpoW0wF2BX0EQqcgngVG6KF7/D41tA9SvyPNUptlPUzIiVLIfO7?= =?Windows-1252?Q?2thcT9C0o5DQKMem4o6dimmDje8Fmbp3NUsQznqBzcdBHsI0llOhnanK?= =?Windows-1252?Q?1PZrnxEuvWNf1OWcd5HtlHrYiQZlD9cdWlLrof6FqSVcE9hNeAy2kNq8?= =?Windows-1252?Q?SOVd4DXPT1lNPvHiRI4j0BxQEHcZ+3M6pPx9RRGoalLvQE+/uXPSCYrg?= =?Windows-1252?Q?YL8eFl73QGfQUhn1IXyyBM4SrNwCEFmofG6WhYA7qUBMMXIW9/C1Y1RH?= =?Windows-1252?Q?6B1cr3kfGRU5vh7kSZYg91SYui2LzF9QBozciPJpUnJUsf4AH0rMds8L?= =?Windows-1252?Q?amVxBfJtbmKQ/TDQ8ovAXEDDGX4duuAjtZq971uQCXYsAaUTmRaIN/jv?= =?Windows-1252?Q?xdVcG3Dx1nMbVqxR4GVrPuE87rlPFpfnOCGZq6RxFeq6eCYLnsAISV+L?= =?Windows-1252?Q?gg5+YX28ukHrE4uj8cVWeGiyM0A80eA+3ePAoMfhKbWnbqU2+VAYmqTf?= =?Windows-1252?Q?TQyuERnKZBkv8OddVlQUma1KxG2kB8PUUXmJJ/kPGOJdcGbWt1IrNoCF?= =?Windows-1252?Q?s3oHENs2oD2UO1P30KBfUt7IZKkevbgGsRETCw0eSkIXmD1nHu2tDxkN?= =?Windows-1252?Q?aUlKa6hRg/Eh2ODKjPGuyo9siUdgwe6icRbfmfSLwEg=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?evi6FY6xjMa+DRTPmRgr25jKDlhHbKvRzR9bqsMwJbTik/lX/VBgaCSp?= =?Windows-1252?Q?zdCedUummxYnDybmPuYx3DWu4+baQ34bqs3jysGmR6/lTDA0M8pe0T5t?= =?Windows-1252?Q?sn7nTFknpHs0qzHXgYk9Ot3X3aKWy85/trvS7wW9JuO0iVLNRJnQlh/H?= =?Windows-1252?Q?QnaxPK4Oy+uV8eckpItpRIXRMBUU645dL3C9jtI1d2GxhrcObS7DiaPt?= =?Windows-1252?Q?n9189dYNNgRSakaRFVUXd05EYKUgu7XgF5K1DRL6D758Y2vxUmAPRSPM?= =?Windows-1252?Q?C8TyH3vM/rlDuow3Lyoqdb0R0dgqb98WugLI0/FK4HqGZaN3pyyiZtJ+?= =?Windows-1252?Q?ymBEk7i+YsOo0ybztzD6m0zwMMuvcS1AkpgO2HzVzh5wd0GVaTOIdh4i?= =?Windows-1252?Q?ia13d9/GhfwrKNEjkqPjE/Aq9B9i5vaaoRfKI8J6vV5AVDpUqA+6vYQM?= =?Windows-1252?Q?y0XCS3zU1cf5ux2BH/QdPcIl5SKqtKXV9nmViB3SEdGSSA+JQuqLwKKI?= =?Windows-1252?Q?73IDLT3yCIoyaGXHSxLNS00sDSDOkPluYPAifuawXgGjQRg32WbUZHze?= =?Windows-1252?Q?AnpdcTAQXF7qCqizJMLxbNlZSBsb7NHzqgxmDh1A15+4DfidMZWCjWI3?= =?Windows-1252?Q?qW//eK9vjJw58A8kYXVScK7I9+isO8vGtX8RwBvowGjDkFC63367iBZc?= =?Windows-1252?Q?HTQO1DRfK8Vi9KgjnM7wXwqLa1zqaJwh/mIxQcUhJZLT9QsQcfz8s5cw?= =?Windows-1252?Q?faDqaxyNaVtQYNfB8E/YGPXNJeW5VP16XOoP4afj24ozddvOeYZ5VhxZ?= =?Windows-1252?Q?7E6zpG6c3+uCC2tJ5A3WlNYD1BssxGw4mNYh6/C9QZXB9T9mB0y+AtDz?= =?Windows-1252?Q?h3A3IW5sRYAnu2GfSfcWI7kfyycp0QDc8L+XwqpspFGOaMqU/h0Remn3?= =?Windows-1252?Q?nlErU9Aa5//bhPuqOm/28k7DiTEhbtweVf9zr2mvMpj2LqgNwQrA+wDa?= =?Windows-1252?Q?uoEMaABvf4BY8RoL3K4VPc2ukWhyPOSOBzZmzX6yqVp6PYeiQ/IhhdJ+?= =?Windows-1252?Q?oRkVTHk3jxumfZbF4V23qdUtmZECnu2y7M3VdUDZ1MXPCpg/QTmAxhm2?= =?Windows-1252?Q?JxzVJsBnGwlZvYjy/8TJSEds1lwKqNlglTyS3FQJyOomlhwVD+RMTGTt?= =?Windows-1252?Q?X5yZIf3k5wnCnL13yaH6VxnF/j4G8YBL+0y6XrPUod8uuzGZr1wY5L83?= =?Windows-1252?Q?E/qSfbWCKhAvo+dWtsa1Ak7hmw3a97HyEXGRKLwJczexY15QUPaxobHK?= =?Windows-1252?Q?kx/GzTsU0XZVMiOhd6dW51swi9k/bT/LQ9yfApmKwCQtkm95GDAeHadZ?= =?Windows-1252?Q?KJgBsMbgetl3MUTaKxpSvcF73mAT90qiWt1auJl/g2Z8sHwdtBsGHgd3?= =?Windows-1252?Q?dN74tCcCAb2l8BmeN5PTacsASg5fnqwA5Qll1KN+GzMKfk34P9f1gkTm?= =?Windows-1252?Q?SNxeeY+4Ry7uBEvONYb7K4GwkFgAWBM9wtz15VGUXtKL+8pBM5q4PNy7?= =?Windows-1252?Q?AD9sIIe76TMz1xn+zQGzKbB1rPXcDHG3VKppqCY7p5VDzsvq6J9kc8XX?= =?Windows-1252?Q?q9YX/vk5kc5lD0Qx4RmEaRkMwfgtirZDr8ievrdIv61qp7n5Yx8bwosF?= =?Windows-1252?Q?38jBR7XntN8OD5iVLy0rfoeVNP9QZ0Ce?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS7PR10MB5375.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53344287-0e17-4394-4521-08dd0d386e75 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Nov 2024 10:03:37.8418 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kUtlO9208M6WAFTeo5CPxTgcuqXFl5Qdwo2bAARQgAjWqbFrECURO+XqsTwBfm41z7GY9aYZtbcZ3MwsO0M2uw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7563 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 25 Nov 2024 02:03:43 -0800 Resent-From: santhoshkumarv@ami.com Reply-To: devel@edk2.groups.io,santhoshkumarv@ami.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: WLAoN9px7iGk7kWjCnMW9aVXx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_DS7PR10MB5375BFD26F87D967FD064FDBD22E2DS7PR10MB5375namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b="GupU/v+o"; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_DS7PR10MB5375BFD26F87D967FD064FDBD22E2DS7PR10MB5375namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable HI All, We are facing issue of httpboot takes more time during large iso file down= loading. The issue is reported on the customer side. The HTTP/HTTPs takes long time = to download the RHEL ISO image from HTTP/HTTPs servers. Tried with different cards =96 Intel x810/x710/MLOM, Mellanox and Broad com= adapters. But this issue is always reproducible with all the adapters. The issue is caused due to the changes made in HttpProto.h, HttpProto.c , H= ttpBootClient.c file. The changes are given below, HttpBootClient.h -#define HTTP_BOOT_BLOCK_SIZE 1500 +#define HTTP_BOOT_BLOCK_SIZE 32000 HttpProto.c + Tcp4Option->EnableWindowScaling =3D TRUE; + Tcp6Option->EnableWindowScaling =3D TRUE; HttpProto.h -#define HTTP_BUFFER_SIZE_DEAULT 65535 +#define HTTP_BUFFER_SIZE_DEAULT 0x200000 After reverting the changes, the issue is not reproduced. Note: Above changes are from EDK2 TianoCore Bugzilla =96 Bug 4505 Link: 4505 =96 NetworkPkg: HTTP protocol throughput too small >From our side we tried to reproduce the issue. With change HTTP_BOOT_BLOCK_= SIZE as 32000 and HTTP_BUFFER_SIZE_DEAULT as 0x200000. It took 23minutes 40= seconds to download the RHEL ISO (11.5 GB) through private network from loc= al HTTP server. With reverted changes HTTP_BOOT_BLOCK_SIZE as1500 and HTTP_= BUFFER_SIZE_DEAULT as 65535. It took 17 minutes 15 seconds to download the = RHEL ISO (11.5 GB) through private network from local HTTP server. Can you please provide your suggestions on this behaviour? Thanks, santhosh ________________________________ From: devel@edk2.groups.io on behalf of Michael D Ki= nney via groups.io Sent: Saturday, September 9, 2023 02:25 To: Kasbekar, Saloni ; Li, Yi1 ; devel@edk2.groups.io Cc: Otcheretianski, Andrei ; Clark-william= s, Zachary ; Luo, Heng ; Kinney, Michael D Subject: [EXTERNAL] Re: [edk2-devel] [PATCH] NetworkPkg: Increase HTTP buff= er size and enable TCP window scaling **CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.** Merged: https://nam12.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2= Fgithub.com%2Ftianocore%2Fedk2%2Fcommit%2Fb240eab03530f063ef5438497d70a731b= 19a201e&data=3D05%7C01%7Csanthoshkumarv%40ami.com%7Cc6667944c43c41e3132b08d= bb0ade19d%7C27e97857e15f486cb58e86c2b3040f93%7C1%7C0%7C638298033105005252%7= CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwi= LCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DbMifbtnsYEA6xpgZVDenmtSoa7%2F5%2BC4w= ETTwnGvxJFk%3D&reserved=3D0 > -----Original Message----- > From: Kinney, Michael D > Sent: Friday, September 8, 2023 10:07 AM > To: Kasbekar, Saloni ; Li, Yi1 > ; devel@edk2.groups.io > Cc: Otcheretianski, Andrei ; Clark- > williams, Zachary ; Luo, Heng > ; Kinney, Michael D > Subject: RE: [PATCH] NetworkPkg: Increase HTTP buffer size and enable TCP > window scaling > > Acked-by: Michael D Kinney > > > -----Original Message----- > > From: Kasbekar, Saloni > > Sent: Wednesday, September 6, 2023 3:41 PM > > To: Li, Yi1 ; devel@edk2.groups.io; Kinney, Michael D > > > > Cc: Otcheretianski, Andrei ; Clark- > williams, > > Zachary ; Luo, Heng > > > Subject: RE: [PATCH] NetworkPkg: Increase HTTP buffer size and enable T= CP > > window scaling > > > > Mike, > > > > Could you help us merge the patch? > > > > Thanks, > > Saloni > > > > -----Original Message----- > > From: Li, Yi1 > > Sent: Wednesday, September 6, 2023 1:52 AM > > To: Kasbekar, Saloni ; devel@edk2.groups.io > > Cc: Otcheretianski, Andrei ; Clark- > williams, > > Zachary ; Luo, Heng > > > Subject: RE: [PATCH] NetworkPkg: Increase HTTP buffer size and enable T= CP > > window scaling > > > > Hi Saloni and Zachary, can you help to merge this patch? It got > reviewed-by > > but not check-in, Thanks! > > > > -----Original Message----- > > From: Kasbekar, Saloni > > Sent: Tuesday, July 25, 2023 12:18 PM > > To: Li, Yi1 ; devel@edk2.groups.io > > Cc: Otcheretianski, Andrei ; Clark- > williams, > > Zachary > > Subject: RE: [PATCH] NetworkPkg: Increase HTTP buffer size and enable T= CP > > window scaling > > > > Reviewed-by: Saloni Kasbekar > > > > -----Original Message----- > > From: Li, Yi1 > > Sent: Thursday, July 20, 2023 10:18 PM > > To: devel@edk2.groups.io > > Cc: Li, Yi1 ; Otcheretianski, Andrei > > ; Kasbekar, Saloni > > ; Clark-williams, Zachary > williams@intel.com> > > Subject: [PATCH] NetworkPkg: Increase HTTP buffer size and enable TCP > window > > scaling > > > > REF: https://nam12.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%= 2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D4505&data=3D05%7C01%7Csantho= shkumarv%40ami.com%7Cc6667944c43c41e3132b08dbb0ade19d%7C27e97857e15f486cb58= e86c2b3040f93%7C1%7C0%7C638298033105005252%7CUnknown%7CTWFpbGZsb3d8eyJWIjoi= MC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&= sdata=3DxMzBMuvcaWmfXYMR3YrTDvGo6x1aCC%2F9WMDUHbeGvW4%3D&reserved=3D0 > > This gives something like ~3 fold throughput boost. > > > > Signed-off-by: Andrei Otcheretianski > > Cc: Saloni Kasbekar > > Cc: Zachary Clark-williams > > --- > > NetworkPkg/HttpBootDxe/HttpBootClient.h | 2 +- > > NetworkPkg/HttpDxe/HttpProto.c | 48 +++++++++++++------------ > > NetworkPkg/HttpDxe/HttpProto.h | 2 +- > > 3 files changed, 27 insertions(+), 25 deletions(-) > > > > diff --git a/NetworkPkg/HttpBootDxe/HttpBootClient.h > > b/NetworkPkg/HttpBootDxe/HttpBootClient.h > > index 2fba713679..86a28bc91a 100644 > > --- a/NetworkPkg/HttpBootDxe/HttpBootClient.h > > +++ b/NetworkPkg/HttpBootDxe/HttpBootClient.h > > @@ -10,7 +10,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #ifndef > > __EFI_HTTP_BOOT_HTTP_H__ #define __EFI_HTTP_BOOT_HTTP_H__ > > > > -#define HTTP_BOOT_BLOCK_SIZE 1500 > > +#define HTTP_BOOT_BLOCK_SIZE 32000 > > #define HTTP_USER_AGENT_EFI_HTTP_BOOT "UefiHttpBoot/1.0" > > #define HTTP_BOOT_AUTHENTICATION_INFO_MAX_LEN 255 > > > > diff --git a/NetworkPkg/HttpDxe/HttpProto.c > b/NetworkPkg/HttpDxe/HttpProto.c > > index 33ae622c3f..7dfb82dd2e 100644 > > --- a/NetworkPkg/HttpDxe/HttpProto.c > > +++ b/NetworkPkg/HttpDxe/HttpProto.c > > @@ -1073,18 +1073,19 @@ HttpConfigureTcp4 ( > > Tcp4AP->ActiveFlag =3D TRUE; > > IP4_COPY_ADDRESS (&Tcp4AP->RemoteAddress, &HttpInstance->RemoteAddr)= ; > > > > - Tcp4Option =3D Tcp4CfgData->ControlOption; > > - Tcp4Option->ReceiveBufferSize =3D HTTP_BUFFER_SIZE_DEAULT; > > - Tcp4Option->SendBufferSize =3D HTTP_BUFFER_SIZE_DEAULT; > > - Tcp4Option->MaxSynBackLog =3D HTTP_MAX_SYN_BACK_LOG; > > - Tcp4Option->ConnectionTimeout =3D HTTP_CONNECTION_TIMEOUT; > > - Tcp4Option->DataRetries =3D HTTP_DATA_RETRIES; > > - Tcp4Option->FinTimeout =3D HTTP_FIN_TIMEOUT; > > - Tcp4Option->KeepAliveProbes =3D HTTP_KEEP_ALIVE_PROBES; > > - Tcp4Option->KeepAliveTime =3D HTTP_KEEP_ALIVE_TIME; > > - Tcp4Option->KeepAliveInterval =3D HTTP_KEEP_ALIVE_INTERVAL; > > - Tcp4Option->EnableNagle =3D TRUE; > > - Tcp4CfgData->ControlOption =3D Tcp4Option; > > + Tcp4Option =3D Tcp4CfgData->ControlOption; > > + Tcp4Option->ReceiveBufferSize =3D HTTP_BUFFER_SIZE_DEAULT; > > + Tcp4Option->SendBufferSize =3D HTTP_BUFFER_SIZE_DEAULT; > > + Tcp4Option->MaxSynBackLog =3D HTTP_MAX_SYN_BACK_LOG; > > + Tcp4Option->ConnectionTimeout =3D HTTP_CONNECTION_TIMEOUT; > > + Tcp4Option->DataRetries =3D HTTP_DATA_RETRIES; > > + Tcp4Option->FinTimeout =3D HTTP_FIN_TIMEOUT; > > + Tcp4Option->KeepAliveProbes =3D HTTP_KEEP_ALIVE_PROBES; > > + Tcp4Option->KeepAliveTime =3D HTTP_KEEP_ALIVE_TIME; > > + Tcp4Option->KeepAliveInterval =3D HTTP_KEEP_ALIVE_INTERVAL; > > + Tcp4Option->EnableNagle =3D TRUE; > > + Tcp4Option->EnableWindowScaling =3D TRUE; > > + Tcp4CfgData->ControlOption =3D Tcp4Option; > > > > if ((HttpInstance->State =3D=3D HTTP_STATE_TCP_CONNECTED) || > > (HttpInstance->State =3D=3D HTTP_STATE_TCP_CLOSED)) @@ -1156,17 > +1157,18 > > @@ HttpConfigureTcp6 ( > > IP6_COPY_ADDRESS (&Tcp6Ap->StationAddress, &HttpInstance- > > >Ipv6Node.LocalAddress); > > IP6_COPY_ADDRESS (&Tcp6Ap->RemoteAddress, &HttpInstance- > >RemoteIpv6Addr); > > > > - Tcp6Option =3D Tcp6CfgData->ControlOption; > > - Tcp6Option->ReceiveBufferSize =3D HTTP_BUFFER_SIZE_DEAULT; > > - Tcp6Option->SendBufferSize =3D HTTP_BUFFER_SIZE_DEAULT; > > - Tcp6Option->MaxSynBackLog =3D HTTP_MAX_SYN_BACK_LOG; > > - Tcp6Option->ConnectionTimeout =3D HTTP_CONNECTION_TIMEOUT; > > - Tcp6Option->DataRetries =3D HTTP_DATA_RETRIES; > > - Tcp6Option->FinTimeout =3D HTTP_FIN_TIMEOUT; > > - Tcp6Option->KeepAliveProbes =3D HTTP_KEEP_ALIVE_PROBES; > > - Tcp6Option->KeepAliveTime =3D HTTP_KEEP_ALIVE_TIME; > > - Tcp6Option->KeepAliveInterval =3D HTTP_KEEP_ALIVE_INTERVAL; > > - Tcp6Option->EnableNagle =3D TRUE; > > + Tcp6Option =3D Tcp6CfgData->ControlOption; > > + Tcp6Option->ReceiveBufferSize =3D HTTP_BUFFER_SIZE_DEAULT; > > + Tcp6Option->SendBufferSize =3D HTTP_BUFFER_SIZE_DEAULT; > > + Tcp6Option->MaxSynBackLog =3D HTTP_MAX_SYN_BACK_LOG; > > + Tcp6Option->ConnectionTimeout =3D HTTP_CONNECTION_TIMEOUT; > > + Tcp6Option->DataRetries =3D HTTP_DATA_RETRIES; > > + Tcp6Option->FinTimeout =3D HTTP_FIN_TIMEOUT; > > + Tcp6Option->KeepAliveProbes =3D HTTP_KEEP_ALIVE_PROBES; > > + Tcp6Option->KeepAliveTime =3D HTTP_KEEP_ALIVE_TIME; > > + Tcp6Option->KeepAliveInterval =3D HTTP_KEEP_ALIVE_INTERVAL; > > + Tcp6Option->EnableNagle =3D TRUE; > > + Tcp6Option->EnableWindowScaling =3D TRUE; > > > > if ((HttpInstance->State =3D=3D HTTP_STATE_TCP_CONNECTED) || > > (HttpInstance->State =3D=3D HTTP_STATE_TCP_CLOSED)) diff --git > > a/NetworkPkg/HttpDxe/HttpProto.h b/NetworkPkg/HttpDxe/HttpProto.h index > > 620eb39158..012f1f4b46 100644 > > --- a/NetworkPkg/HttpDxe/HttpProto.h > > +++ b/NetworkPkg/HttpDxe/HttpProto.h > > @@ -37,7 +37,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent // > > #define HTTP_TOS_DEAULT 8 > > #define HTTP_TTL_DEAULT 255 > > -#define HTTP_BUFFER_SIZE_DEAULT 65535 > > +#define HTTP_BUFFER_SIZE_DEAULT 0x200000 > > #define HTTP_MAX_SYN_BACK_LOG 5 > > #define HTTP_CONNECTION_TIMEOUT 60 > > #define HTTP_DATA_RETRIES 12 > > -- > > 2.31.1.windows.1 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120829): https://edk2.groups.io/g/devel/message/120829 Mute This Topic: https://groups.io/mt/100271527/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_DS7PR10MB5375BFD26F87D967FD064FDBD22E2DS7PR10MB5375namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable
HI All,

We are  facing issue of httpboot takes more time during large iso file= downloading.



The issue is reported on the customer side. The HTTP/HTTPs takes long time = to download the RHEL ISO image from HTTP/HTTPs servers.
Tried with different cards =96 Intel x810/x710/MLOM, Mellanox and Broad com= adapters. But this issue is always reproducible with all the adapters.
The issue is caused due to the changes made in HttpProto.h, HttpProto.c , H= ttpBootClient.c file.  The changes are given below,

HttpBootClient.h

             -#define HTTP_BOOT_BLOCK_SI= ZE                   1500
             +#define HTTP_BOOT_BLOCK_SI= ZE                   32000

HttpProto.c

          +  Tcp4Option->EnableWindowScali= ng =3D TRUE;
          + Tcp6Option->EnableWindowScaling =3D= TRUE;

HttpProto.h

           -#define HTTP_BUFFER_SIZE_DEAULT &= nbsp; 65535
           +#define HTTP_BUFFER_SIZE_DEAULT &= nbsp; 0x200000

After reverting the changes, the issue is not reproduced.

Note: Above changes are from EDK2 TianoCore Bugzilla =96 Bug 4505   &n= bsp;    
Link:  4505 =96 NetworkPkg: HTTP protocol throughput too small

>From our side we tried to reproduce the issue. With change HTTP_BOOT_BLOCK_= SIZE as 32000 and HTTP_BUFFER_SIZE_DEAULT as 0x200000. It took 23minutes 40= seconds to download the RHEL ISO (11.5 GB) through private network from loc= al HTTP server. With reverted changes HTTP_BOOT_BLOCK_SIZE as1500 and HTTP_BUFFER_SIZE_DEAULT as 65535. It took = 17 minutes 15 seconds to download the RHEL ISO (11.5 GB) through private ne= twork from local HTTP server.

Can you please provide your suggestions on this behaviour?

Thanks,
santhosh

From: devel@= edk2.groups.io <devel@edk2.groups.io> on behalf of Michael D Kinney v= ia groups.io <michael.d.kinney=3Dintel.com@groups.io>
Sent: Saturday, September 9, 2023 02:25
To: Kasbekar, Saloni <saloni.kasbekar@intel.com>; Li, Yi1= <yi1.li@intel.com>; devel@edk2.groups.io <devel@edk2.groups.io>= ;
Cc: Otcheretianski, Andrei <andrei.otcheretianski@intel.com&= gt;; Clark-williams, Zachary <zachary.clark-williams@intel.com>; Luo,= Heng <heng.luo@intel.com>; Kinney, Michael D <michael.d.kinney@in= tel.com>
Subject: [EXTERNAL] Re: [edk2-devel] [PATCH] NetworkPkg: Increa= se HTTP buffer size and enable TCP window scaling
 

**CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.**
Merged: https://nam12.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub.= com%2Ftianocore%2Fedk2%2Fcommit%2Fb240eab03530f063ef5438497d70a731b19a201e&= amp;data=3D05%7C01%7Csanthoshkumarv%40ami.com%7Cc6667944c43c41e3132b08dbb0a= de19d%7C27e97857e15f486cb58e86c2b3040f93%7C1%7C0%7C638298033105005252%7CUnk= nown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJX= VCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DbMifbtnsYEA6xpgZVDenmtSoa7%2F5%2BC4w= ETTwnGvxJFk%3D&reserved=3D0


> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Friday, September 8, 2023 10:07 AM
> To: Kasbekar, Saloni <saloni.kasbekar@intel.com>; Li, Yi1
> <yi1.li@intel.com>; devel@edk2.groups.io
> Cc: Otcheretianski, Andrei <andrei.otcheretianski@intel.com>; Cl= ark-
> williams, Zachary <zachary.clark-williams@intel.com>; Luo, Heng<= br> > <heng.luo@intel.com>; Kinney, Michael D <michael.d.kinney@int= el.com>
> Subject: RE: [PATCH] NetworkPkg: Increase HTTP buffer size and enable = TCP
> window scaling
>
> Acked-by: Michael D Kinney <michael.d.kinney@intel.com>
>
> > -----Original Message-----
> > From: Kasbekar, Saloni <saloni.kasbekar@intel.com>
> > Sent: Wednesday, September 6, 2023 3:41 PM
> > To: Li, Yi1 <yi1.li@intel.com>; devel@edk2.groups.io; Kinne= y, Michael D
> > <michael.d.kinney@intel.com>
> > Cc: Otcheretianski, Andrei <andrei.otcheretianski@intel.com>= ;; Clark-
> williams,
> > Zachary <zachary.clark-williams@intel.com>; Luo, Heng
> <heng.luo@intel.com>
> > Subject: RE: [PATCH] NetworkPkg: Increase HTTP buffer size and en= able TCP
> > window scaling
> >
> > Mike,
> >
> > Could you help us merge the patch?
> >
> > Thanks,
> > Saloni
> >
> > -----Original Message-----
> > From: Li, Yi1 <yi1.li@intel.com>
> > Sent: Wednesday, September 6, 2023 1:52 AM
> > To: Kasbekar, Saloni <saloni.kasbekar@intel.com>; devel@edk= 2.groups.io
> > Cc: Otcheretianski, Andrei <andrei.otcheretianski@intel.com>= ;; Clark-
> williams,
> > Zachary <zachary.clark-williams@intel.com>; Luo, Heng
> <heng.luo@intel.com>
> > Subject: RE: [PATCH] NetworkPkg: Increase HTTP buffer size and en= able TCP
> > window scaling
> >
> > Hi Saloni and Zachary, can you help to merge this patch?  It= got
> reviewed-by
> > but not check-in, Thanks!
> >
> > -----Original Message-----
> > From: Kasbekar, Saloni <saloni.kasbekar@intel.com>
> > Sent: Tuesday, July 25, 2023 12:18 PM
> > To: Li, Yi1 <yi1.li@intel.com>; devel@edk2.groups.io
> > Cc: Otcheretianski, Andrei <andrei.otcheretianski@intel.com>= ;; Clark-
> williams,
> > Zachary <zachary.clark-williams@intel.com>
> > Subject: RE: [PATCH] NetworkPkg: Increase HTTP buffer size and en= able TCP
> > window scaling
> >
> > Reviewed-by: Saloni Kasbekar <saloni.kasbekar@intel.com> > >
> > -----Original Message-----
> > From: Li, Yi1 <yi1.li@intel.com>
> > Sent: Thursday, July 20, 2023 10:18 PM
> > To: devel@edk2.groups.io
> > Cc: Li, Yi1 <yi1.li@intel.com>; Otcheretianski, Andrei
> > <andrei.otcheretianski@intel.com>; Kasbekar, Saloni
> > <saloni.kasbekar@intel.com>; Clark-williams, Zachary <za= chary.clark-
> > williams@intel.com>
> > Subject: [PATCH] NetworkPkg: Increase HTTP buffer size and enable= TCP
> window
> > scaling
> >
> > REF: https://nam12.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugzill= a.tianocore.org%2Fshow_bug.cgi%3Fid%3D4505&data=3D05%7C01%7Csanthoshkum= arv%40ami.com%7Cc6667944c43c41e3132b08dbb0ade19d%7C27e97857e15f486cb58e86c2= b3040f93%7C1%7C0%7C638298033105005252%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wL= jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&s= data=3DxMzBMuvcaWmfXYMR3YrTDvGo6x1aCC%2F9WMDUHbeGvW4%3D&reserved=3D0
> > This gives something like ~3 fold throughput boost.
> >
> > Signed-off-by: Andrei Otcheretianski <andrei.otcheretianski@in= tel.com>
> > Cc: Saloni Kasbekar <saloni.kasbekar@intel.com>
> > Cc: Zachary Clark-williams <zachary.clark-williams@intel.com&g= t;
> > ---
> >  NetworkPkg/HttpBootDxe/HttpBootClient.h |  2 +-
> >  NetworkPkg/HttpDxe/HttpProto.c     = ;     | 48 +++++++++++++------------
> >  NetworkPkg/HttpDxe/HttpProto.h     = ;     |  2 +-
> >  3 files changed, 27 insertions(+), 25 deletions(-)
> >
> > diff --git a/NetworkPkg/HttpBootDxe/HttpBootClient.h
> > b/NetworkPkg/HttpBootDxe/HttpBootClient.h
> > index 2fba713679..86a28bc91a 100644
> > --- a/NetworkPkg/HttpBootDxe/HttpBootClient.h
> > +++ b/NetworkPkg/HttpBootDxe/HttpBootClient.h
> > @@ -10,7 +10,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent&nb= sp; #ifndef
> > __EFI_HTTP_BOOT_HTTP_H__  #define __EFI_HTTP_BOOT_HTTP_H__ > >
> > -#define HTTP_BOOT_BLOCK_SIZE      =              15= 00
> > +#define HTTP_BOOT_BLOCK_SIZE      =              32= 000
> >  #define HTTP_USER_AGENT_EFI_HTTP_BOOT   &nbs= p;      "UefiHttpBoot/1.0"
> >  #define HTTP_BOOT_AUTHENTICATION_INFO_MAX_LEN  255
> >
> > diff --git a/NetworkPkg/HttpDxe/HttpProto.c
> b/NetworkPkg/HttpDxe/HttpProto.c
> > index 33ae622c3f..7dfb82dd2e 100644
> > --- a/NetworkPkg/HttpDxe/HttpProto.c
> > +++ b/NetworkPkg/HttpDxe/HttpProto.c
> > @@ -1073,18 +1073,19 @@ HttpConfigureTcp4 (
> >    Tcp4AP->ActiveFlag  =3D TRUE;
> >    IP4_COPY_ADDRESS (&Tcp4AP->RemoteAddress= , &HttpInstance->RemoteAddr);
> >
> > -  Tcp4Option        = ;            =3D Tcp= 4CfgData->ControlOption;
> > -  Tcp4Option->ReceiveBufferSize =3D HTTP_BUFFER_SIZE_DEA= ULT;
> > -  Tcp4Option->SendBufferSize    =3D HTTP_= BUFFER_SIZE_DEAULT;
> > -  Tcp4Option->MaxSynBackLog     =3D = HTTP_MAX_SYN_BACK_LOG;
> > -  Tcp4Option->ConnectionTimeout =3D HTTP_CONNECTION_TIME= OUT;
> > -  Tcp4Option->DataRetries     &= nbsp; =3D HTTP_DATA_RETRIES;
> > -  Tcp4Option->FinTimeout     &n= bsp;  =3D HTTP_FIN_TIMEOUT;
> > -  Tcp4Option->KeepAliveProbes   =3D HTTP_KEEP_= ALIVE_PROBES;
> > -  Tcp4Option->KeepAliveTime     =3D = HTTP_KEEP_ALIVE_TIME;
> > -  Tcp4Option->KeepAliveInterval =3D HTTP_KEEP_ALIVE_INTE= RVAL;
> > -  Tcp4Option->EnableNagle     &= nbsp; =3D TRUE;
> > -  Tcp4CfgData->ControlOption    =3D Tcp4O= ption;
> > +  Tcp4Option        = ;            &n= bsp; =3D Tcp4CfgData->ControlOption;
> > +  Tcp4Option->ReceiveBufferSize   =3D HTTP_BUF= FER_SIZE_DEAULT;
> > +  Tcp4Option->SendBufferSize    &nbs= p; =3D HTTP_BUFFER_SIZE_DEAULT;
> > +  Tcp4Option->MaxSynBackLog     = ;  =3D HTTP_MAX_SYN_BACK_LOG;
> > +  Tcp4Option->ConnectionTimeout   =3D HTTP_CON= NECTION_TIMEOUT;
> > +  Tcp4Option->DataRetries     &= nbsp;   =3D HTTP_DATA_RETRIES;
> > +  Tcp4Option->FinTimeout     &n= bsp;    =3D HTTP_FIN_TIMEOUT;
> > +  Tcp4Option->KeepAliveProbes     = =3D HTTP_KEEP_ALIVE_PROBES;
> > +  Tcp4Option->KeepAliveTime     = ;  =3D HTTP_KEEP_ALIVE_TIME;
> > +  Tcp4Option->KeepAliveInterval   =3D HTTP_KEE= P_ALIVE_INTERVAL;
> > +  Tcp4Option->EnableNagle     &= nbsp;   =3D TRUE;
> > +  Tcp4Option->EnableWindowScaling =3D TRUE;
> > +  Tcp4CfgData->ControlOption    &nbs= p; =3D Tcp4Option;
> >
> >    if ((HttpInstance->State =3D=3D HTTP_STATE_T= CP_CONNECTED) ||
> >        (HttpInstance->State= =3D=3D HTTP_STATE_TCP_CLOSED)) @@ -1156,17
> +1157,18
> > @@ HttpConfigureTcp6 (
> >    IP6_COPY_ADDRESS (&Tcp6Ap->StationAddres= s, &HttpInstance-
> > >Ipv6Node.LocalAddress);
> >    IP6_COPY_ADDRESS (&Tcp6Ap->RemoteAddress= , &HttpInstance-
> >RemoteIpv6Addr);
> >
> > -  Tcp6Option        = ;            =3D Tcp= 6CfgData->ControlOption;
> > -  Tcp6Option->ReceiveBufferSize =3D HTTP_BUFFER_SIZE_DEA= ULT;
> > -  Tcp6Option->SendBufferSize    =3D HTTP_= BUFFER_SIZE_DEAULT;
> > -  Tcp6Option->MaxSynBackLog     =3D = HTTP_MAX_SYN_BACK_LOG;
> > -  Tcp6Option->ConnectionTimeout =3D HTTP_CONNECTION_TIME= OUT;
> > -  Tcp6Option->DataRetries     &= nbsp; =3D HTTP_DATA_RETRIES;
> > -  Tcp6Option->FinTimeout     &n= bsp;  =3D HTTP_FIN_TIMEOUT;
> > -  Tcp6Option->KeepAliveProbes   =3D HTTP_KEEP_= ALIVE_PROBES;
> > -  Tcp6Option->KeepAliveTime     =3D = HTTP_KEEP_ALIVE_TIME;
> > -  Tcp6Option->KeepAliveInterval =3D HTTP_KEEP_ALIVE_INTE= RVAL;
> > -  Tcp6Option->EnableNagle     &= nbsp; =3D TRUE;
> > +  Tcp6Option        = ;            &n= bsp; =3D Tcp6CfgData->ControlOption;
> > +  Tcp6Option->ReceiveBufferSize   =3D HTTP_BUF= FER_SIZE_DEAULT;
> > +  Tcp6Option->SendBufferSize    &nbs= p; =3D HTTP_BUFFER_SIZE_DEAULT;
> > +  Tcp6Option->MaxSynBackLog     = ;  =3D HTTP_MAX_SYN_BACK_LOG;
> > +  Tcp6Option->ConnectionTimeout   =3D HTTP_CON= NECTION_TIMEOUT;
> > +  Tcp6Option->DataRetries     &= nbsp;   =3D HTTP_DATA_RETRIES;
> > +  Tcp6Option->FinTimeout     &n= bsp;    =3D HTTP_FIN_TIMEOUT;
> > +  Tcp6Option->KeepAliveProbes     = =3D HTTP_KEEP_ALIVE_PROBES;
> > +  Tcp6Option->KeepAliveTime     = ;  =3D HTTP_KEEP_ALIVE_TIME;
> > +  Tcp6Option->KeepAliveInterval   =3D HTTP_KEE= P_ALIVE_INTERVAL;
> > +  Tcp6Option->EnableNagle     &= nbsp;   =3D TRUE;
> > +  Tcp6Option->EnableWindowScaling =3D TRUE;
> >
> >    if ((HttpInstance->State =3D=3D HTTP_STATE_T= CP_CONNECTED) ||
> >        (HttpInstance->State= =3D=3D HTTP_STATE_TCP_CLOSED)) diff --git
> > a/NetworkPkg/HttpDxe/HttpProto.h b/NetworkPkg/HttpDxe/HttpProto.h= index
> > 620eb39158..012f1f4b46 100644
> > --- a/NetworkPkg/HttpDxe/HttpProto.h
> > +++ b/NetworkPkg/HttpDxe/HttpProto.h
> > @@ -37,7 +37,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent&nb= sp; //
> >  #define HTTP_TOS_DEAULT      =      8
> >  #define HTTP_TTL_DEAULT      =      255
> > -#define HTTP_BUFFER_SIZE_DEAULT   65535
> > +#define HTTP_BUFFER_SIZE_DEAULT   0x200000
> >  #define HTTP_MAX_SYN_BACK_LOG     5
> >  #define HTTP_CONNECTION_TIMEOUT   60
> >  #define HTTP_DATA_RETRIES     &nbs= p;   12
> > --
> > 2.31.1.windows.1






-The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are on notice that any distribution of = this message, in any form, is strictly prohibited. Please promptly notify t= he sender by reply e-mail or by telephone at 770-246-8600, and then delete = or destroy all copies of the transmission.
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#120829) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_DS7PR10MB5375BFD26F87D967FD064FDBD22E2DS7PR10MB5375namp_--