Re: [edk2-devel] Add SmmCpuPlatformHookLib IsLmceStatusCheckNeeded interface PR review request

Re: [edk2-devel] Add SmmCpuPlatformHookLib IsLmceStatusCheckNeeded interface PR review request

[Khor, Swee Aun via groups.io]

[-- Attachment #1: Type: text/plain, Size: 1739 bytes --]

Hi Ard, JieWen and Greg,

Please help to review my PR.Thanks.

Regards,
Swee Aun

From: Khor, Swee Aun
Sent: Monday, December 23, 2024 2:28 PM
To: Yao, Jiewen <jiewen.yao@intel.com>; kraxel@redhat.com
Cc: Wu, Jiaxin <jiaxin.wu@intel.com>
Subject: Add SmmCpuPlatformHookLib IsLmceStatusCheckNeeded interface PR review request

Hi JieWen and Greg,

Could you please help to review PR https://github.com/tianocore/edk2/pull/6557?

This PR is to add a new interface for SmmCpuPlatformHookLib which can used to check whether the LMCE status check is required depending on platform requirements.
By default, 2 edk2 implementations (UefiCpuPkg/SmmCpuPlatformHookLibNull  and OvmfPkg/SmmCpuPlatformHookLibQemu ) returns TRUE indicating LMCE status check should be performed. Platform specific implementation could return FALSE if would like to skip the LMCE check due to any reason.

This new interface will be consumed by UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c  SmmWaitForApArrival(). However, the consumer part PR will be submitted later to avoid immediate downstream build error. https://github.com/tianocore/edk2/pull/6557  PR allow downstream to implement platform specific implementation, thus the transition will be smooth when downstream received the updated SmmWaitForApArrival().

Please let me know if you have any questions.

Regards,
Swee Aun


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120953): https://edk2.groups.io/g/devel/message/120953
Mute This Topic: https://groups.io/mt/110420494/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 5987 bytes --]