From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9612C740038 for ; Sat, 4 Jan 2025 09:11:43 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=FSo4oLNBl8kAc5+pv2ZynsEYUhyfYN4Pp2gCfzfpAQI=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240830; t=1735981903; v=1; x=1736241101; b=uBjdv8kUrU7cwCLwM6K/nD3JAaB3VO5f5aLJrHMLEcdw0Fb7Fa0qAfd0uNK47E5uAZZd6i7P VpDdPXn0zy11bMqRfaKbn/xcY0XeE6Wt+dGUi37HOYD2Q8fBtk/GXoALB1G1xhaE7j3YgO5EniB iYvgXUfeHGrMFg/gWnquQmERjkKL253bDU9fhkUxdIyYK8RrEHYdEdfcvSlh+7nKxpMy+myRo8k vmtUPUBWGRE7wSHOsofsuxF9jRay1HlAFRHog+6rQNCTiemV5w+EKTn9Cf8aoF1SfhSlE42Rq/b qIqKNYn1fwEckBtiKhVo2T14PDIvTBQOXBJihUA99YNwA== X-Received: by 127.0.0.2 with SMTP id P5lXYY7687511x3HsHV0pfvw; Sat, 04 Jan 2025 01:11:41 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by mx.groups.io with SMTP id smtpd.web10.74799.1735607169224659426 for ; Mon, 30 Dec 2024 17:06:09 -0800 X-CSE-ConnectionGUID: pCLMWX+XRsqcAuK2BMc03A== X-CSE-MsgGUID: 4yz0iC34SGyd61Ftxj4vTw== X-IronPort-AV: E=McAfee;i="6700,10204,11301"; a="46573702" X-IronPort-AV: E=Sophos;i="6.12,278,1728975600"; d="scan'208,217";a="46573702" X-Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Dec 2024 17:06:09 -0800 X-CSE-ConnectionGUID: Uq/CZexmRnmmmFkk7aVsMQ== X-CSE-MsgGUID: MZp7s04iSEKuYtnLeOnKeA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208,217";a="105544781" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 30 Dec 2024 17:05:47 -0800 X-Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Mon, 30 Dec 2024 17:05:46 -0800 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Mon, 30 Dec 2024 17:05:46 -0800 X-Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.42) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Mon, 30 Dec 2024 17:05:46 -0800 X-Received: from DS7PR11MB6175.namprd11.prod.outlook.com (2603:10b6:8:99::11) by CH3PR11MB7201.namprd11.prod.outlook.com (2603:10b6:610:143::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8293.20; Tue, 31 Dec 2024 01:05:40 +0000 X-Received: from DS7PR11MB6175.namprd11.prod.outlook.com ([fe80::3e79:b5df:40fa:beae]) by DS7PR11MB6175.namprd11.prod.outlook.com ([fe80::3e79:b5df:40fa:beae%4]) with mapi id 15.20.8293.000; Tue, 31 Dec 2024 01:05:40 +0000 From: "Khor, Swee Aun via groups.io" To: "Yao, Jiewen" , "kraxel@redhat.com" , "ardb+tianocore@kernel.org" CC: "Wu, Jiaxin" , "devel@edk2.groups.io" Subject: Re: [edk2-devel] Add SmmCpuPlatformHookLib IsLmceStatusCheckNeeded interface PR review request Thread-Topic: Add SmmCpuPlatformHookLib IsLmceStatusCheckNeeded interface PR review request Thread-Index: AdtVA4y2tX8AJHD6RIij8hNnr7vZUwGG8ocA Date: Tue, 31 Dec 2024 01:05:40 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DS7PR11MB6175:EE_|CH3PR11MB7201:EE_ x-ms-office365-filtering-correlation-id: af0de17e-86f3-4bb3-f26c-08dd29373e3d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?oKO0lNaiq4Kag5grO2T4WDPxB9TNlMlr2mgWNkzUFnOglBf16o4PN27cv2MH?= =?us-ascii?Q?b0t58tu3JYNKIWnN/6RsehF7nLT52f4gpnlE2B6kMVotrN6y+nNkigZdEWyH?= =?us-ascii?Q?Uq/4uZEh6F7jMbdmNOe7HsRpq7uMgBxRjkJo72tU+KIzW1iwHx3PRbIyeTS6?= =?us-ascii?Q?1FZUsvMWi9jGhrR9ubMWnTdoNkjZegjDMpiATEG+GkeOONWVN4GFvm6pE8Ht?= =?us-ascii?Q?PWFzzIE6PXdMY39dW3aiFizW40HQhejiXHma8Gtjb8MCbbsymrKhOS+ljaNh?= =?us-ascii?Q?lHW0mv2sKRBLhFuVcf770fjhtJ5q0LT3D3T7zSenLodFuwHM81oqf4+PeBkL?= =?us-ascii?Q?HV5qrhiakG7m9fZptTkHfPvRToluBswX7vgcqvPYojIBEMVLp2FKwxBEqqIb?= =?us-ascii?Q?BJC8nM3Y314jYtVk5fX4dLMhHFAj51FuVhNxdXKmZi2OpqGlCxmFmz6P5mhO?= =?us-ascii?Q?O3k12TnFnJAg398FGs074NJdNmn9aYVp902n+rHMWpKh4ujPNz1BrJXKU0JU?= =?us-ascii?Q?MWF6NZbPWEcCPSkyjFkDqqZ1V/hvn9HP+2MUL571ofq+ye5Q0PjLj6OIg8d0?= =?us-ascii?Q?FS1RqAdgQef9rgdyffVviqhxbGbRqK4N6UDCzQlw3XJ8bX5AXMGhvO0QebH5?= =?us-ascii?Q?UueHPbKtRt0ANMzFeFbyP8AiH97j9Ej+eYHty+hoqK067pGqgRgxmnCGhRTM?= =?us-ascii?Q?8zLeWd56bqgzQM7jN8jgstvdeRH2+/Kp7dmvFiwXCZMuqcMWJm/UI1DadNjL?= =?us-ascii?Q?2p26Ttukz8OSUniRCVWedhM7DtLbt83c1OI9aOWkC/z09UeqLvK0BMN3uv3X?= =?us-ascii?Q?jkiNzPswXnybBy+d5Y7NpD2Re/Y+TJJKPQYePqI96MBduKgyFMydGfuUotOf?= =?us-ascii?Q?SIklUJkqxPC+LktozqwuY82GOs2QeUlyH4VXIOOo5QCGN8Cxkw7tW1eP5edm?= =?us-ascii?Q?Ww0Zq6mvppY6XABICLkHQYW1GPHVKzoTSM84boo82pbqS71h3KgyGFrP4GxC?= =?us-ascii?Q?z7zdiaWWoHM54M0hcEipYO31+pIc2mlen5oaiE+Nt3DqEMstu0IoxtLYKoK7?= =?us-ascii?Q?Erco1hLca4rfiBW3MuB8lHSjs85+eTIleFfF7YcXLC1YXxlT4p7b31YLdK5y?= =?us-ascii?Q?vH2xWWOLKqOBhVL0jmGi7BxCEhQu9e6uyi39/qnRKsAIV5Ge/EpXZoWKuPxj?= =?us-ascii?Q?Idef6XQxb4NGp03Xhj7b0ubKw1lyiacSN0HzSkoZ6mo1qGHMZV61K4YSOvPF?= =?us-ascii?Q?XAv1ycmetQx57N83DdPNrAXKABbEUDZNZU1VrYOuIYr0TEivt1jOgmw6NhRS?= =?us-ascii?Q?Zbm/vculyMEAKUycLO8wMqgl4g4wdpY8+gq2lgMtsqCq0+25n2Gng6OFGmsb?= =?us-ascii?Q?9e12yFWunngtVe6KsEPlbEDfg5MuStXOu7QlKEy8d2qBtDvQzsipdoAouZCI?= =?us-ascii?Q?knLdJY5Is5WC9eM+4Ip+7m/q2A2mzVjk?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YWNR6tqI3zlGo9ku30czrofFccJDOCqEG+vSuiIKIswrEd2Ahisaeii7ukP7?= =?us-ascii?Q?krjemkC3yu45a3jd9QTMn7xF7M5jm8vbns6Rk1JAb9g8od7p0Wyhm/pZDPpi?= =?us-ascii?Q?/xS3ntVOG8/Z1ZYpA7mYX1lpk1twxs2BsWG5kFN3XFaa4zgv75j3KFOlBbKT?= =?us-ascii?Q?hqLburdfk+A8qr1gaBzjLlhqKapJ38TyqYJUQ6MdOtZ0LnSzqgatwYCNUsiZ?= =?us-ascii?Q?mIVoOdPjEAZGTclrRJvcHjMD3kzEdvNMleD6FsKvoh/M8sXAjnZV+8P/lnY0?= =?us-ascii?Q?iqR8+Rz1tkBvfBQNfU9zd3LMowQxqFUHkQPPXhsIU9nFhCaEaRpX5DYR4NXE?= =?us-ascii?Q?7sgQT0OgmknQkQ4WyLdVpAlJzJwhHK5We+mC6xzRij2t0IxfGI9HyjDvHc6c?= =?us-ascii?Q?Cw+i3DDwqym0u3OS8vCHVzvaS8kwrcVaMmOKzKfz67+QOBAtVNP4JKx9rZ/m?= =?us-ascii?Q?uTD1LpAn0+wX+1Fxva9aF+tO2Ks6DeF8F8zoxvEdNaQyP8xArWe3ioS3TeIi?= =?us-ascii?Q?NM8XUG/DvLK4oO39uqtSyix9bYQk0nQNhff7TCe3CQqpedetrqmBSAxcceLj?= =?us-ascii?Q?yDCI9ITxKXAEML7X4OPEbOctt5Cdotf1uKqDWZvO5b3G8xDUD3wMhGdB54lh?= =?us-ascii?Q?IzULgmOxY0XhbdVLYBueV18GMDt+i4795KMDFOv9MjeuLGsftJE9Tc1WIJ7H?= =?us-ascii?Q?A4bUn4DOtFz3HA4Wd/lRbhBhXyfl6WKrKdYT4JNEoyyWz40KLb5H5BNNT1wz?= =?us-ascii?Q?A+WaWlISTf5PLOzbm77jYNY/29qVZG9MKePDtN5oOzbV1CRA9G8zWrG2ybyX?= =?us-ascii?Q?qIBV8imzQxpbpLDH127vGuS/36tLdg2/bxg741oraYDABCwCSkHlopBHnoiO?= =?us-ascii?Q?jDdUImqgAMIyydjrCTLcSBH20J40QvxtD2xjlpmfjZADV52dfgwXua2N8doP?= =?us-ascii?Q?gviGoGtSpgqvb2hFj9Dly/amRXx9RvMnADPjIULOIWjf1gBDSreFiKPEU0wP?= =?us-ascii?Q?GvDBaib2BF8GwWkEeWt74WLuhF5V3WtRG/774l3HG8PBd64T9Fg78AuSoaqQ?= =?us-ascii?Q?T/Lkf96JdyX5Cm8w7bIwniTLFd7A52M6h2/9gaTDUOIrkfeQQsHhR9CPyOrC?= =?us-ascii?Q?th8qPGcxywj+/3D0xtrEPJrDo0TFXcFVoma2H2Ybv78pplvA9nEDkv/OEPvv?= =?us-ascii?Q?yORzZJwi2HwZr80Ntf7d463J2UtPM6hzwKD95GRcq77wGVjvDMjbsnf/eud1?= =?us-ascii?Q?zI1b8E70qEJryPplQXtgeFIkJhCyXkYVS6UP/OPhWBPEQciGS7lnM8Rei7KE?= =?us-ascii?Q?Qtsw9LzDDGg7VIg63fPZqgy6ElpqiKs7jmqyie0MVGABnN2CdOCWMHB9EZ/g?= =?us-ascii?Q?D1KPUIJZxHH8WV8WTB7IiooWKA6fjiF+SYp7+N0s47uL2fM7gufguPpxmfxh?= =?us-ascii?Q?MR1iiHGjt7aXNSQHRGcS/BUwSGwYrKBtfK7J+cBkBZdid6o0ANDJ0T6bDu02?= =?us-ascii?Q?7jJBr/sEsx4cQLXe/YRacH636N9Lu3jnhXuY1hon+ucQ2hdxp8YFdBGpp5Ot?= =?us-ascii?Q?ob8LtlMZN206DYvwT+td+YAVS8N3HztKPl5g0YRG?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB6175.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: af0de17e-86f3-4bb3-f26c-08dd29373e3d X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Dec 2024 01:05:40.0647 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Lys+MNO4DI/VE9ytEOP3IvOQa3QyptZnomI+yRm3QsHiovCY9vkPsheb/rsRYxQAbwEculnrueRR9mFYSZbe7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7201 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sat, 04 Jan 2025 01:11:41 -0800 Resent-From: swee.aun.khor@intel.com Reply-To: devel@edk2.groups.io,swee.aun.khor@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: kWnTCT4eNkLbV3andXH2MUiox7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_DS7PR11MB61750B478519B3683ADD7BA6AF0A2DS7PR11MB6175namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b=uBjdv8kU; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_DS7PR11MB61750B478519B3683ADD7BA6AF0A2DS7PR11MB6175namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ard, JieWen and Greg, Please help to review my PR.Thanks. Regards, Swee Aun From: Khor, Swee Aun Sent: Monday, December 23, 2024 2:28 PM To: Yao, Jiewen ; kraxel@redhat.com Cc: Wu, Jiaxin Subject: Add SmmCpuPlatformHookLib IsLmceStatusCheckNeeded interface PR rev= iew request Hi JieWen and Greg, Could you please help to review PR https://github.com/tianocore/edk2/pull/6= 557? This PR is to add a new interface for SmmCpuPlatformHookLib which can used = to check whether the LMCE status check is required depending on platform re= quirements. By default, 2 edk2 implementations (UefiCpuPkg/SmmCpuPlatformHookLibNull a= nd OvmfPkg/SmmCpuPlatformHookLibQemu ) returns TRUE indicating LMCE status = check should be performed. Platform specific implementation could return FA= LSE if would like to skip the LMCE check due to any reason. This new interface will be consumed by UefiCpuPkg/PiSmmCpuDxeSmm/MpService.= c SmmWaitForApArrival(). However, the consumer part PR will be submitted l= ater to avoid immediate downstream build error. https://github.com/tianocor= e/edk2/pull/6557 PR allow downstream to implement platform specific implem= entation, thus the transition will be smooth when downstream received the u= pdated SmmWaitForApArrival(). Please let me know if you have any questions. Regards, Swee Aun -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120953): https://edk2.groups.io/g/devel/message/120953 Mute This Topic: https://groups.io/mt/110420494/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_DS7PR11MB61750B478519B3683ADD7BA6AF0A2DS7PR11MB6175namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi Ard, JieWen and = Greg,

 

Please help to revi= ew my PR.Thanks.

 

Regards,=

Swee Aun=

 

From: Khor, Swee Aun
Sent: Monday, December 23, 2024 2:28 PM
To: Yao, Jiewen <jiewen.yao@intel.com>; kraxel@redhat.com
Cc: Wu, Jiaxin <jiaxin.wu@intel.com>
Subject: Add SmmCpuPlatformHookLib IsLmceStatusCheckNeeded interface= PR review request

 

Hi JieWen and Greg,=

 

Could you please he= lp to review PR https://github.com/= tianocore/edk2/pull/6557?

 

This PR is to add a= new interface for SmmCpuPlatformHookLib which can used to check whether th= e LMCE status check is required depending on platform requirements.

By default, 2 edk2 = implementations (UefiCpuPkg/SmmCpuPlatformHookLibNull  and OvmfPkg/Smm= CpuPlatformHookLibQemu ) returns TRUE indicating LMCE status check should b= e performed. Platform specific implementation could return FALSE if would like to skip the LMCE check due to any reason.=

 

This new interface = will be consumed by UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c  SmmWaitForA= pArrival(). However, the consumer part PR will be submitted later to avoid = immediate downstream build error. https://github.com/= tianocore/edk2/pull/6557  PR allow downstream to implement platfor= m specific implementation, thus the transition will be smooth when downstre= am received the updated SmmWaitForApArrival().

 

Please let me know = if you have any questions.

 

Regards,=

Swee Aun

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#120953) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_DS7PR11MB61750B478519B3683ADD7BA6AF0A2DS7PR11MB6175namp_--