From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.189023.1673927629706591469 for ; Mon, 16 Jan 2023 19:53:49 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=AYcZDyJ1; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: william2.wang@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673927629; x=1705463629; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ou8IrWPKMMDSEJJoKVTW8tOtpokQadm8PuQEw842e5Y=; b=AYcZDyJ1n2la69nznQJ9ZhxP65JQW1DIw4SsRma+f4L3pa71C+xCjZrt mP0+PM6zky2/duRigL+j61HmaD8Qb1P7oeXYh7uuD4a6YDrvnodmiyzvw pKHr7m4lae4Y88zwL2ZpdkwjJdvNmmEJCnzmS2xGvD4idp2fTYSBIx3jd F4qhz/kF2KCrAcXNVqkAbxQnmBWO2wdtvi2jqIFU++m8k3rSqaii+3VcZ 2BIT4qS3g71MJVzYqtXnJQUXBGPWI1g99dPw44SwIzvQUeH26DWKZA6Xo jVqVF0rYrIH3ZJpeNNZssOIF8wWnDoRsikJxuRd0UxJw8GHVc9ibtR9nU A==; X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="325881358" X-IronPort-AV: E=Sophos;i="5.97,222,1669104000"; d="scan'208";a="325881358" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2023 19:53:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="767113871" X-IronPort-AV: E=Sophos;i="5.97,222,1669104000"; d="scan'208";a="767113871" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga002.fm.intel.com with ESMTP; 16 Jan 2023 19:53:48 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 16 Jan 2023 19:53:48 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 16 Jan 2023 19:53:48 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.45) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 16 Jan 2023 19:53:47 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NydIMcVyJubg5SFlaYPytW8jLeKvyRFoiFrR9BlE5ee5a2f5Fj2ty/yVMxkKlGE8PgTEjhg5XQZ8BDKn+AYLFquo6KCbhm7pR79KzfvS+noA21L5Ouotz2NoyV16ppfHJ1EzkgcSoZUVrs1nVm8BqqcP3iJOYVtV81CMYO2qnPmVIwJsmoUJ5FysU39l/1A3EkCzQ61Fetc8tdjGb69frrhPMIRP7tWvSYilO8mbXXzTEzHFQxipX2eFmUUenLHIvZVumA0lKKMjr/LAApU33pEagfyyIGkynhZ+JTlPtMbimzrd5Ry71zfq+79h1JvY0ShrU+ijSYQau8epXyeuyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gxBVtlhxT6Y2nLWtveKrcCCyvAcdzCFh9UvvZaxMavI=; b=PK/7dQvr2hcsXl7TstfcrLGdCHd20zpzcqURciVkcve86oEdj43WxiUOrruT4xwz5FLhAO3ItfsL7THorNxCH6K83e8lzPuPcarD/PUbU0vmPlInfM5w/upyqgln9G3sHnBo7cUuBq7qDe81UP5IJn2YVT/q2t8YU/GFPvfElX6VO28n52x+CSmpDpbnyMyK7lNckSDFEEKHYs9+KiW+PbippjUCI85djsAEwsRWayf8f9Oqj3EKws9E7MlrlVUSWmgt9XpMGhn7eP3ju10BvU0AfnKEsMW6IAsSpGMILaIlYoRYhN/bdTENIVxmoyoXveOXGhejUkdB9GRbuOn1CA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DS7PR11MB6198.namprd11.prod.outlook.com (2603:10b6:8:9a::10) by CH0PR11MB5346.namprd11.prod.outlook.com (2603:10b6:610:b9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13; Tue, 17 Jan 2023 03:53:45 +0000 Received: from DS7PR11MB6198.namprd11.prod.outlook.com ([fe80::c0ff:f667:f68c:2775]) by DS7PR11MB6198.namprd11.prod.outlook.com ([fe80::c0ff:f667:f68c:2775%9]) with mapi id 15.20.5986.023; Tue, 17 Jan 2023 03:53:45 +0000 From: william2.wang@intel.com To: "Kuo, Donald" , "Ni, Ray" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Gao, Liming" , "Kumar, Chandana C" Subject: Re: [PATCH v2] Update CPUID Leaf 06H to follow latest SDM. Thread-Topic: [PATCH v2] Update CPUID Leaf 06H to follow latest SDM. Thread-Index: AQHZJyiuR84T5R1RWUynK/K4PvkbDK6gviIAgAAKyQCAAAEngIABNgzA Date: Tue, 17 Jan 2023 03:53:45 +0000 Message-ID: References: <20230113082551.685-1-william2.wang@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DS7PR11MB6198:EE_|CH0PR11MB5346:EE_ x-ms-office365-filtering-correlation-id: 7b939794-715b-4cb7-52f1-08daf83e6e92 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: c2Yp1MNYFb1w8SrL/gY6I+L7fIbwY4wbqSHyBkEyD+CyXHuBgSCmXYtuZeG82fTsdM1lZB8gCRYDqbgNYpx+vEWxkPQ18JVCiVtzCbQpXbszvfawsEBsCPXanETXsX5TKFeIb0uuIPnG96NvhZgBQxTsCfQZRMh57fHWP2wkp94n0ogTQh4sQKPuc5ijrE4O1ruGnmzGt/S+URdnjWIsZfABfMQYKidpMMIa4yVUSJfqCGAqxkSW6YGIpcyqpVMnIBg//rs7jG/ZTe58if/bARRjfOlZLSr4K6hu6iwaGhtdv7kn13m0Dh37KLY5ePtQM+bGy91R8kbk+qrv5rwWnAigw9J7BfmiJVxuknmo0/D8NLcp9oVB7kvDc2VomFxxUG5RRt76/SWYYHDS88z2uW3e62oa26iyWFSqPDLFNhwyxjHbSDHH0BJLbMLA6X/SCk91W4R2UkjFzPAmKbIu9UipD7sC8f1Ey/gNawhDwppu65t8J0bACP9YM7KmblT2+TOEQqFNrb6yiKq9hCezhoZnwbk5lhgxoYSAdac6f07ZEvnikujReJfV5Ip8EM1V98ITzYETv5YqOlHlNF/Jya5bwSorwEVYBsL3+MwVC8ZIhruH1WLAwBph7pkEIqNOS6Gdc/PGRz34L9q2in+IhzvHwchlU0IsMueNmb0iMp1woqWvjx+V8RuVwkEK9vSj x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR11MB6198.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(366004)(396003)(346002)(376002)(39860400002)(451199015)(86362001)(33656002)(64756008)(186003)(53546011)(4326008)(8676002)(66556008)(76116006)(66946007)(66446008)(26005)(41300700001)(9686003)(66476007)(316002)(7696005)(83380400001)(6506007)(71200400001)(54906003)(110136005)(478600001)(122000001)(2906002)(38070700005)(15650500001)(38100700002)(52536014)(82960400001)(107886003)(5660300002)(8936002)(55016003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4oARX0Iz4n8LY8RHLJex8f9Od9WAQ8GWNAk5MYzMPoCuaam1AOODh7DCVYC8?= =?us-ascii?Q?rR4wi70KdHYEbnaSCG26X0EXLuKokXEaySSzhoL5z8X9ILsDWtGjfojXonfb?= =?us-ascii?Q?Y5MwEk/jHMBftQpVlT7uwfKDbsk5fo/shnzuq0WvnE6vIrnMXeQ7zEd+MYTy?= =?us-ascii?Q?m9mdV73vDSXGdMIn3OFYH1VC1DylcgDDfAah8VVHSAoYod4YO6s4KlrzPXsA?= =?us-ascii?Q?+Tr/C8S6EJIJlhu2k8G6WaSA1uRY+4Rb3KBhunnQiTQH01n+/R6r29GI6KaN?= =?us-ascii?Q?PWcAgT/Wt3gaQQWMtrnh/6pcgoqw6y2pnQI8Bhbm6izU4fYY4KPO4Tw2xMjc?= =?us-ascii?Q?n/YNHciPdAH47S2hfQNHB/y09LbAm/J/uaJ1zvfF0E7oAlmHGsymmA8g28Ce?= =?us-ascii?Q?1el0ov5LUOUyNIoTVSgtA1zuUivP5jtmo/Dttms/KGdYDrbtvQ0QnKLMNqGI?= =?us-ascii?Q?4hHAfMS8J3VO86h4uK5EGcrsyLWKFsR3nLxHQ8Qbt7+/wFANXhFHMFDRT7Cr?= =?us-ascii?Q?asj6V/zDKS3ttIHH4z6ihcpxYbuT7kk8k0OoERpboBgBH8yle7CQBza+iGJ8?= =?us-ascii?Q?YSuYHWuPXpVE7rn3mgIAdFq9IfhUTQVfQHu8hVV92PKrLUo8QTKEruk82o1N?= =?us-ascii?Q?UUb0H82lbm7Z7kITKJT4QN88P6nXTUpyJbsnhF3kxABoajTxt8F0ZUC5qmqO?= =?us-ascii?Q?bGcaWXqHRrgGnCK4g+Yi5v4TZIRopBKr5QrdIWEAZFe9seQqDa/SuKO+L2rf?= =?us-ascii?Q?x+q/J9DuyvblKL/Q2V1Jb2HPjve74GuGtf5vEhLyUWWUEdAcIwk6bNyRdcvN?= =?us-ascii?Q?yuedHMNLBTBLtzDNZiO3/fDV221nhmMoCrj0NU/qfRLnCa1iAlTvQrZef7Qt?= =?us-ascii?Q?uPBSjxFkMtCLw9lRe6/pBx0Fy/ySHBNpJJ534bgYXv4hFDtjToiRmg3Kj4BR?= =?us-ascii?Q?iTP/ySm6956rUXpOmr8Wf2AXu99i9JAqOEaDg2eSL68s3Ln5otSvPHJUPzg1?= =?us-ascii?Q?Kwnw+wxz+LT0GAO0jVbSw+x3UEJ9pcHWnirnOf9fKI+kn1RQhTzhkd+QCtMX?= =?us-ascii?Q?BFeEgD6C3DLC54rxXT6PokXwlmQ8qGrwZy4Qzf8b2Qs4WwUbQhJGFfR3VcwX?= =?us-ascii?Q?MJtl+bDS0gF0se6Y6E2S/3n8bcqfeCleYgfvVQc9UbKolsZ0JWzvutuCOo0U?= =?us-ascii?Q?fYBzRPy6idLD7GOcJDsgasjsNzidapi4XzF/nc5/tEiHj6bECe4ImIJZwoCt?= =?us-ascii?Q?FxtRLe3IcxYPQduain4pGtUz1sWTmnwOjdGZlHXOxI7lj42LId3V0WSXRAdB?= =?us-ascii?Q?ArIzNjggTgjzIL/Yy1vJj9VDwtRzZYCmVu0z/Wb0z+XvxvwFBPC//cCdNqPG?= =?us-ascii?Q?xYR0bV0RgSQGmjhsJUBbqvaIgm6qA9MEV4pIFrTiovRuW9nGbdKq1DC4NZWo?= =?us-ascii?Q?H8U6gA9SiluZejKOvvwA0sDe1H0hgGWpXwJhVyJwG+URZJclkXyR4C3PF6Z+?= =?us-ascii?Q?X4/nV+pYFkZWX6XO85PyZ4DOsxgK2NVok5QjyV3pfVZgQtoGY3lAEmOWC/MT?= =?us-ascii?Q?k7YuuvLZZLxAGItmiJhO8BMjaiUOLgkKrRrNgdqU?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB6198.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b939794-715b-4cb7-52f1-08daf83e6e92 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jan 2023 03:53:45.2622 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GQysg+Uo1szwdSJbT657UFvqpTa/D67FoRwVDb1Ec18liQoSiWGQYkmBlw9699IUYPK3URaS3IEN8Q795p8XAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5346 Return-Path: william2.wang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable OK, I've updated the reserved bit. Thanks, William Wang -----Original Message----- From: Kuo, Donald =20 Sent: Monday, January 16, 2023 5:23 PM To: Ni, Ray ; Wang, William2 ; d= evel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Kumar, Chandana C Subject: RE: [PATCH v2] Update CPUID Leaf 06H to follow latest SDM. Thanks Ray to clarify. @Wang, William2 let's follow the EDK2 recommendation. =20 Thanks, -----Original Message----- From: Ni, Ray =20 Sent: Monday, January 16, 2023 5:19 PM To: Kuo, Donald ; Wang, William2 ; devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Kumar, Chandana C Subject: RE: [PATCH v2] Update CPUID Leaf 06H to follow latest SDM. Donald, Old code might reference existing Reserved field in the structure definitio= n. So, to avoid old code assigning value to different bits if using same field= name but for different bits position, edk2 recommends to change the field name from ReservedX to ReservedY when t= he bits covered by ReservedX are changed. Y is the next unused index. So comments as below: >=20 > - UINT32 Reserved5 : 11; >=20 > + UINT32 Reserved4 : 2; We should rename Reserved5 to Reserved6. >=20 > + UINT32 IA32_THERM_INTERRUPT : 1; >=20 > + UINT32 Reserved5 : 7; Reserved7.