Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation

["Yuting Yang" <yuting2.yang@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 6576 bytes --]


Hi Liming,

The way to apply new VfrCompiler in Edk2  is detailed in the BaseTools/Source/Python/VfrCompiler/Readme.md file
You can use this branch to have a try ~😊
https://github.com/yytshirley/edk2/tree/PyVfrCompiler_Tool

Thanks,
Yuting
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming via groups.io
Sent: Monday, December 11, 2023 5:34 PM
To: Chen, Christine <yuwei.chen@intel.com>; devel@edk2.groups.io; 'Rebecca Cran' <rebecca@bsdio.com>; Zimmer, Vincent <vincent.zimmer@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; 'Leif Lindholm' <quic_llindhol@quicinc.com>; 'Andrew Fish' <afish@apple.com>
Cc: Feng, Bob C <bob.c.feng@intel.com>; Yang, Yuting2 <yuting2.yang@intel.com>; Hartung, Stephen <stephen.hartung@intel.com>
Subject: 回复: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation

Christine:
 Is there the change in Edk2 to apply new VfrCompiler? Can you share your code branch with new VfrCompiler to pass build on Emulator or Ovmf? I would like to try this tool first.

Thanks
Liming
发件人: Chen, Christine <yuwei.chen@intel.com<mailto:yuwei.chen@intel.com>>
发送时间: 2023年12月7日 17:08
收件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Chen, Christine <yuwei.chen@intel.com<mailto:yuwei.chen@intel.com>>; Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; 'Rebecca Cran' <rebecca@bsdio.com<mailto:rebecca@bsdio.com>>; Zimmer, Vincent <vincent.zimmer@intel.com<mailto:vincent.zimmer@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; 'Leif Lindholm' <quic_llindhol@quicinc.com<mailto:quic_llindhol@quicinc.com>>; 'Andrew Fish' <afish@apple.com<mailto:afish@apple.com>>
抄送: Feng, Bob C <bob.c.feng@intel.com<mailto:bob.c.feng@intel.com>>; Yang, Yuting2 <yuting2.yang@intel.com<mailto:yuting2.yang@intel.com>>; Hartung, Stephen <stephen.hartung@intel.com<mailto:stephen.hartung@intel.com>>
主题: RE: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation

Hi Liming,

Is this feature been tested and reviewed these two weeks? 😊

Thanks,
Christine
From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Yuwei Chen
Sent: Monday, November 13, 2023 8:32 AM
To: Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; 'Rebecca Cran' <rebecca@bsdio.com<mailto:rebecca@bsdio.com>>; Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Zimmer, Vincent <vincent.zimmer@intel.com<mailto:vincent.zimmer@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; 'Leif Lindholm' <quic_llindhol@quicinc.com<mailto:quic_llindhol@quicinc.com>>; 'Andrew Fish' <afish@apple.com<mailto:afish@apple.com>>
Cc: Feng, Bob C <bob.c.feng@intel.com<mailto:bob.c.feng@intel.com>>; Yang, Yuting2 <yuting2.yang@intel.com<mailto:yuting2.yang@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Hartung, Stephen <stephen.hartung@intel.com<mailto:stephen.hartung@intel.com>>
Subject: Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation

Hi Liming,

I know your point. Would you like to start reviewing it and give us more feedbacks? We really hope it can be merged as soon as possible.
We can do the merging after the stable tag, but just like you said, maybe we need to review it firstly.

Looking forward to your feedbacks, and I think this one is a very big step for BaseTools. Thanks a lot for your help and contribution on this.
I have created a BZ for this feature: https://bugzilla.tianocore.org/show_bug.cgi?id=4596
Will update the patch with Bugzilla link. (This step should not influence the reviewing)

Thanks,
Christine

From: gaoliming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>
Sent: Thursday, November 9, 2023 10:19 PM
To: 'Rebecca Cran' <rebecca@bsdio.com<mailto:rebecca@bsdio.com>>; Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Zimmer, Vincent <vincent.zimmer@intel.com<mailto:vincent.zimmer@intel.com>>; Chen, Christine <yuwei.chen@intel.com<mailto:yuwei.chen@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; 'Leif Lindholm' <quic_llindhol@quicinc.com<mailto:quic_llindhol@quicinc.com>>; 'Andrew Fish' <afish@apple.com<mailto:afish@apple.com>>
Cc: Feng, Bob C <bob.c.feng@intel.com<mailto:bob.c.feng@intel.com>>; Yang, Yuting2 <yuting2.yang@intel.com<mailto:yuting2.yang@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Hartung, Stephen <stephen.hartung@intel.com<mailto:stephen.hartung@intel.com>>
Subject: RE: [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation


Christine:

 I can’t directly reply to the original mail because it is too large. This is a new feature to add python version VfrCompiler. I don’t think we have enough time to review the design and implementation. Although it has no real impact, its code may have many change in future. So, I suggest to merge it after this stable tag.



Thanks

Liming



Below is your request.



Hi Liming and Cran,



Could you help on quick reviewing this new VfrCompiler python tool, it has the same functions with origin C version VfrCompiler, meanwhile it supports more new features such as generated Vfr files config info into Yaml format.



This feature is urgent for us to use, and we really hope it can be merged into this stable tag. This patch is linked to the edk2-basetools PR: https://github.com/tianocore/edk2-basetools/pull/109. We list all the known issues which will be enhanced in the ReadMe file. And will enhance them one by one after the patch merged.



For the code quality, in this patch, the new tool is not enabled in build process, it just saves in the basetools python folder, which will not influence the current edk2 behaviors. We will enable it with a new patch when everything is ready.



Many thanks~



Hi Vincent, please help add more information if necessary~ Thanks a lot~



Thanks,

Christine




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112584): https://edk2.groups.io/g/devel/message/112584
Mute This Topic: https://groups.io/mt/103183775/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 17799 bytes --]