public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Jeff Brasen" <jbrasen@nvidia.com>
To: gaoliming <gaoliming@byosoft.com.cn>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"bob.c.feng@intel.com" <bob.c.feng@intel.com>
Cc: "'Chen, Christine'" <yuwei.chen@intel.com>
Subject: Re: [edk2-devel] [PATCH] .gitignore: Ignore build tools build logs
Date: Thu, 7 Jul 2022 18:14:02 +0000	[thread overview]
Message-ID: <DS7PR12MB57890FE468ECA891841D3CF1CB839@DS7PR12MB5789.namprd12.prod.outlook.com> (raw)
In-Reply-To: <DS7PR12MB578934BCB0260F8F57A18678CBAF9@DS7PR12MB5789.namprd12.prod.outlook.com>

Just following up on my outstanding edk2 patches to check on status/review feedback.

Thanks,
Jeff

> -----Original Message-----
> From: Jeff Brasen
> Sent: Friday, June 17, 2022 9:38 AM
> To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io;
> bob.c.feng@intel.com
> Cc: 'Chen, Christine' <yuwei.chen@intel.com>
> Subject: RE: [edk2-devel] [PATCH] .gitignore: Ignore build tools build logs
> 
> Anything else needed prior to getting this merged to edk2?
> 
> > -----Original Message-----
> > From: gaoliming <gaoliming@byosoft.com.cn>
> > Sent: Thursday, May 19, 2022 7:19 PM
> > To: devel@edk2.groups.io; bob.c.feng@intel.com; Jeff Brasen
> > <jbrasen@nvidia.com>
> > Cc: 'Chen, Christine' <yuwei.chen@intel.com>
> > Subject: 回复: [edk2-devel] [PATCH] .gitignore: Ignore build tools build
> > logs
> >
> > External email: Use caution opening links or attachments
> >
> >
> > Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> >
> > > -----邮件原件-----
> > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Bob Feng
> > > 发送时间: 2022年5月18日 15:15
> > > 收件人: devel@edk2.groups.io; Gao, Liming
> > <gaoliming@byosoft.com.cn>;
> > > jbrasen@nvidia.com
> > > 抄送: Chen, Christine <yuwei.chen@intel.com>
> > > 主题: Re: [edk2-devel] [PATCH] .gitignore: Ignore build tools build
> > > logs
> > >
> > > They are the BaseTools build log files that are generated by
> > > BaseTools/Edk2ToolsBuild.py.
> > >
> > > Thanks,
> > > Bob
> > >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > gaoliming
> > > Sent: Wednesday, May 18, 2022 2:40 PM
> > > To: devel@edk2.groups.io; jbrasen@nvidia.com
> > > Cc: Feng, Bob C <bob.c.feng@intel.com>; Chen, Christine
> > > <yuwei.chen@intel.com>
> > > Subject: 回复: [edk2-devel] [PATCH] .gitignore: Ignore build tools
> > > build logs
> > >
> > > Bob:
> > >   Do you know what files will be generated in
> > > BaseTools/BaseToolsBuild directory?
> > >
> > > Thanks
> > > Liming
> > > > -----邮件原件-----
> > > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Jeff
> > Brasen
> > > via
> > > > groups.io
> > > > 发送时间: 2022年4月22日 1:01
> > > > 收件人: devel@edk2.groups.io
> > > > 抄送: bob.c.feng@intel.com; gaoliming@byosoft.com.cn;
> > > > yuwei.chen@intel.com; Jeff Brasen <jbrasen@nvidia.com>
> > > > 主题: [edk2-devel] [PATCH] .gitignore: Ignore build tools build logs
> > > >
> > > > The python BaseTools/Edk2ToolsBuild.py creates files in
> > > > BaseTools/BaseToolsBuild and should be ignored.
> > > >
> > > > Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> > > > ---
> > > >  BaseTools/.gitignore | 3 ++-
> > > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/BaseTools/.gitignore b/BaseTools/.gitignore index
> > > > a45689bc89..ddf93b7116 100644
> > > > --- a/BaseTools/.gitignore
> > > > +++ b/BaseTools/.gitignore
> > > > @@ -17,4 +17,5 @@ Source/C/VfrCompile/VfrTokens.h  Source/C/bin/
> > > > Source/C/libs/
> > > >  Bin/Win32
> > > > -Lib
> > > > \ No newline at end of file
> > > > +Lib
> > > > +BaseToolsBuild/
> > > > \ No newline at end of file
> > > > --
> > > > 2.25.1
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > 
> > >
> >
> >


  reply	other threads:[~2022-07-07 18:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-21 17:01 [PATCH] .gitignore: Ignore build tools build logs Jeff Brasen
2022-05-18  2:58 ` [edk2-devel] " Jeff Brasen
2022-05-18  6:40 ` 回复: " gaoliming
2022-05-18  7:14   ` Bob Feng
2022-05-20  1:19     ` 回复: " gaoliming
2022-06-17 15:38       ` Jeff Brasen
2022-07-07 18:14         ` Jeff Brasen [this message]
2022-07-09 13:46           ` Bob Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DS7PR12MB57890FE468ECA891841D3CF1CB839@DS7PR12MB5789.namprd12.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox