From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.69]) by mx.groups.io with SMTP id smtpd.web08.1040.1657217680445750809 for ; Thu, 07 Jul 2022 11:14:40 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=selector2 header.b=pVfDClOb; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.93.69, mailfrom: jbrasen@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JLGcUmVyP9CyCwgBDhTQt2pj5kTxqOoCW4drBgzgfYjJ3mXoDTvmXVf4bXYf3pV6VOTL7TDYLTM/2v/Nzy7qyN1E/9y5gFVS0r0TTqOH4BE5egd7AWXtGlGJtkPaaTe0t9Rsp2H/fkbOKWi0vVlLPGiZn82SFOyJLUpoQ0nEIY9zPZ1j6QI4eP6psuVwMd2TUUvb0jn0veYhZuRAQ2vmFd+LQe95NPCRAfNZ+2HG2bgh1zqFgdGeep3Zz+p/IiaeDvyjBANlIm8ctXDdh6LOSbWXyr3PPZshQtKOmKp6cJeFcmS+/HcV23u77SjGK/nvTeFlavGE6QKNCYOz6fc69w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PxqILjGN+yjyYKz2pgjoUJ3LcOQbuIaB4dlS2zeYNHE=; b=gSc6zHxlWRX6OjDfJkzgVtboPpyCDDclGhHnyl5ZJhguL2uO27kLv2K5VZNE4NuUtaQIMwxlyN4bGghiqsPf+WBmot6F/rkQG7cYKhzdn90ASJ1x6g559znxwAZvhODZZlFXuLLypKJxckntCEjbL2WwsnMlqLQgCWAK3U5259QhC064sB6Ug6bqzcq3MjBPkfwX99FRHmDXnYZFh9n5xWM4CIo/xTlND05QTJKZBAuzvEsoQmlRh9xll1yUPWsaAlKPgcL/aRSXbGynLdEepEVLS0KMOs/EEMuAI5tdFe4A7XXMGwXBlglYdNhcd7/P/eoEWhc71ndPdennrIp9Dg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PxqILjGN+yjyYKz2pgjoUJ3LcOQbuIaB4dlS2zeYNHE=; b=pVfDClObnntYqbys2uo8xtYNE/w3LI3g9Zpiox+OVVafjkST+tHLjzBX4TTxHDKSmOWVAntBWiQzE6gpL1VzZn5/wqjNUR9jUZqQPNvQAfr2zhGOsnXnm1dj/4X8RjYlMz7yCEg4i4yisMWX4WQSH85NVGBn0zU0QubYuKJIZpMbV3OLqrUoo/smsP7bIcVXAidR84BXuZrfH/IoTFnM0HUYJ+G6fLp7FsWktqU7uGjfmI7QyFDu2VHV0i4TvgwVrBGDe+tGxjYVKYaqlYwzSbmN8AlhGOe0v+BxxC1fZxcbRa/k8AInZUEkNKXyyhMYtSBCpNeJmoE23vBtef8Ekw== Received: from DS7PR12MB5789.namprd12.prod.outlook.com (2603:10b6:8:74::21) by BN6PR1201MB2546.namprd12.prod.outlook.com (2603:10b6:404:b0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Thu, 7 Jul 2022 18:14:38 +0000 Received: from DS7PR12MB5789.namprd12.prod.outlook.com ([fe80::d94:9d75:d614:372]) by DS7PR12MB5789.namprd12.prod.outlook.com ([fe80::d94:9d75:d614:372%9]) with mapi id 15.20.5395.021; Thu, 7 Jul 2022 18:14:38 +0000 From: "Jeff Brasen" To: "devel@edk2.groups.io" CC: "jian.j.wang@intel.com" , "gaoliming@byosoft.com.cn" , "zhichao.gao@intel.com" , "ray.ni@intel.com" Subject: Re: [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs Thread-Topic: [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs Thread-Index: AQHYgBfDWO5K8Fa2wUy2yL4RcCNqFq1zWqPw Date: Thu, 7 Jul 2022 18:14:38 +0000 Message-ID: References: <9c52d44c283b1c42de20ee373be1d4994c4daf35.1655229046.git.jbrasen@nvidia.com> In-Reply-To: <9c52d44c283b1c42de20ee373be1d4994c4daf35.1655229046.git.jbrasen@nvidia.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: db275d8e-c18d-4a03-5ed3-08da60448e29 x-ms-traffictypediagnostic: BN6PR1201MB2546:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XINrrUbbSr6n0ElR4fY3bZlPvBGSryjMKubO9pWdeEK9nkAzALZqo8S6Blld7nbCkwfH2wZK7W9gdXxULY1MC7URBS5k+EZGZXAPEZWrIeIX2FJba7b78fTVcEa2lhiFgbH6VaIo2zY9PZRchK7PLkedKzbiipX0Lw1dG/hbdVj2dG+bw9zE4w9L3skSARKHO/kcNJyh+gEKBr7fGp4qyZBI3qNI5jNcbrotLSyb/pmwbXzXRx//dndph/JHgTCkjT/jH1BsKTuRjYyM9FRMyLw1ceAI98OjMoNrgYujLkFee/9X9FSQYDGLCMc9Mju3FCHI0zQHEjtqOz55vsP7jzhL0ZpTMHmLv/JXkB0xFcsAYQMhpGvap46ap1OKbNocoDRSInfZcI7n3AcpHSzRRPnPBWoc/ml3WqzE3qOMRAL3oD0LY3McDXlQzhx0QA0wFWI8l84Px8u0Erndw4IAktBrTDp3Y8OXU+2ocRqtcw97PeQOgRtoyI05Gfq5UwDCMfcJ+7Td8IkM3qdL9wEJN+vEYd4/bm71b4DQSclcBGyxOhdYZs7W0YsVlmucoJcVNl3uzH57H6KAyLmDKvXWxQ3XF90LtCRMxmqdlq8C+orxfBBn5eS/4/nx3w/9j2EUYvaRTIVFs2FJ+u6VlH5/Xcir/eGxh/ZIifPQT7szxJCZcJItKEhiwa8MhKmSwmYEtBG65R7ZjjocEeMgaQ5MyNeWQX/v3pjFOyN9HMwEfoU9BAgZzTC7iJWFCluBgjXl18w45rh1aVRAD79kxoKt7AvHFBZMtjyoklqCtcsnft9Ky4xbKoudDrYVYLyFtlwn x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB5789.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(396003)(366004)(346002)(39860400002)(122000001)(55016003)(38100700002)(54906003)(186003)(83380400001)(8676002)(6916009)(66446008)(316002)(76116006)(66556008)(71200400001)(66476007)(66946007)(4326008)(64756008)(9686003)(53546011)(7696005)(8936002)(478600001)(41300700001)(26005)(86362001)(2906002)(6506007)(52536014)(38070700005)(5660300002)(33656002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?A76g8guBJpyqIECrqQCfbSo9tKA3jDTCqusVuFypHZt12Fh4/59ZlTfBBYWk?= =?us-ascii?Q?6XrSvbzzG0m8g/ovhqtXcdPmC5BLruz4hRF3A3sraho8yPBt3M23jXOHHr0g?= =?us-ascii?Q?mxXgtMQYquu1dHb+0BQt1BfGWAW8AjtmmukUk8bci00O3ogN+xN8hdGMYJ7M?= =?us-ascii?Q?xV3tdxk+POHqLLFLIm5J4u7gLUofcIOjji+9kfWUXiQnkLYoqAMmwOJMeDgd?= =?us-ascii?Q?CpaVRLeG5eLsM5GusB2xJUqO1kt8DxddZvO/vI8Hay9pr3k2vUeMRup3fETd?= =?us-ascii?Q?AlfziqTOwEi6NtEZmQgh5mMxw9zgBFqxwG8jecsRLm/agWf6JMGdRsD4HFkN?= =?us-ascii?Q?gyVyU4l2BA1QHjZpGwDamtQOhJ4bhUiLgewC1JEw+JsMVtAKN7izWrj+e+FK?= =?us-ascii?Q?5AZZNiTEuM0VrGqdn64Q1jvo6qPnR99UVcu3ru+TWtR9J/CCT/uzOSVHFRXf?= =?us-ascii?Q?MQDbGYciGpjrmEXOzPYwFzsf3EVs94pf/iyCcFn3k8Bg7YBHBcGdG9vgbqyc?= =?us-ascii?Q?HHWLD5sVhe2Otl+NxO0I7PjpfOfw7zomfyGClC/U/anO9KmszECpTFdZ/hgI?= =?us-ascii?Q?R3FNr3Zc9rCbIDy3BfDHaWeUaeF9HoZGFBsJ6juCzQlOfNd8/4yEXtZH5vzC?= =?us-ascii?Q?FKj3fszu6QRlgoSoMBtniv6TAwILBsI+V+tzbZ/LcCPT9BLi81ZcSkJTCC+J?= =?us-ascii?Q?aheDq62EsVJUUJZ1Wql4bOqS92rN4U74mSab825RIVIWWbSxWsC9mN66nb+9?= =?us-ascii?Q?XfzCRZJtSQi+TQvjNVAKbVe8eUn2PKeEyOd1z8QzV5ZjxolbGiGMC7/IN26Y?= =?us-ascii?Q?tQ/bQS9mybDWu3tLdeEd8rqNJENN+jYplY8Vsiwf31N8V8FsYGig64bOjWM2?= =?us-ascii?Q?FoEIQg7ercgQ5BV0626hB0ViD85Lh3N5LUZjjN3QGsv9T7TcaKGQxNQcc6be?= =?us-ascii?Q?8s3rCSTGMiUs/jBVBCyo3l8o5JBfd5BjabANONos5nd2XRSjc6DD76P32Ihv?= =?us-ascii?Q?4OGoNFD4eoPcPki4wqzELFU1vQce1takzgmOIUbCcTx88PVKlbIxUtwLCSmE?= =?us-ascii?Q?59+FBeJXz474NNI+/gIzuzEFQHNYEwwrShp5M0P5Tx95Lq0B0HOMV+/Hil6D?= =?us-ascii?Q?VKTCYoxHAMShgcg/sEufPgUHdRXymmApMDDsvxRPgGzBOOrDET+5+Wg+HYvu?= =?us-ascii?Q?y4Rlr0zBuJZzJUp/vJ6GP23HLmJ56rfLGH5pJIXDciBpCE46oVFHeB3jB1Bk?= =?us-ascii?Q?SlWJMW/51Zi2eQXET9kz1jlcCet0I7Zg8FlfOm0SL5NctZWfX//mNm/d00/5?= =?us-ascii?Q?/NLiwRiZZ8PoGRnXlzsaHJxRYCJBHvS15nvkZTMRx1k2rciQ+iog0rNyop8D?= =?us-ascii?Q?TFhacUARh8t8u84XEtwjODCD8ZJ5VUAC+n7YaaSwrGg7gV9qr3nTeNstSEha?= =?us-ascii?Q?jBn/umKI+uIw3CO3FXrMwCz61OSAcAF3L+l5xveqlMHUU2QteB7/LA5cXC7U?= =?us-ascii?Q?vWc/PGB9XLWTwDBMUgLpV34V+vSTcHkgIofNn1lS9vWwX031JD3rvr5JvkMg?= =?us-ascii?Q?bUFwVpk2AwiSec+hhBsYd4vDiGcE9DWNUGOEAV1T?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5789.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: db275d8e-c18d-4a03-5ed3-08da60448e29 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2022 18:14:38.5308 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HQzRYXzgHoC+PGu2Uvu9WR3ZEH5OO44KVBzpSqIdn6Jd/I+d9mLaIsRj53/LELy+VGEbU66zDQSqa1rhDuAR9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB2546 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Just following up on my outstanding edk2 patches to check on status/review = feedback. Thanks, Jeff > -----Original Message----- > From: Jeff Brasen > Sent: Tuesday, June 14, 2022 11:54 AM > To: devel@edk2.groups.io > Cc: jian.j.wang@intel.com; gaoliming@byosoft.com.cn; > zhichao.gao@intel.com; ray.ni@intel.com; Jeff Brasen > > Subject: [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info > support for Ufs >=20 > Add support for getting disk info from UFS devices. >=20 > Signed-off-by: Jeff Brasen > --- > MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c | 3 ++- > MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1 + > 2 files changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git > a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c > b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c > index fac33b9ee9..87b82f299f 100644 > --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c > +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c > @@ -195,7 +195,8 @@ BmGetDescriptionFromDiskInfo ( >=20 >=20 > BmEliminateExtraSpaces (Description); >=20 > } >=20 > - } else if (CompareGuid (&DiskInfo->Interface, > &gEfiDiskInfoScsiInterfaceGuid)) { >=20 > + } else if (CompareGuid (&DiskInfo->Interface, > &gEfiDiskInfoScsiInterfaceGuid) || >=20 > + CompareGuid (&DiskInfo->Interface, > &gEfiDiskInfoUfsInterfaceGuid)) { >=20 > BufferSize =3D sizeof (EFI_SCSI_INQUIRY_DATA); >=20 > Status =3D DiskInfo->Inquiry ( >=20 > DiskInfo, >=20 > diff --git > a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > index fe05d5f1cc..2fc0a80a4e 100644 > --- a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > +++ > b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > @@ -85,6 +85,7 @@ > gEfiDiskInfoIdeInterfaceGuid ## SOMETIMES_CONSUMES ##= GUID >=20 > gEfiDiskInfoScsiInterfaceGuid ## SOMETIMES_CONSUMES ##= GUID >=20 > gEfiDiskInfoSdMmcInterfaceGuid ## SOMETIMES_CONSUMES ## > GUID >=20 > + gEfiDiskInfoUfsInterfaceGuid ## SOMETIMES_CONSUMES ## > GUID >=20 >=20 >=20 > [Protocols] >=20 > gEfiPciRootBridgeIoProtocolGuid ## CONSUMES >=20 > -- > 2.25.1