From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.88]) by mx.groups.io with SMTP id smtpd.web08.10081.1663952710636656914 for ; Fri, 23 Sep 2022 10:05:11 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=selector2 header.b=GSlef05e; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.94.88, mailfrom: jbrasen@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dbnuLhBAqKbFegcltX0BMCrKR7Ds02gzRihDzdNYU500uTBQv8rn9QVnQO4eYPwLsuD9xuYoxcgtY2EvxgmH9KM5waF025+cTCWj5G6ZPMCthlXhy11GVg+z44TgbOOg2udtFA62/AcOWrVD96Cn+wJB79YOCLPJ33cOeo0rvxsEy+MU3MYShw+SkQ7ny4PsgFWkWup64+zkJ/LlZwtop++Dx+zF3vKS4lUIwti6qcRly74MkIjq5UaJulKSOtjG+ZRxg1Vh3sT4dQHSu57Ej9t/OD0apq316uCFXygZIEKE5VBaO0jct9uBFUcUg350VIyGiGS9jInj1bdaYAcyig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bbawj4p4p7JC0ho24759OlWdIvS+QbkF71AWdjSPN6Q=; b=X+xNTW2HEB26M2qVSCEPsCD/8GyAJpBji/4l9KucI0y+NvZSU0XzTn9SS/EZChdlVLkNQGv13T7Cavs6O3laq5CpX2FFDjyzQtF0Iz4C+BILaPzkJIAtxonYMo4reYwHoMoyq1D/yTP1r5vvQzcqYR5yqqYTl5rhoflqFEDwWF9TTB1g2vw+EWcb1pGVYCG6xDF+RPPokjqYFC5XrQlfHfuxjSX747KzH50oDdAHPy9SlUIUX3vpGC0fdiyMj5i4q6hQBXQKtiKTPtbUFNt+iXNHRnuabCPlApfxSgyfTSX8RcLa85Jcrnif3ZAbRKpzhy0sMk/sxLnsUs3Eb5Fl+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bbawj4p4p7JC0ho24759OlWdIvS+QbkF71AWdjSPN6Q=; b=GSlef05ezgQ1862OWuL0niC+Ws+S3bjXDSVZ/BVNgD5ANw+1jidD2gLSwyv9QFa7O8kVogTmYCqLByeLRjaY8C51RzTcpYM14v5tKh6Ru9pZ9LwSTEWv40g80wRUkbZ0eb7DakPEn4msYs/VgDNSPFSAWxhNH16MwoNETz+EUQzdHmLgy9o2T7UIOAHcQJMWSgCj4kYI57Rvxpj6UXClxfnECwdENeVbACa/o3yPr/jqKsgfwwab4jVRN8WwdNXiNmhJjBq2UhNczrwrPeIZ13bN2YB6rO0EvWaC4NCWzsff98PA4JZzRgixSch4JFb9YYR8wrwVl+zqaxiWQQGAFw== Received: from DS7PR12MB5789.namprd12.prod.outlook.com (2603:10b6:8:74::21) by DM6PR12MB5022.namprd12.prod.outlook.com (2603:10b6:5:20e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.20; Fri, 23 Sep 2022 17:05:08 +0000 Received: from DS7PR12MB5789.namprd12.prod.outlook.com ([fe80::84f:b16e:729e:2eca]) by DS7PR12MB5789.namprd12.prod.outlook.com ([fe80::84f:b16e:729e:2eca%4]) with mapi id 15.20.5654.020; Fri, 23 Sep 2022 17:05:08 +0000 From: "Jeff Brasen" To: Sami Mujawar , "devel@edk2.groups.io" CC: "ardb+tianocore@kernel.org" , "Alexei.Fedorov@arm.com" , "pierre.gondois@arm.com" , "nd@arm.com" Subject: Re: [PATCH v5 0/3] DynamicTablesPkg: _CPC support Thread-Topic: [PATCH v5 0/3] DynamicTablesPkg: _CPC support Thread-Index: AQHYzsMVcPmDJOtWVEupYvLW3Ig08a3tPQmAgAAChyA= Date: Fri, 23 Sep 2022 17:05:08 +0000 Message-ID: References: <9e752a96-e578-6641-19b9-7de75137fb22@arm.com> In-Reply-To: <9e752a96-e578-6641-19b9-7de75137fb22@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DS7PR12MB5789:EE_|DM6PR12MB5022:EE_ x-ms-office365-filtering-correlation-id: 4e1fe433-8d0d-4f6a-0505-08da9d85c502 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nNcj0x4ybHjg4VokEV2b+sX/HRa6YCsQDwYOuiSYCe9t0BDRfWT10X8eMGHp2+msbvZywGZQIGhlu0Srh040ai2+dZB3T17vNRDQao8SebSApm/3K2yOlX6c8SHSkGhwwEJvlAnuyPy4BtlbGP/lyGFOLNX+HqQ5cuxBWPTpiS/J0E1Y2Ir5fLRrmEsfZvIyVTyCVRHd98yix2DEWjsqWn5si2hmfgoO0mO1LVIksY7IUakSUyuhBHhzMuMWTaBvSvjAuj8QwSMILJdjskUV2jXFx8h52SglYYWsFQbLm8fFkbV+oTPM+z7fCWYVq2fnWX9KxSefEI8Rrv1f3liwJZF2ND8BQ0c1KeSO2bvNQBp5sWIXKg3QrMMqIw1q4Mc1y834DfJ3jjnz8w//4+w97hEx3/f055UWxTlX8/+idJ06X+mE/K+ya+XYR4cDiub7nk3cNPHTxz6mbPHxOkDxdZ29R3JMTMv4zpucCxDDqCv6u8nu1xlEolyxVGW2fnwG5F1QOjqV3DzHwSMHB65406P32vxQDZmLliAF/PFgOhblrgCh76hhUW9U6UQFbnE3nwNMXLd4WcL1mUYPa6NTnYexo7sL6ohhuHCD7GwTHIl+jbFm4AWpWTeLb7ELgVFdlx4OvojtRygJm4QfudlrVnw/ucZnxZO1U5xLKsDBNoICulzpIAgzSPFwLjZ6E7sA8TZyMXx/WJJXJ1ZLPO8xqzgMAOvtK48rysg6WpeqRs6yvjYX2jEtWUY3NKKF8ZxKeLjZx3j4CDy6yHWsNV6FtL5VK79gN0Os9Mj1rYabMzk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB5789.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(366004)(396003)(39860400002)(346002)(451199015)(478600001)(2906002)(38100700002)(76116006)(38070700005)(966005)(66946007)(45080400002)(316002)(54906003)(110136005)(71200400001)(66556008)(186003)(86362001)(122000001)(83380400001)(9686003)(26005)(52536014)(66446008)(55016003)(64756008)(33656002)(41300700001)(8936002)(5660300002)(4326008)(66476007)(7696005)(6506007)(8676002)(53546011);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VXS/4eQlRHWriedFQLjB/CLLjMuMXO1r614PgP/FyRw8pf0XetimbKxuTd4J?= =?us-ascii?Q?9C9vbB3KMUlR/Bj1OY5PNBC03rCCf29y1OcAq3446lFfaMb5fmlvOteLYCW7?= =?us-ascii?Q?47Fep+Blhsj7HeEqX3e9M4NDkD0EFC6bYyvTIpD4IbTttK/PPvm1XZsJSfqn?= =?us-ascii?Q?EqYurQMmZG5A6hjbCUNjDm9y0E72niUhIpjFh+MwuQLfAaIuC2VmNQLqFcEW?= =?us-ascii?Q?UclF0zUcmI+DEnekbAkAVD8tEeCVzQ7mOIJxLxO6PY1bjDV34JHdws685aQl?= =?us-ascii?Q?KJcjmhbUwebcrSjl4aFTzMUY4CdvTkMOBD5ZN5TnKnQ6u8xPviQZb1uryXEJ?= =?us-ascii?Q?2/GQ3SyXv13WTl+m8CvLDpwVfWRG4p0cwRt0UhKL/aWZUpCuUJa3K0KFMfhV?= =?us-ascii?Q?8ltxmwsg/ePZLweRmke52O0ybryJrr9Rd3hGZL8KRAVea+jQPoQPL44lJLQw?= =?us-ascii?Q?K8Wbv+ejXwO+peYfSRaDR9SmxW6Y9akzbiUUNpMggPjdAVZ1V43fujrIigLE?= =?us-ascii?Q?GG9GEJ6ySlOdP7Sskh0Y2AjQ74BA+qopZMEu/4AQipRN0j/wV5HE8+8xYB+6?= =?us-ascii?Q?ehkyWwag5ztrZoEX3DBRhzur/F6O/o9nXwIkLVI2qNyui7Rq0uR1UrG+JbeA?= =?us-ascii?Q?GtbXCxXKjHNm33OUBuXNCALuY2KEfj1Q2bBN9Gr1fkh9QgwAQgDH+kurjY/S?= =?us-ascii?Q?1WijxB2KqqtmA1yuu40HIBBPWKZiVCHTFXwKTgKAeKh2m3hfCgEW+e5aOVqP?= =?us-ascii?Q?2llZNk/I4bD5fIs27hTe/nRVWsU9CoyOTWrqF1rtdJVAc38ubhCSKR9GWS/S?= =?us-ascii?Q?jDYV9uWoLinueNGEJH1+hL329eIdNF0ryC+NnDmf2sfH3SjV3IrqAIOiUJ2e?= =?us-ascii?Q?k/6kqYdSP1Z1ZAm8EPaSE7IQ5xv/rrDTlxOXuXJCvRndJax8BHlb0NlV/EnO?= =?us-ascii?Q?Ap9I3sqbLd9z/yYUtsNPPkNbEXSMF0EJTUxq8poAqdyva4Hzducv2XMCrht9?= =?us-ascii?Q?Dj4iQ+xHjX4RnIIx0Fi515Q7u+tPWhAyBpAVU7t3koQQqelk7rU1rorzv+Qj?= =?us-ascii?Q?gZVZCzG1c+VNVYzkTfqo6K2LgIZSlg0JuXjZG8HCp6Qkd8ew8HPeFs4d769/?= =?us-ascii?Q?lDAdOhLW2VYibKFkSui3lU7r6iGoc9Xta2ne/UL3zKUYftzcAyfb349R2KAA?= =?us-ascii?Q?G5Pw4/mrsdqmAk2G5pgoRWhkYGERN45N8GxGGHOg9nL86pkKchVmPsHO+SNS?= =?us-ascii?Q?xYPUDLnBjiunPyOb+w0ffwnve2NcP8bkDvHk+wmSkVf45wf+8DI14bPROs2M?= =?us-ascii?Q?uj5qycslbq/NHVGVuJoRHCAWKHXU/o2meMI22s8OW3Wb2vMrewU7MlFe/Mdh?= =?us-ascii?Q?A/2BdYjHJ+HI/awGvnui19rAQEHaa+13WonYPKno0d0qOUoRGpa+S/ERGMOC?= =?us-ascii?Q?9FV3qGVM847ZfUAUU5YzIE/8kQb2NU630XMqeQJU1BVPKwvJ3GYi3fKCdTal?= =?us-ascii?Q?2q3yVSznkUjKkqEbCVT0r/hP7io1kEpGZ4MHw6D+wwKK3D3u40upH3CrUdpe?= =?us-ascii?Q?5RijaHfrnl6opxj583fU7yyzpMYEp4wuXVtZRixF?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5789.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e1fe433-8d0d-4f6a-0505-08da9d85c502 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2022 17:05:08.7489 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Qqywb8NJuMx16t5eCKW8Q/QBZaR76h1/zpiNqwBo8vADvcc/18eOKCVvydHfqOanM2aGCis/DlOzunagrqhd4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB5022 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Those changes look good to me. Thanks, Jeff > -----Original Message----- > From: Sami Mujawar > Sent: Friday, September 23, 2022 10:55 AM > To: Jeff Brasen ; devel@edk2.groups.io > Cc: ardb+tianocore@kernel.org; Alexei.Fedorov@arm.com; > pierre.gondois@arm.com; nd@arm.com > Subject: Re: [PATCH v5 0/3] DynamicTablesPkg: _CPC support >=20 > External email: Use caution opening links or attachments >=20 >=20 > Hi Jeff, >=20 > Thank you for the updated patch series. >=20 > I have made some minor changes: >=20 > 1. Move DynamicTablesPkg/Include/Library/AmlCpcInfo.h to > DynamicTablesPkg/Include/AmlCpcInfo.h to stop edk2 CI from complaining. >=20 > 2. Minor update to the documentation for CpcToken in > CM_ARM_GICC_INFO. >=20 > I have scheduled a pull request > (https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgith > ub.com%2Fsamimujawar%2Fedk2%2Fpull%2Fnew%2FREVIEW_2369_dynami > c_cpc_support_v5&data=3D05%7C01%7Cjbrasen%40nvidia.com%7Cfa438c > 463975467b580908da9d84760a%7C43083d15727340c1b7db39efd9ccc17a%7C0 > %7C0%7C637995489497585332%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC > 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000% > 7C%7C%7C&sdata=3DhwqiwMp1xW4hu1uTcJMiHhCpMnHCYh6jjmRDi1allx > Q%3D&reserved=3D0) > for checking that edk2 CI is happy with the changes. >=20 > Please let me know if you are ok with the above changes, and I will push > these changes. >=20 > For this series: >=20 > Reviewed-by: Sami Mujawar >=20 > Regards, >=20 > Sami Mujawar >=20 > On 22/09/2022 09:36 pm, Jeff Brasen wrote: > > Add generator for creating the _CPC object for CPU nodes. > > > > If viewing this review by a pull request is helpful one exists here: > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgith > > > ub.com%2FNVIDIA%2Fedk2%2Fpull%2F12&data=3D05%7C01%7Cjbrasen% > 40nvidia > > > .com%7Cfa438c463975467b580908da9d84760a%7C43083d15727340c1b7db39 > efd9cc > > > c17a%7C0%7C0%7C637995489497585332%7CUnknown%7CTWFpbGZsb3d8ey > JWIjoiMC4w > > > LjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C > %7C%7C > > > &sdata=3D7gI38kSJx1GjNPVikW1UX8nT8D2KIADcyta8MM4TI5c%3D& > reserved > > =3D0 > > > > Change Log: > > v1 - Initial Revision > > v2 - Added revision to object, improved error handling, changed to ACPI= 6.4 > structures. > > v3 - Minor review feedback > > v4 - Convert CpcInfo to structure and use that for APIs > > v5 - Cleanup parameter checks, add token to parser > > > > Jeff Brasen (3): > > DynamicTablesPkg: Add CM_ARM_CPC_INFO object > > DynamicTablesPkg: AML Code generation to add _CPC entries > > DynamicTablesPkg: SSDT CPU _CPC generator > > > > .../Include/ArmNameSpaceObjects.h | 60 ++- > > DynamicTablesPkg/Include/Library/AmlCpcInfo.h | 124 +++++ > > .../Include/Library/AmlLib/AmlLib.h | 54 ++ > > .../SsdtCpuTopologyGenerator.c | 133 ++++- > > .../Common/AmlLib/CodeGen/AmlCodeGen.c | 475 > ++++++++++++++++++ > > .../ConfigurationManagerObjectParser.c | 115 ++++- > > 6 files changed, 921 insertions(+), 40 deletions(-) > > create mode 100644 DynamicTablesPkg/Include/Library/AmlCpcInfo.h > >