From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 85B92AC18A4 for ; Tue, 12 Sep 2023 19:04:31 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=MIENPfVM4ZIscwxNmXZAwaM56MZuQonlHx0sQjyef/o=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1694545470; v=1; b=c+KJCAaHJnguP1N7anMF8URc5VG/LIYvKFFsIQ6wlXbwjo0iluvtXpuhmVI3AuwsD6+PC7Xb ovst3eus1wrXZRzc+SZqKv6MuXEydaOu/wItQOIm8l3Ojbna/5xAY96YTEiW58hpO3O3RdfVcRo fYA695WogJYqgmb269qZVLts= X-Received: by 127.0.0.2 with SMTP id FTQ8YY7687511xL89Nktw7J8; Tue, 12 Sep 2023 12:04:30 -0700 X-Received: from NAM04-MW2-obe.outbound.protection.outlook.com (NAM04-MW2-obe.outbound.protection.outlook.com [40.107.101.66]) by mx.groups.io with SMTP id smtpd.web10.3503.1694545469206910679 for ; Tue, 12 Sep 2023 12:04:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lVKTUgt9UP3srLSTCbYTG3P1EPLpBgrCApeusMGE7JHHzscbizvyRDNYYR/Pig03Me98SAMuxE1YFpeemgJD1EmiyTXCA7eUP2agSG0VfhiqN3SeRdLo4Ta94hNujnCst/baSHzkXh+QMqd5rtPMzjxvCvbrWEtqkc+vGIhSyDPkmhikh2KXHJknVMY2ErdK0b4JSAaYh7TP0mk8Ph8E7mS1R0kDgZhY70ONu9pc9/QPJ4PbvAv0T2xNoyqG1Xl4GJTmozJWWb5XZ2NuYs03sBg2ArIwv9T8Wzp02QkcfpM7F5KyHyiXgmNCGuUouCg9mPUJMEbaZippYwjI+KFhBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NVZXY+8Nx6zDpzCAJF1jD/EMchHm4ef26yJelYZdaEI=; b=ljyBFrYcOHIIqjb7SJ1g5xPLZlBg0PI5gLA0KD5vjr6NSA0ERyPrQBtXBXeD3y7xd9JZOeof4YkEALV/w6xbHSupS1VZqSAwRV9wZBhUQHvHKwzaF31a9XWM0jNeuC65HIFVTk+MHfnvDcteGnW3r2eu0NgO97Xa2Lee8EHKD2uBJQoJhY/nTQrTYw+z6P6MmUL2aVnTObpTjbD7OSoyGLVc6PsdePBTH9Ah0Rl/xcCYkddHiHrO+o5p3JFRW1/xxKjIgYj/bXuj3W8PPUAVWlmTXOE4vQMzKSash0e32xuDSeZEtd+NCLiCoK/oAZUMsdhTbMNlsp/0av31X76PbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from DS7PR12MB5789.namprd12.prod.outlook.com (2603:10b6:8:74::21) by SN7PR12MB7227.namprd12.prod.outlook.com (2603:10b6:806:2aa::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.36; Tue, 12 Sep 2023 19:04:26 +0000 X-Received: from DS7PR12MB5789.namprd12.prod.outlook.com ([fe80::ed5e:f299:fc26:f571]) by DS7PR12MB5789.namprd12.prod.outlook.com ([fe80::ed5e:f299:fc26:f571%4]) with mapi id 15.20.6768.029; Tue, 12 Sep 2023 19:04:26 +0000 From: "Jeff Brasen via groups.io" To: Leif Lindholm CC: "devel@edk2.groups.io" , "ardb+tianocore@kernel.org" , "Sami.Mujawar@arm.com" , "pierre.gondois@arm.com" , Vidya Sagar , Shanker Donthineni Subject: Re: [edk2-devel] [PATCH 1/2] DynamicTablesPkg: AML Code generation for I/O ranges Thread-Topic: [PATCH 1/2] DynamicTablesPkg: AML Code generation for I/O ranges Thread-Index: AQHZ5QqPxEvUMtoTDkSxoMAjkd1n5rAW7u+AgACdvvA= Date: Tue, 12 Sep 2023 19:04:26 +0000 Message-ID: References: <64a84c1fedd66114f46ddd5d47ff922d68169d4c.1694475927.git.jbrasen@nvidia.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DS7PR12MB5789:EE_|SN7PR12MB7227:EE_ x-ms-office365-filtering-correlation-id: 6ed7b26c-e9db-462e-4b9b-08dbb3c31580 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: RPR9os3Nd0Ad/O6A03rxNA6kOFZn62nVGA6sM8cixgRrfHnDoraKf/I7TvRdY7dkQhZ9s5jq8KUYm2J5HX7gnH4V1dbXIhSkEVhDxItszHHquuSWhe1e/D97W2mUkLkPGi/pE0Eebn2zCE2Khbkhi3gKbfWaH9c3C8bBaf7iR2+PL/Eopdz3YdZm0AgVHR8GWDoYKP9WLABrKW7bg3+h2x7WbWh5ZqhuEQSVywJjeN5EhL4m8c7Qgt9dIcQfEa9YTsgcNLZ6gKOk46r8t2Sn7NfllsECWkjkPJhq9DHECnp8J2XdXwmfqUV5HjNuGTAHkIprtXLmuEXY9RnLejM7OaOLicW4Z2bOqdBtW8i2AjWCA9M0uD+2HIYblAWlYGlxdLotZV3148mX3I6trvlD0Dpqxo958E561vCIc0a+4fX9b+g/IWF1ZWDSuByYn6NyBuXIYiYKEUex6c26eeklp+JkKPDbATgoDJzwF/7yOy/eJK7GcPPwzPEPTBLmh/b1k9Zb/iZJnol9hm4+tJGok2nREMX5KCGA5zNVxK/OcsIiZnh8qdyNY0QB4huC29vWGGnsnhslAk5T2YXEPxhv1U4WwC2KbQf9z5evpPJLOrI= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4G1dXPGLtLhetWmHiGYBeXXdjFDqwwd6kjsJ1OwbqnhTWyv1sYUhqlSk1izR?= =?us-ascii?Q?kcIh7tHSQMpJHfsYNLKTLlb+BchL0yuoTJu6vyhJb/zXSv5r6apNRE2b16QH?= =?us-ascii?Q?4dxCAgN/9YVn+4irAf1zCbiHYTBz1wQ0Eidm5RGmb2C2F/ja5DSInYStYkyF?= =?us-ascii?Q?xUzpc/5kc/t691/oz5137ZFtzp8vnhxna7oAAIAAV9oMnsD/RuC1oQSR6sTB?= =?us-ascii?Q?sVdLJfkPBQRoSccIxL016kMd/0M6XrTPoek/5OQ3cIdia36PJcW1Fpfe42fF?= =?us-ascii?Q?kLUVmVQLTEN8k/sJZL1bGR7mTboYjyL4P+NaNfh63xSaaLjYnrqxklFjFTTv?= =?us-ascii?Q?flADzoj7Erqj/7Cl6X4E0to9SIJl4uYUomwWF5Q1pnbOEtg8oMFDdf1cfaun?= =?us-ascii?Q?GcWHQCFPHrRhMhWBLN9gbCvHEFu57lqZUx150fqoHxdrO6phx3U0bPdNdhEo?= =?us-ascii?Q?pmAadqVOp/+6AOC1d9wYWcyG5qLfmpTmK6rAWxbJIcGAv/4PcCcvyHwPi6sb?= =?us-ascii?Q?cfh2EVKp1BCewUpr4lfIEBTd33HxEFrZlCRHEjPXrZC09JkF5YSVxXSW7K/O?= =?us-ascii?Q?T+SUJcjTSoNPDn1zeKs4CtsFbcVO0hzJ0EO1Bj5DU9cjZK2c7Rzjg0mCHNUG?= =?us-ascii?Q?Ec3nOOVIUr/S2W1lvD7g+T1GZidnlZmjLPLYPuwQw9fqrmurBGVnj2TJa9Bd?= =?us-ascii?Q?11DOJ8KLRgQuMYTnSitAgim02NHLYYT5GUNMHG6muFRQHz906h9RzjUhuB+a?= =?us-ascii?Q?N51U1a1PRtM1WqNjdi7OXZFTGtU8g75poN0NPHVoaKPKH8ifveM9pr8pAkgc?= =?us-ascii?Q?itFyaFzjgNJ5VovgGgUlomdwvmHyFLvpgQYX5dbtvkqNKeuaQFGO1OmccNsS?= =?us-ascii?Q?b2XmbuanOMQEq9Raqof/zsDysel/aHN1OYZtnTsweh2qd1Qmjog8RWcvW+vz?= =?us-ascii?Q?x/Z394mJgvhkPfuF5QYfWNfzVynzflU5KkKYG3J1UJ6mBQk6eUk0z2LrloSZ?= =?us-ascii?Q?Epm7sHiS/R8WbJ7y/j+VcZU2m/GAQxRZOGvxubiFOO34w4wMFhhTGXPuBJuQ?= =?us-ascii?Q?rdI6IRI4rbqTCDtx2kSOBGsQRh1NVg+MjtN0hSaUZH1dSF3lVToQ795pWebh?= =?us-ascii?Q?agIMjU2wkHUVMcRnYpCE/IRrY4PNiZw/PnYce4kXDiJY7hmN1zS5APEqcjr9?= =?us-ascii?Q?Rly4p1u+XJ0bCztDeZGLh/mzZP5Auw2s/6+KRvOSPFzJpCbASXy+qQx3uFid?= =?us-ascii?Q?eycjjoiE4sgLJqpHDZWAUl5JIL8xUu2J3UPZ3JZBro8QJ0tUzzKvOc/c6zEE?= =?us-ascii?Q?43Ms/aCNjrEEQz2MQikl1ePzctnjQPelw/jRdTNuV/Lqxyxxgm184usj+MkS?= =?us-ascii?Q?53RloetSFIBRiI0lpj7tMn81B4nikvP0MsteDMKZRzoGHXgcQ2cTFsb1L7zV?= =?us-ascii?Q?8AL95ohRQW1WE7JSiUVJEWGn0C/l3Oprkhj/e4W2bnsjTifAaBbIwx32IzJ3?= =?us-ascii?Q?56BhkX+ox95TjYkgKJ2UXUjAJhMGfLOy2srZp3OT3p+dKs6D031775zLik3W?= =?us-ascii?Q?XLosKLAsvBy7elXlOKQFTxyXWF8t/RyFNzWsc4ph?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5789.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ed7b26c-e9db-462e-4b9b-08dbb3c31580 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Sep 2023 19:04:26.3168 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uvwkhf4CylCpAElPW4Sh8rxIXryjLnIfr/f/Byiq8xo84NWrT6IUsqBc+4LRY/UENdXgfXykPXCgNoqy7PBthg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7227 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jbrasen@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: RCqGq9gjHWfAua0fpKBvOiDox7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=c+KJCAaH; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Regarding the signed-off-by I wasn't sure the right way to handle this. Vid= ya was the author of this patch and applied the signed off on our internal = repo during development. I was upstreaming it on his behalf. I was unsure i= f I should just replace his as I assumed just leaving his from this wouldn'= t be ideal as I figured we would want the signed-off by the submitter to th= e devel list. Here is the copy of the patch on our edk2 fork as well. https://github.com/= NVIDIA/edk2/commit/0171b6c1f60500c5e5178ef3521fa14bcacd3488 > -----Original Message----- > From: Leif Lindholm > Sent: Tuesday, September 12, 2023 3:36 AM > To: Jeff Brasen > Cc: devel@edk2.groups.io; ardb+tianocore@kernel.org; > Sami.Mujawar@arm.com; pierre.gondois@arm.com; Vidya Sagar > ; Shanker Donthineni > Subject: Re: [PATCH 1/2] DynamicTablesPkg: AML Code generation for I/O > ranges >=20 > External email: Use caution opening links or attachments >=20 >=20 > Hi Jeff, >=20 > On Mon, Sep 11, 2023 at 23:48:57 +0000, Jeff Brasen wrote: > > From: Vidya Sagar > > > > Add helper functions to generate AML Resource Data describing I/O > > ranges of four words long. API AmlCodeGenRdQWordIo () is exposed. > > > > Reviewed-by: Shanker Donthineni >=20 > The above isn't really applicable to upstream. > Although I feel less strongly about that than >=20 > > Signed-off-by: Vidya Sagar >=20 > The DCO is a statement that you have performed basic legal due diligence = on > the provenance of the change. I'm uncomfortable with people making such > statements on behalf of others. >=20 > If this is being upstreamed from a downstream repository, such that the > review trail is available there, then both of these could be fine. > But I think it would be useful to include a link to the patch in that rep= ository in > the commit message in that case. >=20 > One technical, but not necessarily for this set (it just made me spot it)= , note > below. >=20 > > Signed-off-by: Jeff Brasen > > --- > > .../Include/Library/AmlLib/AmlLib.h | 67 ++++++++++++++ > > .../AmlLib/CodeGen/AmlResourceDataCodeGen.c | 90 > +++++++++++++++++++ > > 2 files changed, 157 insertions(+) > > > > diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h > > b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h > > index 9210c5091548..8e24cecdd77b 100644 > > --- a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h > > +++ b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h > > @@ -683,6 +683,73 @@ AmlCodeGenRdWordBusNumber ( > > OUT AML_DATA_NODE_HANDLE *NewRdNode OPTIONAL > > ); > > > > +/** Code generation for the "QWordIO ()" ASL function. > > + > > + The Resource Data effectively created is a QWord Address Space > > + Resource Data. Cf ACPI 6.4: > > + - s6.4.3.5.1 "QWord Address Space Descriptor". > > + - s19.6.109 "QWordIO". > > + > > + The created resource data node can be: > > + - appended to the list of resource data elements of the NameOpNode. > > + In such case NameOpNode must be defined by a the "Name ()" ASL > statement > > + and initially contain a "ResourceTemplate ()". > > + - returned through the NewRdNode parameter. > > + > > + See ACPI 6.4 spec, s19.6.109 for more. > > + > > + @param [in] IsResourceConsumer ResourceUsage parameter. > > + @param [in] IsMinFixed Minimum address is fixed. > > + @param [in] IsMaxFixed Maximum address is fixed. > > + @param [in] IsPosDecode Decode parameter > > + @param [in] IsaRanges Possible values are: > > + 0-Reserved > > + 1-NonISAOnly > > + 2-ISAOnly > > + 3-EntireRange >=20 > This is an existing antipattern which this patch (rightly) adheres to whe= n > adding an additional variant of an existing API. But this also pushes the= count > to three functions in the same file where we're doing enum-but-in-doxygen > and then keep magic values in the code. >=20 > I think someone should rewrite this as an enum and get rid of the magic v= alues > in the callers. >=20 > An additional antipattern is that because the doxygen stanza becomes > exessively bulky, it leaves out actually documenting the parameter at all= . >=20 > But as I said, that's not the fault of this set, and does not need to be = fixed by it. >=20 > / > Leif >=20 > > + @param [in] AddressGranularity Address granularity. > > + @param [in] AddressMinimum Minimum address. > > + @param [in] AddressMaximum Maximum address. > > + @param [in] AddressTranslation Address translation. > > + @param [in] RangeLength Range length. > > + @param [in] ResourceSourceIndex Resource Source index. > > + Unused. Must be 0. > > + @param [in] ResourceSource Resource Source. > > + Unused. Must be NULL. > > + @param [in] IsDenseTranslation TranslationDensity parameter. > > + @param [in] IsTypeStatic TranslationType parameter. > > + @param [in] NameOpNode NameOp object node defining a name= d > object. > > + If provided, append the new resour= ce data > > + node to the list of resource data = elements > > + of this node. > > + @param [out] NewRdNode If provided and success, > > + contain the created node. > > + > > + @retval EFI_SUCCESS The function completed successfully. > > + @retval EFI_INVALID_PARAMETER Invalid parameter. > > + @retval EFI_OUT_OF_RESOURCES Could not allocate memory. > > +**/ > > +EFI_STATUS > > +EFIAPI > > +AmlCodeGenRdQWordIo ( > > + IN BOOLEAN IsResourceConsumer, > > + IN BOOLEAN IsMinFixed, > > + IN BOOLEAN IsMaxFixed, > > + IN BOOLEAN IsPosDecode, > > + IN UINT8 IsaRanges, > > + IN UINT64 AddressGranularity, > > + IN UINT64 AddressMinimum, > > + IN UINT64 AddressMaximum, > > + IN UINT64 AddressTranslation, > > + IN UINT64 RangeLength, > > + IN UINT8 ResourceSourceIndex, > > + IN CONST CHAR8 *ResourceSource, > > + IN BOOLEAN IsDenseTranslation, > > + IN BOOLEAN IsTypeStatic, > > + IN AML_OBJECT_NODE_HANDLE NameOpNode, OPTIONAL > > + OUT AML_DATA_NODE_HANDLE *NewRdNode OPTIONAL > > + ); > > + > > /** Code generation for the "QWordMemory ()" ASL function. > > > > The Resource Data effectively created is a QWord Address Space > > Resource diff --git > > > a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCo > deGe > > n.c > > > b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCo > deGe > > n.c index 4ca63ccd2396..9c6700b9e08c 100644 > > --- > > > a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCo > deGe > > n.c > > +++ > b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCo > > +++ deGen.c > > @@ -1012,6 +1012,96 @@ AmlCodeGenRdQWordSpace ( > > return LinkRdNode (RdNode, NameOpNode, NewRdNode); } > > > > +/** Code generation for the "QWordIO ()" ASL function. > > + > > + The Resource Data effectively created is a QWord Address Space > > + Resource Data. Cf ACPI 6.4: > > + - s6.4.3.5.1 "QWord Address Space Descriptor". > > + - s19.6.109 "QWordIO". > > + > > + The created resource data node can be: > > + - appended to the list of resource data elements of the NameOpNode. > > + In such case NameOpNode must be defined by a the "Name ()" ASL > statement > > + and initially contain a "ResourceTemplate ()". > > + - returned through the NewRdNode parameter. > > + > > + See ACPI 6.4 spec, s19.6.109 for more. > > + > > + @param [in] IsResourceConsumer ResourceUsage parameter. > > + @param [in] IsMinFixed Minimum address is fixed. > > + @param [in] IsMaxFixed Maximum address is fixed. > > + @param [in] IsPosDecode Decode parameter > > + @param [in] IsaRanges Possible values are: > > + 0-Reserved > > + 1-NonISAOnly > > + 2-ISAOnly > > + 3-EntireRange > > + @param [in] AddressGranularity Address granularity. > > + @param [in] AddressMinimum Minimum address. > > + @param [in] AddressMaximum Maximum address. > > + @param [in] AddressTranslation Address translation. > > + @param [in] RangeLength Range length. > > + @param [in] ResourceSourceIndex Resource Source index. > > + Unused. Must be 0. > > + @param [in] ResourceSource Resource Source. > > + Unused. Must be NULL. > > + @param [in] IsDenseTranslation TranslationDensity parameter. > > + @param [in] IsTypeStatic TranslationType parameter. > > + @param [in] NameOpNode NameOp object node defining a name= d > object. > > + If provided, append the new resour= ce data > > + node to the list of resource data = elements > > + of this node. > > + @param [out] NewRdNode If provided and success, > > + contain the created node. > > + > > + @retval EFI_SUCCESS The function completed successfully. > > + @retval EFI_INVALID_PARAMETER Invalid parameter. > > + @retval EFI_OUT_OF_RESOURCES Could not allocate memory. > > +**/ > > +EFI_STATUS > > +EFIAPI > > +AmlCodeGenRdQWordIo ( > > + IN BOOLEAN IsResourceConsumer, > > + IN BOOLEAN IsMinFixed, > > + IN BOOLEAN IsMaxFixed, > > + IN BOOLEAN IsPosDecode, > > + IN UINT8 IsaRanges, > > + IN UINT64 AddressGranularity, > > + IN UINT64 AddressMinimum, > > + IN UINT64 AddressMaximum, > > + IN UINT64 AddressTranslation, > > + IN UINT64 RangeLength, > > + IN UINT8 ResourceSourceIndex, > > + IN CONST CHAR8 *ResourceSource, > > + IN BOOLEAN IsDenseTranslation, > > + IN BOOLEAN IsTypeStatic, > > + IN AML_OBJECT_NODE_HANDLE NameOpNode, OPTIONAL > > + OUT AML_DATA_NODE_HANDLE *NewRdNode OPTIONAL > > + ) > > +{ > > + return AmlCodeGenRdQWordSpace ( > > + ACPI_ADDRESS_SPACE_TYPE_IO, > > + IsResourceConsumer, > > + IsPosDecode, > > + IsMinFixed, > > + IsMaxFixed, > > + RdIoRangeSpecificFlags ( > > + IsaRanges, > > + IsDenseTranslation, > > + IsTypeStatic > > + ), > > + AddressGranularity, > > + AddressMinimum, > > + AddressMaximum, > > + AddressTranslation, > > + RangeLength, > > + ResourceSourceIndex, > > + ResourceSource, > > + NameOpNode, > > + NewRdNode > > + ); > > +} > > + > > /** Code generation for the "QWordMemory ()" ASL function. > > > > The Resource Data effectively created is a QWord Address Space > > Resource > > -- > > 2.25.1 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108550): https://edk2.groups.io/g/devel/message/108550 Mute This Topic: https://groups.io/mt/101305535/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-